Commit Graph
32590 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi ef2dd2473b $JENKINS_HOME might contain symbols that are interpreted as regular expression 2014-10-18 19:55:28 -07:00
Kohsuke Kawaguchi b4ffb2d01b More follow-up renames 2014-10-18 19:47:19 -07:00
Kohsuke Kawaguchi 7376aa0e29 Renamed package. 2014-10-18 19:39:21 -07:00
Kohsuke Kawaguchi 062f9d4845 Show the warning & config only when it's relevant 2014-10-18 19:34:57 -07:00
Kohsuke Kawaguchi 5db8cecae3 Added a AdminMonitor to to warn when this subsystem is disabled
... unless a few conditions indicate that it is likely irrelevant.
2014-10-18 18:51:25 -07:00
Kohsuke Kawaguchi e24ceef22a Disabling this subsystem by default.
As much as we'd like to enable this by default, what we've learned over
the past few days indicate that this is just too disruptive a change. In a nutshell,

 - The change is just too big. It touches more than 4000 lines just in the core and remoting,
   which makes this by far the biggest change we've done in secret. The chance of something
   going wrong is just too high. As recently as yesterday we are still finding significant
   problems with this subsystem.

 - We've learnt that Subversion 1.x contains Callables that we cannot just whitelist, but
   that version is used by roughly a third of users. If we put this on by default, they will
   see their builds break.

 - Every time we come up with a new way to scan plugins to find impacted code, we always
   find several plugins that are affected, indicating that we probably have missed more
   plugins that will be impacted.

 - We haven't really analyzed past versions of any plugins at all, but as the Subversion
   version distribution indicates, considerable portion of people run old plugins.

As we see in the Wiki page (http://jenkins-ci.org/security-144), vast majority of Jenkins
installations will fit in the category of "I have set up Jenkins master and all slaves by
myself", for whom this subsystem is entirely redundant.

Based on the knowledge we now have about the impact of this addition, and considering people
who benefit from this vs people who don't benefit from this, I'm not enabling this feature
out of the box, just yet.

Our plan is to advertise this feature, then get necesary plugin updates in place over time.
At some later point, we can make this feature on by default, which will only impact new
installations. Further down the road, we can inch up the warning given to people who run
without this feature, or remove the GUI configuration and force this feature on, to get
close to the ideal state of having everyone run with this feature on.

Jesse doesn't like this, but I think he understands where I'm coming from. Sorry Jesse,
this time I'm having this my way.
2014-10-18 18:20:09 -07:00
Oleg Nenashev cc06ae78e3 [JENKINS-19017] - Unit tests
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-10-18 22:03:28 +04:00
Kohsuke Kawaguchi 8a105ce57c Adding separate check for symlink to prevent jailbreak
Otherwise a symlink can be created to point to a file outside $JENKINS_HOME and be read
2014-10-17 19:03:55 -07:00
Kohsuke Kawaguchi ec1e47c053 Change the name because this directory is shared by all secrets 2014-10-17 18:55:05 -07:00
Kohsuke Kawaguchi 9342558ab1 Based on a discussion with Daniel Beck, implemented a master kill switch as an admin configurable feature.
The wiki page already talks about how an admin can do this: https://wiki.jenkins-ci.org/display/JENKINS/Slave+To+Master+Access+Control#SlaveToMasterAccessControl-Disabletheaccesscontrolmechanismaltogether

There's a risk in making this too easy, but we keep finding more plugins that need SECURITY-144 adjustments, and I'm really worried
about SECURITY-144 fix blowing up in the face of too many people.
2014-10-17 18:51:57 -07:00
Kohsuke Kawaguchi 7c9c5c73e8 Path related changes & Windows fix
- Added <JOBDIR> based on Daniel's comment
- Path macros need to be translated if on Windows
- Windows treat '/' as a valid path separator, so it needs to be normalized to '\\'.
2014-10-17 18:08:35 -07:00
Daniel Beck 7fa1252e58 Noting #1306, 2b6c00d in 1.584 2014-10-18 01:28:11 +02:00
Kohsuke Kawaguchi e8adb10bcb tightening up the treatment of access to directory itself 2014-10-17 16:10:01 -07:00
Kohsuke Kawaguchi 37a3ddaaed Path has to be in Windows format on Windows 2014-10-17 16:07:41 -07:00
Kohsuke Kawaguchi ee16f8b63b Fixing another inconsistency.
Most other files are local, so 'gui.conf' better explains what they are.
2014-10-17 15:37:08 -07:00
Kohsuke Kawaguchi aec88b73b5 Fixing inconsistency.
Daniel Beck pointed out that if we ask people to create files not writable from Jenkins as a means to suppress edit to gui.conf,
then we should just stick to the same approach all the way.
2014-10-17 15:37:08 -07:00
Kohsuke Kawaguchi 050b0e7588 set a shorter ID to make URL bit nicer 2014-10-17 15:37:08 -07:00
Kohsuke Kawaguchi bc4d0e1824 Adding new line like elsewhere 2014-10-17 15:37:08 -07:00
Kohsuke Kawaguchi 6ff47b37f6 Need to guide the users to SECURITY-144 landing page 2014-10-17 15:37:08 -07:00
Jesse Glick 57b38ecfb7 Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580 2014-10-17 17:23:50 -04:00
Jesse Glick 14f05e9141 One more entry. 2014-10-17 17:20:47 -04:00
Jesse Glick da0f7e84e9 Adding a couple of whitelist entries. 2014-10-17 16:44:40 -04:00
Kohsuke Kawaguchi cfb59257bf Using the wording changes suggested by Daniel 2014-10-17 10:38:37 -07:00
Jesse Glick af6c5c9070 Merge branch 'SECURITY-144' into SECURITY-144-rc
Conflicts:
	war/pom.xml
2014-10-17 12:29:27 -04:00
Jesse Glick 01827e1e2b Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580
Conflicts:
	war/pom.xml
2014-10-17 12:28:52 -04:00
Jesse Glick c0444a5b46 Updating bundled versions of credentials, ssh-credentials, and ssh-slaves. 2014-10-17 12:23:10 -04:00
Jesse Glick c94c1716f3 Merge branch 'SECURITY-144' into SECURITY-144-rc
Conflicts:
	core/src/main/java/hudson/FilePath.java
	core/src/main/java/hudson/PluginManager.java
	core/src/main/java/hudson/PluginWrapper.java
2014-10-17 10:59:32 -04:00
Jesse Glick 4f3b6811c1 Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580 2014-10-17 10:36:26 -04:00
Jesse Glick 38cb00b325 Refining comments in *.conf. 2014-10-17 10:34:19 -04:00
Jesse Glick e89da8d52d Also removing BYPASS_CALLABLES, which should have been superseded by richer admin UI. 2014-10-17 10:21:00 -04:00
Jesse Glick f327fc284a Removing BYPASS_LOG here as well. 2014-10-17 10:18:46 -04:00
Jesse Glick ba9525336b Presumably <JENKIN_HOME> was a typo. 2014-10-17 10:15:28 -04:00
Jesse Glick d113d93194 Merge branch 'security-stable-1.580' into SECURITY-144-stable-1.580 2014-10-17 07:50:26 -04:00
Jesse Glick 69a4969a98 b105627 failed to move completely away from 1.580. 2014-10-17 07:40:47 -04:00
Stephen Connolly 4d987accef Clarify when to use SlaveComputer#setAcceptingTasks over RetentionStrategy#isAcceptingTasks(T) 2014-10-17 12:36:01 +01:00
Stephen Connolly 34d59a277e Tidy up javadoc some more 2014-10-17 12:27:48 +01:00
Stephen Connolly 197f2ffd27 Fix syntax in Javadoc comment 2014-10-17 12:23:45 +01:00
Stephen Connolly 77d9aa33a5 typos 2014-10-17 12:21:45 +01:00
Stephen Connolly 4e27d4ec17 Narrow the scope of lock required to get the pending nodes.
- Too many things have incorrect locking assumptions on calling NodeProvisioner#getPendingLaunches()
- Simpler to narrow the lock requirements as that should prevent deadlocks
- We now only need the lock for a very short window and the lock is only on the list of pending launches.
2014-10-17 12:21:45 +01:00
Stephen Connolly 6b583764b6 Clarify the lock semantics 2014-10-17 12:21:45 +01:00
Stephen Connolly 9fff4118d4 Make node provisioning strategy plugable 2014-10-17 12:21:44 +01:00
Stephen Connolly 7acbba330c Typo 2014-10-17 12:21:12 +01:00
Stephen Connolly 10ac2b3ccd add @since tags 2014-10-17 12:20:07 +01:00
Jesse Glick 84a92396de Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580
Conflicts:
	core/src/main/java/hudson/FilePath.java
	core/src/main/java/hudson/PluginManager.java
	core/src/main/java/hudson/PluginWrapper.java
2014-10-17 06:58:12 -04:00
Stephen Connolly f07fb85352 Allow Node and RetentionStrategy to contribute to Computer#isAcceptingTasks 2014-10-17 09:38:32 +01:00
Kohsuke Kawaguchi 582128b9ac [FIXED JENKINS-25019]
A truly conforming servlet 3.0 container does not allow us to set "secure cookie" flag beyond ServletContextListener.onInitialized().
If we see that, don't scare the users.
builds/280 changes/280
2014-10-16 19:23:23 -07:00
Kohsuke Kawaguchi 19f9b63d74 [FIXED JENKINS-24046]
Warn users if the pinning is preventing Jenkins from overwriting older versions with bundled versions.
2014-10-16 18:18:25 -07:00
Kohsuke Kawaguchi 65e2a757f9 ConcurrentList cannot be sorted because iterator doesn't support set() 2014-10-16 17:09:30 -07:00
Kohsuke Kawaguchi bb3b68079c Should be only active when there's non-whitelisted Callable 2014-10-16 17:00:02 -07:00
Kohsuke Kawaguchi 6f622df761 Tweak the order of the extensions to make sure the bypass switch works 2014-10-16 16:55:18 -07:00