Kohsuke Kawaguchi
e5a1e82e11
Higer priority one should come first
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
8d1f9d56c0
Removed code that's marked as "delete before release"
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
5794c5d337
provide faster version that doesn't touch I/O
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
d58a9044a3
Finding another whitelisted plugin
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
5af0ac955b
When you don't have any untrusted slaves, the whole defense mechanism is unnecessary
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
50a63ba6d7
Wording tweaks after walking this through with Jesse
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
d4efe71219
Adding default callable whitelist
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
50a7ba09a1
End of iteration handling was buggy
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
a348f16aaf
UI touch-up
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
6d6e19ebf2
if it's already whitelisted, don't bother listing it
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
d495f144bd
redirect access to this monitor to the rule setting UI
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
e1a0935919
report a better error
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
b077d9e7b5
This isn't created via injection
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
fbf3b2658a
Now loading upon the first use
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
2133bb9439
Describing what the default rule will be.
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
5c4a3bbdde
Added default rules
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
9300e7eb15
Support for conf.d pattern to help people deploy rules via configuration management tools
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
5a9b3b4ea5
Hooked up the rule configuration in the UI
2014-10-16 16:55:18 -07:00
Kohsuke Kawaguchi
187e246ab9
Added persistence logic for FilePathRules
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
f3283ca4cc
Refactoring: code that handles I/O to a file is moved to a separate class
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
07809fc12f
Added a convenience method
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
356764dced
Moved the rules into a separate class
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
cb65dd65f3
Moving related code into a separate package and adding a scaffolding to do FilePathFilter
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
7d5b098bf2
Promoting this common pattern into a convenience class
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
21ead8532a
Most ordinals will be zero, and it is undesirable for the order to be affected by the order of insertion, which is not necessarily predictable.
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
bbf0162610
doc improvement
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
ef848c67e1
Expose the ordinal control to FilePathFilter
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
b2deccb771
Now the order of FilePathFilter is significant, so we need to let the caller control that
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
c062e7b426
Final rejection is no longer a job of FilePathFilter
2014-10-16 16:55:17 -07:00
Kohsuke Kawaguchi
c20308c3fa
Making FilePathFilter itself more composable
2014-10-16 16:55:17 -07:00
Jesse Glick
ef2a90c387
maven-plugin SECURITY-144 is now 2.7.1-SNAPSHOT.
2014-10-16 19:41:43 -04:00
Jesse Glick
69c1492fa0
maven-plugin SECURITY-144 is now 2.7.1-SNAPSHOT.
2014-10-16 19:41:26 -04:00
Jesse Glick
32376946b8
Merge branch 'SECURITY-144' into SECURITY-144-rc
...
Conflicts:
core/src/main/java/hudson/FilePath.java
2014-10-16 13:18:39 -04:00
Jesse Glick
ccbe96227f
Merge branch 'security-rc' into SECURITY-144-rc
...
Conflicts:
core/src/main/java/hudson/FilePath.java
pom.xml
2014-10-16 13:18:08 -04:00
Jesse Glick
4ddafceec3
Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580
...
Conflicts:
core/src/main/java/hudson/EnvVars.java
core/src/main/java/hudson/FilePath.java
core/src/main/java/hudson/cli/ClientAuthenticationCache.java
core/src/main/java/hudson/markup/MyspacePolicy.java
core/src/main/java/hudson/model/Computer.java
core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java
core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
core/src/main/java/hudson/security/AbstractPasswordBasedSecurityRealm.java
core/src/main/java/hudson/slaves/SlaveComputer.java
core/src/main/java/hudson/tasks/Fingerprinter.java
core/src/main/java/hudson/tasks/Shell.java
core/src/main/java/hudson/tasks/junit/JUnitParser.java
core/src/main/java/hudson/tasks/test/DefaultTestResultParserImpl.java
core/src/main/java/hudson/util/ProcessTree.java
core/src/main/java/hudson/util/RemotingDiagnostics.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/test/java/hudson/LauncherTest.java
pom.xml
2014-10-16 13:13:31 -04:00
Jesse Glick
11b240c361
Merge branch 'security' into SECURITY-144
...
Conflicts:
core/src/main/java/hudson/slaves/Channels.java
pom.xml
2014-10-16 12:27:45 -04:00
Jesse Glick
1203b09190
Merge branch 'security' into stable-1.580
...
Conflicts:
.idea/compiler.xml
.idea/encodings.xml
core/pom.xml
core/src/main/java/hudson/Functions.java
core/src/main/java/hudson/markup/MyspacePolicy.java
core/src/main/java/hudson/model/AbstractItem.java
core/src/main/java/hudson/security/ACL.java
core/src/main/java/hudson/util/RobustReflectionConverter.java
core/src/main/resources/lib/layout/layout.jelly
pom.xml
test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy
test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
test/src/test/groovy/hudson/model/UpdateCenter2Test.groovy
test/src/test/java/hudson/model/UpdateSiteTest.java
test/src/test/java/hudson/tasks/FingerprinterTest.java
test/src/test/java/hudson/tasks/junit/CaseResultTest.java
test/src/test/java/hudson/tasks/junit/JUnitResultArchiverTest.java
war/pom.xml
2014-10-16 12:21:36 -04:00
Jesse Glick
d2a0a6c2ae
Merge pull request #1424 from synopsys-arc-oss/refactoring_User_class
...
Annotated hudson.model.User methods
2014-10-16 08:58:57 -04:00
Oleg Nenashev
cafe5493a1
Merge pull request #1430 from garlandkr/master
...
Changed wording for command line message.
2014-10-16 15:23:33 +04:00
Oleg Nenashev
6e5520a7d5
Merge pull request #1416 from dominiquebrice/javadoc_update
...
Updating javadoc after struggling to add action to nodes
2014-10-16 15:21:40 +04:00
Stephen Connolly
f423174d0b
Additional safety as an addendum to 34b4bf52ad
2014-10-16 10:26:27 +01:00
Stephen Connolly
34b4bf52ad
Do not fail certificate validation because some files in Jenkins Home are not actually certificates
...
- If there are any files in `$JENKINS_HOME/update-center-rootCAs` that are not ending in `.txt` and are
not valid certificates, do not blow up the entire certificate checking (and hence the ability to see updates
or tool installers) but rather ignore those files and warn the user that the file should not be there.
The correct thing to do is only use as trusted certificates those certificates that parse.
- Also fix resource leak
2014-10-16 10:21:48 +01:00
Harald Albers
033637a143
Merge pull request #1431 from thiagozanetti/patch-1
...
Updating the number of provided plugins.
2014-10-16 09:25:55 +02:00
Kohsuke Kawaguchi
547cc241c0
untar() has the same problem as unzip() about the directionality of the read.
...
This code duplication in two sides of the if statement is undesirable.
Post-release, I need to come back here to introduce a variant of FileCallable that runs on the given FilePath but with InputStream to another FilePath.
2014-10-15 22:15:30 -07:00
Kohsuke Kawaguchi
db5f184981
Preserve fidelity of the whitelist
2014-10-15 22:05:42 -07:00
Kohsuke Kawaguchi
1aebd6fd49
Implemented the basics of Callable whitelisting
...
Still has to extend this to cover FilePaths
2014-10-15 19:51:49 -07:00
Kohsuke Kawaguchi
36f32a7fb3
Navigate the user to the website where we can explain the details, mitigations, etc.
2014-10-15 19:51:49 -07:00
Kohsuke Kawaguchi
225935af5a
Added the extension point to whitelist Callables
2014-10-15 19:51:49 -07:00
Kohsuke Kawaguchi
e37597a81d
Unzipping a local zip into a remote directory results in the file getting read from remote.
...
This change flips the order so that the read happens locally, and pipe gets forwarded to the other side.
2014-10-15 19:51:49 -07:00
Dominique
52941e3381
Updating javadoc after struggling to add action to nodes
2014-10-15 22:05:04 -04:00