Commit Graph
32590 Commits
Author SHA1 Message Date
Daniel Beck 913844de17 Javadoc improvements, improve description of Manage permission 2020-02-18 14:09:09 +01:00
Daniel Beck 9c8a44ca34 Rename to #getRequiredGlobalConfigPagePermission to disambiguate 2020-02-18 12:41:00 +01:00
James NordandRaihaan Shouhell b39ff9938a [JENKINS-61046] - Allow plugins to force an update of the UpdateCenter (#4488)
* Allow plugins to force an update of the UpdateCenter

* Add javadoc to updateDirectlyNow

* [JENKINS-61046] introduce updateDirectlyNow() and updateDirectly()

@oleg-nenashev notes that the public API should not expose the security
option that is for testing.  Introduced updateDirectlyNow() as the new
API and updateDirectly() to have a mirror and deprecated
updateDirectly(boolean) as a consequence.

* fix javadoc grammar

fixes the grammar of the UpdateSite#updateDirectlyNow javadoc

Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>

Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2020-02-18 11:36:38 +01:00
Oleg Nenashev 5e4eeb2ad2 Merge pull request #4499 from daniel-beck/memory-usage-graph
Make memory usage graph discoverable
2020-02-18 11:32:24 +01:00
Daniel BeckandOleg Nenashev 735193c2ec Add at-since TODO to Javadoc
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-02-17 14:14:58 +01:00
Wadeck Follonier 6fd24024d0 Disable failing test in UDP broadcast
(cherry picked from commit d6db99df8d)
2020-02-17 09:35:51 +01:00
Tim Jacomb 13bb6690ef Disable native maven based tests (#4435)
* Fix maven tests - https only

* More test fixes

* Copy settings.xml to home directory

Due to the maven central change to require only https, this ensures that
tests pickup the settings as well and not just the main process

* Revert "Copy settings.xml to home directory"

This reverts commit 37ccab7c55.

* Ignore tests that fail on CI due to https required on maven central

* Comment out HudsonTestCase based test

* Rerun CI

(cherry picked from commit 954e64b0fb)
2020-02-17 09:35:13 +01:00
Raihaan Shouhell 60b3ef1260 Use Streams 2020-02-17 11:27:39 +08:00
Tim Jacomb 9ba18f5de0 Merge branch 'master' into jep-223 2020-02-15 11:56:04 +00:00
Jesse Glick 7ff5f097d0 [JENKINS-61071] Ensure that initialization tasks run as SYSTEM (#4491) 2020-02-15 11:51:03 +00:00
Tim Jacomb a405be946f Merge pull request #4455 from Wadeck/JENKINS-60866_cleanup-hudson-security-realm
[JENKINS-60866] Un-inline JavaScript / CSS from HudsonPrivateSecurity…
2020-02-15 11:49:51 +00:00
Tim Jacomb 5c36f4571f Merge pull request #4381 from jeffret-b/findsecbugs
Add findsecbugs plugin to spotbugs.
2020-02-15 11:47:01 +00:00
Daniel Beck 84f43e2fa4 Update script-security to 1.70 (#4490) 2020-02-15 11:39:57 +00:00
testfixer 32a51374ce [JENKINS-61102] Use XMLUnit to fix test (#4502) 2020-02-15 11:37:21 +00:00
Daniel Beck 58a3f01c1e Address review feedback 2020-02-15 02:43:40 +01:00
Daniel Beck 042dc75a8f For consistency with ManagementLink, name this #getRequiredPermission() 2020-02-14 21:55:18 +01:00
Daniel Beck 311fe0a3ef Only show the link to the cloud configuration to admins 2020-02-14 21:37:15 +01:00
Daniel Beck 17f1a7c155 Fix Javadoc 2020-02-14 21:31:28 +01:00
a1d097f30c Add test back
Co-Authored-By: Esther Alvarez Feijoo <ealvarez@cloudbees.com>
Co-Authored-By: A. Jard <angelique.jard@gmail.com>
Co-Authored-By: michael cirioli <mikecirioli@gmail.com>
2020-02-14 21:23:29 +01:00
Daniel Beck 3b2d0d2c78 As this is experimental, annotate with Restricted(Beta) 2020-02-14 19:59:03 +01:00
Jeff Thompson d4b5d3f845 Show stack trace for jetty:run. 2020-02-14 11:41:12 -07:00
55b2bc7f3f [JEP-223] Overall/Manage permission
Co-Authored-By: Esther Alvarez Feijoo <ealvarez@cloudbees.com>
Co-Authored-By: aHenryJard <ajard@cloudbees.com>
Co-Authored-By: michael cirioli <mikecirioli@gmail.com>
2020-02-14 19:37:32 +01:00
Daniel Beck 32068863a3 Make memory usage graph discoverable 2020-02-14 16:58:13 +01:00
Daniel Beck 5c9ba1428b Add extensible background build discarders (#4368) 2020-02-14 08:50:07 +00:00
Mark Waite 12c246a849 Do not use Azure maven cache - unavailable
The Azure maven cache was removed at the end of January 2020.  When the
DNS entry was also removed, builds began failing. Fix the builds.

(cherry picked from commit 7026b4d042)
2020-02-14 07:57:58 +01:00
Raihaan Shouhell 57d8045e8d Use predicate form in getItems(Class)
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>
2020-02-14 14:52:34 +08:00
Raihaan Shouhell b9b0265002 Fix test
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>
2020-02-14 14:30:06 +08:00
Raihaan Shouhell 19be5e2862 Optimize getTiedJobs()
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>
2020-02-14 10:26:55 +08:00
Raihaan Shouhell e93e236d84 Optimize getAllItems() 2020-02-14 10:01:28 +08:00
Mark Waite 10947717b7 Merge pull request #4493 from jenkinsci/jtnord-patch-1
update AdministrativeMonitor javadoc to reference alert-danger not alert-error
2020-02-13 18:03:21 -07:00
Mark Waite 7cacf276e6 Merge branch 'master' into jtnord-patch-1 2020-02-13 15:27:35 -07:00
Mark Waite 604e6943dc Merge pull request #4494 from MarkEWaite/do-not-use-azure-cache
Remove references to Azure maven cache
2020-02-13 15:02:21 -07:00
Oleg Nenashev 23fce281bd [JENKINS-57888, JENKINS-60821] - Winstone 5.7: Restore java.util.logging.config.file property support and change the Jetty thread pull name
(cherry picked from commit 6c18a397b7)
2020-02-13 21:55:35 +01:00
Ramon Leon 0a56b5967e [JENKINS-60678] Fix java checking on ComputerLauncher for AdoptOpenJDK 11 (#4434)
* [JENKINS-60678] Fix java checking on ComputerLauncher for AdoptOpenJDK 11

* [JENKINS-60678] Add more JDKs tests to check ComputerLauncher checks them correctly

(cherry picked from commit 0dd7009a0a)
2020-02-13 21:51:44 +01:00
Ramon Leon 45a902eac1 [JENKINS-60725] Add an ignored place to missing class telemetry (#4433)
* [JENKINS-60725] Add an ignored place to missing class telemetry

* Apply suggestions from code review

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>

* Add issue inline to the ignored place

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>

Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
(cherry picked from commit ea77a6f7bf)
2020-02-13 21:47:27 +01:00
Jesse Glick de48331494 [JENKINS-60750] Skip CONFIGURE_INSTANCE panel when root URL is set during skipFirstUser (#4430)
* [JENKINS-60750] Skip the CONFIGURE_INSTANCE panel when JenkinsLocationConfiguration.url is set, even when skipFirstUser is called.

* Add nullability annotation

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
(cherry picked from commit d02c756358)
2020-02-13 21:45:55 +01:00
Jeff Thompson 313d198519 Update to use newer jenkins-test-harness.
Use one that enables stack traces for tests that rely on it for easier development and troubleshooting.
Only in incrementals so far.
2020-02-13 13:36:36 -07:00
Andrea Scarpino e84fd0deb6 JENKINS-42658: fix NPE when the slave if offline
(cherry picked from commit 10a52c102b)
2020-02-13 20:52:10 +01:00
Jesse Glick 8921fd773d [JENKINS-60716] Retain causes of a LogRotator failure for diagnosis.
(cherry picked from commit d051dc307c)
2020-02-13 20:50:27 +01:00
Mark Waite 7026b4d042 Do not use Azure maven cache - unavailable
The Azure maven cache was removed at the end of January 2020.  When the
DNS entry was also removed, builds began failing. Fix the builds.
2020-02-13 12:08:13 -07:00
Jeff Thompson 19b25ed2ba Merge branch 'suppressStack' of github.com:jeffret-b/jenkins into suppressStack 2020-02-13 11:50:42 -07:00
Jeff Thompson 39fc974889 Pass the HTTP status code on to the oops page.
If we didn't get a code then continue to use 500. If we did, then use it.
2020-02-13 11:29:12 -07:00
James Nord d67c1b0247 allert-error does not exist, update javadoc to allert-danger 2020-02-13 17:03:45 +00:00
Tim Jacomb 2fcd831866 Merge pull request #3989 from olivergondza/afw-suppressed
Changed exception presented when AtomicFileWriter fails to write to file
2020-02-13 13:18:17 +00:00
Jesse Glick 79060efda9 [JENKINS-60625] Introduced UpdateCenter.isSiteDataReady for use from administrative monitors.
(cherry picked from commit af7c4bece2)
2020-02-13 12:34:02 +01:00
Daniel Beck 7777d8f28b Do not show disabled permissions in permission errors (#4482) 2020-02-13 09:40:58 +01:00
Raihaan ShouhellandEvaristo Gutiérrez 9c4dac702e Add preauth filtering overload of getAllItems(), getItems() and allItems() (#4469)
* Add preauth filtering overload of getAllItems()

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>

* Add allItems filtering

* Apply suggestions from code review

Co-Authored-By: Evaristo Gutiérrez <egutierrez@cloudbees.com>

* Use streams

* Add stream functions

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>

* Missed simplification

Co-authored-by: Evaristo Gutiérrez <egutierrez@cloudbees.com>
2020-02-13 09:40:35 +01:00
Jeff Thompson 76e64fcd4a Use released Stapler. 2020-02-11 14:10:12 -07:00
Jeff Thompson cfc5e526fa Adjust naming. 2020-02-11 14:10:12 -07:00
Jeff Thompson 4a0146390c Adopt Daniel's suggestion for tying Stapler change to Jenkins.
And remove duplication in tests.
2020-02-11 14:10:12 -07:00