Jeff Thompson
13d4a37ae0
Remove now unused method.
2020-02-11 14:10:12 -07:00
Jeff Thompson
8baddd2f42
Don't handle embedded security exceptions.
2020-02-11 14:10:12 -07:00
Jeff Thompson
83148e0d83
Adjust tests.
2020-02-11 14:10:12 -07:00
Jeff Thompson
354a054964
Don't use public static boolean property.
2020-02-11 14:10:12 -07:00
Jeff Thompson
b848f853c8
Use the stapler incremental now that's republished.
2020-02-11 14:10:12 -07:00
Jeff Thompson
acebd93d17
Remove the unused messages.
2020-02-11 14:10:12 -07:00
Jeff Thompson
ed53793d13
Remove messages that aren't used after all.
2020-02-11 14:10:12 -07:00
Jeff Thompson
b56a380670
Catch embedded security exceptions.
2020-02-11 14:10:12 -07:00
Jeff Thompson
86382897c4
Fix tests.
2020-02-11 14:10:12 -07:00
Jeff Thompson
c936bd1c09
Small adjustments to oops.jelly.
...
Show stack trace only if system property is set.
2020-02-11 14:10:12 -07:00
Jeff Thompson
e00a8600dc
Stop adding filter for now.
2020-02-11 14:10:12 -07:00
Jeff Thompson
45e2f5ca24
Revert inadvertent changes to SimpleJobTest.
2020-02-11 14:10:12 -07:00
Jeff Thompson
bcf587bcab
Add logging ID to uncaught exception handler.
2020-02-11 14:10:12 -07:00
Jeff Thompson
eead355179
Add a couple more tests and some comments about the error source.
2020-02-11 14:10:12 -07:00
Jeff Thompson
aad2b10875
Finish cleanup of Stapler separation.
2020-02-11 14:10:12 -07:00
Jeff Thompson
c18b81b531
Need a new Stapler release or incremental for these tests.
...
They really belong in Stapler anyway, but they're easier here.
2020-02-11 14:10:12 -07:00
Jeff Thompson
452128c1f9
Rename class for better clarity.
2020-02-11 14:10:12 -07:00
Jeff Thompson
e6e261fb42
Adjust comment.
2020-02-11 14:10:12 -07:00
Jeff Thompson
9b6aeba581
Shift to using HttpResponse.SHOW_STACK_TRACE.
2020-02-11 14:10:12 -07:00
Jeff Thompson
b380e62a20
Add test for basic exception.
...
And clean up a few tests.
2020-02-11 14:10:12 -07:00
Jeff Thompson
1eb11afa99
Remove some unrelated tests.
2020-02-11 14:10:12 -07:00
Jeff Thompson
d41b0cb2d7
Convert to not show the trace to admins.
...
Show it to everybody if the system property is set.
2020-02-11 14:10:12 -07:00
Jeff Thompson
fff47bb6a9
First pass at adding tests.
2020-02-11 14:10:12 -07:00
Jeff Thompson
3cf878f203
Better handle AccessDeniedException.
2020-02-11 14:10:12 -07:00
Jeff Thompson
c3e39ef65f
Handle two review comments.
...
Check isCommitted().
Guard against circular causes when checking for AccessDeniedException.
2020-02-11 14:10:11 -07:00
Jeff Thompson
94726609ec
Minor review comments.
2020-02-11 14:10:11 -07:00
Jeff Thompson
a4f0f8f700
Clean up suppression filter.
2020-02-11 14:10:11 -07:00
Jeff Thompson
8b50892bd8
Add stack trace suppression into core as a standard.
2020-02-11 14:10:11 -07:00
Mark Waite
a8f5167dae
Merge pull request #4484 from contextshuffling/hudson.util.ArgumentListBuilderTest#assertKeyValuePairsWithMask
...
[JENKINS-61024] Use LinkedHashMap for deterministic iterations
2020-02-10 20:57:02 -07:00
Jeff Thompson
dfee356032
Use released Stapler.
2020-02-10 14:29:53 -07:00
Allan Burdajewicz
495030350f
[JENKINS-60966] Order admin monitors in Global Configuration
2020-02-10 22:57:46 +10:00
Mark Waite
91e01e0bec
Merge pull request #4485 from res0nance/increase-timeout
...
Increase timeout on test to stop flaking
2020-02-10 04:49:07 -07:00
Oliver Gondža
8b60510cb4
Clarify what exception gets propagated
2020-02-10 12:43:21 +01:00
Raihaan Shouhell
99767d6882
Increase timeout on test to stop flaking
2020-02-10 11:39:43 +08:00
Kohsuke Kawaguchi
e489dc20e5
[maven-release-plugin] prepare for next development iteration
2020-02-09 13:18:36 -08:00
Kohsuke Kawaguchi
e97efd05df
[maven-release-plugin] prepare release jenkins-2.220
2020-02-09 13:18:30 -08:00
contextshuffling
23f311c8c8
Use LinkedHashMap for deterministic iterations
2020-02-09 14:55:36 -06:00
Jeff Thompson
9912692b5b
[JENKINS-60926] - Fix agent installation as a service on Windows. (regression in 2.217) ( #4476 )
...
* Upgrade to 4.2 version of Remoting.
* Upgrade to slave-installer 1.7.
2020-02-07 19:50:41 -07:00
Josh Soref
4e53fe17e4
Deprecation: Channel(...) ( #4449 )
2020-02-07 08:41:28 -05:00
Wadeck Follonier
2f51583c8b
[JENKINS-60867] Prevent creation of duplicated SetupWizard singleton instances on Jenkins startup ( #4456 )
...
* [JENKINS-60867] Blank page after SetupWizard: root cause
* Correct a test that was a bit too greedy
2020-02-07 08:40:08 -05:00
Oleg Nenashev
0ef9a4d1ad
Release Drafter: Do not use regression-fix label for the changelog, use the global template ( #4481 )
...
* Release Drafter: Do not use `regression-fix` label for the changelog, clarify the category headers
* Release Drafter: use categories from the org-wide settings
2020-02-07 08:04:01 -05:00
Oleg Nenashev
ce0923ccc8
Merge pull request #4474 from il--ya/patch-1
...
Enforce singleton pattern in CaseInsensitiveComparator
2020-02-07 03:56:03 -05:00
Zhao Xiaojie
f51f5577cc
Export whether plugin update is compatible ( #4385 )
...
* Export if plugin update is compatible
* Remove the erorr usage of Exported annoation
* Remove unclear export annotation
2020-02-07 03:54:34 -05:00
f10d9f95fc
[JENKINS-60913] Remove network discovery services ( #4460 )
...
* Remove multicast discovery services.
* Refine clean up with DNSMultiCast.
Doesn't need to be referenced in the other pom any more.
We need to keep the class and the property around for a while.
Jenkins Test Harness sets the property. Until we can get all
versions aligned so it isn't needed, it's best to keep the property
doing nothing.
* Deprecate remaining class fragment.
* Remove unneeded dependency.
* Improve code comments for external usages.
Co-Authored-By: Jesse Glick <jglick@cloudbees.com >
* Remove multicast discovery services.
* Refine clean up with DNSMultiCast.
Doesn't need to be referenced in the other pom any more.
We need to keep the class and the property around for a while.
Jenkins Test Harness sets the property. Until we can get all
versions aligned so it isn't needed, it's best to keep the property
doing nothing.
* Deprecate remaining class fragment.
* Remove unneeded dependency.
* Add log warning messages.
* Don't need to implement the interface anymore.
* Fix initializer.
Change capitalization for logger.
* Add URLs to log messages.
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com >
Co-authored-by: Jesse Glick <jglick@cloudbees.com >
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com >
2020-02-07 03:53:54 -05:00
Joseph Petersen
9db48dd53d
Add configuration-as-code as suggested plugin ( #4410 )
...
* add configuration-as-code as suggested
2020-02-06 19:04:04 -05:00
Oleg Nenashev
820b64a6a6
Merge pull request #4473 from daniel-beck/JENKINS-21837
...
[JENKINS-21837] Do not record user creating an agent
2020-02-06 07:44:29 -05:00
Oleg Nenashev
57c51a3fb4
Merge pull request #4461 from pjdarton/jenkins-54496
...
[JENKINS-54496] - Don't log node-monitoring errors from deleted nodes
2020-02-06 07:41:01 -05:00
efe2b876a9
[JENKINS-51856] Add new milestones ( #4450 )
...
* [JENKINS-51856] Add new milestones
* Apply suggestions from code review
* [JENKINS-51856] Improve description of JOB_CONFIG_ADAPTED
* [JENKINS-51856] Add test for milestones
* [JENKINS-51856] Fix test error
* Apply suggestions from code review
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com >
* Update core/src/main/java/hudson/init/impl/GroovyInitScript.java
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com >
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com >
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com >
2020-02-06 07:39:46 -05:00
Raihaan Shouhell
75e3565018
[JENKINS-60721] Annotate parameter classes ( #4439 )
...
* Annotate and fix Parameter functions
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com >
* Add checkfornull annotation
* Add test for issue
Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com >
* Fix test
* Previous ctor was private d'oh
* Fix annotation
* Prevent parameter names from being null
* Add comment about check
2020-02-06 07:38:53 -05:00
Jeff Thompson and Wadeck Follonier
b0eee6d655
[JENKINS-60848] Improve RSS title wording + Add more RSS tests ( #4442 )
...
* Add more tests.
Also a little cleanup of RSS.
Fix the broken "All all ..." title and description.
Remove a long unused bit for never implemented trackback.
* Increase date time checks.
* Copy and paste error.
Co-Authored-By: Wadeck Follonier <Wadeck@users.noreply.github.com >
* Assert not empty.
Co-Authored-By: Wadeck Follonier <Wadeck@users.noreply.github.com >
* Add a bunch more tests and clarify title.
Add a number of more tests. Test the various places that RSS is used.
Improve title wording to something consistent and somewhat sensible.
Co-authored-by: Wadeck Follonier <Wadeck@users.noreply.github.com >
2020-02-06 07:38:31 -05:00
Jeff Thompson