Commit Graph
32590 Commits
Author SHA1 Message Date
Stefan Spieker 8910bde1ae removed accidently added usings 2020-01-23 18:38:44 +01:00
Stefan Spieker eb8274d924 set locale for test, because test fails on german system 2020-01-23 18:36:13 +01:00
Kohsuke Kawaguchi 30dbf728ec [maven-release-plugin] prepare for next development iteration 2020-01-23 07:14:52 -08:00
Kohsuke Kawaguchi 3d8a846a75 [maven-release-plugin] prepare release jenkins-2.217 jenkins-2.217 2020-01-23 07:14:46 -08:00
Kohsuke Kawaguchi c436413d08 Merge remote-tracking branch 'origin/master' 2020-01-23 05:55:23 -08:00
Baptiste Mathus b4ef17dd4c Merge pull request #4425 from fqueiruga/replace-jsbuilder-with-webpack
[JENKINS-60734] Replace jsbuilder with webpack
2020-01-23 10:19:10 +01:00
Kohsuke Kawaguchi 7e3382acba [maven-release-plugin] prepare for next development iteration 2020-01-22 15:34:51 -08:00
Kohsuke Kawaguchi 6b6fece88c [maven-release-plugin] prepare release jenkins-2.216 jenkins-2.216 2020-01-22 15:34:37 -08:00
Jeff Thompson 232edf5670 Use the stapler incremental now that's republished. 2020-01-22 13:37:00 -07:00
Félix Queiruga 60a0816cc0 Fix: broken interface of the jenkins object yielded by the setupWizard
- Callbacks registered with `onSetupWizardInitialized` are yielded a `wizard` parameter, that contained a reference to the jenkins object.
- Some plugins called the method `jenkins.initHandlebars` from this callback, to receive a Handlebars intance.
- Added a unit test to ensure this regression does not happen again
2020-01-22 18:47:15 +01:00
Félix Queiruga d1b833deb6 Adds .eslintignore file and changes the way eslint is run 2020-01-22 17:54:12 +01:00
Oleg Nenashev 99b822eb6a Merge pull request #4441 from jtnord/update-accmod
Update access-modifier to allow plugins to use suppressions
2020-01-22 17:07:59 +01:00
Félix QueirugaandTim Jacomb f7b961d548 Update war/src/test/js/widgets/config/tabbar.spec.js
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
2020-01-22 16:00:42 +01:00
Félix Queiruga 6cccb69969 Move module-level comments to underneath the imports 2020-01-22 15:59:55 +01:00
Félix Queiruga b1dd0d294d Migrates from requires to imports
- Fixes some related linter errors in the way
2020-01-22 15:42:59 +01:00
Félix QueirugaandAdrien Lecharpentier e3e0497960 Update CONTRIBUTING.md
Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
2020-01-22 11:23:48 +01:00
Jesse Glick 33f90516ec Merge pull request #4444 from jglick/ExtensionFinder-NPE-JENKINS-60816
[JENKINS-60816] Missing null check when traversing type hierarchy of interfaces
2020-01-21 20:29:13 -05:00
Ramon LeonandAdrien Lecharpentier ea77a6f7bf [JENKINS-60725] Add an ignored place to missing class telemetry (#4433)
* [JENKINS-60725] Add an ignored place to missing class telemetry

* Apply suggestions from code review

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>

* Add issue inline to the ignored place

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>

Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
2020-01-21 23:00:42 +01:00
Jeff Thompson 20e3c784c9 Remove the unused messages. 2020-01-21 14:37:27 -07:00
Jeff Thompson 86bad5a022 Remove messages that aren't used after all. 2020-01-21 14:25:50 -07:00
Jeff Thompson 6a1418598e Catch embedded security exceptions. 2020-01-21 14:11:31 -07:00
Jesse Glick 17c4c35813 [JENKINS-60816] Missing null check when traversing type hierarchy of interfaces 2020-01-21 15:53:19 -05:00
Jeff Thompson 4f223042a7 Fix tests. 2020-01-21 13:39:44 -07:00
Jeff Thompson 3e9444a2f9 Small adjustments to oops.jelly.
Show stack trace only if system property is set.
2020-01-21 12:27:09 -07:00
Jeff Thompson e00d41cd67 Stop adding filter for now. 2020-01-21 10:29:57 -07:00
Jeff Thompson e9d80f08e0 Revert inadvertent changes to SimpleJobTest. 2020-01-21 10:29:08 -07:00
Félix Queiruga b58ea61223 Add development instructions and bump the node versions 2020-01-21 18:27:03 +01:00
Jeff Thompson a441cbb1ce Add logging ID to uncaught exception handler. 2020-01-21 10:25:11 -07:00
Félix Queiruga 99832f1b94 Adds clarification that the vendors.js file is built by webpack 2020-01-21 18:03:27 +01:00
Félix Queiruga 1887edbd44 Fixes typo 2020-01-21 16:50:26 +01:00
Félix Queiruga d4addbbd99 Enables linting for JS and LESS files
- Uses eslint for JS and stylelint for LESS
- Uses default configs
- Default severity set to warn to avoid breaking current builds
2020-01-21 16:48:26 +01:00
Oleg Nenashev 5a7af03c5b Merge pull request #4438 from StefanSpieker/clean_up
Removed unnecessary semicolons and unused imports
2020-01-21 08:16:44 +01:00
Jon Brohaugeandjnz-topdanmark 676ef12fc7 Fix JENKINS-60822 cannot parse changelog.url in message property files (#4440)
Co-authored-by: jnz-topdanmark <58268646+jnz-topdanmark@users.noreply.github.com>
2020-01-21 07:01:22 +01:00
Jesse Glick 5b5040298f [JEP-222] WebSocket support (#4369)
* Playing with WebSocket connections.

* Pluggable handlers.

* errorWithoutStack

* Server-side keepalive pings.

* Redesigned to work as an HttpResponse.

* Unused dep.

* Comment on JnlpSlaveRestarterInstaller.

* Sketch of WebSocket-based endpoint for JNLPLauncher.

* Comment.

* Test enhancement.

* Making it more obvious from JNLPLauncherTest where remoting.jar is being loaded from.

* Reworked protocol to negotiate remote capabilities.

* Unhelpful comment.

* Simplifying handshake to use HTTP headers.

* Moving code into top-level classes and otherwise prettifying.

* Linking to upstream PRs.

* Timestamped snapshot + incremental.

* Picking up incrementalified build of winstone.

* Working around https://github.com/kohsuke/access-modifier/pull/17.

* Finally have an incrementalified build of remoting.

* Use -webSocket option.

* Handling some close and error methods.

* Sending X-Remoting-Minimum-Version.

* If hudson.remoting.jnlp.Main._main fails, show the error.

* Comment.

* GUI analogue of https://github.com/jenkinsci/remoting/pull/357/commits/86cea5b83fd2fc93a9fc10896962eb42c95f80a0.

* Missing since tags.

* Capitalization.

* WebSockets.isSupported

* Rather than hiding JNLPLauncher.DescriptorImpl when the TCP port is disabled, always display it, but show form validation appropriate to WebSocket or TCP mode.

* Form validation fixes.

* Minor test improvements.

* Reworked WebSocketAgents to be compatible with JnlpAgentReceiver.

* Removing WebSocketSession.keepAlive in favor of a global setting applicable to all services.

* Add a -webSocket option to the Jenkins CLI.

* Using a snapshot deployment of Remoting, pending INFRA-2379.

* After #3838 there is no reason to recheck authentication after parsing CLICommand arguments.

* Advertise the -webSocket option.

* Adapt to newer HtmlUnit.

* https://github.com/HtmlUnit/htmlunit/pull/29 seems to have been incompatible.
WebClient.addRequestHeader will no longer override a header in a WebRequest,
such as when the same WebClient/WebRequest was previously used with different headers.

* Tracked down a behavioral change in passing through URL-encoded path characters.
https://github.com/HtmlUnit/htmlunit/commit/2c4956863420e4baef9d3d8c23ec0577ec64d2bf picks up
https://github.com/apache/httpcomponents-client/commit/8c04c6ae5e5ba1432e40684428338ce68431766b which is the actual change.

* Disabled TCP port does not matter in WebSocket mode.

* Shade dependencies needed for jenkins-cli.jar.

* Help text edit.

* https://github.com/jenkinsci/winstone/pull/79 was released as 5.5.

* https://github.com/jenkinsci/jenkins-test-harness/pull/183 released as 2.59.

* https://github.com/jenkinsci/jenkins/pull/4387#discussion_r362696234

* Bumping remoting to a new deployed snapshot.

* Need https://github.com/jenkinsci/winstone/pull/86.

* https://github.com/jenkinsci/winstone/pull/86 released as 5.6.

* Introduced constant for X-Remoting-Minimum-Version.

* s/slave/agent/ in GUI

* Removing in-JVM test, as it was no longer useful after introducing shading anyway.

* Bump.

* No need to check for anonymous CONNECT here.

* s/jenkins.slaves/jenkins.agents/g for new code.

* Restrict the diagnostic endpoint to administrators.

* Fixed Javadoc import after package move.

* https://github.com/jenkinsci/remoting/pull/357 released as 4.0.
2020-01-21 07:00:39 +01:00
James Nord b2b6465a66 Update access-modifier to allow plugins to use suppressions 2020-01-20 14:27:51 +00:00
Wadeck Follonier 574ec6e5bd Merge branch 'master' into security-master 2020-01-20 14:55:10 +01:00
Wadeck Follonier 2df813f9c7 Merge commit '1568f328cd91d7f2d86b6f34635940a9ee71516e' of https://github.com/jenkinsci/jenkins 2020-01-20 14:31:29 +01:00
Ramon Leon 0dd7009a0a [JENKINS-60678] Fix java checking on ComputerLauncher for AdoptOpenJDK 11 (#4434)
* [JENKINS-60678] Fix java checking on ComputerLauncher for AdoptOpenJDK 11

* [JENKINS-60678] Add more JDKs tests to check ComputerLauncher checks them correctly
2020-01-20 03:24:36 +01:00
Kohsuke Kawaguchi 1568f328cd [maven-release-plugin] prepare for next development iteration 2020-01-19 13:00:48 -08:00
Kohsuke Kawaguchi c4b2894202 [maven-release-plugin] prepare release jenkins-2.215 jenkins-2.215 2020-01-19 13:00:43 -08:00
Stefan Spieker c8ff153cdf removed unused imports 2020-01-19 14:49:21 +01:00
Stefan Spieker 126e3f577d removed unnecessary semicolons 2020-01-19 14:38:39 +01:00
Tim Jacomb 954e64b0fb Disable native maven based tests (#4435)
* Fix maven tests - https only

* More test fixes

* Copy settings.xml to home directory

Due to the maven central change to require only https, this ensures that
tests pickup the settings as well and not just the main process

* Revert "Copy settings.xml to home directory"

This reverts commit 37ccab7c55.

* Ignore tests that fail on CI due to https required on maven central

* Comment out HudsonTestCase based test

* Rerun CI
2020-01-19 10:55:58 +01:00
Félix Queiruga 9c1ed1958c Remove outdated comment 2020-01-17 15:49:30 +01:00
Daniel Beck 68b2b4df7f Add a job's disabled status to the REST API output 2020-01-17 14:04:32 +01:00
Félix Queiruga c2e8ac13d4 Adds a reporter because jest will output messages to stderr 2020-01-17 12:56:48 +01:00
Félix Queiruga b52bd327d5 Migrates unit tests to Jest
- Jest was chosen because it's the most feature-complete one
- Fixes tests so that they would work with the new JS modules
- Removed the gulpfile unused test dependencies
- Enabled tests in maven
2020-01-17 12:54:16 +01:00
Jesse GlickandOleg Nenashev d02c756358 [JENKINS-60750] Skip CONFIGURE_INSTANCE panel when root URL is set during skipFirstUser (#4430)
* [JENKINS-60750] Skip the CONFIGURE_INSTANCE panel when JenkinsLocationConfiguration.url is set, even when skipFirstUser is called.

* Add nullability annotation

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-01-17 06:46:57 +01:00
Jeff Thompson 70503e2890 Add a couple more tests and some comments about the error source. 2020-01-15 11:15:45 -07:00
Jeff Thompson 8efba8a766 Finish cleanup of Stapler separation. 2020-01-15 11:02:29 -07:00