Commit Graph
13564 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 2f9dff73c6 Fixed PermGen OutOfMemoryError during full clean build.
Plexus compiler 1.8.6 that maven-compiler-plugin 2.4 has a static field
to store a reference to the Javac class in tools.jar

In JDK that I use (6u26), Javac has a static field that stores what
appears to be a cache of jar files (ZipFileIndex.zipFileIndexCache).
And in addition, Maven instantiates a separate ClassRealm to host plugin
jar files when a project has any build extensions.

The combined result is that during a build, we end up having multiple
copies of URLClassLoader that loads tools.jar, and each ends up caching
jar files it was used. This puts a pressure to permgen (although I
couldn't pinpoint which portions of those caches use permgen), resulting
in OOME.

In Plexus compiler 1.9, Olivier added a new feature to control the
caching/reuse of Javac compiler. While this apparently was done
primarily for fixing concurrency issues in multi-threaded builds, it is
also a useful mechanism to prevent the retention of Javac classes.

So I pushed the SNAPSHOT version of maven-compiler-plugin as
2.5-jenkins-1 and tweaking POM to use it.
2012-05-24 10:27:57 -07:00
Olivier Lamy 7c51287f83 Merge pull request #484 from cquinn/master
Fixed grammatical error in build page message.
Thnaks!
2012-05-24 01:08:14 -07:00
Kohsuke Kawaguchi 18963ee9af [FIXED JENKINS-13625]
In the end, proper fix requires having a filter that tracks
GZipOutputStream.
2012-05-23 20:11:58 -07:00
Kohsuke Kawaguchi ecec5902ff leaving the record of attempted gzip encoding problem fix. 2012-05-23 20:08:57 -07:00
Carl Quinn cd34e38468 Fixed grammatical error in build page message. 2012-05-23 17:50:33 -07:00
Carl Quinn f945f91399 Merge branch 'master' of github.com:jenkinsci/jenkins 2012-05-23 17:45:19 -07:00
Kohsuke Kawaguchi be1f8f91a3 Fixed a bug in Jenkins.overallNodeProvisioner
Until now, Jenkins.overallNodeProvisioner was tracking an inconsistent
pair of numbers. On one hand, it was tracking all the executors in the
system, but then it was also only tracking the # of free-roaming
label-unassigned jobs as the queue length.

So if all your slaves are set with Node.Mode.EXCLUSIVE and you have some
free-roaming jobs, then it'll never tickle NodePrivisioner.

In other words, the # of executors weren't reflecting the actual # of
executors that can execute what's counted as the queue length.

See the problem report at
https://groups.google.com/forum/?fromgroups#!topic/jenkinsci-dev/bUwGEgOwv4Q

To fix this, I introduced another LoadStatistics that only counts
the # of executors that can execute free-roaming jobs, and # of
free-roaming jobs as the queue length. In this way, two pairs of numbers
are consistent.

This now allows us to use overallLoadStatistics for really the entire
system, including all executors and the total queue length. This is
primarily for administrators to see the resource utilization, and it is
not useful for NodeProvisioner input because it's mixing too many
different things.

The semantics change in OverallLoadStatistics.queueLength allows us to
deprecate its totalQueueLength field.
2012-05-23 17:34:47 -07:00
Kohsuke Kawaguchi 5bba8c7660 use of "Content-Encoding:gzip" was causing the automatic login initiation to fail. 2012-05-23 17:28:25 -07:00
Kohsuke Kawaguchi 95c1728c05 [FIXED JENKINS-13202] fixed a regression in untar on exotic platforms.
Fall back in non-JNA case wasn't working.
2012-05-22 18:43:45 -07:00
Dave Hunt 70ee74c5fc [FIXED JENKINS-13640] Allow file parameters to be viewed as plain text. 2012-05-22 18:30:30 -07:00
Kohsuke Kawaguchi af0af44906 Massaging the previous commit a bit.
404 for nearby configuration builds can make the life of automated
client script more complicated, so opt for redirection.
2012-05-22 18:12:19 -07:00
lvotypko add119d353 Correction of returned url 2012-05-22 17:46:29 -07:00
Vincent Latombe d1b2ba7e49 [FIXED JENKINS-13429]
Backward compatibility is preventing the View.READ permission to apply
correctly. It actually overrides the View.READ instead of complementing
it.

This change only applies default READ right if the View.READ is not
available, and the user has View.CONFIGURE + the view is not empty.
2012-05-22 17:45:01 -07:00
Fred G 2128c9d7fe Fixed broken JSON representation caused by hyperlink in console output 2012-05-22 17:39:04 -07:00
Kohsuke Kawaguchi 3b55feede9 fixed NPE.
See https://github.com/jenkinsci/jenkins/pull/474 for the original conversation
2012-05-22 17:15:19 -07:00
Eric Dalquist f5f77bf2b5 [FIXED JENKINS-13826] Include file system path in error
Include the file system path that was checked in the low disk space
error message
2012-05-22 16:58:22 -07:00
Kohsuke Kawaguchi fa68f24292 Merge branch 'pull-478' 2012-05-22 16:51:39 -07:00
Kohsuke Kawaguchi ec87354003 recording this change 2012-05-22 16:51:30 -07:00
Kohsuke Kawaguchi 09ffd9916b touch up. jobNames is a collection that does require a synchronization.
But the general direction of reducing the size of the lock is correct.
2012-05-22 16:50:41 -07:00
Brian Moyles ed0a615743 getViews here could also probably drop synchronized 2012-05-22 16:41:27 -07:00
Brian Moyles d2699b4859 synchronizing here can cause deadlock conditions from plugins like the
keyboard shortcuts plugin that ask for all views very frequently and do
additional locking on the actual view objects
2012-05-22 16:41:27 -07:00
Kohsuke Kawaguchi 1589ec44fa Recording changes in 8f6fda0052 2012-05-22 16:33:34 -07:00
Kohsuke Kawaguchi c7d8b54178 [FIXED JENKINS-6747] support concurrent runs of matrix builds.
The actual fix was in c86aa67953
2012-05-22 16:28:52 -07:00
Kohsuke Kawaguchi 8f6fda0052 added a subtype of HyperlinkNote that creates model link 2012-05-22 16:24:03 -07:00
Kohsuke Kawaguchi 33a4c2f08c redone the custom workspace support in matrix project.
The previous implementation was always appending the per-configuration unique suffix, making it impossible for different configuration builds to share workspaces. In this fix, we introduce a secondary field to control the workspace of sub-builds (which can be either absolute or relative to the matrix head workspace.)
2012-05-22 16:23:55 -07:00
Kohsuke Kawaguchi 06ec0c3dd8 doc improvement 2012-05-22 16:23:22 -07:00
Kohsuke Kawaguchi 93b88af550 doc change 2012-05-22 16:23:22 -07:00
Olivier Lamy 25b694351f changelog entry for [JENKINS-13822] 2012-05-22 16:05:26 +03:00
Olivier Lamy ec9d403c63 Merge pull request #480 from IanKemp/master
[JENKINS-13822] fix
Thanks
2012-05-22 06:03:16 -07:00
IanKemp 4e8775fc2c Fixes JENKINS-13822: expand variables in "Root POM" field of Maven plugin 2012-05-22 13:15:28 +02:00
Seiji Sogabe 6e58e07cb3 Merge pull request #479 from manolo/master
Update Spanish translations keys
2012-05-22 04:09:56 -07:00
Manolo Carrasco 1f5bc9bdd6 Update Spanish translation 2012-05-22 12:32:33 +02:00
Kohsuke Kawaguchi fe67909c6f If the JDK file size is too small, don't use it as a cache.
In the past JDK download site had served error message with 200 error code, making Jenkins think that the download is actually successful. Without this check, such cache polution will not be corrected.
2012-05-21 18:43:17 -07:00
Kohsuke Kawaguchi d85d3b2f07 the trunk is toward 1.467-SNAPSHOT 2012-05-21 18:05:07 -07:00
Kohsuke Kawaguchi 48be9b03e7 creating an RC branch 2012-05-21 18:05:03 -07:00
Kohsuke Kawaguchi 7c8eea7157 Merge branch 'master' of github.com:jenkinsci/jenkins 2012-05-21 18:04:45 -07:00
Kohsuke Kawaguchi 5753ca5924 fixed a test regression.
Now that Ant plugin is outside Jenkins core, changing the message (was done in 76edfd3a56) caused this regression.
2012-05-21 18:04:16 -07:00
Kohsuke Kawaguchi 905a3c9ea6 Merge branch 'master' of github.com:jenkinsci/jenkins 2012-05-21 17:54:54 -07:00
Kohsuke Kawaguchi c5cefcb165 documenting what this method does 2012-05-21 17:24:00 -07:00
Kohsuke Kawaguchi c86aa67953 Enabled concurrent build support for matrix projects 2012-05-21 17:03:35 -07:00
Kohsuke Kawaguchi 039b359a26 added a note 2012-05-21 17:03:08 -07:00
Kohsuke Kawaguchi 76efb9eecb improved error diagnostics 2012-05-21 17:03:08 -07:00
Kohsuke Kawaguchi 76832379d8 exposed data about installed plugins, installable plugins, update center jobs, etc., to the REST API 2012-05-21 16:59:24 -07:00
Kohsuke Kawaguchi bbad34bf3e merged back the RC branch 2012-05-21 14:18:53 -07:00
Kohsuke Kawaguchi 1521986bd3 updated changelog as a part of the release 2012-05-21 14:18:50 -07:00
Kohsuke Kawaguchi ede201ec3d toward the next release 2012-05-21 13:48:17 -07:00
Kohsuke Kawaguchi bb4ebfdc0c releasing a new plugin parent POM 2012-05-21 13:48:09 -07:00
Kohsuke Kawaguchi 1525f5979d updated changelog for release 2012-05-21 13:48:09 -07:00
Kohsuke Kawaguchi 5ff3db3f61 [maven-release-plugin] prepare for next development iteration 2012-05-21 13:32:17 -07:00
Kohsuke Kawaguchi aa2bb5082b [maven-release-plugin] prepare release jenkins-1.465 jenkins-1.465 2012-05-21 13:32:16 -07:00