Commit Graph
3930 Commits
Author SHA1 Message Date
kohsuke 5450534dc8 fixed a problem in the initialization order issue.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9414 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:32:20 +00:00
kohsuke 05f5266892 fixed a bug of stapler wrt @DataBoundConstructor and no-arg constructor.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9413 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:31:58 +00:00
kohsuke 843bf67bc2 moving the StartMethod-specific part of the view rendering to the proper place
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9412 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:31:26 +00:00
davidseymore e25747c341 fix for #1539.. svn:externals can have externals in them... the path needs to be appended for revisions to be properly recorded
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9411 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 23:11:52 +00:00
kohsuke 8b8ff2fb36 more renaming
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9410 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:51:57 +00:00
kohsuke ce2614e121 Renaming to reflect what it really does.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9409 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:44:43 +00:00
kohsuke efcfe5d1d6 Renamed to reflect what it really does.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9408 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:41:23 +00:00
kohsuke c2d95bcab3 moving the initialization code to the proper place.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9407 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:39:30 +00:00
kohsuke f7a131f85d still reserving the rights to change this signature
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9406 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:38:44 +00:00
kohsuke 28dbb672ca clarifying the role of Computer a little.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9405 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:37:08 +00:00
kohsuke 0a4746751f needs NOOP for the master.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9404 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:36:19 +00:00
kohsuke d86ffdebd9 extension points shouldn't depend on implementation detail class, so promoted ComputerImpl to SlaveComputer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9403 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:33:55 +00:00
kohsuke 7723cd7e9c extension points shouldn't depend on implementation detail class, so promoted ComputerImpl to SlaveComputer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9402 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:10:37 +00:00
kohsuke 995ca2382c simplified by using a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9401 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:03:19 +00:00
kohsuke c30c3a80ac added a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9400 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:02:55 +00:00
kohsuke fc0f23c017 no need to do this inside the loop, although not that it hurts
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9399 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:01:52 +00:00
kohsuke 0cf3e83a52 bug fix. This needs to be kept across the doRun method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9398 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:01:25 +00:00
kohsuke ec0bd15ff6 noted
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9397 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:48:04 +00:00
kohsuke 8eb71b6b2c Creating a package to host slave related code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9396 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:46:30 +00:00
kohsuke d83a256540 simplified
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9395 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:45:56 +00:00
kohsuke 9c546d6d7c Creating a package to host slave related code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9394 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:45:31 +00:00
kohsuke 375cca85ed Creating a package to host slave related code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9393 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:42:57 +00:00
kohsuke 295650c008 doc improvements
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9392 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:39:40 +00:00
kohsuke 924d0c4be4 launch should be asynchronous by default.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9390 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:31:30 +00:00
kohsuke 408294a8e3 pointless empty line
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9389 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:28:42 +00:00
kohsuke 0f3f6658ca pass more structured logger
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9388 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:28:31 +00:00
kohsuke 21faaf7a61 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9387 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:28:04 +00:00
kohsuke d5752b8a41 The term used in Hudson for this is 'launch', not 'start', so making it consistent.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9386 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:17:54 +00:00
kohsuke acfb32adaa doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9385 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:15:17 +00:00
kohsuke b18553d6a9 Better encapsulation by hiding numRetryAttempt entirely inside ComputerImpl.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9384 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:13:23 +00:00
kohsuke 5694fb050e refactoring to remove redundant parameters.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9383 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:12:36 +00:00
kohsuke d6419f1cf6 rolling back my 9366 to bring Stephen's slave related changes to the main line
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9382 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:10:09 +00:00
kohsuke 36c60b320b rolling back my 9366 to bring Stephen's slave related changes to the main line
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9381 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:07:24 +00:00
masanobuimai cf70da21f1 Fix Japanese l10N.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9377 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 13:31:52 +00:00
sogabe a339999371 Rolling back. See 9366 and improve translation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9373 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 00:09:30 +00:00
sogabe 18fc6db4fb fix not exist URL.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9372 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 00:08:22 +00:00
sogabe 60b1d133bb Rolling back. See 9366
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9371 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 00:07:33 +00:00
kohsuke d618dcbd76 Rolling back 9328,9331,9352-9354 as I still wanted to make some adjustments to them
before they are merged into the main line.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9366 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 17:54:45 +00:00
sogabe ffabf250e5 Small fix Japanese l10N
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9360 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 14:57:38 +00:00
sogabe bedbc00c1a Fix Japanese l10N for master-slave
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9358 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 14:09:55 +00:00
stephenconnolly 53db09e20d Make the slave availability strategy actually do stuff!
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9354 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 10:14:05 +00:00
stephenconnolly a3fe9ae91d Make the slave availability strategy actually do stuff!
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9353 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 10:09:52 +00:00
stephenconnolly c32b011d31 Making slave availability a strategy extension point
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9352 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 09:54:13 +00:00
sogabe 8114bd1b0b Fix Japanese l10N
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9351 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 04:52:18 +00:00
sogabe 9393791a73 Fix matrix Japanese l10N
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9350 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 04:50:24 +00:00
sogabe 398d1bb08c Removing TODO Comment & fix translation
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9349 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 23:23:10 +00:00
sogabe b9d7847f0d Fix japanese l10N for updating master/slave UI
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9348 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 23:21:48 +00:00
kohsuke 489fab3e89 Integrated the scripts contributed by Amelia Lwis <alewis@tibco.com>
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9346 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 21:36:31 +00:00
kohsuke d1e5182170 [FIXED HUDSON-1696] applied a patch. Be more lenient in comparing a version. Fixed in 1.216.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9334 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 19:06:38 +00:00
kohsuke 4645b8def8 handling the comparison little more carefully so that it can work with some "broken" CVS clients.
See http://www.nabble.com/Problem-with-polling-CVS%2C-from-version-1.181-tt15799926.html

Pasted below for convenience:

------
 finally got time to do a little debugging. I didn't know what to look for
but this is what I found:

The call on isUpdatable in pollChanges returns false (not true as you said),
and it enters the if-statement which returns true.

Inside isUpdatable it enters the instance of the FileCallable object dir, 
and the method invoke which returns false because isUpdatableModule is
false.

isUpdatableModule  recognize module
(C:\workspaces\Hudson\main\war\work\jobs\MyProject_TEST\workspace\MyProject)
as a file and not a directory.
from  isUpdatableModule  it enters checkContents where it compares the
strings s and content. 

Thees two strings are not equal (which they maybe should be?): 
s = :pserver:usid@cvsserver:d:\cvsrepo 
contents = :pserver:usid:uspwd@cvsserver:d:\cvsrepo

This, in the end, makes isUpdatable return false, as far as I can tell.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9332 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 18:42:44 +00:00