* remove idle executors from widget
showing idle executors brings no value. They only blow up the widget.
Instead the busy/total number of executors are added behind the agent
name when the agent is online.
The executor name is kept intentionally to distinguish regular executors
from oneoffexecutors
* feedback
use an icon for oneoffexecutors (FlyweightTask), instead of using a
number for normal executors (which is also not really interesting).
When there are no agents and no builds running use the same text as when
collapsed to show that nothing is running.
* busy in widget header
* fine tuning styling
* icon-xs symbols
* show offline
* show collapsed with no executors
* fix css
* append tooltip to parent
---------
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* [JENKINS-14789] Configurable interval for computer retention check
Also update the lower bound delay as returned by each RetentionStrategy
from 1min to 0min. This is enabling check intervals of <1min to trigger
a re-check in the next cycle (previously, the nextCheck tracking would
defer the next re-check into the 2nd cycle -- one for the timer loop
and once for the nextCheck timestamp).
Includes a bug fix:
`CloudSlaveRetentionStrategy` tracks the agent timeout in milliseconds
internally and returned the nextCheck delay as a tenth of that.
The nextCheck delay is consumed in minutes, leading to the max delay
of one hour being used.
Fix: Convert the delay from milliseconds to minutes.
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] Allow a check interval of one second
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] Apply review feedback
- Double down on JavaDoc
- Migrate UI to jelly
Co-Authored-By: Alexander Brandes <mc.cache@web.de>
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] Store computerRetentionCheckInterval in model instance
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] Add missing javadoc comment
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] Add tests for model
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] Use AperiodicWork for ComputerRetentionWork
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] limit computer retention check interval to 60s
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
* [JENKINS-14789] apply review feedback
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
---------
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
Co-authored-by: Alexander Brandes <mc.cache@web.de>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Several of the changes are not detected by the Python script but were
detected by `git grep TODO | grep since` with review of the output.
The cases that are not detected by the Python script seem obscure enough
to not bother with additions to the script. If they become common
practice, then we can extend the Python script.
* Add a null check for a method return result that may return null.
In file PluginManager.java the parsePluginManifest method may return null. In other parts of the code (https://github.com/jenkinsci/jenkins/blob/7aad67832442b8cd1dfaf363a3630d2687ddf3e3/core/src/main/java/hudson/PluginManager.java#L868), the return value was checked for null. But the null check is missing in this part of the code.
The fix just adds the missing null check in the code.
**Sponsorship and Support:**
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed - to improve global software supply chain security.
The bug is found by running the iCR tool by OpenRefactory, Inc. and then manually triaging the results.
* Comment: Applied mvn spotless to clean up formating issues.
---------
Co-authored-by: Munawar Hafiz <munawar@munawars-mbp.lan>
Basil Crow