Commit Graph
23851 Commits
Author SHA1 Message Date
Oleg Nenashev 8540468ba7 Javadoc: Fix wrong since references in UpdateSite coming from #2442 2016-08-27 23:08:17 +02:00
Oleg Nenashev 3201ea0948 Noting #1787, #2515, #2442, #2504, #2482, #2521, #2511, #2507 towards 2.20 release 2016-08-27 23:05:05 +02:00
csiden 0f364e3a55 [JENKINS-37559] cannot abort shell scripts on 64-bit Solaris (#2507) 2016-08-27 22:26:29 +02:00
Joseph c505dec685 [FIXED JENKINS-37549] - Fixed background color for ComboBoxList (#2511)
Hard to see anything with Gray background and White Text.
Style is in line with Selects and other form inputs.
2016-08-27 22:24:34 +02:00
Oliver Gondža 11af7d0bc1 [FIXED JENKINS-37616] Make Cloud.PROVISION independent from Jenkins.ADMINISTER (#2521) 2016-08-27 22:23:08 +02:00
Felix Belzunce Arcos 4278804582 [JENKINS-36748] Do not process null specs in triggers (#2482)
* [JENKINS-36748] Add a test case and not process null specs

* [JENKINS-36748] Correct license and add a minor comment

* [JENKINS-36748] Add a Waning logger when spec is null
2016-08-25 01:14:06 +02:00
Daniel Beck ee447af7e8 [FIX JENKINS-37360] Fix editing default view description with auto refresh (#2504) 2016-08-24 13:23:38 +02:00
valentina 8acc12ff79 [FIXED JENKINS-36537] Allow the use of custom json signature validator for metadata signature check (#2442) 2016-08-23 12:55:38 +02:00
Keith Zantow 58ba65cacf [FIX JENKINS-33374] - Correct Lifecycle-based restart behavior during setup wizard (#2515)
* JENKINS-33374 - correct restart behavior during setup wizard

* Add tests

* One more test
2016-08-23 12:54:15 +02:00
dbroady1 f4edf91782 [JENKINS-29956] Test Windows junctions before Java 7 symlink (#1787)
* Test Windows junctions before Java 7 symlink

Apparently Java 7 (and later) do not count Windows junctions as
symlinks.  When you drill down into the BasicFileAttributes structure,
reparse points are only counted under isOther.  So, since we already
have code that properly detects Windows Junctions, let's use that first
and then fallback to the Java 7 code.

* Add comment for change & link bug.

* Add test case

* Switch to Functions.isWindows().

* Use non-deprecated APIs for tmp file/dir mgmt

* Add better debugging.

* Allow spaces in junction name & dir name.

To do that, it was easier to use ProcessBuilder vs building up the correct
string in code to send to cmd.exe.

Also, I'll note that according to http://ss64.com/nt/syntax-internal.html,
mklink is in internal cmd.exe command.  So, it must be invoked through
"cmd.exe /c" for it to work.

* Remove comment mentioning bug number.

* Remove debugging output, per Baptiste's request

* Add newline at end of file.

* Make sure that the junction was removed.

* Use assertEquals to show retcode of Process.waitFor.

* Fix compilation errors by importing functions
2016-08-22 15:21:33 +02:00
Kohsuke Kawaguchi aa3188e421 updated changelog for release 2016-08-21 13:10:38 -07:00
Kohsuke Kawaguchi ea042efcb3 [maven-release-plugin] prepare for next development iteration 2016-08-21 13:03:27 -07:00
Kohsuke Kawaguchi d73a37ced4 [maven-release-plugin] prepare release jenkins-2.19 jenkins-2.19 2016-08-21 13:03:26 -07:00
Oleg Nenashev 432a936d22 Noting #2510, #2513, #2370, #2516, #2517, #2512, #2125 towards 2.19 2016-08-21 17:59:28 +02:00
Daniel Beck 239ec86bdb Merge pull request #2125 from fbelzunc/JENKINS-33549
[FIXED JENKINS-33549] Specify on the logger the job which cannot create a new build
2016-08-21 02:16:57 +02:00
Keith Zantow 4376fdedfc [JENKINS-37438] - method to run setup wizard after Jenkins is modified (#2512) 2016-08-21 00:08:16 +02:00
Oleg Nenashev 67347c3c5f [FIXED JENKINS-37561, CID-1205051] - Prevent resource leak in AntClassLoader#findClassInComponents() (#2517)
It has been originally reported by Coverity in https://scan5.coverity.com/reports.htm#v36021/p10292/fileInstanceId=97573616&defectInstanceId=28155759&mergedDefectId=1205051. It happens on Exceptional paths only, but actually I see 31 runaway handlers on my jenkins-2.18 instance (maybe happens due to plugin dynamic load failure)

The issue happens, because finally block is misplaced. It handles only the last stream in this cycle
2016-08-21 00:01:11 +02:00
Oleg Nenashev 96c97860b0 [FIXED JENKINS-37332] - Prevent File descriptor leaks when reading manifests from JARs (#2516)
* [JENKINS-37332] - Improve diagnostics of non-closed streams during reading of the manifests in PluginManager

* [JENKINS-37332] - Leakless processing of JarUrlConnection during Manifest parsing

* [JENKINS-37332] - Also implement leak-safe method for retrieving file modification date

* [JENKINS-37332] - Add spotcheck methods for manifest file access + Javadoc

* [JENKINS-37332] - Also test multi-line and empty attributes in the test
2016-08-21 00:00:41 +02:00
Keith Zantow c8dcd3b06b [FIXED JENKINS-34532] - replace repetitious setup wizard text with icons (#2370) 2016-08-20 23:59:37 +02:00
Keith Zantow 740fef2978 JENKINS-37523 - wrong message for duplicate item name during create (#2513) 2016-08-20 23:58:20 +02:00
Jesse Glick 4f938817ba Improve GlobalConfiguration Javadoc to describe how to store data. (#2509)
Provide a sensible default implementation of configure.
2016-08-20 23:57:25 +02:00
Jesse Glick 30ede81c13 Downgrade Queue#maintain() message for dead executor from INFO to FINE. (#2510) 2016-08-20 20:05:03 +02:00
Oleg Nenashev d5727c538d Noting changes in remoting-2.62, which has been released in 2.18 2016-08-19 12:37:20 +02:00
Kohsuke Kawaguchi b81041c292 Merge branch 'master' of github.com:jenkinsci/jenkins 2016-08-15 09:36:02 -07:00
Kohsuke Kawaguchi 1f87b0a6dd updated changelog for release 2016-08-15 09:35:57 -07:00
Kohsuke Kawaguchi bc118c03f1 [maven-release-plugin] prepare for next development iteration 2016-08-15 09:27:37 -07:00
Kohsuke Kawaguchi a0c69751a0 [maven-release-plugin] prepare release jenkins-2.18 jenkins-2.18 2016-08-15 09:27:37 -07:00
Harald Albers 81bb15f770 Merge pull request #2412 from senk/master
Change to new spelling rules in german
2016-08-15 18:21:38 +02:00
Kohsuke Kawaguchi ee7fd6670c Missing license information
Determined by visitin http://jcip.net/ and accessing the source code.
The license is in the header.
2016-08-15 08:19:28 -07:00
Kohsuke Kawaguchi 9b36611153 Merge pull request #2506 from oleg-nenashev/remoting/2.62
Update remoting to 2.62.
2016-08-15 08:00:40 -07:00
Robin Naundorf 99f53000fa Change to new spelling rules in german
Changed every occurence of 'muß' to 'muss' and 'daß' to 'dass'
because it's no longer correct.
2016-08-15 15:10:26 +02:00
Oleg Nenashev 06be93309e Update remoting to 2.62.
Changes are listed below:

Fixed issues:
* [JENKINS-22853](https://issues.jenkins-ci.org/browse/JENKINS-22853) -
Be robust against the delayed EOF command when unexporting input and output streams.
(https://github.com/jenkinsci/remoting/pull/97)
* Fixed ~20 minor issues reported by FindBugs.
More fixes to be delivered in future versions.
(https://github.com/jenkinsci/remoting/pull/96)

Enhancements:
* [JENKINS-37218](https://issues.jenkins-ci.org/browse/JENKINS-37218) -
Performance: <code>ClassFilter</code> does not use Regular Expressions anymore to match <code>String.startsWith</code> patterns.
(https://github.com/jenkinsci/remoting/pull/92)
* [JENKINS-37031](https://issues.jenkins-ci.org/browse/JENKINS-37031)
<code>TcpSlaveAgentListener</code> now publishes a list of supported agent protocols to speed up connection setup.
(https://github.com/jenkinsci/remoting/pull/93)
2016-08-14 19:22:06 +02:00
Oleg Nenashev 622625c6db Noting upgrade to remoting 2.61 in #2497 2016-08-14 16:06:13 +02:00
Oleg Nenashev d33825fae6 Noting #2498, #2470, #2473, #2459, #2494, #2491, #2490, #2500, #2502 2016-08-14 16:06:13 +02:00
Alexander Shopov 9d0846274e Updating Bulgarian translation (#2498)
Many more *.properties files
Started HTML files

Signed-off-by: Alexander Shopov <ash@kambanaria.org>
2016-08-14 15:12:30 +02:00
ge-vi ee362dce1a translations for lt language (#2470) 2016-08-13 13:09:50 +02:00
Nicolas De loof 3cbf018782 Update pluginSetupWizard_fr.properties
typo
2016-08-12 12:41:25 +02:00
Stephen Connolly 70fbd1528d Merge pull request #2502 from stephenc/jenkins-37315
[JENKINS-37315] Stop A/B testing JNLP3
2016-08-11 00:13:42 +01:00
Stephen Connolly 4f5300003c [JENKINS-37315] Stop A/B testing JNLP3 2016-08-10 20:35:06 +01:00
Stephen Connolly 04be71b0a7 Merge pull request #2500 from stephenc/jenkins-37189
[FIXED JENKINS-37189] Only append `?uctest` to http/https update center URLs
2016-08-09 13:36:34 +01:00
Stephen Connolly 136aeb86a4 [JENKINS-37189] Refactor to make more testable
- A pure unit tests will suffice
2016-08-09 11:07:53 +01:00
Nicolas De loof acc52fff5e Merge pull request #2490 from ndeloof/file_leak
[JENKINS-37098] don’t rely on ReopenableFileOutputStream
2016-08-08 20:59:09 +02:00
phoenix384 1da93e2f5d Add/correct translation (#2473)
* Added translation

* Corrected translation
2016-08-08 19:37:52 +02:00
Jesse Glick a8e7b65251 [JENKINS-23365] Better diagnostics and robustness. (#2491) 2016-08-08 20:36:35 +03:00
Jesse Glick e94c399139 Simplified HTTP calls with basic auth. (#2441) 2016-08-08 20:35:31 +03:00
Stephen Connolly b1e7c1bf62 [FIXED JENKINS-37189] Only append ?uctest to http/https update center URLs
- Also fixes to append `&uctest` if the update center URL already contains a query fragment
2016-08-08 17:20:26 +01:00
Stephen Connolly 584ecc0bd1 Integrate JENKINS-37223 with changes from JENKINS-37032 2016-08-08 10:28:57 +01:00
Nicolas De Loof dc710b7809 [JENKINS-37098] deprecate ReopenableFileOutputStream
ReopenableFileOutputStream introduces file-leaks (detected on windows) when channel onClose writes on already closed log, and breaks when computer tries to delete the slave’s log directory.
2016-08-08 11:06:36 +02:00
Oleg Nenashev ba83b3dee5 Merge pull request #2459 from oleg-nenashev/findbugs/JENKINS-36717-cleanup
[JENKINS-36717] - FindBugs cleanup
2016-08-07 20:15:18 +03:00
James Nord 03750c92ee [JENKINS-36757] don't quote a paramaterized message in UpdateCenter. (#2494)
'{0}' is the literal string {0} in a message format - if you want to quote
the parameter then you need to use double single quotes ''{0}''
2016-08-07 20:10:00 +03:00