Commit Graph
12525 Commits
Author SHA1 Message Date
Oleg Nenashev abbde77458 Added missing null checks for Computer::getNode(), SlaveComputer::getNode() and AbstractBuild::getCurrentNode()
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

Conflicts:
	core/src/main/java/hudson/model/AbstractBuild.java
2014-06-03 00:16:39 +04:00
Oleg Nenashev d3cbc2524e Minor improvements in Jenkins Node-related classes.
The change adds some missing null checks

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-06-03 00:14:03 +04:00
Jesse Glick 3f8fc4e2ec [FIXED JENKINS-23277] Better diagnosis for an NPE probably involving cloud slaves. 2014-06-02 13:55:21 -04:00
Oleg Nenashev a71240c88a Merge pull request #1205 from daniel-beck/JENKINS-22699
[FIXED JENKINS-22699] - JUnit Archiver. Add option to archive only when successful
2014-06-01 10:21:07 -07:00
Oliver Gondža 9402bd82cd Merge pull request #1229 from synopsys-arc-oss/CLI_null_ParameteValue
[READY][FIXED JENKINS-15094] - Handle null parameter values to avoid massive executor deaths
2014-06-01 17:24:44 +02:00
Oliver Gondža 9f3a2b5bfb Merge pull request #1262 from synopsys-arc-oss/javadoc_hudson_model_executor_isActive
Javadoc: Noting changes in Executor availability check approaches (1.536)
2014-06-01 16:57:45 +02:00
Oliver Gondža bdfcd26253 Merge pull request #1258 from daniel-beck/JENKINS-16264
[FIX JENKINS-16264] Don't advertise POSTing config.xml on master
2014-06-01 15:04:55 +02:00
Daniel Beck af67ae868e [FIX JENKINS-16264] Don't advertise POSTing config.xml on master 2014-06-01 14:05:51 +02:00
Daniel Beck a63606d0b7 Merge pull request #1252 from daniel-beck/JENKINS-17114
[FIX JENKINS-17114] Distinguish 'nodes offline' from 'no nodes'
2014-06-01 13:49:23 +02:00
Daniel Beck b152037634 Merge pull request #1245 from daniel-beck/JENKINS-19250
[FIX JENKINS-19250] Add causes to queue item tool tip
2014-06-01 13:48:39 +02:00
Oleg Nenashev ee3ea5dc47 Merge pull request #1247 from daniel-beck/JENKINS-22617
[FIX JENKINS-22617] Fix path to deletion of JVM Crash error log
2014-06-01 03:59:00 -07:00
Oleg Nenashev d172f5836d Javadoc: Noting changes in Executor availability check approaches in 1.536
This change is a follow-up to Executor::isAlive() issues in #1229.

Since 1.536, {@link Executor}s start threads on-demand.
The entire logic should use Executor::isActive() instead of Executor::isAlive() in order to check if the {@link Executor} it ready to take tasks.

Since the change breaks previous executor availability flows, it is required to document changes somehow.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-06-01 14:00:12 +04:00
Oleg Nenashev 4af464a624 Merge pull request #576 from JoelJ/patch-2
[FIXED JENKINS-18626] - Test result page keeps identifying tests as age 1
2014-06-01 02:33:52 -07:00
Oleg Nenashev d2fb6d918c Merge pull request #1225 from synopsys-arc-oss/jenkins22693-inputstream-fix
[FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue
2014-06-01 02:12:00 -07:00
Oleg Nenashev 91ef911326 Merge pull request #1230 from daniel-beck/JENKINS-22934
[FIXED JENKINS-22934] Show poll thread count option when necessary.
2014-06-01 01:56:36 -07:00
Oleg Nenashev d5fc738e63 Merge pull request #1249 from daniel-beck/JENKINS-8358
[FIX JENKINS-8358] Use DISABLED_ANIME icon while building
2014-06-01 01:38:22 -07:00
Oleg Nenashev 19f4cbcce1 Merge pull request #1242 from daniel-beck/JENKINS-20031
[FIXED JENKINS-20031] Useful error message when UC not found
2014-06-01 01:27:58 -07:00
Oleg Nenashev 0c76f85f8d Merge pull request #1248 from daniel-beck/JENKINS-20499
[JENKINS-20499] Don't fail horribly with null causes
2014-06-01 00:36:05 -07:00
Oleg Nenashev 7b894f57b7 [FIXED JENKINS-15094] - Handle null parameter values in BuildCommand (CLI) and Parameter classes (CLI).
The change adds missing checks for null ParameterValue, which may be passed from the CLI.
It prevents the death of Jenkins executors during the canTake() check of node labels.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-05-31 23:40:30 +04:00
Oleg Nenashev cd23fac995 [JENKINS-15094] - Unit tests for the issue
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-05-31 23:38:02 +04:00
Yoann Dubreuil 3ddd2b0c08 [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path
The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash (/) character.
Regression introduced in 547d4ed8d3
2014-05-28 11:00:25 +02:00
Jesse Glick 2ff7a905ac [FIXED JENKINS-22822] PeepholePermalink should maintain an in-memory cache of symlinks to avoid disk I/O. 2014-05-27 22:10:57 -04:00
Jesse Glick 8a79907280 Gratuitous use of Permalink constants when there are standard methods for the purpose in Job. 2014-05-27 18:36:43 -04:00
Andrew Bayer f484daf01e Merge pull request #1033 from daniel-beck/filter-descriptors
[JENKINS-20739] Filter descriptors before adding them to hetero-list
2014-05-27 14:27:54 -07:00
Jesse Glick 68fd984c0e Merge branch 'JENKINS-10477' of github.com:daniel-beck/jenkins 2014-05-27 12:36:15 -04:00
Jesse Glick 7f7eb60bdd [JENKINS-23151] Need to revert part of 5789f0c since codemirror-mode on f:textarea apparently does not work for lazy-load fragments. 2014-05-27 12:28:03 -04:00
Kohsuke Kawaguchi 8a56b36179 the trunk is toward 1.567-SNAPSHOT 2014-05-26 17:42:23 -07:00
Daniel Beck 2f7a49b7cc [FIX JENKINS-10477] Use build display name in executors list 2014-05-25 17:02:39 +02:00
Daniel Beck 5aa32c8681 [FIX JENKINS-17114] Distinguish 'nodes offline' from 'no nodes'
Jenkins currently does not distinguish between 'All nodes for a
label are offline' and 'There are no nodes for a label'. This is
exacerbated by the current wording:

    All nodes of label 'foo' are offline

Instead of just changing the wording to something not seeming to
imply existence of such nodes, add a second wording that clearly
states that there are no such nodes.
2014-05-24 15:50:46 +02:00
Daniel Beck 916340750e [FIX JENKINS-8358] Use DISABLED_ANIME icon while building 2014-05-24 00:02:53 +02:00
Jesse Glick 67dd49a2e5 Helpful to show the user ID in the same place as the API token, since you will be using them together.
(With a security realm where the ID is an email address but a short name is used elsewhere, people can get confused.)
2014-05-23 16:53:44 -04:00
Jesse Glick 68fbc8c664 Avoid using StreamTaskListener.fromStdout. 2014-05-23 16:49:46 -04:00
Jesse Glick 0cca8929b5 Diagnostic message moved to logger. 2014-05-23 16:49:30 -04:00
Daniel Beck f434c22f58 Merge pull request #1238 from gmjck/master
[FIX JENKINS-22685] Jenkins cannot restart Windows service
2014-05-23 22:33:51 +02:00
gmjck c667110763 [FIXED JENKINS-22685] - Update WindowsLifeCycle.java to call restart! to properly restart the service.
Using "restart!" instead of "restart" performs the restart in a separate process, so the service wrapper doesn't kill itself.
2014-05-23 16:03:34 -04:00
Daniel Beck aa677ed848 [JENKINS-20499] Don't fail horribly with null causes 2014-05-23 10:56:41 +02:00
Daniel Beck b517eb7925 [FIX JENKINS-22617] Fix path to deletion of VM error log 2014-05-23 10:13:35 +02:00
Harald Albers 0d8a1d1015 adjusted localizations to previous commit 2014-05-23 08:41:25 +02:00
Jesse Glick d0149ff3da Changing remoteFS display label as discussed on jenkinsci-dev. 2014-05-22 16:38:29 -04:00
Jesse Glick 484db6b645 [FIXED JENKINS-22247] Noting merge of #1161. 2014-05-22 14:36:23 -04:00
Jesse Glick ef949ee1d3 Merge branch 'config-userid-case-sensitivity' of github.com:stephenc/jenkins 2014-05-22 14:29:46 -04:00
Jesse Glick aeebf9f652 Noting summary.jelly view in run actions. 2014-05-22 10:01:45 -04:00
Oliver Gondža 3bc5381d5f Merge pull request #1243 from ph-One/patch-2
Move invalid body ID to body class and data
2014-05-22 11:06:30 +02:00
Oliver Gondža 112c6f07df Noting #1234 2014-05-21 22:22:19 +02:00
Oliver Gondža c6a492a2bb Merge pull request #1234 from olivergondza/directly-modifiable-view
[FIXED JENKINS-22967] Introduce directly modifiable views
2014-05-21 22:17:59 +02:00
Daniel Beck 19e40a9338 [FIX JENKINS-19250] Add causes to queue item tool tip 2014-05-21 22:03:00 +02:00
Jesse Glick b3109de4bb Merge branch 'fix' of github.com:KostyaSha/jenkins 2014-05-21 13:24:56 -04:00
Jesse Glick 1a4e17b742 Pending a rework of #538, the least we can do is show users the wiki page with suggestions.
Cf.: http://stackoverflow.com/questions/8109607/headless-continuous-integration-with-jenkins
2014-05-21 13:13:41 -04:00
Kanstantsin Shautsou 9568986efb [FIXED JENKINS-23127] Allow loading classes from plugins. 2014-05-21 17:47:17 +03:00
Kyle A. Matheny 9ac5357e8d Move invalid body ID to body class and data
IDs cannot contain spaces. Instead, let's move jenkins-${h.version} to the `class` attribute, which is space delimited. This way it can still be used for styling if needed (using `body.jenkins-x.y`). If this is not used for anything other than knowing which version of Jenkins is running, use `<body id="jenkins" class="yui-skin-sam" data-version="jenkins-${h.version}">` -- IDs and Classes should not be used to store data.
2014-05-21 09:05:18 -04:00