Commit Graph
17924 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi accc0e59d3 NPE fix 2014-03-11 16:15:18 -07:00
Kohsuke Kawaguchi a4e29ae0df Doing impersonation here as well.
See javadoc for discussion why this possibly redundant use is desirable
2014-03-11 16:11:14 -07:00
Kohsuke Kawaguchi 27d208b0a9 Moving impersonation logic once again.
I think the cleanest place to do this is as a filter of UserDetailsService.

The problem is that SecurityRealm defines loadUserByName method, which AbstractPasswordBasedSecurityRealm overrides
2014-03-11 15:55:17 -07:00
Kohsuke Kawaguchi bded790f46 User.impersonate() now does the loadUserDetailsByName call.
So ApiTokenFilter no longer needs to do that.
2014-03-11 15:36:46 -07:00
Kohsuke Kawaguchi b173e8d403 Using latest and greatest (take 2 2014-03-11 15:01:06 -07:00
Kohsuke Kawaguchi 0e339d7a45 [JENKINS-20064]
Jenkins now remembers the authorities (read group memberships) that the user had carried when he/she last time interactively logged in.
This information is exposed via User.impersonate(), which is used when using Jenkins SSH, Jenkins CLI, or access via API tokens.

Previously this was impossible for a subset of SecurityRealms that does not allow us to read group membership information without
successful login (such as Active Directory, OpenID, etc.)

For security reasons, if the backend determines that the user does not exist (as opposed to the backend who cannot tell if the user
exists or not), then the impersonation will fail.

I need to check AD plugin is reporting a failure correctly in this case, before marking as JENKINS-20064 fixed.
2014-03-11 14:55:25 -07:00
Kohsuke Kawaguchi 86fcc4733d added a convenience method. 2014-03-11 14:21:46 -07:00
Kohsuke Kawaguchi 983ee33df1 added a convenience method 2014-03-11 14:12:27 -07:00
Kohsuke Kawaguchi 2dbd6eca7f [JENKINS-11643]
An unexpected failure in processing remember me cookie should be handled
gracefully. In particular, possibly problematic cookie should be
removed, or else the browser will keep bombarding the server with the
same cookie, and will never be able to get through.

It's much better to just drop the cookie.
2014-03-11 12:17:11 -07:00
Kohsuke Kawaguchi 3b477a62ed Revert "Using the latest and greatest"
This reverts commit 816f9d02e6.
2014-03-11 11:42:31 -07:00
Kohsuke Kawaguchi 816f9d02e6 Using the latest and greatest 2014-03-11 10:08:06 -07:00
Kohsuke Kawaguchi 5b81675c6d added a convenience method 2014-03-11 09:22:27 -07:00
Oliver Gondža 000b93fe70 Merge pull request #1147 from olivergondza/expose-key-reading
Expose PrivateKeyProvider
2014-03-11 12:17:02 +01:00
Olivier Lamy 0d3819bb91 Merge pull request #1155 from msrb/logging
Switch to java.util.logging on few places
2014-03-11 21:20:38 +11:00
Michal Srb 86ad82227c Switch to java.util.logging on few places 2014-03-11 07:57:52 +01:00
Steven Christou a4c4ed5fda Merge pull request #1143 from christ66/JENKINS-21969
[FIXED JENKINS-21969] Performance issue with search box
2014-03-10 17:47:54 -07:00
Oliver Gondža 63ceab84a5 Test PrivateKeyProvider 2014-03-10 22:21:50 +01:00
Daniel Beck 99e080f33a Fix link to 21773 2014-03-10 17:08:07 +01:00
Kohsuke Kawaguchi b0f00aa7da the trunk is toward 1.556-SNAPSHOT 2014-03-10 07:46:48 -07:00
Kohsuke Kawaguchi 4253e75c2c creating an RC branch 2014-03-10 07:46:43 -07:00
Kohsuke Kawaguchi c9ead7d868 merged back the RC branch 2014-03-10 07:42:20 -07:00
Kohsuke Kawaguchi 76498deaec updated changelog as a part of the release 2014-03-10 07:42:18 -07:00
Kohsuke Kawaguchi 3e67bf48ce updated changelog for release 2014-03-09 23:01:15 -07:00
Kohsuke Kawaguchi 857a229617 [maven-release-plugin] prepare for next development iteration 2014-03-09 22:51:51 -07:00
Kohsuke Kawaguchi 55eb795769 [maven-release-plugin] prepare release jenkins-1.554 jenkins-1.554 2014-03-09 22:51:50 -07:00
Nicolas De loof 32d8a1ee42 Merge pull request #1153 from daniel-beck/UpstreamCause_Improvements
Improvements to the UpstreamCause
2014-03-08 21:17:00 +01:00
Daniel Beck d4ff36b9fc Improvements to the UpstreamCause
* Use model-links with context menu
* Show the display name of the linked job
* If the build isn't available, but the job is, still link to the job
2014-03-08 17:23:01 +01:00
Daniel Beck 7a78a556a5 [JENKINS-21773] Noting merge of #1149 2014-03-07 22:12:44 +01:00
Daniel Beck 843159b4f9 Merge pull request #1149 from adamwolf/JENKINS-21773 2014-03-07 22:09:55 +01:00
Stephen Connolly 5a6cf8ec04 Merge pull request #1151 from stephenc/master
[FIXED JENKINS-22080] Braindead logic in author of original fix... corre...
2014-03-07 15:29:47 +00:00
Stephen Connolly 483181c0a1 [FIXED JENKINS-22080] Braindead logic in author of original fix... corrected by same author 2014-03-07 15:29:21 +00:00
Stephen Connolly 067acbf697 Merge pull request #1150 from stephenc/master
[FIXED JENKINS-22080] NPE if trying to install a plugin from the update ...
2014-03-07 15:26:43 +00:00
Stephen Connolly f9b0f348d0 [FIXED JENKINS-22080] NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name 2014-03-07 15:26:06 +00:00
Adam Wolf 432d07bfdb JENKINS-21773: Fixed sidepanel Up link for multiaxis jobs. 2014-03-05 16:55:32 -06:00
Adam Wolf e1ecb6beb1 JENKINS-21773: Removed one level of ../ in the Up link to fix matrix job Up links. 2014-03-05 15:31:40 -06:00
Oliver Gondža 66d61328cc Expose PrivateKeyProvider 2014-03-05 19:47:33 +01:00
Jesse Glick 21016fcbef Removed horribly obsolete but apparently forgotten svn-password.jelly. builds/60 changes/60 2014-03-04 17:28:58 -08:00
Jesse Glick 6f62fcf2b7 Minor improvement to suggestion in Javadoc. builds/59 changes/59 2014-03-04 16:52:40 -08:00
Kohsuke Kawaguchi 2ea3d8f129 if available, use the path variable exposed from winsw.
See https://github.com/kohsuke/winsw/commit/2ffdbde6a92cf582baa4137e7b4de1116a3ca88b
2014-03-04 10:17:48 -08:00
Kohsuke Kawaguchi 54fc890f05 the trunk is toward 1.555-SNAPSHOT 2014-03-03 07:01:05 -08:00
Kohsuke Kawaguchi 76fe7f3235 creating an RC branch 2014-03-03 07:01:00 -08:00
Kohsuke Kawaguchi bd4f6bcf4c merged back the RC branch 2014-03-03 06:58:15 -08:00
Kohsuke Kawaguchi 8b64b62e50 updated changelog as a part of the release 2014-03-03 06:58:12 -08:00
Kohsuke Kawaguchi 1ae37b74ee updated changelog for release 2014-03-02 23:13:43 -08:00
Kohsuke Kawaguchi ddf1a5267c [maven-release-plugin] prepare for next development iteration 2014-03-02 23:04:12 -08:00
Kohsuke Kawaguchi 1f28286ee6 [maven-release-plugin] prepare release jenkins-1.553 jenkins-1.553 2014-03-02 23:04:12 -08:00
Kohsuke Kawaguchi 7b0daade1f Timestamp has expired 2014-03-02 22:25:53 -08:00
Fernando Boaglio bfda933f4b pt_BR translations 2014-03-01 21:12:51 -03:00
christ66 ae5a3cb362 Merge branch 'master' into JENKINS-21969 2014-02-28 15:40:36 -08:00
Jesse Glick 00d27176f3 [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. builds/58 changes/58 2014-02-28 14:34:29 -05:00