Commit Graph
12086 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi accc0e59d3 NPE fix 2014-03-11 16:15:18 -07:00
Kohsuke Kawaguchi a4e29ae0df Doing impersonation here as well.
See javadoc for discussion why this possibly redundant use is desirable
2014-03-11 16:11:14 -07:00
Kohsuke Kawaguchi 27d208b0a9 Moving impersonation logic once again.
I think the cleanest place to do this is as a filter of UserDetailsService.

The problem is that SecurityRealm defines loadUserByName method, which AbstractPasswordBasedSecurityRealm overrides
2014-03-11 15:55:17 -07:00
Kohsuke Kawaguchi bded790f46 User.impersonate() now does the loadUserDetailsByName call.
So ApiTokenFilter no longer needs to do that.
2014-03-11 15:36:46 -07:00
Kohsuke Kawaguchi b173e8d403 Using latest and greatest (take 2 2014-03-11 15:01:06 -07:00
Kohsuke Kawaguchi 0e339d7a45 [JENKINS-20064]
Jenkins now remembers the authorities (read group memberships) that the user had carried when he/she last time interactively logged in.
This information is exposed via User.impersonate(), which is used when using Jenkins SSH, Jenkins CLI, or access via API tokens.

Previously this was impossible for a subset of SecurityRealms that does not allow us to read group membership information without
successful login (such as Active Directory, OpenID, etc.)

For security reasons, if the backend determines that the user does not exist (as opposed to the backend who cannot tell if the user
exists or not), then the impersonation will fail.

I need to check AD plugin is reporting a failure correctly in this case, before marking as JENKINS-20064 fixed.
2014-03-11 14:55:25 -07:00
Kohsuke Kawaguchi 2dbd6eca7f [JENKINS-11643]
An unexpected failure in processing remember me cookie should be handled
gracefully. In particular, possibly problematic cookie should be
removed, or else the browser will keep bombarding the server with the
same cookie, and will never be able to get through.

It's much better to just drop the cookie.
2014-03-11 12:17:11 -07:00
Kohsuke Kawaguchi 3b477a62ed Revert "Using the latest and greatest"
This reverts commit 816f9d02e6.
2014-03-11 11:42:31 -07:00
Kohsuke Kawaguchi 816f9d02e6 Using the latest and greatest 2014-03-11 10:08:06 -07:00
Kohsuke Kawaguchi 5b81675c6d added a convenience method 2014-03-11 09:22:27 -07:00
Michal Srb 86ad82227c Switch to java.util.logging on few places 2014-03-11 07:57:52 +01:00
Steven Christou a4c4ed5fda Merge pull request #1143 from christ66/JENKINS-21969
[FIXED JENKINS-21969] Performance issue with search box
2014-03-10 17:47:54 -07:00
Kohsuke Kawaguchi b0f00aa7da the trunk is toward 1.556-SNAPSHOT 2014-03-10 07:46:48 -07:00
Nicolas De loof 32d8a1ee42 Merge pull request #1153 from daniel-beck/UpstreamCause_Improvements
Improvements to the UpstreamCause
2014-03-08 21:17:00 +01:00
Daniel Beck d4ff36b9fc Improvements to the UpstreamCause
* Use model-links with context menu
* Show the display name of the linked job
* If the build isn't available, but the job is, still link to the job
2014-03-08 17:23:01 +01:00
Daniel Beck 843159b4f9 Merge pull request #1149 from adamwolf/JENKINS-21773 2014-03-07 22:09:55 +01:00
Stephen Connolly 483181c0a1 [FIXED JENKINS-22080] Braindead logic in author of original fix... corrected by same author 2014-03-07 15:29:21 +00:00
Stephen Connolly f9b0f348d0 [FIXED JENKINS-22080] NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name 2014-03-07 15:26:06 +00:00
Adam Wolf 432d07bfdb JENKINS-21773: Fixed sidepanel Up link for multiaxis jobs. 2014-03-05 16:55:32 -06:00
Adam Wolf e1ecb6beb1 JENKINS-21773: Removed one level of ../ in the Up link to fix matrix job Up links. 2014-03-05 15:31:40 -06:00
Jesse Glick 21016fcbef Removed horribly obsolete but apparently forgotten svn-password.jelly. 2014-03-04 17:28:58 -08:00
Jesse Glick 6f62fcf2b7 Minor improvement to suggestion in Javadoc. 2014-03-04 16:52:40 -08:00
Kohsuke Kawaguchi 2ea3d8f129 if available, use the path variable exposed from winsw.
See https://github.com/kohsuke/winsw/commit/2ffdbde6a92cf582baa4137e7b4de1116a3ca88b
2014-03-04 10:17:48 -08:00
Kohsuke Kawaguchi 54fc890f05 the trunk is toward 1.555-SNAPSHOT 2014-03-03 07:01:05 -08:00
Fernando Boaglio bfda933f4b pt_BR translations 2014-03-01 21:12:51 -03:00
christ66 ae5a3cb362 Merge branch 'master' into JENKINS-21969 2014-02-28 15:40:36 -08:00
Jesse Glick 00d27176f3 [FIXED JENKINS-22001] Simpler fix of JENKINS-19446 that does not introduce asynchronous behavior. 2014-02-28 14:34:29 -05:00
Jesse Glick 3aa0dd5368 [JENKINS-19446] Saving Jenkins configuration in onRenamed/onDeleted is often overkill.
This is already handled by ListView.Listener (other kinds of views are now responsible for their own listeners).
And handled better—if there are no actual changes
(because you have no such views, or they do not mention this job), there is no need to save.
Also moving the actual saving in those remaining cases out of the lock on the ListView itself, just in case.
2014-02-28 14:30:44 -05:00
Jesse Glick f3558e17ee Fix imports for Javadoc. 2014-02-28 14:27:39 -05:00
Jesse Glick a0d6e5286d Fixed outstanding uses in core of deprecations from #1135 & #1138. 2014-02-27 17:29:29 -05:00
Jesse Glick f9953add7b Attempting NetBeans automatic fixes for deprecations in #1135, #1138.
Not currently working: https://netbeans.org/bugzilla/show_bug.cgi?id=242428
2014-02-27 13:34:49 -05:00
Jesse Glick 94d81b0181 Missing deprecation from #1135. 2014-02-27 13:34:03 -05:00
christ66 84e8d01180 [FIXED JENKINS-21969] Performance issue with search box when doing case insensitive searching. 2014-02-26 16:08:24 -08:00
Jesse Glick 6fe5d6c6ba [JENKINS-21780] Much more effective fix.
Introduce VirtualFile.run method to batch together commands.
This should restore pre-ArtifactManager performance for workspace browsing.
2014-02-26 18:01:07 -05:00
Jesse Glick e51fdbbc0e [FIXED JENKINS-21780] Revised fix to make cache work properly without introducing a new remote call to find hash codes. 2014-02-26 16:58:59 -05:00
Oliver Gondža d9b16017e4 Merge pull request #1133 from daniel-beck/JENKINS-21855
[FIXED JENKINS-21855] Add preview for parameter descriptions
2014-02-26 18:31:23 +01:00
Jesse Glick 7c568178f3 [FIXED JENKINS-21958] FilePath.copyRecursiveTo given a scanner including a symlink but not any regular file in the same directory would neglect to create the parent directory on the destination and thus not copy the link.
(Util.createSymlink is partly to blame for not throwing a descriptive IOException when it fails to create a link,
but this is its historical behavior needed for compatibility.
copyRecursiveTo also continues to suppress error text from this method because there is nowhere for it to go.
Perhaps need a new variant of createSymlink that is guaranteed to either have created the link or throw an exception.)
2014-02-26 10:13:39 -05:00
qxo 29948ade45 fixed i18n issue for Chinese(zh_CN): remove 查克·诺里斯说 ( "\u67E5\u514B\u00B7\u8BFA\u91CC\u65AF\u8BF4\uFF1A" ) from *.zh_CN.properties 2014-02-26 11:05:23 +08:00
Kohsuke Kawaguchi 011f4ceca8 the trunk is toward 1.554-SNAPSHOT 2014-02-25 07:18:40 -08:00
Kohsuke Kawaguchi 56024205c1 Excluding this test on unsupported platform
... based on Tyler's discovery at https://gist.github.com/rtyler/9195510

testRemoting(hudson.util.ProcessTreeTest)  Time elapsed: 0.097 sec  <<< ERROR!
java.util.NoSuchElementException: null
        at java.util.HashMap$HashIterator.nextEntry(HashMap.java:897)
        at java.util.HashMap$ValueIterator.next(HashMap.java:922)
        at hudson.util.ProcessTreeTest$MyCallable.call(ProcessTreeTest.java:42)
        at hudson.util.ProcessTreeTest$MyCallable.call(ProcessTreeTest.java:38)
        at hudson.remoting.UserRequest.perform(UserRequest.java:118)
        at hudson.remoting.UserRequest.perform(UserRequest.java:48)
        at hudson.remoting.Request$2.run(Request.java:328)
        at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
        at java.util.concurrent.FutureTask.run(FutureTask.java:166)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:724)

He runs this on FreeBSD.
2014-02-24 11:57:25 -08:00
Jesse Glick 97cc96c925 Merge pull request #1140 from christ66/commons-io-up
Add alternative field calls for deprecated methods.
2014-02-24 13:32:14 -05:00
christ66 e88de958ca Add alternative field calls for deprecated methods. 2014-02-24 00:38:46 -08:00
Jesse Glick fdda9ca656 [FIXED JENKINS-16332] Ensure that User records are saved when the fullName is not recoverable from the id.
Otherwise User.get(id).getFullName() after restarting Jenkins will produce the wrong result.
2014-02-23 17:48:44 -05:00
Jesse Glick 5d91ed77f7 Merge branch 'JENKINS-20965' of github.com:christ66/jenkins 2014-02-23 13:28:47 -05:00
Olivier Lamy 761af2d2db Merge pull request #1138 from christ66/commons-io-up
Deprecate the static final variables used in IOUtils.
2014-02-22 14:14:39 +11:00
christ66 9beb9cd958 Deprecate the static final variables used in IOUtils. 2014-02-21 17:21:25 -08:00
christ66 82e94e5e73 [FIXED JENKINS-20965] Run.writeWholeLogTo causes high CPU usage.
Wait one second before writing to log files. Switched to while loop to
prevent extra one second delay.
2014-02-21 17:03:42 -08:00
Jesse Glick 898f1f76a3 [FIXED JENKINS-12124] Occasionally errors loading plugin classes since it is expected that findClass (and findLoadedClass) are called under synchronization.
The problem was masked by a blind assumption that an InvocationTargetException was in fact wrapping a ClassNotFoundException.
Many thanks to @gotwarlost for demonstrating how to reproduce the problem and diagnosing the cause.
2014-02-21 15:03:16 -05:00
Olivier Lamy 3b472e5b86 Merge pull request #1135 from christ66/commons-io-up
Upgrade to commons-io 2.4
2014-02-21 17:10:04 +11:00
christ66 4c32649db5 Upgrade to commons-io 2.4
In order to maintain backwards compatibility we need to keep IOUtils the
same as in commons-io 1.4. This code is backwards compatible, however
most of the methods have been deprecated and should instead use the
org.apache.commons.io.IOUtils version instead.
2014-02-20 21:50:14 -08:00