Commit Graph
10778 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 0f46fb78fe Experiment revealed that a thread's interrupt flag cannot be set before it's started:
The following code prints false.

    public static void main(String[] args) {
        Thread t = new Thread() {
            @Override
            public void run() {
                System.out.println(Thread.currentThread().isInterrupted());
            }
        };
        t.interrupt();
        t.start();
    }
2013-09-09 13:06:59 -07:00
Kohsuke Kawaguchi 6d9c83a86d if an executor is interrupted before it's started, just throw it away 2013-09-09 13:06:09 -07:00
Kohsuke Kawaguchi 7b8a153e2a killComputer only interrupts idle threads 2013-09-09 13:02:39 -07:00
Jesse Glick 7790dbcabf [FIXED JENKINS-19515] Try to avoid truncation of fingerprint storage files.
1. Use AtomicFileWriter on the hypothesis that an exception during save() caused truncation.
2. Improve logging from the cleanup thread since that may be related to the root cause.
3. Regardless of the cause, recover more gracefully by deleting any truncated file rather than throwing the error up.
2013-09-09 13:24:58 -04:00
Jesse Glick 89a11462c7 [FIXED JENKINS-18337] Must use xmlEscape for freeform text fields in fingerprint XML. 2013-09-09 10:06:55 -04:00
Kohsuke Kawaguchi 9b058aebc3 killComputer interrupts executors, so no need to do it separately 2013-09-09 00:57:54 +01:00
Kohsuke Kawaguchi 111a8d364c more simplification and bug fix 2013-09-09 00:44:42 +01:00
Kohsuke Kawaguchi 4d9429f88f needs to be checking a different method 2013-09-09 00:40:41 +01:00
Kohsuke Kawaguchi 74c2ab460c further simplification 2013-09-09 00:30:31 +01:00
Vojtech Juranek 3eea396489 [FIXED JENKINS-19488] Expand variable in a consistent way 2013-09-06 13:09:01 +02:00
Vincent Latombe 127c1145f9 Fixing copy-paste error 2013-09-06 08:54:26 +02:00
Jesse Glick a219148891 Noting possibility of summary.jelly. 2013-09-05 23:34:50 +02:00
Kohsuke Kawaguchi 99d62c7c2c adding more convenience constructors 2013-09-05 11:55:55 +02:00
Kohsuke Kawaguchi 73073387c8 Still a work in progress 2013-09-04 23:11:24 -07:00
Nicolas De Loof dfd60492e7 fixed duplicate builds in view build history when nested in folders
Jenkins with folders A job A/j
a top-level view to recurse into subfolders and include all available jobs and folders (so A and A/j)
=> builds for A/j are included twice, as view.builds iterate on its items, so get A/j + builds from A.
2013-09-04 17:58:07 +02:00
rednuht 8ab50323c5 Update AbstractProject.java
Should follow this statement:
"Called after a job has its configuration updated."
2013-09-04 12:13:12 +02:00
rednuht fd696e1911 Update AbstractItem.java
Should follow this statement:
"Called after a job has its configuration updated."
2013-09-04 12:13:11 +02:00
Daniel Olausson e81a9076c4 JENKINS-17108. This solves the problem with ItemListner.onUpdated not being called if the project was disabled/enabled by pushing the button on the project page. Also solved the problem with ItemListener.onUpdated not getting called if the project description was updated using the edit description on the project page. 2013-09-04 12:13:11 +02:00
Jesse Glick 49c731fc03 PROXY_HEADER should be static, so it does not get serialized into the crumb configuration. 2013-09-03 17:06:47 -04:00
Oliver Gondža 1623160e6b Merge pull request #919 from LarryNorth/JENKINS-17603 2013-09-01 18:56:24 +02:00
Stefan Wolf 3bf39c16f9 Merge pull request #916 from wolfs/aggregate-test-result
[FIXED JENKINS-9637] Fixed the 404 when clicking the testResult on the Project Page when there is only an aggregated test result.
2013-08-30 13:25:44 -07:00
Jesse Glick c63e1f7084 Merge pull request #925 from ctapobep/master
[JENKINS-18723] Fixed performance bottleneck. Corrected the formation of...
2013-08-29 14:23:02 -07:00
Jesse Glick 574fe1409e [FIXED JENKINS-9540] Failure of recursive copy on slave side should be reported.
Instead it was being thrown in a Future that the master did not wait for:
the writing side failed with a closed pipe exception, and this meaningless error was thrown up.
Fixing by waiting for the reading side first, so any error there will be thrown up.
(If there was _also_ an error on the writing side, we would miss it, but typically this will just be the closed stream.)
2013-08-29 16:13:48 -04:00
Olivier Dagenais d12b16c66b Minor formatting fixes. 2013-08-29 14:35:29 -04:00
Olivier Dagenais 7c9aab3831 Fix random HTTP 404 when viewing build details
Added a unit test (and supporting localExpiredBuilder) to expose a
defect in the search() method of AbstractLazyLoadRunMap whereby the
index contained an entry for the requested build number, but the
BuildReference's referent was null.
Fixed the search() method to handle this rare[ish] corner case.
2013-08-29 14:31:22 -04:00
ctapobep cc259504ae [JENKINS-18723] Fixing performance bottleneck, first step. There were 2 times relative path for the job was asked which was replaced by a single time and saving the result in a var. 2013-08-29 14:19:02 +04:00
Jesse Glick 352a6f26cb Merge branch 'master' of github.com:jenkinsci/jenkins 2013-08-28 09:54:18 -04:00
Jesse Glick 7cb81ee826 [FIXED JENKINS-19391] Trying to show the annotation on an Advanced block in newly inserted dynamic section failed since the span is not yet registered.
More generally, suppressing customizedField detection when attrs.field is null;
this prevents us from giving false positives for complex forms with Java-based defaults like CoberturaPublisher.
2013-08-28 09:53:53 -04:00
Oliver Gondža e8cee74b6d Avoid linebreaks around l:breakable 2013-08-28 12:05:20 +02:00
Oliver Gondža b2883e212f Merge pull request #924 from dwdyer/master 2013-08-28 12:02:34 +02:00
Jesse Glick f6d20fa8f3 [FIXED JENKINS-3107] Annotate the Advanced section if some fields are already customized. 2013-08-27 18:08:50 -04:00
Jesse Glick 5c6044ca49 Merge branch 'advanced-auto-expand-JENKINS-3107' 2013-08-27 18:03:02 -04:00
dwdyer 151a58cc8c Fixed incosistency, use st:nbsp for all spaces. 2013-08-27 22:50:27 +01:00
Jesse Glick 99f84bc8e0 7232798611 mistakenly made a new method deprecated. 2013-08-27 17:34:07 -04:00
Jesse Glick bf444887ac [FIXED JENKINS-19377] ViewJob.removeRun must take effect synchronously or LogRotator gets confused. 2013-08-27 12:22:26 -04:00
Jesse Glick 1d20c524e1 [JENKINS-18775] Noting that this usage of XStream is unsupported and could cause future problems. 2013-08-27 11:54:31 -04:00
dwdyer e240b75a24 Fix for underlined trailing spaces on project links. Tried various solutions including the Jelly trim attribute, but in the end the only thing that would work was to remove the line break prior to the closing tag. 2013-08-27 00:58:29 +01:00
dwdyer 59b3118807 Don't underline the space between RSS icons and the link text. 2013-08-26 23:52:00 +01:00
evernat f5742df16b Optimize and close Zip resources in ClassicPluginStrategy and FilePath 2013-08-27 00:03:09 +02:00
Jesse Glick 8df5cb85e7 Merge pull request #922 from evernat/master
Optimize String appends in hudson.Functions
2013-08-26 14:08:30 -07:00
Jesse Glick 554d0a0e0c customizedFields support for f:checkbox (and thus also f:optionalBlock). 2013-08-26 16:42:02 -04:00
Jesse Glick 3ce3ec4496 Merge remote-tracking branch 'origin/master' into advanced-auto-expand-JENKINS-3107 2013-08-26 16:08:16 -04:00
evernat 3835b3fcc7 Optimize String appends in hudson.Functions 2013-08-26 21:15:35 +02:00
Jesse Glick 44b1a4a02b Does not make much sense to put @DataBoundConstructor on an abstract class.
(Stapler 1.218 rejects it, I think correctly.)
2013-08-26 14:28:26 -04:00
Jesse Glick 97d3f02c1a Merge branch 'master' of github.com:jenkinsci/jenkins 2013-08-26 13:37:03 -04:00
Jesse Glick 5704e5da78 Merge pull request #918 from evernat/master
Close JarFile resources in PluginWrapper and UpdateCenter
2013-08-26 09:56:00 -07:00
Jesse Glick 4def416224 [JENKINS-17248] Be robust against exceptions in ItemListener.onLoaded, since this could interrupt Jenkins startup. 2013-08-26 11:38:39 -04:00
Bráulio Bezerra 8cfdf8ac6f Fixed Brazilian Portuguese translation of "Full Log".
The translation was too literal: the log is not full as in a cup of water (this is what "cheio" means), it is full because it is not a partial object.
2013-08-26 09:43:37 -03:00
Nicolas De Loof 872a6d740d fix computeRelativeNamesAfterRenaming for job tbs using same prefix in name 2013-08-25 12:43:35 +02:00
Larry North e757ae3224 Code format corrections: replaced some tabs with spaces. 2013-08-24 20:10:31 -05:00