Kohsuke Kawaguchi
513a45b309
Added QueueListener extension point
...
This can track items as they go through the queue.
2013-06-13 15:42:00 +03:00
Kohsuke Kawaguchi
7b2541d4db
doc fix
2013-06-13 15:42:00 +03:00
Kohsuke Kawaguchi
f984e8298d
doc fix
2013-06-13 15:41:59 +03:00
Jesse Glick
cc26f23ec4
[JENKINS-16845] Properly report the IllegalStateException, rather than throwing an NPE producing the exception message.
...
java.lang.NullPointerException
at hudson.model.Run.getFullDisplayName(Run.java:711)
at hudson.model.Run.toString(Run.java:706)
at java.lang.String.valueOf(Unknown Source)
at java.lang.StringBuilder.append(Unknown Source)
at hudson.model.AbstractBuild.getPreviousBuild(AbstractBuild.java:218)
2013-06-12 15:18:15 -04:00
Jesse Glick
acf8884f42
Was missing Javadoc.
2013-06-12 11:44:21 -04:00
Kohsuke Kawaguchi
4398a60bcb
wrong method was implemented
2013-06-12 18:33:45 +03:00
Kohsuke Kawaguchi
a821d859bc
this sentence was already moved to Queue.Task.getDefaultAuthentication()
2013-06-12 18:33:45 +03:00
Kohsuke Kawaguchi
a452e5ff26
Handshaking should fix on the encoding.
...
See f8916a839c5a7bfe6d0de100a33cf23de33de6e4 for the corresponding change in the remoting.
Since the error messages only use ASCII
2013-06-12 18:33:45 +03:00
Jesse Glick
25eff9006f
getInjector introduced in 1.433.
2013-06-12 11:31:08 -04:00
Kohsuke Kawaguchi
e3a1a78f6d
ProjectAuthenticator -> QueueItemAuthenticator
...
As Jesse pointed out, contextual information is often useful in authenticating the build, which means we need to take Queue.Item (initially AbstractBuild was the parameter, which provided the context, and I failed to accommodate that in transition to AbstractProject.)
To still allow Queue.Tasks to provide a meaningful value fallback to Queue.Task.getDefaultAuthentication() as opposed to hard code it to ACL.SYSTEM. This allow plugins like remote-terminal-access to supply a meaningful secure value without forcing a configuration change to the user.
2013-06-12 17:20:17 +03:00
Kohsuke Kawaguchi
ec91933fc3
Minor edits based on review comments
2013-06-12 16:53:09 +03:00
Kohsuke Kawaguchi
2d09a0e54b
[FIXED JENKINS-18285] Merge the feature branch
2013-06-12 13:56:35 +03:00
Kohsuke Kawaguchi
b89387cfed
Not shipping any implementation out of the box.
...
... because the fallback behaviour is sufficient for compatibility. In this way, we can phase in this feature more slowly
2013-06-12 13:52:13 +03:00
Kohsuke Kawaguchi
6fa5b936d7
wrong package name
2013-06-12 13:08:47 +03:00
Kohsuke Kawaguchi
e5b834921c
IntelliJ complains about this. Not sure if it's a real problem
2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi
aa6dd095a4
Grouping related messages together
2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi
7392d3f0d1
tweaking the wording a bit
2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi
ada4a21607
Have the scheduling algorithm honor the permissions
2013-06-12 13:08:46 +03:00
Kohsuke Kawaguchi
6d8723a985
Instead of authenticating Executor, authenticating AbstractProjects.
...
This is necessary because a part of the access control is determining which Executor can accept which Queue.Task, so we can't have the authenticator taking Executor as a parameter.
I briefly thought about changing ExecutorAuthenticator to authenticate Queue.SubTask, but doing this intelligently is very difficult as an authenticator wouldn't really be able to make any sensible decisions unless it checks for specific subtypes (think of the dist-fork plugin and the remote terminal access plugin that implements Queue.Task.) So I made the change to have it accept AbstractProject, which is really the primary use case anyway.
The relevant classes are renamed to better represent what it does now.
2013-06-12 13:08:45 +03:00
Kohsuke Kawaguchi
a3bf8c7297
run the build under the designated Authentication objec
2013-06-12 13:08:45 +03:00
Kohsuke Kawaguchi
570197fc93
PersistedList now implements List, not just Iterable.
...
This required bridge method injector that maps boolean->void
2013-06-12 13:08:45 +03:00
Jesse Glick
3c01366e0b
[FIXED JENKINS-16974] Unsafe to define a function in <script> without a generated name, as it could clash with functions defined in unrelated *.jelly that happen to included in the same page.
2013-06-11 17:48:22 -04:00
Kohsuke Kawaguchi
e42149faa9
Added basic abstraction for authenticating Executors
2013-06-11 16:29:05 +01:00
Jesse Glick
b64d3dbfb7
Merge pull request #802 from Vlatombe/JENKINS-17451
...
[FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven
2013-06-11 05:58:19 -07:00
Jesse Glick
dedb24ef03
Merge branch 'master' into JENKINS-14362-jzlib
2013-06-11 08:00:27 -04:00
Jesse Glick
cc2a91bdbd
Merge commit '9d8ee80'
2013-06-11 06:55:41 -04:00
Jesse Glick
9d8ee801f2
Fixed regression in AbstractItem.getShortUrl from e50f0f5 caught by MatrixTest.testSpaceInUrl.
...
https://ci.jenkins-ci.org/job/jenkins_main_trunk/2590/testReport/junit/hudson.matrix/MatrixTest/testSpaceInUrl/
2013-06-11 06:54:52 -04:00
Oliver Gondža
7ac7967f55
[FIXED JENKINS-18282] Optionally override name from XML in create-node CLI command
2013-06-11 12:31:37 +02:00
Oliver Gondža
df786136bd
[JENKINS-18282] Introduce create-node CLI command
2013-06-11 12:31:37 +02:00
Oliver Gondža
92a74104af
[JENKINS-18282] Introduce update-node CLI command
2013-06-11 12:31:37 +02:00
Oliver Gondža
548e9b8bbf
[JENKINS-18282] Introduce get-node CLI command
2013-06-11 12:31:36 +02:00
Jesse Glick
ca53043076
[JENKINS-18274] ComputerListener methods should be called as ACL.SYSTEM.
...
https://ci.jenkins-ci.org/job/jenkins_main_trunk/2588/testReport/junit/hudson.bugs/JnlpAccessWithSecuredHudsonTest/testServiceUsingDirectSecret/
2013-06-10 18:33:40 -04:00
Jesse Glick
e50f0f5fc2
If urlChildPrefix is ".", do not prefix shortUrl with "./".
2013-06-10 18:21:08 -04:00
Jesse Glick
d10fbc5eac
[FIXED JENKINS-18274] LogRecorder.getSlaveLogRecords
2013-06-10 15:43:23 -04:00
Jesse Glick
dd28e97049
2527778d amended to display Level.localizedName but track Level.name in the form submission.
2013-06-10 13:40:03 -04:00
Jesse Glick
0ca88a6cea
[JENKINS-16952] [JENKINS-18274] Slave computers should record all log messages at INFO+, not just those in the hudson.* namespace.
2013-06-10 13:33:12 -04:00
Jesse Glick
2527778d3b
Level.getLocalizedName should be preferred to Level.toString().toLowerCase().
...
Consider the poor Turk who is prompted to log at fıner!
2013-06-10 13:09:25 -04:00
Jesse Glick
b8b1edc566
ALL is a more sensible default value than SEVERE (which would be logged anyway).
2013-06-10 13:08:34 -04:00
Jesse Glick
e66a94868a
[JENKINS-16952] contextDestroyed needs to be changed to match.
2013-06-10 12:48:31 -04:00
Jesse Glick
b1c82f1e30
stephenc asks to use TODO rather than XXX
2013-06-10 11:53:13 -04:00
Jesse Glick
e67746c97f
Queue.clearLeftItems to fix AbstractProjectTest.testGetBuildAfterGC test failure after 84a2593.
2013-06-10 10:52:16 -04:00
Jesse Glick
cabbe941c7
fixed @since
2013-06-10 09:18:04 -04:00
Jesse Glick
67f3c7626f
Merge branch 'prefetch-JENKINS-15120'
...
Conflicts:
pom.xml
2013-06-10 08:22:24 -04:00
Vincent Latombe
9cb0d11f5a
[FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven
...
module jobs. shows TopLevelItem only.
Restricts displayed projects to TopLevelItem only.
2013-06-10 12:16:38 +02:00
Kohsuke Kawaguchi
f7330d7a15
[FIXED JENKINS-15120]
...
- integrated the newer release of remoting
- jar caching won't work with class file directory, so plugin
WEB-INF/classes are now exploded as WEB-INF/lib/classes.jar
(This should also solve the problem of slow plugin extraction in the
presene of Anti-virus software on Windows.)
- because the structure of the exploded jar file has changed, I changed
the up-to-date check timestamp file name to force re-extraction in
existing installations.
2013-06-08 12:21:18 +03:00
Kohsuke Kawaguchi
b1f5d28f90
doc improvements based on Jesse's comments
2013-06-07 20:02:49 +03:00
Kohsuke Kawaguchi
6a3743a526
deleted this earlier experiment
2013-06-07 19:52:10 +03:00
Kohsuke Kawaguchi
84a259388c
Improved the tracking of queued jobs and their eventual builds in the REST API.
...
This came from Alpha CSP guys during JUC Israel. The remote API needs to expose a better way of tracking a submitted task.
2013-06-07 19:51:52 +03:00
Kohsuke Kawaguchi
ee82f5894d
if the master node config changes, executors might have to recalibrate
2013-06-07 19:35:15 +03:00
Kohsuke Kawaguchi
6c4715820f
Jenkins
2013-06-07 18:33:43 +03:00