Commit Graph
10778 Commits
Author SHA1 Message Date
Jesse Glick 61921fbb71 [SECURITY-16]
Require POST for various operations.
(cherry picked from commit 36c8624379)

Conflicts:

	core/src/main/java/hudson/model/AbstractBuild.java
2013-02-13 15:30:09 -08:00
Jesse Glick 0271fdb8a2 [SECURITY-13]
(cherry picked from commit 1fb2acfd7b)

Conflicts:

	core/src/main/java/hudson/model/AbstractProject.java
	core/src/main/java/hudson/model/ParametersDefinitionProperty.java
2013-02-13 15:29:20 -08:00
Kohsuke Kawaguchi ad08359f53 [SECURITY-54] Massaging the original fix.
- Use the proper block cipher mode.
  Or else the information about the plain text still ends up revealing as a pattern without the attacker knowing the key.
- No need to hide SLAVE_SECRET from the encrypted payload.
  jnlpMac is needed to decrypt this payload to begin with, so there's no point in hiding it. This simplifies the code a little bit.
- Using a newer slave installer that uses the -secret option
(cherry picked from commit f4496df19e)
2013-02-13 15:24:34 -08:00
Kohsuke Kawaguchi 7338713975 [SECURITY-54]
Jesse's original patch
(cherry picked from commit 01a24e2cb1)
2013-02-13 15:24:23 -08:00
Kohsuke Kawaguchi f4496df19e [SECURITY-54] Massaging the original fix.
- Use the proper block cipher mode.
  Or else the information about the plain text still ends up revealing as a pattern without the attacker knowing the key.
- No need to hide SLAVE_SECRET from the encrypted payload.
  jnlpMac is needed to decrypt this payload to begin with, so there's no point in hiding it. This simplifies the code a little bit.
- Using a newer slave installer that uses the -secret option
2013-02-13 14:04:41 -08:00
Kohsuke Kawaguchi 01a24e2cb1 [SECURITY-54]
Jesse's original patch
2013-02-13 14:04:41 -08:00
Kevin P. Fleming 46d94e0880 Adding a mechanism for NodeProvisioner to know when it's done.
This came from pull request #705
2013-02-13 11:51:34 -08:00
Kohsuke Kawaguchi b5ed31990e [JENKINS-15466]
Failure to load JNA should be handled graciously
2013-02-12 17:25:36 -08:00
Kohsuke Kawaguchi 6f0e221441 fixed a bug in handling of escaping/unescapin of XML names 2013-02-12 17:16:24 -08:00
Nicolas De Loof 29426012ce [FIXED JENKINS-16718] check executor has been interrupted 2013-02-11 19:36:59 +01:00
lvotypko df00baea5a Revert changes in method encode too. 2013-02-11 11:35:15 +01:00
Jesse Glick dcb3972b85 Convenience overload of impersonate taking a thunk. 2013-02-08 14:00:16 -05:00
Jesse Glick 981202e802 NotSerilizableSecurityContext -> NonSerializableSecurityContext 2013-02-08 13:15:58 -05:00
Harald Albers 933224f97e translation cleanup
purged duplicated translations for GlobalCrumbIssuerConfiguration
("Prevent Cross Site Request Forgery exploits").
Changed property name "Crumb" to "Crumbs" because this is the value that the existing translations actually use.
2013-02-08 11:13:51 +01:00
Fred G 4bf431cfaf Fixed wrong camel casing and simplified dealing with locale 2013-02-07 23:20:23 +01:00
Nicolas De Loof dac37a8ab8 added @since and changelog for previous commits 2013-02-07 20:13:54 +01:00
Jesse Glick 1ce132aafb Adding boolean signatureCheck param to UpdateSite.updateDirectly.
Removing old static field, which was not friendly to tests, especially multithreaded runners.
Cleaned up existing tests to use updateDirectly rather than POSTing raw JSON.
2013-02-07 13:32:45 -05:00
Jesse Glick 259f302cf8 Meaningful FormValidation.toString. 2013-02-07 11:55:23 -05:00
Jesse Glick 5d89529e91 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-02-07 10:13:18 -05:00
Jesse Glick 37bf35b5db [JENKINS-15156] AbstractProject.builds accessed by Maven & matrix module builds before onLoad or onCreatedFromScratch called.
Seem to need to keep the deprecated no-arg RunMap initializer though it is unclear to me how it could work.
2013-02-07 10:12:51 -05:00
Nicolas De Loof 629b42a309 [FIXED JENKINS-16682] getItem(name) can throw an AccessDeniedException
so iterate on itemGroup.getItems and filter by job names
2013-02-07 15:46:30 +01:00
Nicolas De Loof cb07748569 Extension point to listen buildStep execution 2013-02-07 14:30:31 +01:00
Nicolas De Loof c0d987ef20 Extension point to provide access to workspace even when node is offline
used to browse workspace and run scm polling
2013-02-07 14:13:57 +01:00
Jesse Glick 7ac15767bc [JENKINS-15156] Massive test failures with NPE.
Seems that the RunMap must be initialized before updateTransientActions, which uses it, is called.
2013-02-06 20:57:03 -05:00
Fred G 6437fe2e78 Unit test for JENKINS-16630 2013-02-07 02:32:49 +01:00
Jesse Glick 25f4c60f96 Merge pull request #696 from johnou/JENKINS-15156
[FIXED JENKINS-15156] Initialize AbstractLazyLoadRunMap.dir for newly created jobs.
2013-02-06 16:05:21 -08:00
Johno Crawford fe95fc53f8 [JENKINS-15156] Refactored fix. 2013-02-07 00:56:47 +01:00
Johno Crawford 8f62901ee5 Merge remote-tracking branch 'tsartarzan/JENKINS-15156' into JENKINS-15156 2013-02-07 00:44:44 +01:00
Jesse Glick e43e5f338e Merge pull request #694 from recampbell/update-directly
Correctly support direct updates of html update sites
2013-02-06 15:28:42 -08:00
Ryan Campbell 19f3b29f9c Correctly support direct updates of html update sites and other issues pointed out by jglick in https://github.com/jenkinsci/jenkins/pull/692 2013-02-06 15:42:31 -06:00
Jesse Glick 92d87f0632 Merge pull request #693 from albers/translation
translation cleanup
2013-02-06 10:44:41 -08:00
Ryan Campbell c1c979747e API for updating update sites programatically, enabling automated plugin updates and installation. 2013-02-06 11:14:48 -06:00
Harald Albers 26cc2dea7d translation cleanup
removed dislocated messages defined in GlobalSecurityConfiguration,
added LOADING messages to GlobalSecurityConfiguration
2013-02-06 12:29:18 +01:00
Jesse Glick 9a95d23344 [FIXED JENKINS-16651] Broken Filter field in Plugin Manager. 2013-02-05 17:28:27 -05:00
Jesse Glick 6231f2b316 Use ${resURL} for ${attrs.css}. 2013-02-05 16:54:02 -05:00
Jesse Glick 89515df970 Added @since.
(Method actually introduced in 1.461, but was wrong—corrected in 1.462.)
2013-02-05 15:01:28 -05:00
Aleksas Pielikis 8f6a22297e Minor updates.
Code style convention related updates.
2013-02-05 12:47:16 +02:00
Fred G f19f772322 [FIXED JENKINS-16630] Human readable file size method returns ",00" for
files with byte length 0
2013-02-05 01:26:50 +01:00
Jesse Glick c9adc14485 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-02-04 18:11:53 -05:00
Jesse Glick f9da4a867e Found a log file full of IAEs from ModelObjectWithContextMenu.MenuItem due to an (unknown) action with an illegal absolute URI. 2013-02-04 18:11:12 -05:00
Julian Schmidt 2feb19ef34 [FIXED JENKINS-15156] Initialize AbstractLazyLoadRunMap.dir for newly created jobs 2013-02-03 14:00:09 +01:00
Christoph Kutzinski 12efbc3a9b [FIXED JENKINS-16499] Assuming that:
- save() is not strictly necessary here. config.xml might be saved later or not - doesn't really matter
- this else branch should only be entered when migrating from very old Hudson instances
2013-02-02 18:27:13 +01:00
Jesse Glick ef612da95d Observed repeated NPEs printed during shutdown.
java.lang.NullPointerException
	at hudson.model.listeners.RunListener.all(RunListener.java:216)
	at hudson.model.listeners.RunListener.fireFinalized(RunListener.java:196)
	…
2013-02-01 18:20:21 -05:00
Jesse Glick 1f29f0d0e3 Observed an NPE printed during shutdown. 2013-02-01 18:16:38 -05:00
Jesse Glick b6cd92d74b Merge pull request #689 from justinsb/perf_lazyload_getdependencychanges
Don't check if the job exists if we are going to ignore the result
2013-02-01 14:14:30 -08:00
Jesse Glick 302140b2c6 [JENKINS-15747] Improved fix: not only cap total number of transitive upstream causes but also avoid redundantly storing information about upstream causes listed elsewhere. 2013-01-31 20:16:28 -05:00
Jesse Glick 8b1df85fdb [JENKINS-15747] Comment about possible improvement to console logging. 2013-01-31 20:12:35 -05:00
Jesse Glick d506b32f1f [FIXED JENKINS-15747] Avoid recording too many upstream causes at any depth. 2013-01-31 19:33:33 -05:00
Jesse Glick 9e58d944b4 Another 0626f28 (show UpstreamCause recursively) tweak: indent nested causes in log. 2013-01-31 19:11:33 -05:00
Jesse Glick 6023716fe5 Minor adjustments to 0626f28 (show UpstreamCause recursively). 2013-01-31 18:01:40 -05:00