StevenGBrown
cdbe303dd2
[FIXED HUDSON-6897] The file parameter name is now encoded before used within the download URL.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32431 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 13:57:25 +00:00
StevenGBrown
a0c958b61f
[FIXED HUDSON-6896] The correct file name is now provided when a file parameter is uploaded via the CLI.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32421 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 13:30:12 +00:00
mindless
67a3c8a5bf
remove !=false on canDelete call.. thought this would provide backward compatibility,
...
but jelly does get AbstractMethod error (not null) if instance doesn't implement the
canDelete method, so I'll just release a new version of nested view plugin..
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32398 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 19:07:54 +00:00
mindless
257aa0d992
use "command" as name for shell/batchfile textarea in the form,
...
so the @DataBoundConstructor on these classes can work.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32397 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 17:37:12 +00:00
kohsuke
570e3e6bc0
added another convenience method.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32396 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:45:26 +00:00
kohsuke
66b9d9baaf
fixed a possible security issue (SECURITY-3)
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32394 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:31:02 +00:00
StevenGBrown
f756ddae48
[FIXED HUDSON-6889] FileParameterValue now creates the directory that the file parameter is copied into, since DiskFileItem does not.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32393 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:21:33 +00:00
StevenGBrown
a85f563950
Fixed the file parameter description help URL (TODO.html does not exist).
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32390 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 14:18:48 +00:00
mindless
bbf53fc98b
add system property to set auto refresh interval
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32336 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 22:31:48 +00:00
mindless
9083e5d6e6
[HUDSON-6849] revert r32272.. might as well keep URLs a little shorter
...
until/unless this issue is better understood.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32325 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 03:18:23 +00:00
mindless
af20a4dc2b
[FIXED HUDSON-6862] Update Ant fileset link from
...
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32324 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-27 21:09:33 +00:00
mindless
6ce5b797cc
[FIXED HUDSON-6832] Hide some sidepanel links that should not be shown in
...
user-private views. Use it="${app}" for Manage Hudson and New Job links,
so these check the proper permission. Replaced !it.isDefault() check
with new ViewGroup.canDelete API call.. Hudson ViewGroup uses isDefault()
for this method; MyViewsProperty checks views.size() > 1 so link is
hidden when there is only one user-private view.
Used !=false in jelly for backward compatibility (if a plugin implements
ViewGroup but does not have canDelete, null!=false will result in true).
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32319 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-27 18:31:50 +00:00
kutzi
40ffa913f8
[FIXED HUDSON-6543] use last 3 builds to calculate estimated remaining build time
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32310 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-26 13:37:56 +00:00
km
f1b4cf47de
[FIXED HUDSON-6849]
...
Go to getDescriptorByName rather than getDescriptor to get the help files. This is useful in
situations where Hudson instance is not the root of the webapp.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32272 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 23:03:56 +00:00
kohsuke
3216dface6
[FIXED HUDSON-6819] Here is the race condition that induces this problem.
...
- Task X becomes buildable
- Thread E1 enters the pop() method, assigns X to an executor E2.
Note that at this point X is not removed from the buildables list yet
- Thread E1 goes to offer.event.block and blocks, losing the lock
- Thread E3 enters the pop() method, assigns X to anogher executor E4.
This is possible because X is still in the buildables list.
- Thread E3 goes to offer.event.block and blocks, losing the lock.
- Thread E2 wakes up, obtains the lock and execute the rest of the
pop() method. It decides that it's assigned X, it removes X from
the buildables list.
- Thread E2 leaves the pop() method, loses the lock, and starts building X
- Thread E4 wakes up, obtains the lock, and executes the rest of the
pop() method. It decides that it's assigned X. It tries to remove X
from the buildables list. This remove operation becomes no-op,
but we don't check that.
- Thread E4 leaves the pop(), and start building X.
Thus we end up building X twice.
To avoid this problem, I've introduced the 4th state "pending", and moves BuildableItem from buildables to pendings as soon as we assigned it to the executor. New BuildableItem cannot be created
while its another copy is either in the buildables or pendings state.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32258 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 01:40:12 +00:00
kohsuke
b2df57e4f0
[FIXED HUDSON-6497] slightly revised the patch, to avoid using a boolean flag for a concurrency control. It affects the serialization format, and it's not concurrency safe.
...
Given the use case described in the bug, I wonder if it's better to have a different extension point (sort of like ComputerListener) that can contribute build variables to any builds going on in the system.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32257 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 00:47:03 +00:00
kohsuke
59317c93fb
[HUDSON-6819] tweaking the implementation a bit so that the code never ever have multiple edges between the same src and dst.
...
Not that I was able to spot where the previous code did that, but this implementation is bit more straightforward.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32256 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 00:17:13 +00:00
kohsuke
46f7945813
value equality unnecessary
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32255 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-23 23:21:34 +00:00
jglick
33f7ed732f
[FIXED HUDSON-6824] Statically held fields should be of type Localizable rather than String.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32240 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 20:10:59 +00:00
GLundh
0aaa0fa5b0
[FIXED HUDSON-6787] If a suitable truncable index cannot be found, force a trunc at maxTruncLength.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32224 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 09:24:08 +00:00
jglick
b83a335e85
Fixed typo.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32205 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-21 16:52:34 +00:00
wyukawa
ff9ece2299
fix link of Apache Ant FileSet URL
...
from http://ant.apache.org/manual/CoreTypes/fileset.html
to http://ant.apache.org/manual/Types/fileset.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32171 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-19 10:06:47 +00:00
wyukawa
b0cdf1eb2e
fix link of Apache Ant FileSet URL
...
from http://ant.apache.org/manual/CoreTypes/fileset.html
to http://ant.apache.org/manual/Types/fileset.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32164 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-19 06:45:26 +00:00
mode
6f1cdeda56
Merged revisions 32154-32155,32157 via svnmerge from
...
https://svn.dev.java.net/svn/hudson/branches/rc
........
r32154 | kohsuke | 2010-06-18 20:38:45 -0700 (Fri, 18 Jun 2010) | 1 line
fixed a bug in the logic of aggregating multiple dependency edges.
........
r32155 | kohsuke | 2010-06-18 21:41:33 -0700 (Fri, 18 Jun 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_363
........
r32157 | kohsuke | 2010-06-18 21:41:47 -0700 (Fri, 18 Jun 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32161 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-19 05:35:41 +00:00
jacob_robertson
1a48b12f46
ViewJobFilter - finalizing api
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32116 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-17 16:47:13 +00:00
kohsuke
30895cd17b
the loop variable is unused.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32103 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-17 00:53:04 +00:00
mindless
e318030209
pass along delay as query param instead of form value
...
so it gets picked up by getDelay(req)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32096 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-16 20:22:48 +00:00
mindless
aad53296de
[FIXED HUDSON-6431] set system privilege during task
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32088 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-16 17:57:03 +00:00
jglick
1d5dbd8a03
[FIXED HUDSON-5551] Keep track of which JDK we have installed, so it is possible to upgrade without changing the tool's name.
...
Note that this will force a redownload of the JDK in everyone's installation, even if it was already the right version; irritating but probably unavoidable.
(Could compare to `java -version` but this would require parsing code to compare download IDs with self-reported versions.)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32082 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 23:50:51 +00:00
jglick
2bd01adb61
[FIXED HUDSON-6559] Proc.joinWithTimeout convenience method.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32076 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 22:19:57 +00:00
kohsuke
da612c83c5
"who am I?" page should be visible to everyone.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32073 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 21:22:50 +00:00
kohsuke
e3fab71cdf
eliminated the exception handling by using the Failure class.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32055 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 18:52:34 +00:00
kohsuke
b53c12d313
regression in my last commit.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32054 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 18:41:24 +00:00
kohsuke
12c4cc253d
added a hook to customize custom node creation.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32052 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 18:00:18 +00:00
kohsuke
1b441d4579
moved the method to the right place.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32048 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 17:41:29 +00:00
kohsuke
2755df4d01
added a convenience method.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32047 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 17:36:23 +00:00
kohsuke
e862b4974b
expose 'descriptor' and 'instance' variable to fragments.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32046 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 17:31:38 +00:00
mdillon
97c46cf8df
Fix close tag of <dl> that was breaking Javadocs
...
Flag summary.jelly view as optional in the NodeProperty Javadocs
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32015 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-14 01:47:45 +00:00
mdillon
8a9fc58a7f
Mention summary.jelly view from HUDSON-6753 in the Javadocs
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32014 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-14 01:13:08 +00:00
sogabe
f7faf4b8e8
Fixed exception without uploaded Plugin.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32004 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-13 12:35:50 +00:00
kohsuke
a89abe260b
finished up an incomplete sentence.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31998 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-12 19:47:07 +00:00
sogabe
1c247fc587
Updated Japanese localization.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31991 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-12 12:03:17 +00:00
kohsuke
e5768ba850
Don't mask the cause of the checkout related exception.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31978 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-12 03:11:42 +00:00
mdillon
9d4ddf351c
[FIXED HUDSON-6753]
...
Added NodeProperty/summary.jelly view hook, called from Computer index page for
all global and local node properties
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31963 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 21:32:16 +00:00
kohsuke
0738a75b2b
Community-contributed localization for ja
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31957 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 19:18:09 +00:00
kohsuke
acda6a56bf
Community-contributed localization for it
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31956 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 19:16:35 +00:00
kohsuke
36e982c849
Community-contributed localization for hu
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31955 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 19:16:19 +00:00
kohsuke
6a379cd967
Community-contributed localization for fr
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31954 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 19:16:07 +00:00
kohsuke
3224eaf547
Community-contributed localization for fi
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31953 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 19:15:21 +00:00
kohsuke
77104da5bc
Community-contributed localization for el
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31951 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 19:15:04 +00:00