Commit Graph
10778 Commits
Author SHA1 Message Date
kohsuke 33f26e439a Hudson shouldn't show a login error page unless the user really failed to login (think about when the user presses a back button.)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30828 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 22:36:13 +00:00
kohsuke eae388edff formatting changes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30811 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 18:52:32 +00:00
kohsuke 29ec8a8a1f clarified doc.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30808 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 18:46:06 +00:00
kohsuke 2e13eb03dd Added a convenience method to reduce the invocation of a deprecated method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30806 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 18:23:26 +00:00
mindless 44096c0d14 [FIXED HUDSON-6437] don't use LIBC outside catch block for LinkageError.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30794 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-06 23:47:32 +00:00
mindless 1ac357c2ea [FIXED HUDSON-6459] workaround for bug in Glassfish Enterprise
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30793 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-06 23:22:23 +00:00
mindless ae064518fc add LOADING overlay for global config page, as in r30681 for job configure page
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30769 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-06 14:53:40 +00:00
mindless 1ee0988b06 update javadoc reference based on r30748 change
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30751 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-05 20:19:13 +00:00
jglick 7cff653800 Do not make DescriptorExtensionList attempt to override a static method from ExtensionList. Should fix CCE caused by last commit.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30748 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-05 18:48:48 +00:00
kohsuke b31b67cc5d also do chmod(2) in an attempt to make a file writable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30734 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-05 04:15:53 +00:00
kohsuke 617af7ded3 merged back the RC branch
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30703 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-04 17:14:24 +00:00
jglick 57a59c535e [FIXED HUDSON-5884] Making compilable with JDK 7 javac.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30701 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-04 15:40:41 +00:00
mindless a84d7dcfca provide visual indication on job configure page of when behavior rules
have been applied and the form is ready to be used..


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30681 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-03 22:47:01 +00:00
mindless dc4fb1386a [FIXED HUDSON-4255] hide exception traces on Update Center page by default
(with "Details" link to see them), to keep this page shorter and make it easier
to find the latest update jobs when retrying after failure.  Also scroll to
bottom of page when it first loads, for the same reason.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30680 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-03 21:08:19 +00:00
mindless 6fecc37fde change java.net to hudson-ci.org in msg for connectivity check
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30667 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-03 18:51:00 +00:00
mindless 0e37effa72 [HUDSON-6252] add test for UrlAnnotator
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30612 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-02 17:38:39 +00:00
mindless 4d61a06045 As instructed by injected test, use <label class="attach-previous">
instead of <label for=...>
Also added null check in javascript for attach-previous,
and fixed typo in error message from injected test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30582 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 22:45:15 +00:00
mindless f855c5ee22 [HUDSON-5951] yay for tests, fix error in new normalize() before it went in any release
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30579 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 21:57:24 +00:00
mindless a6e6c7946a add SubText.groupCount()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30578 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 21:09:41 +00:00
mindless cd8376e9b4 In editableDescription for test results, invalid variable reference for
permission attribute made the add/edit description link show up for all
users, even if they don't have permission to submit the description.
Fixed this so link is omitted when appropriate.
Also changed permission required to add/edit a description from "Build"
to "Update Run".


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30575 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 20:16:54 +00:00
mindless 5974981064 [FIXED HUDSON-6351] update DirectoryBrowserSupport to use long for contentLength,
and update stapler to 1.141 which supports long for contentLength.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30571 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 18:50:16 +00:00
kohsuke 0a62096a6d added a new attribute to avoid nesting in the resulting JSON object.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30530 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 00:53:31 +00:00
kohsuke 23aba80f89 added more databinding controls.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30528 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 23:17:55 +00:00
kohsuke dadecc8180 Added a hidden system property to let people change the 'workspace' directory name, for those who are desparate to make the path fit to 256 chars (this is important for old ASCII-based Win32 apps, such as Cygwin 1.5 --- Unicode based later ones aren't affected.)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30523 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 22:00:36 +00:00
abayer 2eedba8679 [FIXED HUDSON-6394] Email recipient lists now support build parameters
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30485 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 18:38:39 +00:00
mindless ae837cecf4 [FIXED HUDSON-5951] improve normalization of ".." in FilePath
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30462 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 07:35:22 +00:00
sogabe 51773e58ec i18n & l10n(ja) of buildTimeTrend
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30458 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 00:22:52 +00:00
mindless c0db657f22 [HUDSON-5844] set build duration to zero if it comes out negative
(clock was set during a short build?).
Also added i18n for getDurationString() result when build is in progress.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30455 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 18:58:12 +00:00
mindless 55aef4bb5c [FIXED HUDSON-5617] catch and report missing/invalid proxy port value
when submitting proxy settings.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30454 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 18:35:42 +00:00
mindless 95c1ba927a [FIXED HUDSON-5180] remove url binding for this property.. it just shows parameters
form and a Build button that results in error.  index.jelly should only be accessed
via /build (shows index.jelly via _doBuild in this class) where the Build button works.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30453 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 17:07:52 +00:00
mindless 4da5f9486c just say "upstream files" instead of "upstream jar files"
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30452 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 16:45:43 +00:00
mindless 71854d1b69 [FIXED HUDSON-6371] Fix getArtifactsUpTo so it doesn't count collapsed-directories
as artifacts, resulting in too few artifacts returned (since 1.348).
Also fix limit check so it returns "n" items, not n+1.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30451 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 16:13:37 +00:00
mindless 5ad11a0dbc [FIXED HUDSON-6332] for 1.357
Add setOverwrite(true) for local->local copy in FilePath.copyRecursiveTo().
This makes it consistent with master/slave copy (either direction),
and also avoids returning 0 if all files already have current/newer timestamp
which some code (javadoc publishing, copyartifact plugin) would interpret as
copy failure or no matching files found.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30450 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 23:53:41 +00:00
kohsuke 5c339d5040 @nameRef is a mechanism to designate a different parent, so it needs to be in the different branch of if/then/else from e=e.parentNode.
I realize that this is a risky change, so I need to pay attention to the regerssions caused by this.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30449 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 23:43:23 +00:00
kohsuke b988eb8b83 @fillUrl should take the public static fromStapler method into account.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30448 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 21:33:23 +00:00
kohsuke b0f664dfcf improved construction of query string.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30447 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 21:09:40 +00:00
kohsuke 5963112082 f:combobox is preferred now.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30442 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 18:33:49 +00:00
kohsuke 38d8c36aa9 a convenience method to assist trouble-shooting.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30441 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 18:32:45 +00:00
kohsuke 77e5369157 fixed ArrayIndexOutOfBoundsException
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30421 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-26 21:15:34 +00:00
kohsuke 4cc6223c45 @items doesn't exist for <f:select>. C&P error from <f:dropDownList>.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30415 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-26 19:09:25 +00:00
kohsuke f672a29cd5 adding a UI sample for dynamic combo box.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30360 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-23 20:05:12 +00:00
mindless 24bfe8eac5 r30283 introduced an NPE when tests do createSlave(), as there is no Stapler context
to get the rootUrl.  Add null check here.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30359 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-23 18:09:42 +00:00
kohsuke ee711d4e63 added a convenient base class.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30333 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:42:41 +00:00
kohsuke 23c7b05fc7 simplified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30332 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:31:39 +00:00
kohsuke 4af6899fbf @field is supported and @items is not mandatory.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30331 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:25:43 +00:00
kohsuke ad7b504ced user report indicates that if someone puts a null value into a system proeprty we get a hard-to-diagnose NPE. Adding code to proactively watch out for that:
[workspace] $ /usr/lib/jvm/sun-jdk-1.6/bin/java -cp /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-agent-1.355.jar:/usr/share/maven-bin-2.1/boot/classworlds-1.1.jar hudson.maven.agent.Main /usr/share/maven-bin-2.1 /opt/glassfish/server/glassfish/domains/domain1/applications/hudson/WEB-INF/lib/remoting-1.355.jar /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-interceptor-1.355.jar 35855 /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven2.1-interceptor-1.2.jar
<===[HUDSON REMOTING CAPACITY]===>���channel started
channel stopped
ERROR: Processing failed due to a bug in the code. Please report this to users@hudson.dev.java.net
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)
project=hudson.maven.MavenModuleSet@19cc863[Meetspace]
project.getModules()=[hudson.maven.MavenModule@19fef64[Meetspace/com.steeplesoft:meetspace], hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent], hudson.maven.MavenModule@11d8f11[Meetspace/com.steeplesoft.meetspace:plugin-engine], hudson.maven.MavenModule@b6e204[Meetspace/com.steeplesoft.meetspace:webapp], hudson.maven.MavenModule@b097da[Meetspace/com.steeplesoft.meetspace.plugins:helloworld-plugin], hudson.maven.MavenModule@1c18b6a[Meetspace/com.steeplesoft.meetspace.plugins:plugin-api], hudson.maven.MavenModule@1a80928[Meetspace/com.steeplesoft.meetspace.plugins:plugin-engine]]
project.getRootModule()=hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent]
FATAL: null
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30326 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 17:14:06 +00:00
mindless e2666f0645 avoid math on buildNumber value when possible, in case it isn't numeric
(e.g. batch-task plugin)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30303 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 22:54:17 +00:00
mindless 7694a68258 tiny simplification
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30302 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 17:48:32 +00:00
kohsuke d21407be4f [FIXED HUDSON-6311] (actually, this change went in as rev.30287, but I'm testing if the issue update is working again)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30290 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 07:07:55 +00:00
kohsuke 7e183a983b [FIXED HUDSON-6311] reverted the problematic change and instead introduced the ideal signature in a new name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30287 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:29:10 +00:00