* Fix NPE in ReverseBuildTrigger due to null upstream threshold (JENKINS-39044)
* Use ReverseTrigger constructor that is not deprecated
Has the same result as the deprecated constructor that was used before.
* Add automated test of JENKINS-39044
If the ReverseTrigger threshold were null, a null pointer exception would
be thrown. The config round trip operation resets a null threshold to
SUCCESS, so this test reaches inside the job definition and changes the
threshold directly.
Testing done:
* Confirmed that the modified automated test fails when the change to
ReverseTrigger is removed.
* Confirmed that the modified automated test passes when the change to
ReverseTrigger is included.
* Link to GitHub issue
---------
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Warn users of Java 25 end of support September 2029
Beginning in March 2029, users will be warned that Java 25 will be
reaching its end of support in the Jenkins project.
Amends pull request:
* https://github.com/jenkinsci/jenkins/pull/11148
The 2+2+2 Java support plan recommends that we drop support for a Java
line after two years so that we're only supporting two Java versions at
a time. Refer to the blog post:
* https://www.jenkins.io/blog/2023/11/06/introducing-2-2-2-java-support-plan/
Also refer to the Jenkins Enhancement Proposal pull request (incomplete):
* https://github.com/jenkinsci/jep/pull/400
Testing done:
* None. Relying on the existing behavior that I've seen from the Java
17 administrative monitor. It is now shown to users to warn them that
we plan to drop Java 17 support by the end of March 2026
* make the MANAGE permission enabled by default
Removed experimental warning for MANAGE permission and enable it by default.
* update tests to accomodate enabling of Overall/Manage
* [JENKINS-45927] Truncate verbose CauseOfBlockage messages in queue
When multiple nodes reject a task, CompositeCauseOfBlockage previously
joined ALL rejection reasons with "; ", causing extremely verbose
tooltips that could fill the entire browser window.
This fix truncates the message to show only the first 5 reasons,
followed by "... and N more" when there are more than 5 reasons.
Signed-off-by: Steve Armstrong <stevearmstrong-dev@users.noreply.github.com>
* Fix test assertions to account for TreeMap alphabetical ordering
The CompositeCauseOfBlockage uses a TreeMap which sorts keys
alphabetically, so "Reason 10" comes before "Reason 2". Updated
tests to use zero-padded numbers to ensure predictable ordering.
Signed-off-by: W0474997SteveArmstrong <113034949+W0474997SteveArmstrong@users.noreply.github.com>
* Fix Checkstyle import order - static imports must come first
Jenkins Checkstyle rules require static imports to be in their own
group at the top, before regular imports.
Signed-off-by: W0474997SteveArmstrong <113034949+W0474997SteveArmstrong@users.noreply.github.com>
---------
Signed-off-by: Steve Armstrong <stevearmstrong-dev@users.noreply.github.com>
Signed-off-by: W0474997SteveArmstrong <113034949+W0474997SteveArmstrong@users.noreply.github.com>
Co-authored-by: Steve Armstrong <stevearmstrong-dev@users.noreply.github.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Jenkins Release Bot