The previous implementation of 'disable remember me' just removes the
checkbox from the UI. Users still can set the parameter using a web
browser extension, or patch the login page using a Greasemonkey script
and keep using the feature. And just after the feature is enabled, users
still might be able to use it if they loaded the login page early.
This change prevents that by checking the current configuration and, if
'remember me' is disabled, ignoring any headers set.
In this case display the reported exceptions differently and be done with it.
java.lang.NullPointerException
at hudson.diagnosis.OldDataMonitor.report(OldDataMonitor.java:178)
at hudson.util.RobustReflectionConverter.doUnmarshal(RobustReflectionConverter.java:312)
at hudson.util.RobustReflectionConverter.unmarshal(RobustReflectionConverter.java:222)
at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/1436/testReport/hudson.model/UpdateCenter2Test/install/
java.lang.NullPointerException: null
at hudson.Functions$ThreadSorterBase.<init>(Functions.java:1151)
at hudson.Functions$ThreadSorterBase.<init>(Functions.java:1142)
at hudson.Functions$ThreadGroupMap.<init>(Functions.java:1163)
at hudson.Functions.sortThreadsAndGetGroupMap(Functions.java:1136)
at org.jvnet.hudson.test.JenkinsRule$2.evaluate(JenkinsRule.java:482)
Observed in 1.509.3:
java.lang.NullPointerException
at hudson.model.AbstractItem.getRootDir(AbstractItem.java:162)
at hudson.model.Items.getConfigFile(Items.java:236)
at hudson.model.AbstractItem.getConfigFile(AbstractItem.java:461)
at hudson.model.AbstractItem.save(AbstractItem.java:456)
at hudson.model.Job.save(Job.java:152)
at hudson.model.AbstractProject.save(AbstractProject.java:268)
at hudson.diagnosis.OldDataMonitor.doDiscard(OldDataMonitor.java:275)
Conflicts:
core/src/main/resources/hudson/model/UpdateCenter/RestartJenkinsJob/Running/status_de.properties
core/src/main/resources/hudson/model/UpdateCenter/body_de.properties
core/src/main/resources/hudson/model/UpdateCenter/index_fr.properties
core/src/main/resources/hudson/model/View/sidepanel_cs.properties
Conflicts are resolved in favor of the master branch, assuming people
editing the core is more trustworthy.
This reverts commit b354bca000.
Unfortunately, Afrikaaans is the default selection of the language, and
some people apparently contributed translations without selecting the
proper locale. I see some Hebrew text in here, which was easier to
distinguish because it uses an entirely different character set.
But I have to assume other locales are mixed in here as well.
I'll remove the default language from the translation assistance plugin.
But in the mean time, we don't have anyone who's capable of reviewing
this, so I'm forced to roll back.