Jesse Glick
53a8ab2028
Pull #979 : noting.
...
[JENKINS-11347] [JENKINS-16692] might have been fixed by this, but unclear.
2013-10-23 15:04:51 -04:00
Jesse Glick
7c606ae5c8
Merge branch 'fix-refused-build-cli-npe' of github.com:marco-miller/jenkins into marco-miller-fix-refused-build-cli-npe
2013-10-23 14:58:58 -04:00
Jesse Glick
2771d23307
ExtensionList.remove was unconditionally returning true, against Collection contract.
2013-10-23 14:39:52 -04:00
Marco Miller
365df70b1f
Refactor string constant duplicate in BuildCommand and BuildCommandTest.
2013-10-23 14:14:14 -04:00
Jesse Glick
728caf4dd0
Noting executor-ondemand branch merge.
2013-10-23 12:00:10 -04:00
Marco Miller
8db9ceaccb
Merge branch 'fix-refused-build-cli-npe' of github.com:marco-miller/jenkins into fork_fix-refused-build-cli-npe
...
Conflicts:
core/src/main/java/hudson/cli/BuildCommand.java
2013-10-23 11:38:41 -04:00
Marco Miller
eaeb45bdaa
Null check for if build scheduling Refused by extension => not in Queue.
...
New test in hudson/cli/BuildCommandTest.groovy, as well as companion
@TestExtension class, thanks to Jesse' suggestion. This is so that we
test this hereby fixed case of a QueueDecisionHandler Refusing a build,
leading to that null value now checked and handled accordingly.
Commit also includes sorted imports and a few minor indentation fixes,
as well as another (very) minor string change.
2013-10-23 11:05:03 -04:00
Jesse Glick
dceac8f0ac
[FIXED JENKINS-19173] Added ContextMenuVisibility marker interface for Action’s.
2013-10-23 10:44:01 -04:00
Vojtěch Juránek
549e23ba64
Merge pull request #980 from JasnaPaka/master
...
Fix typo for Czech (cs) L10N.
2013-10-23 06:21:57 -07:00
Olivier Dagenais
ba5003a510
Switch to User.current
2013-10-23 09:10:55 -04:00
Pavel Cvrcek
cdddd38145
Fix typo for Czech (cs) L10N.
2013-10-23 14:53:49 +02:00
Jesse Glick
bdaea02d88
Fail with a clear message when a mode parameter is given but no such descriptor exists.
...
Otherwise get e.g.:
java.lang.IllegalArgumentException: java.lang.NullPointerException
at hudson.model.ItemGroupMixIn.createProject(ItemGroupMixIn.java:253)
at hudson.model.ItemGroupMixIn.createTopLevelItem(ItemGroupMixIn.java:175)
at jenkins.model.Jenkins.doCreateItem(Jenkins.java:2827)
at jenkins.model.Jenkins.doCreateItem(Jenkins.java:308)
at …
Caused by: java.lang.NullPointerException
at hudson.model.ItemGroupMixIn.createProject(ItemGroupMixIn.java:251)
... 65 more
2013-10-22 18:45:52 -04:00
Jesse Glick
e6632cdaab
Throw Failure, which FormException would just delegate to when we are not coming from a regular form’s Apply button, as in this case.
2013-10-22 18:42:34 -04:00
Jesse Glick
d7fb1f7ed2
Simpler and better to throw Failure than to hand-craft an error result.
2013-10-22 18:41:25 -04:00
Jesse Glick
08aaf2b9b3
Trying to make AsynchPeopleTest more robust.
...
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/1369/testReport/junit/hudson.model/AsynchPeopleTest/display/
org.junit.ComparisonFailure: expected:<[display: none;]> but was:<[]>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at hudson.model.AsynchPeopleTest.display(AsynchPeopleTest.java:44)
was presumably a race condition.
Could reproduce by adding a Thread.sleep into AsynchPeople.compute.
This patch (with waitForBackgroundJavaScript) avoids that error;
but causes the assertNotNull at the end to fail, for reasons TBD.
2013-10-22 17:38:49 -04:00
Marco Miller
b24aefb31f
Null check for if build scheduling Refused by extension => not in Queue.
...
No test added in hudson/cli/BuildCommandTest.groovy, as this case is no
longer reproducible with bare Jenkins core and cli. Indeed, one now
need a plugin to extend QueueDecisionHandler, so it can Refuse a build,
hence test this specific null case. Regression tests do all pass still.
2013-10-22 15:13:51 -04:00
Olivier Dagenais
1f5fe41383
Enhance the current user link in the header.
...
1 - Link to user's ID, which is properly escaped.
2 - Display user's full name if possible, otherwise their ID.
2013-10-22 14:52:51 -04:00
Jesse Glick
ae6ec8491b
Can be confusing to import nested classes.
2013-10-22 12:32:18 -04:00
Jesse Glick
9b53643c7a
Updated to maven-plugin 2.0 general release.
2013-10-22 08:24:08 -04:00
Jesse Glick
82b6e8e02b
Fixed [JENKINS-20143], not [JENKINS-20123].
2013-10-22 08:13:49 -04:00
Harald Albers
133be863af
fixed broken link in changelog
2013-10-22 11:41:44 +02:00
Nicolas De Loof
7115589134
[FIXED JENKINS-20143] Pass full list of all possible jobs to ViewJobFilter when recurse option is set
2013-10-22 10:05:21 +02:00
Kohsuke Kawaguchi
f9f1483865
the trunk is toward 1.538-SNAPSHOT
2013-10-21 21:56:36 -07:00
Kohsuke Kawaguchi
900e12d6d9
creating an RC branch
2013-10-21 21:56:31 -07:00
Kohsuke Kawaguchi
8dc68b7b99
merged back the RC branch
2013-10-21 21:53:50 -07:00
Kohsuke Kawaguchi
deb3fec922
updated changelog as a part of the release
2013-10-21 21:53:27 -07:00
Jesse Glick
b8ace7789a
Ensuring that getRelativeNameFrom actually inserts ../ sequences where it should.
...
The implementation of the method is rather hard to follow so this certainly needs to be tested!
2013-10-21 15:34:58 -04:00
Jesse Glick
bac8b9795a
Clarified Javadoc: non-display names use '/' as a separator.
2013-10-21 15:34:17 -04:00
Jesse Glick
0e3afeb6c5
Sources are UTF-8 so might as well use the raw character when specifying something that will be a part of output.
2013-10-21 14:20:24 -04:00
Harald Albers
76bd6d6b91
purged orphaned messages (UpdateCenter)
2013-10-21 09:49:24 +02:00
Harald Albers
d138464a30
updated German localization (UpdateCenter)
2013-10-21 09:49:23 +02:00
Kohsuke Kawaguchi
613bd6b550
updated changelog for release
2013-10-20 23:06:14 -07:00
Kohsuke Kawaguchi
80ff4fe06c
[maven-release-plugin] prepare for next development iteration
2013-10-20 22:57:55 -07:00
Kohsuke Kawaguchi
25c4e09528
[maven-release-plugin] prepare release jenkins-1.536
jenkins-1.536
2013-10-20 22:57:54 -07:00
Kohsuke Kawaguchi
687a0dbf63
Community-contributed localization for zh_TW (zh_TW)
2013-10-20 22:10:05 -07:00
Kohsuke Kawaguchi
918c619da1
Community-contributed localization for zh_CN (zh_CN)
2013-10-20 22:10:04 -07:00
Kohsuke Kawaguchi
c82cafe98a
Community-contributed localization for Ukrainian (uk)
2013-10-20 22:10:04 -07:00
Kohsuke Kawaguchi
b373ec0d3e
Community-contributed localization for Turkish (tr)
2013-10-20 22:10:04 -07:00
Kohsuke Kawaguchi
a9079e82e5
Community-contributed localization for Thai (th)
2013-10-20 22:10:04 -07:00
Kohsuke Kawaguchi
bf3962fc6b
Community-contributed localization for Telugu (te)
2013-10-20 22:10:04 -07:00
Kohsuke Kawaguchi
59682d6a4f
Community-contributed localization for Tamil (ta)
2013-10-20 22:10:04 -07:00
Kohsuke Kawaguchi
d983b58739
Community-contributed localization for sv_SE (sv_SE)
2013-10-20 22:10:03 -07:00
Kohsuke Kawaguchi
0ec13420df
Community-contributed localization for Serbian (sr)
2013-10-20 22:10:03 -07:00
Kohsuke Kawaguchi
b9f4af6890
Community-contributed localization for Albanian (sq)
2013-10-20 22:10:03 -07:00
Kohsuke Kawaguchi
60d8abc254
Community-contributed localization for Slovenian (sl)
2013-10-20 22:10:03 -07:00
Kohsuke Kawaguchi
6bff2d147b
Community-contributed localization for Slovak (sk)
2013-10-20 22:10:03 -07:00
Kohsuke Kawaguchi
10206c863c
Community-contributed localization for Sinhala; Sinhalese (si)
2013-10-20 22:10:03 -07:00
Kohsuke Kawaguchi
7828dcb46d
Community-contributed localization for Russian (ru)
2013-10-20 22:10:02 -07:00
Kohsuke Kawaguchi
a4ef863b03
Community-contributed localization for Romanian; Moldavian; Moldovan (ro)
2013-10-20 22:10:02 -07:00
Kohsuke Kawaguchi
1227d3b155
Community-contributed localization for pt_PT (pt_PT)
2013-10-20 22:10:02 -07:00