Commit Graph
18880 Commits
Author SHA1 Message Date
Jesse Glick a60de6ce6a Javadoc comment. builds/191 changes/191 2014-07-16 09:35:27 -04:00
Jesse Glick 0511da3ed0 Merge branch 'master' of git://github.com/jenkinsci/jenkins builds/190 changes/190 2014-07-16 09:26:39 -04:00
Jesse Glick 57c2d77085 @since 2014-07-16 08:59:50 -04:00
Daniel Beck ef9db76810 Merge pull request #1318 from daniel-beck/JENKINS-2673
[JENKINS-2673] Clarify that suggestion means polling just once per hour
2014-07-16 09:27:13 +02:00
Jesse Glick 17d9093165 [FIXED JENKINS-17667] Fixed race condition when running tool installers on many slaves at once.
Correcting change made in #1176, which introduced an NPE, to restore original logic merely wrapped in a synchronized block.
Reproduced NPE in new functional test (original bug probably very hard to reproduce).
builds/189 changes/189
2014-07-15 13:36:10 -04:00
Jesse Glick 9d016f68fd Report a warning to build log when the selected JDK cannot be found. 2014-07-15 13:25:51 -04:00
Jesse Glick 45dec68e00 FingerprintCleanupThread ought to write messages to its saved log file. builds/188 changes/188 2014-07-15 11:54:01 -04:00
Jesse Glick 84d49ceef2 [JENKINS-14749] Suppress warnings about expected exception from prototype.js#HAS_EXTENDED_CREATE_ELEMENT_SYNTAX. builds/187 changes/187 2014-07-15 09:37:00 -04:00
Jesse Glick 759c8a52ce [JENKINS-14749] Temporarily work around CSS errors by just suppressing the warnings until they can be fixed. builds/186 changes/186 2014-07-15 09:22:47 -04:00
Jesse Glick d85fd687fe Toning down some uninteresting logging which just clutters test runs. builds/185 changes/185 2014-07-15 09:02:10 -04:00
Jesse Glick 833130c945 The JNLP port is not interesting enough to warrant logging at INFO during every startup, including the vast majority of functional tests which do not even use JNLP slaves. 2014-07-15 09:01:25 -04:00
Jesse Glick 71469cea85 JUnit 4. builds/184 changes/184 2014-07-15 08:40:48 -04:00
Jesse Glick 9d960e68ca Updated Javadoc of AntClassLoader2. builds/183 changes/183 2014-07-14 17:40:54 -04:00
Jesse Glick 6f4242114e [JENKINS-23774] Better report the case that the incoming web request has no Referer header set. builds/182 changes/182 2014-07-14 15:25:07 -04:00
tfennelly a277b73497 [JENKINS-23492] Fixed auth/login links in top navbar 2014-07-14 12:57:41 +01:00
tfennelly 65d3799f15 [JENKINS-23492] Fixed issue where empty welcome page callout block was appearing. 2014-07-14 12:57:41 +01:00
Kohsuke Kawaguchi b598301ec3 the trunk is toward 1.574-SNAPSHOT 2014-07-13 21:25:30 -07:00
Kohsuke Kawaguchi 767451cf29 creating an RC branch 2014-07-13 21:25:24 -07:00
Kohsuke Kawaguchi 56d5f40f4f merged back the RC branch 2014-07-13 21:24:01 -07:00
Kohsuke Kawaguchi 6201f04ad2 updated changelog as a part of the release 2014-07-13 21:23:58 -07:00
Kohsuke Kawaguchi 3d40861c5e updated changelog for release 2014-07-13 19:08:42 -07:00
Kohsuke Kawaguchi 7db8af10b8 [maven-release-plugin] prepare for next development iteration 2014-07-13 19:00:24 -07:00
Kohsuke Kawaguchi d9380f0d4d [maven-release-plugin] prepare release jenkins-1.572 jenkins-1.572 2014-07-13 19:00:23 -07:00
Fernando Boaglio 6900c7ae7f pt_BR translation 2014-07-12 22:13:12 -03:00
Daniel Beck 94bc3be9c6 [JENKINS-2673] Clarify that suggestion means polling just once per hour 2014-07-12 22:50:58 +02:00
Daniel Beck 87fe6ce3f8 Merge pull request #1157 from phoenix384/patch-2
updated German translation
2014-07-12 21:50:21 +02:00
Daniel Beck 72f37e4145 Remove JENKINS-22395, JENKINS-18065 from 1.572 section 2014-07-12 02:28:59 +02:00
Daniel Beck fdc0b5c565 Noting #1314, #1316, #1308, JENKINS-17667, JENKINS-22395, JENKINS-18065 2014-07-12 02:24:00 +02:00
Kohsuke Kawaguchi 38ab6192a8 [ZD-19640] diagnostic improvement in case impersonation failed.
I think this is an oversight in bded790f46. A random attacker wouldn't know the correct API token value,
so given that it matched, I think the caller should know that it was the impersonation that failed, not the authentication.

Also log this at a higher level, since this indicates a problem in SecurityRealm.
2014-07-11 16:32:49 -07:00
Kohsuke Kawaguchi f09430189e Bundling the latest 2014-07-11 16:21:46 -07:00
Daniel Beck 5ef293d7a0 Merge pull request #1176 from jkolash/master
[FIXED JENKINS-17667] - Syncronization of InstallerTranslator::getToolHome()
2014-07-12 01:18:54 +02:00
Daniel Beck 7b70bd96d7 Merge pull request #1189 from jeanblanchard/master
Fix changelog generation in ExtractResourceWithChangesSCM
2014-07-12 00:09:51 +02:00
CloudBees DEV@Cloud 01b888eb59 Merge REMERGE_HEAD into HEAD 2014-07-11 22:07:51 +00:00
Daniel Beck 128ac8b30c Merge pull request #1308 from Simek/patch-1
Break links inside pre tags
2014-07-12 00:05:08 +02:00
Jesse Glick 2f58ceb1a6 [JENKINS-18065] Uncommenting original test.
The actual implementation does not behave as nicely as one would hope, for a few reasons:
1. isEmpty actually tries to load the newestBuild, rather than simply checking whether there is some idOnDisk.
   Arguably this is necessary, since there could be an unloadable build record, in which case it would be technically correct for the map to be considered empty.
2. Loading AbstractLazyLoadRunMap.newestBuild calls search(MAX_VALUE, DESC), which behaves oddly, by doing a binary search, and thus perhaps loading lg(|map|) entries.
   You would think that it would suffice to check for the last member of idOnDisk in index.byId.
3. The iterator eagerly loads the next value before hasNext has even been called.
   Looks bad in a test, though it probably has little practical impact since most callers would be calling hasNext soon afterward anyway.
   Might cause one extra build record to be loaded unnecessarily from a limited RunList.
builds/181 changes/181
2014-07-11 17:17:45 -04:00
Jesse Glick da57ad5c30 [JENKINS-18065] 54c0846 amendment: presumably RunMap.entrySet().iterator().next().setValue(…) should be illegal. builds/180 changes/180 2014-07-11 16:32:53 -04:00
Jesse Glick 11bc4ba268 Reverting apparently unintentional change from 54c0846. 2014-07-11 16:22:15 -04:00
Kohsuke Kawaguchi 54c084613f [FIXED JENKINS-18065] made ALLRM.entrySet() smarter 2014-07-11 12:03:11 -07:00
Kevin Burke 8057217f1f Line up elements in the left side
Now you can draw a straight vertical line and see that the logo image, the
beginning breadcrumb, and the build history are all in a straight line.
2014-07-11 17:40:31 +01:00
Jesse Glick b7ec8578f9 [JENKINS-22395] Taking advantage of BuildReference.clear (just introduced in b6226ad) to simplify test by not requiring a custom build reference holder just to simulate GC.
Confirmed that dropLinksAfterGC and dropLinksAfterGC2 both fail in the expected way (b1a.nextBuild == b2) after commenting out the call to createReference().clear() in dropLinks.
(Also that they fail as expected in assertNotSame if the reference is not cleared at all.)
builds/179 changes/179
2014-07-11 10:56:00 -04:00
Kohsuke Kawaguchi aa8e0b4f0e [JENKINS-22395] more diagnostics
Just in case the previous fix didn't address the root cause of ZD-11985 (and given the time it takes for changes like this to land in LTS), I'm adding additional diagnostics that let us track how previous/next builds are getting discovered
2014-07-10 16:52:52 -07:00
Kohsuke Kawaguchi 5e7efa5bfc Merge branch 'master' of github.com:jenkinsci/jenkins 2014-07-10 16:34:46 -07:00
Kohsuke Kawaguchi fe3575c176 Doc improvements 2014-07-10 16:30:01 -07:00
Kohsuke Kawaguchi b6226ad2d1 [FIXED JENKINS-22395] redoing the fix in f1430a2
Based on the last few commits, I proved that the original fix in f1430a2
doesn't really address the problem.

That is, once b2 is deleted, and after sufficient garbage collection,
we can make b2.previousBuild.get() be null, and then
b2.getPreviousBuild().getNextBuild() ends up incorrectly returning b2.

In this commit, I roll back that part of f1430a2, and then fix the
problem differently.

I started thinking that the main problem we are trying to fix here
is that the deleted build object should be unreferenceable. That is,
it should behave almost as if the object has already been GCed.
The easiest way to do this is to clear a BuildReference object,
since we always use the same BuildReference object for all inbound
references.

This change allows us to clear BuildReference. Code like
b2.getPreviousBuild() will continue to try to update
b1.nextBuildR to b2, but it will only end up wiping out the field,
only to have b1.getNextBuild() recompute the correct value.

This fix makes both test cases pass in LazyBuildMixInTest.
2014-07-10 16:30:01 -07:00
Kohsuke Kawaguchi 7b1b50c85a [JENKINS-22395] correcting the control test
As I step-executed the code, I discovered b2.getPreviousBuild() was getting invoked
between BRHF.drop(b1) and b2.dropLinks() call, in PeepholePermalink.RunListenerImpl.onDeleted()
because Run.delete() calls RunListener.fireDeleted(this).

Thus in effect the sequence of the call order was as follows:

        assertEquals(1, BRHF.drop(b1));
        b2.getPreviousBuild(); // happens indirectly in PeepholePermalink
        b2.delete();
        FreeStyleBuild b1a = b2.getPreviousBuild();

This defeats the purpose of the fix, because in this call sequence, by b2.dropLinks()
as implemented before f1430a2 will correctly fix up b1a.nextBuildR to b3.

For the test to work as intended, it is important that b2.previousBuildR.get()==null
during dropLinks(). That is what causes b2.getPreviousBuild() in the next line to go
load b1a, and sets up b1a.nextBuildR to b2, and trigger the assertion error.

Added a code to remove all RunListeners. With this change, the test now fails without
the fix in f1430a2.
2014-07-10 16:05:23 -07:00
Kohsuke Kawaguchi 53e95ee517 [JENKINS-22395]
I'm not sure if I understand how the original fix in PR #1190 (f1430a2) addresses the problem.

My understanding is of the problem is as follows:

  - someone deletes 'b2' but holds on to its reference (could be different threads)
  - someone calls b2.getPreviousBuild()
    - if b2.previousBuildR is null, then this triggers the loading of b1, and
      that process sets up a bi-di link via b1<->b2 via b1.nextBuildR <-> b2.previousBuildR
    - this makes b1.getNextBuild() incorrectly return b2

Presumably f1430a2 addresses this somehow, but I think I can induce this situation in other ways,
which is what dropLinksAfterGC2() does.

In this test,

initial state:

   b1 <-> b2 <-> b3

   we load everyone and connect them all up

after deleting b2:

   b1 <--------> b3
    ^            ^
    +---- b2 ----+

  b1 and b3 points each other, and b2 still refers to each side

after dropping b1:

          b2 --> b3

now, here, when I do b2.getPreviousBuild(), it loads b1a and it sets b1a.nextBuildR to b2.

    b1a <-> b2 --> b3

So I claim this is a proof that the fix is incomplete, even for the problem JENKINS-22395 has discovered.

I don't think that the problem is for the dropLinks call to fail to patch up references.
The problem is that b2.getPreviousBuild() forcing b1 to point to b2, because if b2 is deleted and assumed to be
invalid, then no matter what bX this method will find you never want bX.nextBuildR to point to b2.
2014-07-10 15:24:34 -07:00
Kohsuke Kawaguchi fb47f1d113 update to #index must be synchronized 2014-07-10 14:26:39 -07:00
Oliver Gondža 2214e9cedb Merge pull request #1314 from kevinburke/lighter
Switch underline/non underline on sidebar
2014-07-10 12:48:06 +02:00
Daniel Beck 682ba570a5 Noting #1310, #1294, #1311 2014-07-09 22:54:48 +02:00
Kevin Burke c438a5f2ab Switch underline/non underline on sidebar
The underline adds slightly too much visual weight to the links in question.
This changes the links to not have an underline by default, while still adding
the underline when the link is hovered.

Normally accessibility requirements demand that you add an underline for all
clickable text. However, in this case the positioning of the elements, their
changed color, the presence of an icon next to the links, and the link hover
effect combine to give these elements the appearance of clickability.
2014-07-09 13:01:46 -07:00