Commit Graph
19385 Commits
Author SHA1 Message Date
Jesse Glick aac8c23972 [FIXED JENKINS-25081] Memory leak in BoundObjectTable when ProgressiveRendering is used. builds/271 changes/271 2014-10-09 17:58:39 -04:00
Jesse Glick f463abbe53 [FIXED JENKINS-25074] Make sure to call Job.getBuildHealthReports just once per t:buildHealth render. builds/270 changes/270 2014-10-09 15:24:00 -04:00
Kohsuke Kawaguchi 9c96f3dcca [FIXED JENKINS-25065 JENKINS-24987]
Based on the reaction to these issues and JENKINS-24514, I'm partially
reverting the original change, and bringing the umask default back to
022.

The configurable option does enable the user to choose a different
umask, so I think I can still claim that JENKINS-24514 is addressed.
2014-10-09 11:23:01 -07:00
Tom Fennelly 4eefff9f95 Merge pull request #1423 from tfennelly/JENKINS-24703
[FIXED JENKINS-24703] Do not set any colors for input elements
2014-10-09 18:35:13 +01:00
quinox f98699fa48 [FIXED JENKINS-24703] Do not set any colors for input elements 2014-10-09 15:59:11 +01:00
Jesse Glick e72c11ae4b ssh-credentials 1.6.1, amending 434aecef2f. builds/269 changes/269 2014-10-08 17:13:42 -04:00
Kohsuke Kawaguchi 65c2d37881 Integrated the new version.
This version includes a change from christ66 in
https://github.com/stapler/stapler/pull/40
2014-10-08 13:47:22 -07:00
Kohsuke Kawaguchi fec8786781 Upgraded Apache Ant
Turns out there was a security advisory posted on Ant 1.8.3
(http://ant.apache.org/security.html) though the affected code is not
used in Jenkins.

Reference: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-2098
2014-10-08 13:47:22 -07:00
Jesse Glick c8b6f12784 Merge pull request #1414 from mattmoor/master
Convert AbstractProject to better utilize structure form submission.
2014-10-08 00:32:57 -04:00
Jesse Glick 0adf979c4a [FIXED JENKINS-10450] Use 404 status code for noWorkspace.jelly. builds/268 changes/268 2014-10-07 23:33:30 -04:00
Jesse Glick 434aecef2f ssh-slaves 1.8 2014-10-07 23:09:18 -04:00
Jesse Glick bbb60e51ed Adding Option.toString; should make ListBoxModel.toString more useful for tests or debugging. 2014-10-07 14:06:49 -04:00
Jesse Glick f8146742ed Better robustness when action loading fails.
For example, the following should not cause Run.onLoad itself to fail:
java.lang.NullPointerException
	at org.jenkinsci.plugins.workflow.steps.input.InputAction.onLoad(InputAction.java:29)
	at hudson.model.Run.onLoad(Run.java:342)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:332)
builds/267 changes/267
2014-10-06 12:54:24 -04:00
Jesse Glick 2c5eb2116a Merge branch 'master' of git://github.com/jenkinsci/jenkins builds/266 changes/266 2014-10-06 11:08:53 -04:00
Kohsuke Kawaguchi 02302d4857 the trunk is toward 1.585-SNAPSHOT 2014-10-06 07:56:32 -07:00
Kohsuke Kawaguchi 89d749ee9a creating an RC branch 2014-10-06 07:56:23 -07:00
Jesse Glick 6825121f06 [JENKINS-21224] Defend against exceptions in listeners, for now just for ItemListener.
java.lang.RuntimeException: Unable to copy /…/jobs/…/config.xml
	at hudson.plugins.jobConfigHistory.FileHistoryDao.createNewHistoryEntryAndCopyConfig(FileHistoryDao.java:252)
	at hudson.plugins.jobConfigHistory.FileHistoryDao.createNewItem(FileHistoryDao.java:238)
	at hudson.plugins.jobConfigHistory.JobConfigHistoryJobListener.onCreated(JobConfigHistoryJobListener.java:31)
	at hudson.model.listeners.ItemListener.fireOnCreated(ItemListener.java:161)
	at jenkins.model.Jenkins.putItem(Jenkins.java:2483)
	at …
Caused by: java.io.FileNotFoundException: /…/jobs/…/config.xml (No such file or directory)
	at java.io.FileInputStream.open(Native Method)
	at java.io.FileInputStream.<init>(FileInputStream.java:120)
	at hudson.plugins.jobConfigHistory.FileHistoryDao.copyConfigFile(FileHistoryDao.java:178)
	at hudson.plugins.jobConfigHistory.FileHistoryDao.createNewHistoryEntryAndCopyConfig(FileHistoryDao.java:250)
	... 108 more
builds/265 changes/265
2014-10-06 10:18:16 -04:00
CloudBees DEV@Cloud 7a965452f4 Merge REMERGE_HEAD into HEAD 2014-10-03 21:11:45 +00:00
CloudBees DEV@Cloud 14cd555617 Merge REMERGE_HEAD into HEAD 2014-10-03 20:48:24 +00:00
CloudBees DEV@Cloud 70f84a6fef Merge commit '383b90eaf5b9b296c228836316357989ea157a02' builds/264 2014-10-03 20:32:16 +00:00
Jesse Glick 383b90eaf5 waitUntilNoActivityUpTo should list OneOffExecutable.executor if that is the problem. changes/264 2014-10-03 16:31:03 -04:00
Daniel Beck fda84f456f Merge pull request #1306 from bkmeneguello/post-cancel-shutdown
[FIXED JENKINS-23020 JENKINS-23942] Convert the queue's cancel shutdown to POST
2014-10-03 22:02:30 +02:00
Jesse Glick c4c55d1c03 waitUntilNoActivityUpTo should also produce a thread dump (despite 80da8f2). builds/263 changes/263 2014-10-03 16:00:56 -04:00
Daniel Beck 2b6c00db34 [FIXED JENKINS-24966] Return failure when port is in use
Both 0 and 1 are used to indicate some kind of success (the latter when Jenkins doesn't need to be started because it was already running), so we need to return 2.
2014-10-03 16:07:24 +02:00
Jesse Glick c3d7e940d6 NPE during shutdown.
java.lang.NullPointerException
	at hudson.model.User.idStrategy(User.java:140)
	at hudson.model.User.getOrCreate(User.java:373)
	at hudson.model.User.get(User.java:366)
	at hudson.model.User.get(User.java:331)
	at hudson.model.User.get(User.java:441)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.getAuthentication(CpsFlowExecution.java:614)
	at org.jenkinsci.plugins.workflow.cps.CpsVmThread.run(CpsVmThread.java:20)
builds/262 changes/262
2014-10-02 16:47:44 -07:00
Daniel Beck d10b9fab1d Fix layout 2014-10-01 23:15:46 +02:00
Kohsuke Kawaguchi 926e5f10bc merged back the RC branch 2014-10-01 12:54:13 -07:00
Kohsuke Kawaguchi b875d2cf0e updated changelog as a part of the release 2014-10-01 12:54:08 -07:00
Kohsuke Kawaguchi 1782a256b3 updated changelog for release 2014-10-01 10:45:16 -07:00
Kohsuke Kawaguchi 357af23467 [maven-release-plugin] prepare for next development iteration 2014-10-01 10:39:00 -07:00
Kohsuke Kawaguchi 4ea483f233 [maven-release-plugin] prepare release jenkins-1.583 jenkins-1.583 2014-10-01 10:39:00 -07:00
Kohsuke Kawaguchi 496f569657 Recording changes 2014-10-01 10:18:36 -07:00
Kohsuke Kawaguchi a0fe61a098 Merge remote-tracking branch 'security/security' into rc
Conflicts:
	.idea/encodings.xml
	core/pom.xml
	pom.xml
	test/src/test/java/hudson/tasks/junit/CaseResultTest.java
2014-10-01 10:09:42 -07:00
Kohsuke Kawaguchi 481f28b73f Merge remote-tracking branch 'security/security-rc' into rc 2014-10-01 10:06:37 -07:00
Kohsuke Kawaguchi be195b0e19 [FIXED SECURITY-150]
Integrated the change
2014-10-01 08:21:06 -07:00
Matt Moore eec43983a3 This change converts several optionalBlock's wrapping a single field to inline="true".
By converting several optionalBlock entries to use inline="true", we convert the submitted JSON from:
   "hasPropertyFoo": {
     "propertyFoo": "value"
   },

which is a somewhat unnatural naming scheme, to:
   "hasPropertyFoo": true,
   "propertyFoo": "value",

This enables us to use the pattern:
   if(json.optBoolean("hasPropertyFoo", json.has("propertyFoo"))) {
     ...
   }

To permit either of the following as JSON blobs, for specifying a value for "propertyFoo":
1) "hasPropertyFoo": true,            # What comes through from jelly
   "propertyFoo": "value",

2) "propertyFoo": "value",

It also allows any of the following as JSON blobs, for NOT specifying a value for "propertyFoo":
3) "hasPropertyFoo": false,           # What comes through from jelly
   "propertyFoo": "value",

4) "hasPropertyFoo": false,

5) (nothing specified)

NOTE: The main interest in flexibility in what JSON comes through is in support of: https://wiki.jenkins-ci.org/display/JENKINS/YAML+Project+Plugin, this is also the purpose of the couple renames that are mixed in with this.
2014-09-29 09:36:19 -07:00
Kohsuke Kawaguchi 09c59c0171 merged back the RC branch 2014-09-28 22:33:54 -07:00
Kohsuke Kawaguchi 45ff0bcb83 updated changelog as a part of the release 2014-09-28 22:33:50 -07:00
Kohsuke Kawaguchi e53fde1060 Merge pull request #1410 from rodrigc/JENKINS-24521
Add getFieldOrder() methods.
2014-09-28 21:34:38 -07:00
Matt Moore 86c911e8b9 Switch to using inline optionalBlock for several AbstractProject checkboxes so that we are passed a boolean, instead of either null or {}.
NOTE: The discrepancy between inline-optionalBlock and f:entry/f:checkbox is the text alignment, which optionalBlock keeps consistent with other elements (and what is done for these today).
2014-09-28 21:10:40 -07:00
Matt Moore 873de8cd22 Switch the source of a number of AbstractProject config options from StaplerRequest to JSONObject.
This change shifts the way a number of form elements are accessed when handling AbstractProject's doConfigSubmit from using "req.getParameter(...)" style access to using JSON-style (structured form submission) access through "reg.getSubmittedForm()".
2014-09-28 19:33:47 -07:00
Kohsuke Kawaguchi e026d522d3 updated changelog for release 2014-09-28 14:07:38 -07:00
Kohsuke Kawaguchi 4a8f12b3f2 [maven-release-plugin] prepare for next development iteration 2014-09-28 14:01:28 -07:00
Kohsuke Kawaguchi 3c99828edf [maven-release-plugin] prepare release jenkins-1.582 jenkins-1.582 2014-09-28 14:01:28 -07:00
Harald Albers 1759ffb3e1 localization cleanup 2014-09-28 18:01:55 +02:00
Craig Rodrigues 1c1a4b7544 Add getFieldOrder() methods.
Add getFieldOrder() methods to classes which extend com.sun.jna.Structure,
for compatibility with newer versions of JNA.  [JENKINS-24521]
2014-09-27 17:22:54 -07:00
Kohsuke Kawaguchi 28d997704f [FIXED SECURITY-159]
Bumping up dependencies to 1.3.1, with extra precaution to make
DiskFileItem non-serializable
2014-09-27 15:51:47 -07:00
Kohsuke Kawaguchi 5f1ff56d8c Maven module was removed 2014-09-27 15:46:57 -07:00
Kohsuke Kawaguchi b6a15f502c Winstone now report a proper version during startup and in the 'Server' header 2014-09-27 12:54:28 -07:00
Kohsuke Kawaguchi ee19d1e34f Merge pull request #1400 from msrb/rpm-init-script
init script: don't try to run on Java 5
2014-09-25 17:38:53 -07:00