OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-14 04:22:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
19,502 Commits 58 Branches 1,942 Tags
changes/286
Commit Graph
19502 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jesse Glick 4cb7414e90 fromExternalizableId should just return null, not throw IAE, if the job has since been renamed/move/deleted. 
(It could already return null if the run has since been deleted; #1264 failed to mark this properly.)
Reserving IAE for inputs that getExternalizableId could not actually have produced,
and making sure to also throw this in case of non-numeric text after the hash.
Adding Javadoc for both methods.
builds/286 changes/286 		2014-10-28 11:23:03 -07:00
Stephen Connolly 07fb00e05a If you are synchronizing on something to access a volatile, then you are doing something wrong 
- Yet more interrupting bad patterns, especially where we expect the node monitor to take up to 30 seconds to complete if an async variety
 2014-10-28 13:48:00 +00:00
Stephen Connolly 68f6222633 Prevent a storm of node monitor updates when there is a storm of nodes coming on line within 1 second 
- The old code would result in multiple triggered updates, with corresponding interrupts of in-progress updates
  when faced with lots of slaves coming on line within 1 second of each other.

- New code will ensure that one and only one of the scheduled tasks (i.e. the last one) will trigger the updates.
 2014-10-28 13:27:24 +00:00
Stephen Connolly 1587511c55 fix @since tags 2014-10-28 13:27:03 +00:00
Stephen Connolly bf2206d783 Merge pull request #1433 from stephenc/master 
Refactor NodeProvisioner to allow for extension of strategies
 2014-10-28 13:21:56 +00:00
Oleg Nenashev a22e20d467 Merge pull request #1419 from dnozay/patch-1 
JENKINS-21160: update pom.xml to warn about mismatched args4j
 2014-10-27 20:40:47 +03:00
Oleg Nenashev 8e0b87c0ac Merge pull request #1438 from daniel-beck/JENKINS-15252 
[FIXED JENKINS-15252] Explain problems with CSRF protection
 2014-10-27 08:01:40 +03:00
Kohsuke Kawaguchi 6ee4d4a927 the trunk is toward 1.588-SNAPSHOT 2014-10-26 21:31:09 -07:00
Kohsuke Kawaguchi 4c1d0a5f30 creating an RC branch 2014-10-26 21:31:06 -07:00
Kohsuke Kawaguchi 5cfdff3c00 merged back the RC branch 2014-10-26 21:23:34 -07:00
Kohsuke Kawaguchi d7097269cf updated changelog as a part of the release 2014-10-26 21:23:31 -07:00
Kohsuke Kawaguchi 1989d3465b updated changelog for release 2014-10-26 20:36:19 -07:00
Kohsuke Kawaguchi e631940a2f [maven-release-plugin] prepare for next development iteration 2014-10-26 20:29:37 -07:00
Kohsuke Kawaguchi 36cd30b2da [maven-release-plugin] prepare release jenkins-1.586 jenkins-1.586 2014-10-26 20:29:37 -07:00
CloudBees DEV@Cloud 1671c9e63a Merge commit '9b36e2ae8dbbd2a7ab0d9d4bc9e24e305e33ecbc' builds/285 2014-10-26 22:22:28 +00:00
Kohsuke Kawaguchi 9b36e2ae8d [FIXED JENKINS-25314] 
The original fix was made in 0c3d67097a.
In this fix, I'm also moving the code that creates LeftItem.

It makes no sense that there's Item.cancel(Queue) and Queue.cancel(Item)
and they do different things!
changes/285 		2014-10-26 15:20:38 -07:00
CloudBees DEV@Cloud 6f9fc7d9b5 Merge REMERGE_HEAD into HEAD 2014-10-26 21:40:21 +00:00
Jesse Glick 300b6fa519 Forgotten @since. builds/284 changes/284 2014-10-26 13:58:40 -07:00
Kohsuke Kawaguchi b4a9671c27 Integrated the newest Stapler version 
In particular, this includes pull request #39 from Matt that handles
'$class'
builds/283 changes/283 		2014-10-26 13:35:49 -07:00
Jesse Glick 4f24a0274f [JENKINS-24527] Noting merge of #1442. 2014-10-25 18:36:27 -07:00
Craig Rodrigues 6d3d43275f [FIXED JENKINS-24527] Update jna-posix to 1.0.3-jenkins-1 which uses JNA 4.1 2014-10-25 17:19:42 -07:00
Jesse Glick 12f5dec0ed junit 1.2-beta-3 builds/282 changes/282 2014-10-25 15:39:08 -07:00
Jesse Glick 2f8e2684af Merge pull request #1441 from mattmoor/upstream-javadoc 
Change the javadoc of UpstreamCause to be more accurate...
 2014-10-25 12:19:59 -04:00
Matt Moore 6ceb24cbd9 Change the javadoc of UpstreamCause to be more accurate (the upstream build need not be complete) 2014-10-25 08:54:11 -07:00
Daniel Beck 16509dc22c [FIXED JENKINS-15252] Explain problems with CSRF protection 2014-10-24 15:01:56 +02:00
James Nord e135651539 [FIXED JENKINS-25280] Failed tests do not get displayed properly in the overview 
there is no such mothod getFullDisplayName in a TestObject - only getDisplayName

Change-Id: Idd454be00a22ee3c93f661a3ee3ae322a25c271d
 2014-10-23 17:03:26 +01:00
Jesse Glick 90292ed28a Null safety. 
Observed in a test against 1.480:
… hudson.model.Executor run
SEVERE: Unexpected executor death
java.lang.NullPointerException
	at hudson.model.Computer.getNode(Computer.java:473)
	at hudson.slaves.SlaveComputer.getNode(SlaveComputer.java:177)
	at hudson.slaves.SlaveComputer.getRetentionStrategy(SlaveComputer.java:609)
	at hudson.slaves.SlaveComputer.taskCompleted(SlaveComputer.java:285)
	at hudson.model.queue.WorkUnitContext.synchronizeEnd(WorkUnitContext.java:140)
	at hudson.model.Executor.run(Executor.java:253)
builds/281 changes/281 		2014-10-21 11:42:11 -04:00
Kohsuke Kawaguchi 0fa32eac4e the trunk is toward 1.587-SNAPSHOT 2014-10-19 21:51:18 -07:00
Kohsuke Kawaguchi c7369f2cd6 creating an RC branch 2014-10-19 21:51:14 -07:00
Kohsuke Kawaguchi de6515fab8 merged back the RC branch 2014-10-19 21:50:12 -07:00
Kohsuke Kawaguchi b2fe53aac9 updated changelog as a part of the release 2014-10-19 21:50:09 -07:00
Kohsuke Kawaguchi 8e0e584684 updated changelog for release 2014-10-19 20:10:09 -07:00
Kohsuke Kawaguchi 09d4defec3 [maven-release-plugin] prepare for next development iteration 2014-10-19 20:03:53 -07:00
Kohsuke Kawaguchi 80e79b2af0 [maven-release-plugin] prepare release jenkins-1.585 jenkins-1.585 2014-10-19 20:03:52 -07:00
Kohsuke Kawaguchi 2820dc723c [JENKINS-25169] 
Integrating 2.8 to really ensure SSLv2 is off (even when JDK supports
that, and we haven't found any JDKs that do that)
 2014-10-19 19:43:16 -07:00
Oleg Nenashev 6819a620c0 Noting #1411 
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-10-19 23:47:35 +04:00
Oleg Nenashev e80fa118aa Merge pull request #1411 from synopsys-arc-oss/JENKINS-19017 
[FIXED JENKINS-19017] - FileParameter - Handle non-null file parameters as different values
 2014-10-19 23:28:14 +04:00
Oleg Nenashev cc06ae78e3 [JENKINS-19017] - Unit tests 
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-10-18 22:03:28 +04:00
Daniel Beck 7fa1252e58 Noting #1306, 2b6c00d in 1.584 2014-10-18 01:28:11 +02:00
Stephen Connolly 4d987accef Clarify when to use SlaveComputer#setAcceptingTasks over RetentionStrategy#isAcceptingTasks(T) 2014-10-17 12:36:01 +01:00
Stephen Connolly 34d59a277e Tidy up javadoc some more 2014-10-17 12:27:48 +01:00
Stephen Connolly 197f2ffd27 Fix syntax in Javadoc comment 2014-10-17 12:23:45 +01:00
Stephen Connolly 77d9aa33a5 typos 2014-10-17 12:21:45 +01:00
Stephen Connolly 4e27d4ec17 Narrow the scope of lock required to get the pending nodes. 
- Too many things have incorrect locking assumptions on calling NodeProvisioner#getPendingLaunches()
- Simpler to narrow the lock requirements as that should prevent deadlocks
- We now only need the lock for a very short window and the lock is only on the list of pending launches.
 2014-10-17 12:21:45 +01:00
Stephen Connolly 6b583764b6 Clarify the lock semantics 2014-10-17 12:21:45 +01:00
Stephen Connolly 9fff4118d4 Make node provisioning strategy plugable 2014-10-17 12:21:44 +01:00
Stephen Connolly 7acbba330c Typo 2014-10-17 12:21:12 +01:00
Stephen Connolly 10ac2b3ccd add @since tags 2014-10-17 12:20:07 +01:00
Stephen Connolly f07fb85352 Allow Node and RetentionStrategy to contribute to Computer#isAcceptingTasks 2014-10-17 09:38:32 +01:00
Kohsuke Kawaguchi 582128b9ac [FIXED JENKINS-25019] 
A truly conforming servlet 3.0 container does not allow us to set "secure cookie" flag beyond ServletContextListener.onInitialized().
If we see that, don't scare the users.
builds/280 changes/280 		2014-10-16 19:23:23 -07:00