Commit Graph
19719 Commits
Author SHA1 Message Date
Jesse Glick 78fde58c30 Merge branch 'master' of git://github.com/jenkinsci/jenkins builds/294 changes/294 2014-11-07 14:13:09 -05:00
Oliver Gondža e451789ac7 Merge pull request #1456 from olivergondza/extract-label-validation
Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins
2014-11-07 19:42:03 +01:00
Jesse Glick ae053472a0 Merging #1268. builds/293 changes/293 2014-11-07 13:08:53 -05:00
Jesse Glick bfa557b16a Merge branch 'JENKINS-23339' of github.com:synopsys-arc-oss/jenkins 2014-11-07 13:08:03 -05:00
Kohsuke Kawaguchi ada8432fc5 [JENKINS-25144] Merge pull request #1427 builds/292 changes/292 2014-11-07 09:43:25 -08:00
Kohsuke Kawaguchi 9e81b8e4fe [FIXED JENKINS-25144] Revisiting the attempted fix in the previous commit.
IIUC, the issue here is that the request in question contains both a
valid session cookie AND basic authentication header, and that path
results in a failure because BasicHeaderProcessor expects one of
BasicHeaderAuthenticators to validate the basic authentication header
(without knowing that there's already a valid Authentication object that
came from the HTTP session, yet no BasicHeaderAuthenticator actually
processes this because BasicHeaderRealPasswordAuthenticator backs away
from doing that.

I think the corect fix is for BasicHeaderRealPasswordAuthenticator to
get rid of authenticationIsRequired check. This check instead belongs to
BasicHeaderProcessor, where it should be used to check if any
BasicHeaderAuthenticator should be consulted or not.

The problem with having this logic in
BasicHeaderRealPasswordAuthenticator is that this is just an
implementation of an extension point, and thus it needs to be removable.
As it stands right now in this fix, if this impl is removed,
JENKINS-25144 will be back again.
2014-11-07 09:42:23 -08:00
Christof Schoell 0176b6d902 [JENKINS-25144]
return authentication object instead of null if authentication is not
required - otherwise valid login fails with basic authentication
2014-11-07 09:40:26 -08:00
Oleg Nenashev e6c2e16f7a [FIXED JENKINS-23339] - Introduce the validated Jenkins::getActiveInstance() method
jenkins.model.Jenkins::getInstance() method is marked as @CheckForNull, but the most of Jenkins code does not actually check the return value. It leads to tons of static analysis errors, hence it is hard to analyze the code.

The change also adds annotations to old methods like Hudson::getInstance()

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-07 20:07:52 +03:00
Jesse Glick 24c5e5e440 Javadoc note pertaining to #1454. builds/291 changes/291 2014-11-06 14:29:07 -05:00
Jesse Glick bcdae275d0 [JENKINS-25473] Retroactively filing #1439. 2014-11-06 09:48:32 -05:00
Oliver Gondža e985ee69ff Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins 2014-11-06 13:29:08 +01:00
Kohsuke Kawaguchi e607048d46 SSH slave 1.9 brings in a better error diagnostics. 2014-11-04 19:46:50 -08:00
Kohsuke Kawaguchi 96f97a4579 Integrated the new trilead library that has some minor diagnosability improvements. 2014-11-04 19:46:49 -08:00
Kohsuke Kawaguchi 41c788e2f1 Integrated a new version of remoting 2014-11-04 19:46:49 -08:00
Kohsuke Kawaguchi e7d75dc538 Make stdout swapping more reliable.
This matches fb65a2c3c8584a9ac4daa49ecbce7a540dc7f5a5 in remoting.
2014-11-04 19:46:49 -08:00
Jesse Glick 22d433deae So far unsuccessful attempt to make Jenkins startup more robust against bugs like JENKINS-25440.
Even though SezpozModule.configure catches and ignores the faulty component, Guice still dies:
… hudson.ExtensionFinder$GuiceFinder <init>
SEVERE: Failed to create Guice container from all the plugins
com.google.inject.internal.guava.collect.$ComputationException: java.lang.NoClassDefFoundError: org/eclipse/jgit/storage/file/FileRepository
	at …
	at com.google.inject.Guice.createInjector(Guice.java:73)
	at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:279)
builds/290 changes/290
2014-11-04 17:45:52 -05:00
Jesse Glick a6a3d5e166 [FIXED JENKINS-25400] Rework fix of JENKINS-22769 (c04cdcd) to put the burden on each listener to impersonate ACL.SYSTEM if it needs to. builds/288 changes/288 2014-11-04 15:36:01 -05:00
Jesse Glick b486e46c4e Better Javadoc for new impersonate overload. 2014-11-04 15:32:33 -05:00
Jesse Glick ee13a9a930 junit 1.2-beta-4 builds/287 changes/287 2014-11-04 15:01:03 -05:00
Jesse Glick 06074f4bce Noting merge of #1434. 2014-11-04 13:12:33 -05:00
Oleg Nenashev 8f079fc434 [CID-1182126] - Resource leak in AsynchronousAdministrativeMonitor::run()
Properly close listeners for asynchronous threads.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-04 15:54:13 +03:00
Oleg Nenashev c873722726 [CID-1182132] - Resource leak in BootFailure::loadAttempts()
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-04 15:54:09 +03:00
Oleg Nenashev 5259996c44 [CID-1219446] - Resource leak in ClassicPluginStrategy
Resource leak may happen during the search of manifest file.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-04 15:54:05 +03:00
Oleg Nenashev 2ea0276e7b [CID-1205053] - Resource leak on fingerprint calculation in DirectoryBrowserSupport
The issue is related to JENKINS-18351.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-04 15:54:02 +03:00
Oleg Nenashev 21ba31af42 [CID-1182127] - Resource leak in HsErrPidList constructor.
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-04 15:53:59 +03:00
Oleg Nenashev 3a8b81a0fc [CID-992725] - Resource leak in ClientAuthenticationCache
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-04 15:53:55 +03:00
Oleg Nenashev 9e72099115 [CID-1182128] - Properly close InputStream in ConsoleCommand
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-04 15:53:51 +03:00
Kohsuke Kawaguchi b93a79ceeb the trunk is toward 1.590-SNAPSHOT 2014-11-02 20:56:21 -08:00
Kohsuke Kawaguchi 28e0d01b18 creating an RC branch 2014-11-02 20:56:12 -08:00
Kohsuke Kawaguchi 8d0b026a1c merged back the RC branch 2014-11-02 15:07:11 -08:00
Kohsuke Kawaguchi 316e6bba98 updated changelog as a part of the release 2014-11-02 15:07:08 -08:00
Oliver Gondža 8b71d13233 Merge pull request #1447 from mattmoor/labels
Adjust my prior change to better utilize structured form submission...
2014-11-02 23:42:53 +01:00
Kohsuke Kawaguchi 1522ff92ce updated changelog for release 2014-11-02 10:33:22 -08:00
Kohsuke Kawaguchi 584c215b02 [maven-release-plugin] prepare for next development iteration 2014-11-02 10:25:58 -08:00
Kohsuke Kawaguchi 571ed3b5fa [maven-release-plugin] prepare release jenkins-1.588 jenkins-1.588 2014-11-02 10:25:58 -08:00
Matt Moore c426fd2300 mark the legacy jelly endpoints as DoNotUse 2014-11-01 13:10:37 -07:00
Matt Moore 492b4902d8 Adjust my prior change to better utilize structured form submission to accomodate a plugins that are not using p:config-assignedLabel 2014-10-30 13:57:26 -07:00
Kohsuke Kawaguchi 9bf29e4910 Merge remote-tracking branch 'origin/master' 2014-10-29 20:48:15 -07:00
Kohsuke Kawaguchi 388148e257 the trunk is toward 1.589-SNAPSHOT 2014-10-29 20:47:31 -07:00
Kohsuke Kawaguchi 832aaa31ae creating an RC branch 2014-10-29 20:47:29 -07:00
Jesse Glick 8a68ed0e71 [JENKINS-25358] Noting merge of #1445. 2014-10-29 22:36:24 -04:00
Jesse Glick e22cb19feb Merge branch 'JENKINS-25358' of github.com:rodrigc/jenkins 2014-10-29 22:34:25 -04:00
Kohsuke Kawaguchi 47b8d961ae merged back the RC branch 2014-10-29 18:46:04 -07:00
Kohsuke Kawaguchi 3cd241eda6 updated changelog as a part of the release 2014-10-29 18:46:01 -07:00
Kohsuke Kawaguchi 4d9307f8cb updated changelog for release 2014-10-29 18:16:08 -07:00
Kohsuke Kawaguchi bf736a7407 [maven-release-plugin] prepare for next development iteration 2014-10-29 18:10:06 -07:00
Kohsuke Kawaguchi b3660bf84e [maven-release-plugin] prepare release jenkins-1.587 jenkins-1.587 2014-10-29 18:10:06 -07:00
Kohsuke Kawaguchi 24ea2485e6 Noting SECURITY-144 2014-10-29 17:11:13 -07:00
Kohsuke Kawaguchi 2d46bd5b95 Bundling the version that has SECURITY-144 related changes. 2014-10-29 17:06:47 -07:00
Kohsuke Kawaguchi c7bb90881d Depend on a released version 2014-10-29 17:05:15 -07:00