Commit Graph
18009 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 83f825e8c4 Protect the common thread pool against poorly written tasks that do not restore original context classloader.
Reference: RM-2329 in CloudBees
builds/67 changes/67
2014-03-20 11:43:40 -07:00
Jesse Glick 1755b7aa95 @RequirePOST builds/66 changes/66 2014-03-19 16:59:19 -04:00
Jesse Glick 8861563bd1 [FIXED JENKINS-22262] CopyJobCommand and CreateJobCommand were doing incorrect permission checks. builds/65 changes/65 2014-03-19 16:03:41 -04:00
Jesse Glick 8078894e56 Comment. 2014-03-19 14:59:24 -04:00
Jesse Glick aaa50018ee list-jobs should print names, not display names, since people expect to be able to feed the results into other CLI commands. builds/64 changes/64 2014-03-19 14:42:17 -04:00
Jesse Glick b261ab2122 Clearer diagnosis for JENKINS-12543 and similar issues. 2014-03-19 14:41:26 -04:00
Jesse Glick 2b9cfe3a47 updateByXml need not call reload; just causes duplicated work.
See comments in ce7e639; and note reverted 71f3acf.
builds/63 changes/63
2014-03-19 11:34:10 -04:00
Kohsuke Kawaguchi 2bf23c0ef4 Revert "The intent was for this code to move into the doReload() method"
This reverts commit 71f3acfc3c.
Test regressions
2014-03-18 15:53:55 -07:00
Kohsuke Kawaguchi 71f3acfc3c The intent was for this code to move into the doReload() method
Not sure why it didn't in ce7e6390ee.
2014-03-18 14:35:25 -07:00
Kohsuke Kawaguchi a65bc64d1d Merge branch 'master' of github.com:jenkinsci/jenkins 2014-03-18 14:32:53 -07:00
Jesse Glick 4bb0f98901 [FIXED JENKINS-21190] [FIXED JENKINS-21191] Noting merge of #1082. 2014-03-17 17:54:48 -04:00
Jesse Glick a135dce245 Merge branch 'norefresh_views' of https://github.com/synopsys-arc-oss/jenkins 2014-03-17 17:53:37 -04:00
Oleg Nenashev 5de6a8d06d [JENKINS-21190] - lib/layout/layout.jelly: Interpret norefresh=="false" as "autorefresh is enabled"
The fix allows to explicitly disable automatic page refreshes in the @View extensions.
Resolves https://issues.jenkins-ci.org/browse/JENKINS-21190

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-03-17 22:30:58 +04:00
Jesse Glick 485cc150ea [FIXED JENKINS-19081] Noting merge of #1144. 2014-03-17 14:24:23 -04:00
Kohsuke Kawaguchi ad0144f51f making the version more machine discoverable 2014-03-17 11:09:58 -07:00
Jesse Glick df9c92e461 Removed DownloadSettings.checkSignature; back to using a plain system property for this. 2014-03-17 12:48:24 -04:00
Jesse Glick db8d6508aa Merge branch 'master' into DownloadSettings-JENKINS-19081 2014-03-17 12:33:48 -04:00
Kohsuke Kawaguchi db4f60303a the trunk is toward 1.557-SNAPSHOT 2014-03-17 06:40:21 -07:00
Kohsuke Kawaguchi 78760d5b6c creating an RC branch 2014-03-17 06:40:16 -07:00
Kohsuke Kawaguchi 7352c4017d merged back the RC branch 2014-03-17 00:10:14 -07:00
Kohsuke Kawaguchi 192c915768 updated changelog as a part of the release 2014-03-17 00:10:11 -07:00
Kohsuke Kawaguchi e73b0f24f3 updated changelog for release 2014-03-16 22:27:31 -07:00
Kohsuke Kawaguchi 9de67ba7e3 [maven-release-plugin] prepare for next development iteration 2014-03-16 22:18:26 -07:00
Kohsuke Kawaguchi fed953f01a [maven-release-plugin] prepare release jenkins-1.555 jenkins-1.555 2014-03-16 22:18:25 -07:00
Kohsuke Kawaguchi 0db32ecaa1 Clarifying assertions that they are trying to test. 2014-03-14 14:42:51 -07:00
Kohsuke Kawaguchi bd8234cceb Fixing a test failure.
The intent of this test is to make sure that a floating User object without any storage returns false from canDelete() method.
The earlier change made User.impersonate() to actually check if the user is a valid, so to make this test case work where it does
"user.impersonate" and "user2.impersonate2", I'm creating valid accounts for these two users.

Now what that means is that user2 is no longer a floating flyweight storage-less User, so it breaks the assumption of the
"User should not be able to delete because he is not saved." assertion.

To make this test case work, I'm introducing the 3rd user that is storage-less, and using it for the test.
2014-03-14 14:39:27 -07:00
Jesse Glick 17c4c1f507 [FIXED JENKINS-22131] Merged deconstructing-AbstractProject branch from #1146. 2014-03-14 13:33:44 -04:00
Jesse Glick 2b6726290d Merge branch 'deconstructing-AbstractProject' 2014-03-14 13:29:11 -04:00
Kohsuke Kawaguchi f04b0e011a User.impersonate now requires that the user be a valid user.
These tests weren't using a SecurityRealm that recognizes these user names
2014-03-14 10:17:36 -07:00
Kohsuke Kawaguchi 2a78c10b94 Updating tests to fix more regressions 2014-03-14 10:17:36 -07:00
Jesse Glick 28710f7874 Reverting #1154 (superseding #1159).
There seems to be no way to export this over the REST API without incurring serious performance penalties.
2014-03-14 09:57:05 -04:00
Jesse Glick 8da19c833c Merge pull request #1152 from daniel-beck/BuildTrigger_terminology
Fix terminology used in BuildTrigger conditions
2014-03-14 09:36:45 -04:00
Harald Albers a77b96a113 Merge pull request #1158 from phoenix384/patch-1
Added some missing German translations
2014-03-14 09:22:49 +01:00
Kohsuke Kawaguchi 38ae112093 LastGrantedAuthoritiesProperty was missing a descriptor 2014-03-13 15:42:25 -07:00
Kohsuke Kawaguchi 16d0bc3fa9 More test fixes 2014-03-13 15:19:44 -07:00
phoenix384 5827f6069d Added some missing German translations 2014-03-13 22:32:41 +01:00
phoenix384 c25c223ace Added some missing German translations 2014-03-13 22:25:53 +01:00
Kohsuke Kawaguchi 664f7e3400 More test fixes 2014-03-13 13:31:04 -07:00
Kohsuke Kawaguchi e400bc7d94 Working toward fixing regressions.
So far none of them are real regressions but just that I needed to update tets
2014-03-13 12:48:27 -07:00
Kohsuke Kawaguchi ddf391cfec Updating test to fix failures.
Now that User.impersonate() actually checks if the user is valid, User.get("user").impersonate() is expected to fail.
Use a DummySecurityRealm to make this user a valid user.
2014-03-13 12:48:27 -07:00
Jesse Glick 5a01c0b7c5 Merge branch 'master' into deconstructing-AbstractProject 2014-03-13 10:37:21 -04:00
Kohsuke Kawaguchi 80b1cf9f8b Remember Me option doesn't always show. 2014-03-12 20:56:27 -07:00
Kohsuke Kawaguchi ce7e6390ee Adding the reload job functionality 2014-03-12 18:18:17 -07:00
Kohsuke Kawaguchi c0ed4b82fd doc improvement 2014-03-12 18:01:55 -07:00
Kohsuke Kawaguchi 5a28378cd9 a convenience method 2014-03-12 18:01:55 -07:00
Kohsuke Kawaguchi b478ca8904 Merge branch 'master' of github.com:jenkinsci/jenkins 2014-03-11 16:32:16 -07:00
Kohsuke Kawaguchi b078ac62f5 added another test for the basic remember-me flow 2014-03-11 16:22:40 -07:00
Kohsuke Kawaguchi accc0e59d3 NPE fix 2014-03-11 16:15:18 -07:00
Kohsuke Kawaguchi a4e29ae0df Doing impersonation here as well.
See javadoc for discussion why this possibly redundant use is desirable
2014-03-11 16:11:14 -07:00
Kohsuke Kawaguchi 27d208b0a9 Moving impersonation logic once again.
I think the cleanest place to do this is as a filter of UserDetailsService.

The problem is that SecurityRealm defines loadUserByName method, which AbstractPasswordBasedSecurityRealm overrides
2014-03-11 15:55:17 -07:00