mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-16 13:32:24 +00:00
be34b675f0f9cb59a67c09dbe42364d34c3eaff1
IIUC, the issue here is that the request in question contains both a
valid session cookie AND basic authentication header, and that path
results in a failure because BasicHeaderProcessor expects one of
BasicHeaderAuthenticators to validate the basic authentication header
(without knowing that there's already a valid Authentication object that
came from the HTTP session, yet no BasicHeaderAuthenticator actually
processes this because BasicHeaderRealPasswordAuthenticator backs away
from doing that.
I think the corect fix is for BasicHeaderRealPasswordAuthenticator to
get rid of authenticationIsRequired check. This check instead belongs to
BasicHeaderProcessor, where it should be used to check if any
BasicHeaderAuthenticator should be consulted or not.
The problem with having this logic in
BasicHeaderRealPasswordAuthenticator is that this is just an
implementation of an extension point, and thus it needs to be removable.
As it stands right now in this fix, if this impl is removed,
JENKINS-25144 will be back again.
(cherry picked from commit 9e81b8e4fe)
Jenkins CI
Copyright © 2004–, Kohsuke Kawaguchi, Sun Microsystems, Inc., and a number of other of contributors. Licensed under MIT License.
About
In a nutshell Jenkins CI is the leading open-source continuous integration server. Built with Java, it provides over 930 plugins to support building and testing virtually any project.
Downloads
Non-source downloads such as WAR file and several Linux packages can be found on our Mirrors.
Source
Our latest and greatest source of Jenkins CI can be found on GitHub. Fork us!
News and Website
All about Jenkins CI can be found on our website. Follow us on Twitter @jenkinsci.
Description
No description provided
cicdcontinuous-deliverycontinuous-deploymentcontinuous-integrationdevopsgroovyhacktoberfestjavajenkinspipelines-as-code
Readme
MIT
340 MiB
0 Stars
1 Watchers
0 Forks
Languages
Java
87.1%
HTML
6.4%
JavaScript
3.3%
SCSS
2.3%
Groovy
0.3%
Other
0.5%
