refactor(cutter): share descriptor cleanup aggregation (#12504)

This commit is contained in:
RRFZ authored and GitHub committed 2026-11-19 15:19:46 -05:00
1 parent 7f151e9d0f
commit 5433f65d95
2 files changed
+9 -7

No files matched your search

@@ -10,7 +10,6 @@
"src/browser/PlaywrightBrowserScenarioProvider.ts": 1,
"src/browser/WebSourceMapFetcher.ts": 2,
"src/cli/desktopCaptureCommands.ts": 1,
"src/cutter/CutterBridgeClient.ts": 1,
"src/desktop/ScreenJudgeProcess.ts": 1,
"src/domain/explicitSensitiveFailure.ts": 1,
"src/evm/EvmoleInterfaceProvider.ts": 3,
+9 -6
View File
@@ -1,5 +1,8 @@
import { HOST_PLATFORM } from "../platform/HostPlatform.js";
import { analysisErrorWithCleanupDependencies } from "../domain/analysisErrorCleanup.js";
import {
analysisErrorWithCleanupDependencies,
providerCleanupErrorFromFailures,
} from "../domain/analysisErrorCleanup.js";
import { ProviderAdapterError } from "../domain/providerAdapterError.js";
import {
ArtifactResourceScope,
@@ -1302,12 +1305,12 @@ const discoveryFailure = (
});
const cleanup = failures.filter((failure) => failure.cleanupIncomplete);
if (cleanup.length === 0) return failures[0];
return new ProviderCleanupError(
return providerCleanupErrorFromFailures(
"cutter",
cleanup.flatMap((failure) => failure.cleanupResources),
{ reason: "Cutter descriptor discovery failed with unconfirmed closes" },
{ operation, cause: new AggregateError(failures, cause.message) },
).bindCleanupDependencies(cleanup);
cleanup,
"Cutter descriptor discovery failed with unconfirmed closes",
{ operation, causes: failures, message: cause.message },
);
}
if (!(cause instanceof ArtifactReaderFailure)) return cause;
if (cause.cleanup !== undefined) {