mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 11:43:20 +00:00
refactor(domain): give the binary target filesystem failure projection a domain owner (#11531)
This commit is contained in:
1 parent
412d621fd1
commit
55c317d2b6
6 files changed
+72
-68
No files matched your search
@@ -1,7 +1,5 @@
|
||||
{
|
||||
"upward": {
|
||||
"dotnet -> application": 1
|
||||
},
|
||||
"upward": {},
|
||||
"cycles": [
|
||||
"cli <-> cli.ts",
|
||||
"cli <-> cliBrowserScenarioCommands.ts",
|
||||
|
||||
@@ -28,6 +28,10 @@ import { access, realpath, stat, type FileHandle } from "node:fs/promises";
|
||||
import { extname } from "node:path";
|
||||
|
||||
import { BinaryTargetError } from "../domain/configurationErrors.js";
|
||||
import {
|
||||
classifyTargetFilesystemFailure,
|
||||
type TargetFilesystemStage,
|
||||
} from "../domain/binaryTargetFilesystemFailure.js";
|
||||
import {
|
||||
assertStableRegularFileIdentity,
|
||||
RegularFileChangedError,
|
||||
@@ -654,68 +658,6 @@ const targetResolutionFailure = (
|
||||
return err(failure);
|
||||
};
|
||||
|
||||
/**
|
||||
* `resolve` covers the caller-selected path before canonicalization; `read`
|
||||
* covers a canonical path opened with symbolic links rejected.
|
||||
*/
|
||||
type TargetFilesystemStage = "resolve" | "read";
|
||||
|
||||
/** Classify a filesystem failure while reading a previously selected target. */
|
||||
export const classifyBinaryTargetFilesystemFailure = (
|
||||
path: string,
|
||||
cause: unknown,
|
||||
): BinaryTargetError | undefined =>
|
||||
classifyTargetFilesystemFailure(path, cause, "read");
|
||||
|
||||
const classifyTargetFilesystemFailure = (
|
||||
path: string,
|
||||
cause: unknown,
|
||||
stage: TargetFilesystemStage,
|
||||
): BinaryTargetError | undefined => {
|
||||
if (!(cause instanceof Error)) return undefined;
|
||||
const code = filesystemErrorCode(cause);
|
||||
return code === undefined
|
||||
? undefined
|
||||
: new BinaryTargetError(
|
||||
path,
|
||||
targetFailureReason(code, cause.message, stage),
|
||||
{ cause },
|
||||
);
|
||||
};
|
||||
|
||||
const filesystemErrorCode = (cause: Error): string | undefined => {
|
||||
const code: unknown = Reflect.get(cause, "code");
|
||||
return typeof code === "string" ? code : undefined;
|
||||
};
|
||||
|
||||
const targetFailureReason = (
|
||||
code: string,
|
||||
detail: string,
|
||||
stage: TargetFilesystemStage,
|
||||
): string => {
|
||||
switch (code) {
|
||||
case "ENOENT":
|
||||
case "ENOTDIR":
|
||||
return `target does not exist or a path component is not a directory: ${detail}`;
|
||||
case "EACCES":
|
||||
case "EPERM":
|
||||
return `permission denied while reading target: ${detail}`;
|
||||
case "EISDIR":
|
||||
return `target is a directory, not a readable file: ${detail}`;
|
||||
case "ENOTFILE":
|
||||
return "target is not a regular file";
|
||||
case "ELOOP":
|
||||
// A canonical path has no symbolic links left, so a link rejected while
|
||||
// reading it appeared after resolution. Before that, ELOOP is a loop or
|
||||
// an over-deep link chain in the selected path itself.
|
||||
return stage === "resolve"
|
||||
? `target path could not be resolved: too many symbolic links or a symbolic link loop: ${detail}`
|
||||
: `target changed while being opened: ${detail}`;
|
||||
default:
|
||||
return `target could not be read (${code}): ${detail}`;
|
||||
}
|
||||
};
|
||||
|
||||
const throwIfTargetResolutionCancelled = (signal?: AbortSignal): void => {
|
||||
if (signal?.aborted === true)
|
||||
throw cancelledBy("resolve_binary_target", signal);
|
||||
|
||||
@@ -56,7 +56,6 @@ import {
|
||||
requestsFreshIndependentDecompile,
|
||||
requiresNativeSourceAdmissionBeforeReplay,
|
||||
} from "./binary/AnalysisSnapshotCache.js";
|
||||
import { classifyBinaryTargetFilesystemFailure } from "./BinaryTargetResolver.js";
|
||||
import {
|
||||
snapshotBindingMismatch,
|
||||
snapshotEvidenceForQuery,
|
||||
@@ -94,6 +93,7 @@ import {
|
||||
} from "./DirectAnalysisCleanup.js";
|
||||
import { completeProviderEvidence } from "./ProviderOperationExecution.js";
|
||||
import { BUNDLE_RESOURCE_OPERATIONS } from "../ports/BundleResourceOperations.js";
|
||||
import { classifyBinaryTargetFilesystemFailure } from "../domain/binaryTargetFilesystemFailure.js";
|
||||
|
||||
// These one-shot CLI questions require native utilities, not a deep engine.
|
||||
// Runtime observation retains the ordinary session and authority checks.
|
||||
|
||||
@@ -0,0 +1,64 @@
|
||||
import { BinaryTargetError } from "./configurationErrors.js";
|
||||
|
||||
/**
|
||||
* `resolve` covers the caller-selected path before canonicalization; `read`
|
||||
* covers a canonical path opened with symbolic links rejected.
|
||||
*/
|
||||
export type TargetFilesystemStage = "resolve" | "read";
|
||||
|
||||
/** Classify a filesystem failure while reading a previously selected target. */
|
||||
export const classifyBinaryTargetFilesystemFailure = (
|
||||
path: string,
|
||||
cause: unknown,
|
||||
): BinaryTargetError | undefined =>
|
||||
classifyTargetFilesystemFailure(path, cause, "read");
|
||||
|
||||
/** Project a filesystem failure at `stage` as the target's admission error. */
|
||||
export const classifyTargetFilesystemFailure = (
|
||||
path: string,
|
||||
cause: unknown,
|
||||
stage: TargetFilesystemStage,
|
||||
): BinaryTargetError | undefined => {
|
||||
if (!(cause instanceof Error)) return undefined;
|
||||
const code = filesystemErrorCode(cause);
|
||||
return code === undefined
|
||||
? undefined
|
||||
: new BinaryTargetError(
|
||||
path,
|
||||
targetFailureReason(code, cause.message, stage),
|
||||
{ cause },
|
||||
);
|
||||
};
|
||||
|
||||
const filesystemErrorCode = (cause: Error): string | undefined => {
|
||||
const code: unknown = Reflect.get(cause, "code");
|
||||
return typeof code === "string" ? code : undefined;
|
||||
};
|
||||
|
||||
const targetFailureReason = (
|
||||
code: string,
|
||||
detail: string,
|
||||
stage: TargetFilesystemStage,
|
||||
): string => {
|
||||
switch (code) {
|
||||
case "ENOENT":
|
||||
case "ENOTDIR":
|
||||
return `target does not exist or a path component is not a directory: ${detail}`;
|
||||
case "EACCES":
|
||||
case "EPERM":
|
||||
return `permission denied while reading target: ${detail}`;
|
||||
case "EISDIR":
|
||||
return `target is a directory, not a readable file: ${detail}`;
|
||||
case "ENOTFILE":
|
||||
return "target is not a regular file";
|
||||
case "ELOOP":
|
||||
// A canonical path has no symbolic links left, so a link rejected while
|
||||
// reading it appeared after resolution. Before that, ELOOP is a loop or
|
||||
// an over-deep link chain in the selected path itself.
|
||||
return stage === "resolve"
|
||||
? `target path could not be resolved: too many symbolic links or a symbolic link loop: ${detail}`
|
||||
: `target changed while being opened: ${detail}`;
|
||||
default:
|
||||
return `target could not be read (${code}): ${detail}`;
|
||||
}
|
||||
};
|
||||
@@ -4,7 +4,6 @@ import type { Stats } from "node:fs";
|
||||
import type { FileHandle } from "node:fs/promises";
|
||||
|
||||
import { MANAGED_STATIC_PROVIDER } from "../domain/investigationProviders.js";
|
||||
import { classifyBinaryTargetFilesystemFailure } from "../application/BinaryTargetResolver.js";
|
||||
import {
|
||||
RegularFileCleanupFailure,
|
||||
regularFileCancellation,
|
||||
@@ -28,6 +27,7 @@ import { DEFAULT_MANAGED_SNAPSHOT_BYTES } from "../domain/managed/managedInspect
|
||||
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
|
||||
import { RegularFileChangedError } from "../filesystem/RegularFile.js";
|
||||
import { readBoundedFileBytes } from "../process/BoundedFileBytes.js";
|
||||
import { classifyBinaryTargetFilesystemFailure } from "../domain/binaryTargetFilesystemFailure.js";
|
||||
|
||||
interface ManagedSourceObservation {
|
||||
readonly byteLength: number;
|
||||
|
||||
@@ -16,10 +16,10 @@ vi.mock("node:fs/promises", async (importOriginal) => {
|
||||
});
|
||||
|
||||
import { parseConfig } from "../../src/config/parseConfig.js";
|
||||
import { classifyBinaryTargetFilesystemFailure } from "../../src/application/BinaryTargetResolver.js";
|
||||
import type { BinarySession } from "../../src/application/binary/BinarySession.js";
|
||||
import type { DirectAnalysisDependencies } from "../../src/application/DirectAnalysisDependencies.js";
|
||||
import { runProviderAnalysis } from "../../src/application/DirectAnalysis.js";
|
||||
import { classifyBinaryTargetFilesystemFailure } from "../../src/domain/binaryTargetFilesystemFailure.js";
|
||||
|
||||
afterEach(() => statFailures.clear());
|
||||
|
||||
|
||||
Reference in new issue
Block a user