mirror of
https://github.com/morluto/rea.git
synced 2026-11-12 17:59:08 +00:00
fix(audit): count a dropped linker-map guess as a skipped companion
This commit is contained in:
2 files changed
+13
No files matched your search
@@ -1066,6 +1066,7 @@ describe("ReleaseExposureReader generic map links", () => {
|
||||
await symlink("payload", join(root, "symbols.map"));
|
||||
const scanned = await inspect(root);
|
||||
expect(scanned.debug_companions.skipped).toBe(1);
|
||||
expect(debugCompanionsStatus(scanned)).toBe("unknown");
|
||||
expect(scanned.source_maps.skipped).toBe(1);
|
||||
},
|
||||
);
|
||||
@@ -2910,6 +2911,15 @@ const malformedLeaf = (mappings: string) => ({
|
||||
mappings,
|
||||
});
|
||||
|
||||
const debugCompanionsStatus = (scan: ReleaseExposureScan) =>
|
||||
assembleReleaseExposureReport(scan, {
|
||||
electron_family: "not_electron",
|
||||
fuse_images: [],
|
||||
go_images: [],
|
||||
rust_images: [],
|
||||
credential_markers: { hits: [], omitted_hits: 0 },
|
||||
}).checks.find((check) => check.id === "native.debug_companions")?.status;
|
||||
|
||||
const sourceMapSourcesStatus = (scan: ReleaseExposureScan) =>
|
||||
assembleReleaseExposureReport(scan, {
|
||||
electron_family: "not_electron",
|
||||
@@ -3272,6 +3282,8 @@ describe("ReleaseExposureReader map target allowance", () => {
|
||||
await writeFile(join(folder, "z.map"), "not a map\n");
|
||||
const scanned = await inspect(root);
|
||||
expect(scanned.debug_companions.paths).toEqual([]);
|
||||
expect(scanned.debug_companions.skipped).toBeGreaterThan(0);
|
||||
expect(debugCompanionsStatus(scanned)).toBe("unknown");
|
||||
expect(scanned.source_maps.skipped).toBeGreaterThan(0);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -1585,6 +1585,7 @@ const noteLinkerMapGuess = (state: ScanState, location: string): void => {
|
||||
// Once a declaration was discarded, this map may be its target.
|
||||
if (state.mapTargetsDiscarded) {
|
||||
state.skippedMaps += 1;
|
||||
state.skippedCompanions += 1;
|
||||
return;
|
||||
}
|
||||
const key = memberLocationKey(location);
|
||||
|
||||
Reference in new issue
Block a user