fix(ci): remove unused exports that fail deep static checks (#8095)

* fix(ci): remove unused exports that fail deep static checks

Knip on main reports three analysis-view hub re-exports, two type
re-exports, an unused artifact-format guard and an alias constant. Drop
the dead re-exports and guard, and give the debugger control-reply budget
its own literal: it is a separate budget from the caller command-output
default, as its comment already states.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(config): read the Rizin control budget from its own constant

The Rizin control-reply admission limit still took its value from the
caller command-output default, while GDB used DEBUGGER_CONTROL_REPLY_BYTES.
Read the dedicated constant in both so the control budget has one owner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kaoru0822andClaude Opus 5.5 authored and GitHub committed 2026-10-30 02:25:43 -07:00
1 parent 81378efb71
commit 6b68fb642a
6 files changed
+7 -23

No files matched your search

+5 -4
View File
@@ -1,4 +1,5 @@
import {
DEBUGGER_CONTROL_REPLY_BYTES,
DEFAULT_DEBUGGER_COMMAND_DEADLINE_MS,
DEFAULT_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES,
DEFAULT_DEBUGGER_MAX_PENDING_COMMANDS,
@@ -235,11 +236,11 @@ export const resolveDebuggerSessionLimits = (
*/
export const debuggerControlReplyOutput: DebuggerAdmissionLimit = {
setting: "debugger control-reply budget",
value: DEFAULT_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES,
value: DEBUGGER_CONTROL_REPLY_BYTES,
source: "default",
defaultValue: DEFAULT_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES,
minimum: DEFAULT_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES,
maximum: DEFAULT_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES,
defaultValue: DEBUGGER_CONTROL_REPLY_BYTES,
minimum: DEBUGGER_CONTROL_REPLY_BYTES,
maximum: DEBUGGER_CONTROL_REPLY_BYTES,
unit: "bytes",
};
+1 -2
View File
@@ -184,5 +184,4 @@ export const MAXIMUM_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES = Math.floor(
* GDB startup or detach MI). This is not `REA_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES`:
* a caller cap below this budget must not truncate those required replies.
*/
export const DEBUGGER_CONTROL_REPLY_BYTES =
DEFAULT_DEBUGGER_MAX_COMMAND_OUTPUT_BYTES;
export const DEBUGGER_CONTROL_REPLY_BYTES = 16 * 1024 * 1024;
-7
View File
@@ -82,7 +82,6 @@ import type { AnalysisViewParent } from "./analysisViewParent.js";
import type { GroupingViewKind } from "./analysisViewShape.js";
import {
analysisViewRequestSchema,
analysisViewSourceSchema,
inspectAnalysisViewInputSchema,
type AnalysisViewRequest,
type InspectAnalysisViewInput,
@@ -104,7 +103,6 @@ import {
rustBinaryPageViewResultSchema,
binaryLayoutSummaryViewResultSchema,
javascriptApplicationSummaryViewResultSchema,
javascriptModuleReferencesViewResultSchema,
artifactInventorySummaryViewResultSchema,
desktopApplicationSummaryViewResultSchema,
wasmArtifactSummaryViewResultSchema,
@@ -138,7 +136,6 @@ import {
nativeInventorySummaryViewResultSchema,
nativeLoadImageSummaryViewResultSchema,
nativeFunctionMatchingSummaryViewResultSchema,
nativeFunctionSummarySchema,
nativeFunctionSummaryViewResultSchema,
sourceToBundleSummaryViewResultSchema,
sourceToBundlePageViewResultSchema,
@@ -148,13 +145,11 @@ import {
} from "./analysisViewResult.js";
export {
analysisViewRequestSchema,
analysisViewSourceSchema,
inspectAnalysisViewInputSchema,
type AnalysisViewRequest,
type InspectAnalysisViewInput,
type AnalysisViewParent,
};
export { type GroupingViewKind };
export {
nativeObservationSummaryViewResultSchemas,
byteEntropySummaryViewResultSchema,
@@ -172,7 +167,6 @@ export {
rustBinaryPageViewResultSchema,
binaryLayoutSummaryViewResultSchema,
javascriptApplicationSummaryViewResultSchema,
javascriptModuleReferencesViewResultSchema,
artifactInventorySummaryViewResultSchema,
desktopApplicationSummaryViewResultSchema,
wasmArtifactSummaryViewResultSchema,
@@ -206,7 +200,6 @@ export {
nativeInventorySummaryViewResultSchema,
nativeLoadImageSummaryViewResultSchema,
nativeFunctionMatchingSummaryViewResultSchema,
nativeFunctionSummarySchema,
nativeFunctionSummaryViewResultSchema,
sourceToBundleSummaryViewResultSchema,
sourceToBundlePageViewResultSchema,
-4
View File
@@ -99,10 +99,6 @@ export const ARTIFACT_FORMAT_IDS = [
export type ArtifactFormatId = (typeof ARTIFACT_FORMAT_IDS)[number];
/** Whether a stored format id is one of the recognized artifact formats. */
export const isArtifactFormatId = (value: string): value is ArtifactFormatId =>
(ARTIFACT_FORMAT_IDS as readonly string[]).includes(value);
const artifactFormatSchema = z.enum(ARTIFACT_FORMAT_IDS);
/** Formats established from bytes or a virtual directory tree, independent of path roles. */
@@ -14,10 +14,7 @@ import type {
JavaScriptRpcScan,
} from "./javascriptRpcEndpoint.js";
export type {
JavaScriptRpcEndpoint,
JavaScriptRpcScan,
} from "./javascriptRpcEndpoint.js";
export type { JavaScriptRpcScan } from "./javascriptRpcEndpoint.js";
// tRPC proxies preserve router and procedure names as property names, so they
// survive identifier minification. Method names follow @trpc/react-query and
@@ -14,8 +14,6 @@ import {
type JavaScriptSemanticBindingState,
} from "./javascriptSemanticState.js";
export type { JavaScriptOpaqueScopeEffects } from "./javascriptSemanticState.js";
export const indexSemanticOpaqueEffects = (
candidates: readonly {
node: t.CallExpression;