fix(web): require ambient identity for bundle require edges (#12320)

This commit is contained in:
morluto authored and GitHub committed 2026-11-19 12:34:44 +00:00
1 parent c569982ef3
commit af0e0edbc2
2 files changed
+11 -3

No files matched your search

+7 -2
View File
@@ -2012,7 +2012,7 @@ it("does not infer call names from dynamic computed identifiers", () => {
expect(result.observations.webmcp_declarations).toEqual([]);
});
it("retains direct and literal computed call names", () => {
it("retains literal calls and requires ambient identity for require edges", () => {
const result = analyzeWebBundleFixture(
inspection(`
window.fetch("/direct");
@@ -2020,6 +2020,11 @@ it("retains direct and literal computed call names", () => {
window[receiver].fetch("/nested-receiver");
window.require("./direct.js");
window["require"]("./literal.js");
require("./bare.js");
const vendor = { require() {} };
vendor.require("./vendor.js");
function local(require) { require("./local.js"); }
function withWindow(window) { window["require"]("./shadowed.js"); }
document.modelContext["registerTool"]({ name: "literal-tool" });
`),
);
@@ -2030,7 +2035,7 @@ it("retains direct and literal computed call names", () => {
]);
expect(
result.observations.chunks.edges.map(({ specifier }) => specifier),
).toEqual(["./direct.js", "./literal.js"]);
).toEqual(["./direct.js", "./literal.js", "./bare.js"]);
expect(result.observations.webmcp_declarations).toEqual([
expect.objectContaining({ name: "literal-tool" }),
]);
+4 -1
View File
@@ -239,7 +239,10 @@ const inspectCall = (
): void => {
const name = calleeName(node.callee);
const first = stringValue(node.arguments[0]);
if ((name === "require" || name.endsWith(".require")) && first !== undefined)
if (
first !== undefined &&
isUnmodifiedGlobalReference(node.callee, bindings, "require")
)
addEdge({
script,
specifier: first,