refactor(elf): share bounded note header reads (#12527)

This commit is contained in:
morluto authored and GitHub committed 2026-11-19 21:17:34 +00:00
1 parent b824f9510d
commit b239ea8011
3 files changed
+14 -6

No files matched your search

@@ -14,7 +14,6 @@
"src/domain/managed/managedMetadataHeaps.ts": 4,
"src/domain/managed/managedMetadataInventoryRows.ts": 2,
"src/domain/managed/managedMetadataLayout.ts": 7,
"src/domain/native/elfNoteLayout.ts": 3,
"src/domain/native/elfPointerRelocations.ts": 6,
"src/domain/native/nativeAotPe.ts": 26,
"src/domain/native/readBinaryContainer.ts": 1,
+6 -1
View File
@@ -11,7 +11,12 @@ it.each([false, true])(
view.setUint32(4, 0x80000001, littleEndian);
view.setUint32(8, 0xfedcba98, littleEndian);
const before = Buffer.from(backing);
const parsed = readElfNoteHeader(backing.subarray(7), littleEndian);
const prefix = new Uint8Array(
backing.buffer,
backing.byteOffset + 7,
backing.byteLength - 7,
);
const parsed = readElfNoteHeader(prefix, littleEndian);
expect(backing.equals(before)).toBe(true);
backing.fill(0);
expect(parsed).toEqual({
+8 -4
View File
@@ -1,3 +1,4 @@
import { BinaryReader } from "../binaryContainer.js";
import { err, ok } from "../result.js";
export const ELF_NOTE_HEADER_BYTES = 12;
@@ -26,11 +27,14 @@ export const readElfNoteHeader = (bytes: Uint8Array, littleEndian: boolean) => {
kind: "malformed" as const,
message: "ELF note header is truncated",
});
const view = new DataView(bytes.buffer, bytes.byteOffset, bytes.byteLength);
const prefix = Buffer.isBuffer(bytes)
? bytes
: Buffer.from(bytes.buffer, bytes.byteOffset, bytes.byteLength);
const reader = new BinaryReader(prefix, littleEndian, "ELF note");
return ok({
namesz: view.getUint32(0, littleEndian),
descsz: view.getUint32(4, littleEndian),
type: view.getUint32(8, littleEndian),
namesz: reader.u32(0),
descsz: reader.u32(4),
type: reader.u32(8),
});
};