mirror of
https://github.com/morluto/rea.git
synced 2026-11-21 14:05:49 +00:00
test(artifacts): consolidate reader ordering and coverage checks (#12774)
This commit is contained in:
1 parent
eb1e75b809
commit
d1275f72d6
2 files changed
+25
-55
No files matched your search
@@ -46,28 +46,13 @@ const drain = async (iterable: AsyncIterable<ArtifactEntry>) => {
|
||||
};
|
||||
|
||||
describe("ArtifactTraversalObservation", () => {
|
||||
it("is complete only when the reader declares complete coverage and finishes", async () => {
|
||||
const traversal = new ArtifactTraversalObservation();
|
||||
expect(
|
||||
await drain(traversal.entries(reader("zip", complete), undefined)),
|
||||
).toEqual(["a", "b"]);
|
||||
expect(traversal.snapshot()).toEqual(complete);
|
||||
});
|
||||
|
||||
it("reports a reader that ends without declaring coverage as unknown", async () => {
|
||||
const traversal = new ArtifactTraversalObservation();
|
||||
await drain(traversal.entries(reader("ines", undefined), undefined));
|
||||
expect(traversal.snapshot()).toEqual({
|
||||
status: "unknown",
|
||||
limitations: [
|
||||
"The ines reader ended its traversal without declaring coverage; members it did not list are unknown.",
|
||||
],
|
||||
});
|
||||
});
|
||||
|
||||
it("does not let one declared-complete traversal cover a silent one", async () => {
|
||||
const traversal = new ArtifactTraversalObservation();
|
||||
await drain(traversal.entries(reader("directory", complete), undefined));
|
||||
expect(
|
||||
await drain(traversal.entries(reader("directory", complete), undefined)),
|
||||
).toEqual(["a", "b"]);
|
||||
expect(traversal.snapshot()).toEqual(complete);
|
||||
|
||||
await drain(traversal.entries(reader("asar", undefined), undefined));
|
||||
await drain(traversal.entries(reader("zip", complete), undefined));
|
||||
expect(traversal.snapshot()).toEqual({
|
||||
|
||||
@@ -46,51 +46,36 @@ const enumeration = (
|
||||
};
|
||||
|
||||
describe("consumeWithOrderedReads", () => {
|
||||
it("consumes in enumeration order when a later read finishes first", async () => {
|
||||
const reads = new Map(
|
||||
["a", "b", "c"].map((item) => [item, controlled<string>()]),
|
||||
);
|
||||
it("bounds concurrent reads and consumes eligible entries in enumeration order", async () => {
|
||||
const first = controlled<string>();
|
||||
const second = controlled<string>();
|
||||
const started: string[] = [];
|
||||
const consumed: string[] = [];
|
||||
const done = consumeWithOrderedReads(
|
||||
enumeration(["a", "b", "c"]).items,
|
||||
8,
|
||||
(item) => reads.get(item)!.promise,
|
||||
enumeration(["a", "skip", "b", "c"]).items,
|
||||
2,
|
||||
(item) => {
|
||||
if (item === "skip") return undefined;
|
||||
started.push(item);
|
||||
if (item === "a") return first.promise;
|
||||
if (item === "b") return second.promise;
|
||||
return Promise.resolve("3");
|
||||
},
|
||||
async (item, value) => {
|
||||
consumed.push(`${item}=${value}`);
|
||||
},
|
||||
);
|
||||
await drain();
|
||||
reads.get("c")!.resolve("3");
|
||||
reads.get("b")!.resolve("2");
|
||||
const startedBeforeEitherCompleted = [...started];
|
||||
second.resolve("2");
|
||||
await drain();
|
||||
expect(consumed).toEqual([]);
|
||||
reads.get("a")!.resolve("1");
|
||||
const consumedBeforeFirstCompleted = [...consumed];
|
||||
first.resolve("1");
|
||||
await done;
|
||||
expect(consumed).toEqual(["a=1", "b=2", "c=3"]);
|
||||
});
|
||||
|
||||
it("keeps at most width reads in flight and skips undefined reads", async () => {
|
||||
let inFlight = 0;
|
||||
let maxInFlight = 0;
|
||||
const consumed: string[] = [];
|
||||
await consumeWithOrderedReads(
|
||||
enumeration(["a", "skip", "b", "c", "d", "e"]).items,
|
||||
2,
|
||||
(item) => {
|
||||
if (item === "skip") return undefined;
|
||||
inFlight += 1;
|
||||
maxInFlight = Math.max(maxInFlight, inFlight);
|
||||
return drain().then(() => {
|
||||
inFlight -= 1;
|
||||
return item;
|
||||
});
|
||||
},
|
||||
async (item) => {
|
||||
consumed.push(item);
|
||||
},
|
||||
);
|
||||
expect(maxInFlight).toBe(2);
|
||||
expect(consumed).toEqual(["a", "b", "c", "d", "e"]);
|
||||
expect(startedBeforeEitherCompleted).toEqual(["a", "b"]);
|
||||
expect(consumedBeforeFirstCompleted).toEqual([]);
|
||||
expect(consumed).toEqual(["a=1", "b=2", "c=3"]);
|
||||
});
|
||||
|
||||
it("reports an earlier read failure before a later one", async () => {
|
||||
|
||||
Reference in new issue
Block a user