test(dotnet): consolidate managed ExtraData coverage (#12788)

test(managed): consolidate metadata ExtraData coverage
This commit is contained in:
morluto authored and GitHub committed 2026-11-20 12:34:36 +00:00
1 parent 9899c6659a
commit e8105d6be9
1 file changed
+83 -98
+83 -98
View File
@@ -33,74 +33,62 @@ const fixtureTablesStream = (bytes: Buffer) => {
return { streamHeader, tablesOffset, extraDataOffset: 24 + count * 4 };
};
describe("CLR metadata tables ExtraData extension", () => {
it.each([
{ label: "absent extension", metadataExtraData: undefined },
{ label: "zero word", metadataExtraData: 0 },
{ label: "nonzero word", metadataExtraData: 0x1234_5678 },
{ label: "maximum unsigned word", metadataExtraData: 0xffff_ffff },
])(
"preserves metadata and member identities with $label",
({ metadataExtraData }) => {
const plain = buildManagedPeFixture();
const plainTarget = managedPeFixtureTarget(plain);
const baseline = inspectManagedArtifactBytes(plain, plainTarget);
const baselineMembers = inspectManagedMembersBytes(plain, plainTarget);
expect(baselineMembers.coverage).toEqual({
state: "complete",
issues: [],
});
expect(baselineMembers.types.map(({ full_name }) => full_name)).toEqual([
"Fixture.Program",
]);
expect(baselineMembers.fields).toHaveLength(1);
expect(baselineMembers.methods).toMatchObject([{ name: "Main" }]);
const bytes = buildManagedPeFixture(
metadataExtraData === undefined ? {} : { metadataExtraData },
);
const target = managedPeFixtureTarget(bytes);
const artifact = inspectManagedArtifactBytes(bytes, target);
const members = inspectManagedMembersBytes(bytes, target);
const shift = metadataExtraData === undefined ? 0 : 4;
it("preserves metadata and member identities with zero and maximum ExtraData words", () => {
const plain = buildManagedPeFixture();
const plainTarget = managedPeFixtureTarget(plain);
const baseline = inspectManagedArtifactBytes(plain, plainTarget);
const baselineMembers = inspectManagedMembersBytes(plain, plainTarget);
expect(baseline.coverage).toEqual({ state: "complete", issues: [] });
expect(baselineMembers.coverage).toEqual({ state: "complete", issues: [] });
expect(baselineMembers.types.map(({ full_name }) => full_name)).toEqual([
"Fixture.Program",
]);
expect(baselineMembers.fields).toHaveLength(1);
expect(baselineMembers.methods).toMatchObject([{ name: "Main" }]);
if (baseline.module === null || baseline.assembly === null)
throw new Error("Fixture omitted module or assembly");
expect(artifact.coverage).toEqual({ state: "complete", issues: [] });
expect(members.coverage).toEqual({ state: "complete", issues: [] });
if (baseline.module === null || baseline.assembly === null)
throw new Error("Fixture omitted module or assembly");
expect(artifact.module).toEqual({
...baseline.module,
row_offset: baseline.module.row_offset + shift,
});
expect(artifact.assembly).toEqual({
...baseline.assembly,
row_offset: baseline.assembly.row_offset + shift,
});
expect(artifact.metadata.table_row_counts).toEqual(
baseline.metadata.table_row_counts,
);
expect(artifact.target_frameworks).toEqual(baseline.target_frameworks);
expect(members.types).toEqual(
baselineMembers.types.map((type) => ({
...type,
row_offset: type.row_offset + shift,
})),
);
expect(members.fields).toEqual(
baselineMembers.fields.map((field) => ({
...field,
row_offset: field.row_offset + shift,
})),
);
expect(members.methods).toEqual(
baselineMembers.methods.map((method) => ({
...method,
row_offset: method.row_offset + shift,
})),
);
expect(members.call_edges).toEqual(baselineMembers.call_edges);
expect(members.field_accesses).toEqual(baselineMembers.field_accesses);
},
);
for (const metadataExtraData of [0, 0xffff_ffff]) {
const bytes = buildManagedPeFixture({ metadataExtraData });
const target = managedPeFixtureTarget(bytes);
const artifact = inspectManagedArtifactBytes(bytes, target);
const members = inspectManagedMembersBytes(bytes, target);
expect(artifact.coverage).toEqual({ state: "complete", issues: [] });
expect(members.coverage).toEqual({ state: "complete", issues: [] });
expect(artifact.module).toEqual({
...baseline.module,
row_offset: baseline.module.row_offset + 4,
});
expect(artifact.assembly).toEqual({
...baseline.assembly,
row_offset: baseline.assembly.row_offset + 4,
});
expect(artifact.metadata.table_row_counts).toEqual(
baseline.metadata.table_row_counts,
);
expect(artifact.target_frameworks).toEqual(baseline.target_frameworks);
expect(members.types).toEqual(
baselineMembers.types.map((type) => ({
...type,
row_offset: type.row_offset + 4,
})),
);
expect(members.fields).toEqual(
baselineMembers.fields.map((field) => ({
...field,
row_offset: field.row_offset + 4,
})),
);
expect(members.methods).toEqual(
baselineMembers.methods.map((method) => ({
...method,
row_offset: method.row_offset + 4,
})),
);
expect(members.call_edges).toEqual(baselineMembers.call_edges);
expect(members.field_accesses).toEqual(baselineMembers.field_accesses);
}
});
describe("CLR ExtraData index widths and boundaries", () => {
@@ -210,36 +198,33 @@ describe("CLR ExtraData index widths and boundaries", () => {
]);
});
it.each([0, 1, 3])(
"rejects an ExtraData word with only %i declared bytes",
(availableBytes) => {
const bytes = buildManagedPeFixture({ metadataExtraData: 0x1234_5678 });
const { streamHeader, tablesOffset, extraDataOffset } =
fixtureTablesStream(bytes);
expect(bytes[tablesOffset + 6]).toBe(0x40);
expect(bytes.readUInt32LE(tablesOffset + extraDataOffset)).toBe(
0x1234_5678,
);
// Only the declared tables-stream extent is shortened; the PE and heaps stay intact.
bytes.writeUInt32LE(extraDataOffset + availableBytes, streamHeader + 4);
it("rejects an ExtraData word one byte short of its declared extent", () => {
const bytes = buildManagedPeFixture({ metadataExtraData: 0x1234_5678 });
const { streamHeader, tablesOffset, extraDataOffset } =
fixtureTablesStream(bytes);
expect(bytes[tablesOffset + 6]).toBe(0x40);
expect(bytes.readUInt32LE(tablesOffset + extraDataOffset)).toBe(
0x1234_5678,
);
// Only the declared tables-stream extent is shortened; the PE and heaps stay intact.
bytes.writeUInt32LE(extraDataOffset + 3, streamHeader + 4);
const result = inspectManagedMembersBytes(
bytes,
managedPeFixtureTarget(bytes),
);
expect(result.coverage).toMatchObject({
state: "unavailable",
issues: [
expect.objectContaining({
code: "invalid-metadata-root",
scope: "metadata.tables-extra-data",
offset: tablesOffset + extraDataOffset,
}),
],
});
expect(result.module).toBeNull();
expect(result.types).toEqual([]);
expect(result.methods).toEqual([]);
},
);
const result = inspectManagedMembersBytes(
bytes,
managedPeFixtureTarget(bytes),
);
expect(result.coverage).toMatchObject({
state: "unavailable",
issues: [
expect.objectContaining({
code: "invalid-metadata-root",
scope: "metadata.tables-extra-data",
offset: tablesOffset + extraDataOffset,
}),
],
});
expect(result.module).toBeNull();
expect(result.types).toEqual([]);
expect(result.methods).toEqual([]);
});
});