Commit Graph
9334 Commits
Author SHA1 Message Date
CyberSproutandCursor 360bcb4c6c docs(process): record the capture PTY hangup of same-group children (#10282)
When the target exits, the terminal sends SIGHUP to its foreground process group. The capture guide now says that, and that this signal is not REA cleanup.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-11-21 21:01:14 +01:00
morluto 33d1c6ee44 test(web): control CDP teardown timing and consolidate cleanup proof (#13199) 2026-11-21 20:00:35 +00:00
David Muñoz Rey 559956cf6b refactor(inspector): own the Node discovery path rule in one module (#10680)
Node Inspector discovery reports a target as `file://` plus the pathname,
with quotes and backslashes replaced by underscores. Whether such a
pathname is identifiable was decided twice: inline in
authorizeRuntimeTargetLocation and again as NODE_DISCOVERY_AMBIGUOUS in
the createNodeDiscoveryTempDirectory fixture. The copies could drift, and
the fixture could not import the product rule without loading
JavaScriptRuntimeScope and its Electron file-scope chain.

Move the rule to src/inspector/nodeDiscoveryPath.ts, a module with no
imports, and use it from both places. Behavior is unchanged. A unit test
covers the Windows branch, which Linux CI cannot reach through the
boundary tests.

Validation: nodeDiscoveryPath and cancellation tests 12/12;
javascriptRuntimeTargetLocations and javascriptRuntimeObservation 42/42
with TMPDIR containing an underscore (exercises the /tmp fallback);
check:fast passes.

Refs morluto/rea#9996
2026-11-21 20:59:38 +01:00
morluto 7b856fa5a1 refactor(desktop): validate task pointer syntax at its shared owner 2026-11-21 20:57:32 +01:00
Nianze Wu 361be4cb63 fix(desktop): reject invalid task pointer escapes 2026-11-21 20:57:32 +01:00
David Muñoz Rey 6aa3898317 fix(apple): rethrow internal invariant violations while resolving a bundle's program file (#11392)
* fix(apple): rethrow internal invariant violations while resolving a bundle's program file

Bundle target resolution decodes Info.plist with the shared binary plist decoder, which reports a broken internal assumption as InternalInvariantError. The resolver caught every decode failure and reported it as a BinaryTargetError ("Info.plist is malformed, unsupported, or lacks CFBundleExecutable"), and its two outer catches wrapped anything else the same way. A REA defect therefore reached the caller as a fact about the user's bundle.

#11029 made the other plist consumers rethrow the invariant. The resolver's decode site and both outer catches now do the same.

Tests: a boundary test opens a .app and a .bundle through parseBinaryTarget with the decoder replaced by one that reports an invariant violation. Before this change both resolved { ok: false } with a BinaryTargetError; now both reject with the InternalInvariantError. The same bundles open normally with the real decoder.

* test(apple): mock the binary plist decoder at its domain path

Main moved the binary plist materializer from src/artifacts/apple to
src/domain/apple, and AppBundleExecutable now imports it from there. The
invariant test still mocked the old path, which no longer exists, so tsc
failed and the mock would have intercepted nothing.

The test now mocks src/domain/apple/binaryPlistMaterializer.js. With the
rethrow removed from AppBundleExecutable both cases fail; with it they pass.
2026-11-21 20:56:47 +01:00
Davmunrey 909d4702f2 test(javascript): cover array holes, nested spreads and an empty spread before an argument in kill signals
Review follow-up: firstRuntimeArgument has separate paths for an array hole, a nested array spread and an empty spread followed by another argument. child.kill(...[, "SIGINT"]) sends SIGTERM, child.kill(...[...["SIGINT"]]) sends SIGINT and child.kill(...[], "SIGKILL") sends SIGKILL; the case now pins all three.
2026-11-21 20:48:31 +01:00
ahmed0magdyandClaude Opus 5.5 4bcd0d864a fix(javascript): resolve literal spreads and const aliases in kill signals
Address review feedback on the kill() signal fact:

- Drop the semanticResolutionBlocked import, which isUnshadowedGlobal
  superseded.
- Expand spreads of array literals before selecting the signal, so
  kill(...[]) reports Node's SIGTERM default and kill(...["SIGINT"])
  reports SIGINT. A spread of anything else stays unknown.
- Follow const aliases whose only write is one unconditional initializer
  (the same !mutable + semanticStableInitializer rule other producers
  use), so `const signal = undefined; kill(signal)` reports SIGTERM.
  let, var, reassigned, and shadowed bindings stay unknown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-21 20:48:31 +01:00
morluto 9230f698b3 fix(web): retain Chromium navigation kind in session evidence (#13194)
* fix(web): retain Chromium navigation kind in session evidence

* test(web): use native reload event shape in the shared timeline fixture
2026-11-21 19:47:52 +00:00
David Muñoz Rey 33ecda025f fix(ghidra): name the code seed recovery for addresses outside the listing (#10682)
inspect_native_instruction reports `not-in-listing` when an address lies
in Ghidra's memory but the listing has no instruction or defined data
there. No decode is attempted, so the answer does not show the bytes are
data, yet the result named no way forward. #10623 added the declared-seed
recovery for procedure_not_found and not_in_procedure; this is the
instruction-level sibling, where a `code` seed applies.

A not-in-listing answer now carries ghidraNotInListingLimitation(source).
It names a `code` seed (or a `function` seed for an entry point) in
REA_GHIDRA_SEED_FILE, says which setting to unset first for a selected
project or checkpoint, and does not assert that the address holds code.
decoded, data and other statuses are unchanged. The installation guide's
seed section lists the new carrier.

Validation: src/ghidra/GhidraProvider.behavior.test.ts fails 1/298 with
the caveat removed and passes 298/298 with it; check:fast passes. No
real Ghidra run.

Refs morluto/rea#3767
2026-11-21 20:47:42 +01:00
David Muñoz Rey e7a023263b fix(ghidra): say byte-search pages read match metadata live (#10684)
A search_bytes cursor resumes the same target, profile and query, and
the limitation said only that. In a real session, renaming a function
between pages changed the procedure name on the next page from the same
cursor, while the page Evidence kept the same target and profile digest
and no limitation explained the difference.

The search_bytes limitation now states that the cursor does not pin
match metadata: procedure names and other match metadata are read live
on each page, so a rename in the session between pages appears on later
pages. This takes the issue's "identify that match metadata is live"
option; binding or qualifying pages to a metadata version is left open.

No prose-asserting test was added, following the direction in #10508.
Validation: src/ghidra/GhidraProvider.behavior.test.ts 296/296;
check:fast passes.

Refs morluto/rea#8365
2026-11-21 20:46:47 +01:00
gensokyo-devandgensokyo-dev 62ec695303 fix(ghidra): link the published installation guide from decompiler remediation
The npm package does not ship docs/, so a repository-relative guide path
in doctor's remediation could not be opened by npm users. Link the guide
on GitHub instead.

Refs #7018

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 20:44:21 +01:00
gensokyo-devandgensokyo-dev dc10161a9e docs(ghidra): link the native build steps for Linux arm64
The Ghidra requirements said official archives may require building the
Linux arm64 decompiler but gave no steps, so doctor's new pointer to that
section led nowhere. Ghidra's own guide lists Linux ARM64 among the
platforms that need user-built natives; link its Building Native
Components section and state it plainly in the remediation too.

Refs #7018

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 20:44:21 +01:00
gensokyo-devandgensokyo-dev cc8716ce22 fix(ghidra): say how to build a missing macOS or Linux arm64 decompiler
Official Ghidra release archives ship no macOS decompiler and may ship
none for Linux arm64, but doctor's native_decompiler remediation only
named the expected path. On those hosts it now says the archive's
decompiler source builds it and points to the installation guide's build
steps for that platform.

Fixes #7018

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 20:44:21 +01:00
morluto 905090c0ca test(web): control authorization retries and consolidate session termination (#13196) 2026-11-21 19:41:41 +00:00
ShuaixinHuangandShuaixinHuang ae72c30e2c fix(bun): keep budget refusals out of layout selection (#12763)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-21 20:39:31 +01:00
Yunzhou Li 44e8e72db1 test(cutter): use account home for default bridge assertions (#12728) 2026-11-21 20:35:50 +01:00
morluto c806ba8ed7 test(setup): exercise the MSIX registration regression in Windows CI (#13189)
test(setup): run the MSIX registration regression in Windows CI
2026-11-21 14:33:59 -05:00
ShuaixinHuang b3dfd5305d test(desktop): keep TryExec regression independent of ID masking group 2026-11-21 20:33:38 +01:00
ShuaixinHuang b185803bc8 fix(desktop): respect TryExec when selecting Linux launchers 2026-11-21 20:33:38 +01:00
ShuaixinHuang 0d7112321d fix(reference): render invalid Git config path with native separators 2026-11-21 20:27:50 +01:00
ShuaixinHuang ae8cd50ff7 fix(reference): preserve host spelling for Git metadata paths 2026-11-21 20:27:50 +01:00
AshritVerma 244cb64677 fix(setup): list supported clients instead of a suggestion for an empty client name
An empty or whitespace-only --client or --skill-client value normalizes to an empty key, which is a prefix of every id, so suggestion ranking named an arbitrary client. Skip the suggestion for an empty key and report the supported list.
2026-11-21 20:27:10 +01:00
AshritVerma fe1f851057 test(setup): cover client name resolution and typo suggestions 2026-11-21 20:27:10 +01:00
AshritVerma ed5c3dd10d fix(setup): accept hyphenated client names and suggest the closest one
Setup and doctor resolve --client and --skill-client values by trimming,
lowercasing and collapsing runs of '-', '_' and whitespace, then matching a
canonical id or an alias the client row already declares for 'rea mcp add'.
An unknown value now reports 'Unknown client' with the closest id from
suggestCommand, or the supported list when nothing is close. The error code
and field path are unchanged.
2026-11-21 20:27:10 +01:00
morluto 3130adbb1b perf(web): stop repeated accessibility reads after method refusal (#13191) 2026-11-21 19:26:23 +00:00
ShuaixinHuangandShuaixinHuang 6878c17a83 docs(artifacts): explain the per-file verification cost of extraction (#12745)
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
2026-11-21 20:24:15 +01:00
ShuaixinHuang d9f2fd365d fix(desktop): classify complete filename boundary code points 2026-11-21 20:22:43 +01:00
ShuaixinHuang d07d28b533 fix(desktop): match title filenames at Unicode boundaries 2026-11-21 20:22:43 +01:00
ShuaixinHuangandShuaixinHuang f85fae63e1 fix(build): keep Windows import symbols independent of the build path (#12753)
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
2026-11-21 20:21:12 +01:00
ShuaixinHuangandShuaixinHuang c5b5d9f7ea fix(pe): exclude section padding from RVA metadata reads (#12755)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-21 20:20:04 +01:00
ShuaixinHuang efe692721e fix(desktop): preserve dynamic-token refusal wording 2026-11-21 20:18:25 +01:00
ShuaixinHuang 1b2299c7f8 fix(desktop): leave host-dependent ELF library names unresolved 2026-11-21 20:18:25 +01:00
ShuaixinHuangandShuaixinHuang 6a0a5e7379 fix(desktop): report JSON view depth after reviver stack exhaustion (#12759)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-21 20:16:54 +01:00
Adolanium 947fa8f14d fix(browser): separate the decoder CPU budget from an inherited ceiling
A SIGXCPU at the requested budget is the decoder's own ceiling. Raising RLIMIT_CPU does not extend it. A lower recorded ceiling remains an inherited limit. A failed close of the CPU record stays on the decoder scope and does not skip that classification.
2026-11-21 20:08:53 +01:00
Adolanium d6a5b32ed0 fix(browser): share the capture resource-constraint constructor
Static checks reject a second AnalysisResourceConstraintError in CaptureFailures.ts. SIGXCPU still reports the recorded ceiling and tells the caller to raise RLIMIT_CPU. The CPU record is read through the stable artifact owner, so a failed close stays on the decoder scope.
2026-11-21 20:08:53 +01:00
Adolanium 39ade5694b fix(browser): name the CPU ceiling when mitmproxy dies with SIGXCPU
A tighter inherited RLIMIT_CPU is kept, and that death had no reply. The decoder records the installed ceiling, and SIGXCPU becomes a CPU resource constraint that names it.
2026-11-21 20:08:53 +01:00
Adolanium 92f3f28d29 fix(browser): name the inherited address-space limit on a decoder memory refusal 2026-11-21 20:08:53 +01:00
Adolanium 465ae4d1d5 fix(browser): bound mitmproxy replies by the inherited file limit
A tighter RLIMIT_FSIZE was installed, but the reply check still used the
requested budget. A reply under that budget could exceed the inherited
limit and truncate. The effective cap now bounds the write, and a reply
that does not fit returns a fixed file-size limit. Tests also keep a
higher hard limit distinct from the new soft limit.
2026-11-21 20:08:53 +01:00
Adolanium 919fbfb983 fix(browser): clamp mitmproxy limits and always shut the decoder down
setrlimit ran before the shutdown guard and asked for hard limits the
process may not raise. A tighter inherited hard limit then left mitmdump
running until the capture timeout.
2026-11-21 20:08:53 +01:00
Adolanium 89fe8dcf4e test(binary): throw the cause when restoration setup fails
A failed resolveTarget returned after a boolean assertion, so the setup
failure showed as a mismatch instead of the typed error. Format the long
AnalysisOutputError line that static checks rejected.
2026-11-21 20:06:57 +01:00
Adolanium a963184282 fix(binary): keep an imported snapshot when the first open fails
A failed first open whose client cleanup also failed cleared a staged
import even though no target had been retired. Clearing now waits until
this open has retired a previous target. A later open still retries that
cleanup before another profile can start.
2026-11-21 20:06:57 +01:00
Adolanium 667a0054d6 fix(binary): clear snapshot cache when a failed switch cannot restore
A retired target that does not come back kept its snapshot binding.
The next open failed the staged-snapshot check until close_binary.
2026-11-21 20:06:57 +01:00
Adolanium 72f8f521a6 fix(desktop): claim agentenv capture exclusively and survive FIFO write errors (#12838)
* fix(desktop): claim agentenv capture exclusively and survive FIFO write errors

stop() used makedirs(exist_ok) before the control FIFO existed, so a
start already in that window kept running after stop reported the
capture absent. A broken or full FIFO also aborted stop and mark
instead of reporting that the capture was not reading.

* fix(desktop): retry agentenv stop until the reader accepts it

stop() treated the first failed FIFO write as final and then started a
second full timeout. A start() that has created the FIFO but not opened
it kept running, and an interrupted startup could take twice the
caller's timeout.

* fix(desktop): remember an absent agentenv stop for a retry

stop() claimed a missing directory and returned absent. A retry found
that directory and waited for a FIFO that start() will not create, so
the build-computer release could not clear the folder. The claim is a
file in the directory, and a later stop returns absent.

* test(lifecycle): name the renamed JEB and BEAM coverage tests

The full source suite still expects titles removed by the JEB catalog consolidation and the BEAM CLI consolidation. Point those entries at the tests that replaced them.
2026-11-21 20:05:35 +01:00
morluto 5c390198f7 fix(web): retain CDP scope and request identity during session preparation (#13188) 2026-11-21 19:05:13 +00:00
Vinícius DS Andrade 56838a036c docs(v8): describe the six-word code cache header
State the second pinned layout, its word table and how admission reads
the payload length for each layout. Record that the six-word roles come
from the V8 sources and that runtime compatibility with a V8 8.8 through
11.7 producer remains unverified.
2026-11-21 20:02:30 +01:00
Vinícius DS Andrade 978cc6d46b test(v8): cover the six-word code cache header
No V8 8.8 through 11.7 producer runs in the test environment, so the
fixture is synthetic, as it already is for the narrow header: a real
cache without its build-constant word and its alignment word, which is
the container those releases define.

Cover the admitted layout through the parser and the public CLI, the
bit 31 module flag, a truncated six-word container, a container that
fits both layouts, and the word-table rule for a 24-byte header. The
short-header case now also covers the new 24-byte minimum.

The CLI case is the recorded lifecycle coverage of the provider, so its
new title is updated there as well.
2026-11-21 20:02:30 +01:00
Vinícius DS Andrade cc19240ca9 fix(v8): admit the six-word code cache header of V8 8.8 through 11.7
The reader pinned the seven-word header that V8 11.8 and later write and
took the payload length from the word at 0x14. V8 8.8 through 11.7,
which Node 16 through 20 embed, define six words: there is no read-only
snapshot checksum word, the payload length is the word at 0x10 and the
header is 24 bytes on both pointer widths. For such a container the word
at 0x14 is the payload checksum, so a complete cache was refused as
truncated or corrupt.

Admit the six-word layout when the word at 0x10 reaches the end of the
file from a 24-byte header, and report its six words. A container that
fits both layouts is refused as ambiguous. The six-word roles come from
the V8 sources of those releases, so only the magic and the
payload-length relation are reported as confirmed, and the result states
that the layout was not measured against one of their producers.

A container that fits neither layout is no longer described as certainly
truncated or corrupt, since an unadmitted header has the same effect.
2026-11-21 20:02:30 +01:00
Brahma Reddy f03cce9c01 fix(native): label XML plists that file calls data as xml (#12910)
`file -b` reports `data` for an XML plist containing a control character
or NUL byte, which CoreFoundation still reads. plistSourceFormat only
probed the source for markup when `file` reported text, so these sources
were labelled `unknown` and skipped REA's XML reader. When that reader
would have refused them, the result also lacked the limitation that says
the value came from plutil's conversion. Two plists shipped with macOS
27.2.1 are affected.

Probe the source prefix for any description that does not name binary,
XML or JSON. Such XML now takes the same route as XML that `file`
recognizes: REA's reader decodes it directly, or #12251's plutil fallback
records REA's refusal reason. OpenStep and other non-markup sources stay
`unknown`.
2026-11-21 20:00:31 +01:00
morluto c0963732a7 fix(web): keep unreadable cookie partitions incomplete (#13187) 2026-11-21 19:00:00 +00:00