Commit Graph
8874 Commits
Author SHA1 Message Date
385e5d228f test: own temporary directories through createTestTempDirectory in remaining tests/ (#12727)
* test: own temporary directories through createTestTempDirectory in remaining tests/

Give per-test directories in the remaining tests/ suites to
createTestTempDirectory so onTestFinished removes them through
removeTestWorkspace. Keep suite-scoped roots and child-process directories
whose removal is the assertion.

* test: drop empty cleanup callbacks and keep the capture skip reason visible

Remove the no-op withVerifierCleanup steps left after directory removal
moved to createTestTempDirectory. Put the native capture skip explanation
in the Linux sample test name, because it.skipIf only tests truthiness.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 23:22:53 -05:00
e58c60b36e test(limits): reference limit constants instead of repeating their values (#12715)
* test(limits): reference limit constants instead of repeating their values

Point duplicated default literals at their owner constants and replace
recovery-wording locks with the setting name, units, and those constants.
Keep the single default pins that guard shipped values.

* test(limits): pin the shipped Ghidra value-flow defaults

Consumer checks follow the owner constants, so they no longer catch a
change to 3000, 64, or 12000. One owner pin keeps those shipped values.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-20 04:22:32 +00:00
morlutoandCursor Agent be14c9d475 test: own temporary directories through createTestTempDirectory in src/ tests (#12725)
Give per-test temporary directories to the shared helper so Vitest removes
them after the case. Keep directories whose lifetime is the assertion, or
that are shared from beforeAll, on their existing cleanup.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-20 04:10:06 +00:00
Taksh Kothari 79171a4d02 fix(browser): keep failed trace response statuses unknown (#12724)
Use the recorded HTTP response owner for Playwright trace headlines.
Preserve producer status sentinels and failure facts in the raw record,
without presenting unavailable responses as observed HTTP status codes.
2026-11-19 23:10:03 -05:00
94c3077355 test(providers): own temporary directories through createTestTempDirectory (#12722)
* test(providers): own temporary directories through createTestTempDirectory

Route provider-boundary fixtures through createTestTempDirectory so each
case removes its canonical directory after the test. Process shutdown stays
in afterEach, which still runs before that removal. Skip the two Windows
Cutter checks with it.skipIf, and compare unknown plugin recovery with
cutterBridgeSourceRecovery.

* test(providers): keep gated fixture cleanup with its owner

createTestTempDirectory always deletes after the test, including when
GDB or inferior cleanup fails and when the Rizin MCP harness already
owns the directory. Restore mkdtemp removal behind confirmed process
cleanup, and leave decoder inputs owned by the harness.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(cutter): keep an independent unknown-source recovery check

Comparing discovery recovery with cutterBridgeSourceRecovery follows the
formatter, so dropping the unknown-source explanation still passes. Assert
that explanation directly, beside bridge_source and the plugin path.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-20 04:06:31 +00:00
74bdfd2ec2 test: assert structured recovery facts instead of recovery wording in src tests (#12721)
* test: assert structured recovery facts instead of recovery wording in src tests

Replace recovery-sentence locks with the structured fields that already
carry those facts, and own Batch 4 temporary directories through
createTestTempDirectory.

* test(hopper): keep recovery order that retry_action does not carry

retry_action names restart or unknown. It does not say to read
provider_operation_health before retrying, or to close_binary before
opening and retrying. Those order checks stay.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 23:05:20 -05:00
dc2c31e76d test(limits): check documented limit defaults against code instead of per-file pins (#12720)
* test(limits): check documented limit defaults against code instead of per-file pins

The numeric-limit script now reads every default, floor, and maximum in
docs/design/rea-limit-inventory.md and compares it with ANALYSIS_SETTINGS
or the owner constant the parser enforces. A mismatch names the limit and
both values. Pins that only restated a covered value are removed.

Pwntools input bytes and the Kuna timeouts now use the shared exports, so
the registry value is the one the parser applies.

* fix(limits): reject a fractional documented limit cell

The cell parser treated a dot as the end of the integer, so 5000.5
compared equal to 5000. A documented number is now one complete integer,
with prose only after whitespace.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 23:05:07 -05:00
d5818ad0da refactor(verify): run Ghidra verifier commands through the supervised owner (1 of 2) (#12719)
* refactor(verify): run Ghidra verifier commands through the supervised owner

Route the first Ghidra verifier batch's compilers, linkers, and CLI through
createVerifierCommands, and close that owner before the lineage check.
Replace MCP isError prose checks with the structured refusal each tool builds.

* fix(verify): resolve Windows 6502 toolchain names through the command owner

runOwnedCommand passes a bare ca65 or ld65 name to the Windows process
owner, which accepts only a drive-absolute path. The verifier command
owner resolves those PATH names before launch.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(verify): release the Ghidra fixture when a toolchain probe fails

retain() only registered a cleanup that nothing ran, so a failed compiler
probe left the empty fixture directory behind. Release it after the command
owner closes, and name the retained path when that close does not confirm.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(verify): close the m68k command owner when session shutdown fails

Client, transport, and command cleanup are independent. A failed client or
transport close, or a failed runtime read, no longer skips the command owner.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 23:04:57 -05:00
morlutoandCursor Agent fa918a35f5 test(setup): run the shared JSON registration contract for CodeBuddy, Droid, FreeBuff and Trae (#12716)
Share the mcpServers upsert, create-table, empty-file, and uninstall cases
through jsonClientRegistrationContract. Trae and FreeBuff pass a location
resolver because their paths are not join(home, directory, filename).

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 23:04:24 -05:00
hhangandhhang e1218b0388 fix(java): preserve Maven POM version spelling (#12714)
Co-authored-by: hhang <169027046+xu91102@users.noreply.github.com>
2026-11-19 23:04:11 -05:00
morlutoandCursor Agent bb8e6833eb test: assert structured recovery facts instead of recovery wording in tests/ (#12723)
Drop recovery-sentence locks when a structured field or the owning
formatter already carries the fact, and own this batch's per-test
temporary directories through createTestTempDirectory. Keep setting
names, caller data, and prose that has no structured carrier.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 23:03:53 -05:00
morluto 847c2d5253 test(desktop): check cleanup of both concurrent reader leases 2026-11-19 22:15:56 -05:00
morluto 9d3bf82c6a test(desktop): require a verdict for every regenerated check 2026-11-19 22:12:53 -05:00
morluto e1e24543e4 test: prove retained facts and remove preinstall source greps 2026-11-19 22:12:19 -05:00
morluto 6bb2ad90ac test: harden verifier assertions and prune duplicate checks 2026-11-19 22:09:03 -05:00
morluto f3734d90e7 test(ci): repair stale coverage expectations on main 2026-11-19 22:09:03 -05:00
RRFZ af0d9ed45a test(uninstall): cover Windows purge without POSIX cache assumptions (#12696) 2026-11-19 22:04:23 -05:00
d9df0f9ca2 perf(javascript): allocate nested evaluation contexts with fixed shapes (#9007)
nestedContext builds one EvaluationContext per recursive expression step. A conditional object spread forces V8 through the generic property-copy path even when the spread adds no fields, and prevents a stable shape. It was the top self-time frame (25.4%) in a profile of semantic indexing.

Use two explicit object literals selected by capturePoint, keeping the same field set, order, values and optionality. Completed analyses are byte-identical across 12 representative sources (36 IR/facts/coverage digests), and member-mutation indexing is 1.47-1.65x faster on the profiled alias-chain workload.

Co-authored-by: Zhenyang Han <mshzy@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 22:01:02 -05:00
morluto 34f3682afd docs: apply agent brittleness guidance across the codebase 2026-11-19 21:48:29 -05:00
morluto ba01214063 docs: keep parser brittleness rules explicit in agent guidance 2026-11-19 21:47:52 -05:00
morluto 32753c1b24 docs: consolidate repository agent guidance 2026-11-19 21:47:05 -05:00
morluto 88f885a2f3 docs(development): clarify parser boundary review criteria (#12713) 2026-11-19 21:46:18 -05:00
morluto 6cab415894 fix(desktop): validate group padding before hidden ID masking (#12708)
* fix(desktop): validate group padding before hidden ID masking

* test(desktop): compact group padding overrides
2026-11-20 02:44:32 +00:00
morluto e53c1a17fc fix(gpu): validate standalone PTX encoding during discovery (#12707) 2026-11-19 21:44:06 -05:00
morluto 8fb9456019 docs(development): illustrate parser ownership through APT replay (#12712) 2026-11-19 21:42:49 -05:00
morluto b61006e114 fix(desktop): preserve effective APT one-line source identity (#12711)
Use the same APT word reader for positional fields and option assignments. Carry authored and effective repository facts through capture and replay.

Fixes #12694.
2026-11-19 21:42:39 -05:00
192934c5b1 fix(desktop): verify single-stanza APT source identity (#12363)
* fix(desktop): verify single-stanza APT source identity

* fix(desktop): verify single-stanza APT source identity

* fix(desktop): match APT suites using its configured architecture

* fix(desktop): match APT URI architecture templates

* fix(desktop): normalize empty APT URI ports

* test(desktop): regress empty-port APT repository identity

Assert entryForTarget and repository facts keep the authored empty-port URI while matching the portless Repo-URI APT 2.8.3 emits, including the signing key.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(desktop): parse APT port suffixes with atoi

Match deb822 Repo-URI identity to APT's unsigned port: the host's last colon suffix is atoi'd, zero is omitted, and IPv6 brackets stay intact while the authored URI is kept.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(desktop): accept GNU architecture names and bound port scans

Keep x86_64 as an APT architecture token for $(ARCH) identity, and stop growing a port magnitude once it passes the signed 64-bit limit.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(desktop): keep file:// as APT's empty-path Repo-URI

An empty host with no path stays scheme://, matching APT 2.8.3. A path after that host still drops it, so file:///srv remains file:/srv.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(desktop): normalize APT scheme:host URIs in one host pass

APT 2.8.3 rewrites http:127.0.0.1:18743/archive to an http:// Repo-URI. Identity comparison follows that form and keeps the authored URI. Bracket removal copies each host character once.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(desktop): replay the APT suite selected during capture

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 21:40:33 -05:00
8c7977f174 fix(native)!: require separate inspection for plists outside bundles (#9754)
* fix(native): record inspected plist bytes and refuse files outside the bundle

An open app session keeps the executable as the Evidence subject for
inspect_plist, same as the other bundle-resource tools, but the result had
no digest of the plist bytes and any absolute path was sealed under that
subject. Record source_sha256 for the bytes read, and refuse a selection
that resolves outside the opened bundle.

Fixes #9479

* fix(native)!: scope plist selection to the opened bundle

BREAKING CHANGE: To inspect a plist outside an opened app bundle or resource root, open the plist as a separate target.

* fix(native): report plist snapshot filesystem effects

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 21:35:17 -05:00
morluto c0ee832a30 fix(javascript): honor outer lexical order through standalone blocks (#12701)
fix(javascript): carry lexical timing through standalone blocks
2026-11-19 21:24:20 -05:00
morluto 2245d25aaa fix(harmony): match manifests at exact archive root paths (#12700) 2026-11-19 21:22:18 -05:00
morluto ea26a4a46c fix(elf): retain mapped leading GNU symbol version slots (#12685)
* fix(elf): retain mapped leading GNU symbol version slots

* fix(elf): report short version tables during admission
2026-11-20 02:19:55 +00:00
morluto ed96765d11 refactor(macho): share unsigned dispatch metadata reads (#12668) 2026-11-20 02:17:09 +00:00
morluto cf64e4ce3c fix(nuget): respect OPC part-name equivalence (#12691)
fix(nuget): preserve ambiguous OPC manifest identity
2026-11-20 02:16:52 +00:00
morluto 870f9b7432 fix(desktop): refuse malformed hidden application overrides (#12686)
* fix(desktop): require structure before masking an application by ID

* fix(desktop): record invalid group names in hidden overrides
2026-11-20 02:16:49 +00:00
morluto 68604b7e95 fix(elf): distinguish exhausted string tables from capped scans (#12693)
fix(elf): distinguish exact string-table ends from scan limits
2026-11-20 02:15:34 +00:00
morluto 60707abd94 fix(desktop): preserve APT one-line source token boundaries (#12692)
fix(desktop): honor APT one-line separators and comments
2026-11-20 02:15:18 +00:00
morluto ddd31b0289 fix(javascript): preserve uncertainty before lexical initialization (#12682)
* fix(javascript): preserve uncertainty before lexical initialization

* fix(javascript): respect lexical declarator initialization order
2026-11-20 02:13:04 +00:00
morluto 8b60f3f25f fix(nuget): reject invalid manifest relationship target modes (#12684)
fix(nuget): require an internal OPC manifest mode
2026-11-20 02:08:39 +00:00
morluto d7269f7385 fix(desktop): respect APT ASCII source field separators (#12680) 2026-11-20 02:05:53 +00:00
morluto acd967c58a fix(elf): report the enforced kernel build config parser limit (#12679) 2026-11-20 02:02:48 +00:00
morluto 0fcbfe83dc fix(elf): retain readable build IDs beside compressed notes (#12674) 2026-11-20 02:02:45 +00:00
RRFZ 460517d1b7 fix(desktop): honor hidden application overrides during ID lookup (#12675)
* fix(desktop): honor hidden application overrides during ID lookup

* test(desktop): preserve refusal details for invalid user overrides
2026-11-19 21:02:24 -05:00
morluto 9c95d0ded3 fix(gradle): preserve variant identity in metadata evidence (#12677)
* fix(gradle): preserve unique variant identity

* test(gradle): cover unnamed variants and whitespace identity
2026-11-20 02:01:27 +00:00
morluto c6f86cce57 fix(elf): preserve dynamic string diagnostic provenance (#12678)
* fix(elf): preserve DT_NEEDED diagnostic source offsets

* fix(elf): distinguish missing dynamic strings from invalid indices
2026-11-20 02:01:09 +00:00
morluto a5f19cbaf6 fix(javascript): preserve uncertainty after immutable pattern targets (#12673)
* fix(javascript): preserve uncertainty after immutable pattern targets

* fix(javascript): retain self-name assignment rules in patterns
2026-11-20 02:01:05 +00:00
morluto 2c7c858c5a refactor(native): share mapped ELF and FAT scalar readers (#12631) 2026-11-20 01:59:55 +00:00
morluto bd887a96be refactor(apk): project signing block pair limits from the parser (#12670)
* refactor(apk): project the signing-block pair limit from the parser

* test(apk): compare the pair refusal with the parser-owned reason
2026-11-20 01:58:07 +00:00
morlutoandCursor Agent 976edd68e7 docs(agents): state limit, test, verifier and feature-record conventions and list PR title types (#12652)
* docs(agents): state limit, test, verifier and feature-record conventions

Record ceiling, runtime-setting, assertion, verifier, and feature-record
rules for agents, and make the pull request title pattern explicit.

* docs(agents): defer limit controls to their owning guide

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 20:56:20 -05:00
morluto 0ab693fe81 fix(maven): match declarations in the project namespace (#12672) 2026-11-20 01:54:59 +00:00
RRFZandmorluto 070d6420ec test(platform): skip POSIX host-path premises on Windows (#12664)
* test(platform): skip POSIX host-path premises on Windows

* test(inspector): retain Windows target listing coverage

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 20:53:15 -05:00