The desktop state-reader close collects up to three failures (artifact
scope, SQLite service, and the export worker retry), but composed only
the first two with analysisErrorWithCleanupFailure and bound the rest by
hand. The third failure's reason never reached the caller. Fold the
failures through analysisErrorWithCleanupDependencies so each keeps its
reason and owner; two failures produce the same composite as before.
Refs #11859
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The completed-abort-reclassification pattern matched any `.ok && …aborted`,
including `!outcome.ok && signal?.aborted`, which attaches a secondary
cancellation to an already failed primary and reclassifies nothing. Move
the pattern to completed-abort-guard.mjs, where the receiver chain
(member, optional, private, element and call segments) must start the
check, and cover positive and negated forms in tests.
DesktopApplicationState and FridaInstrumentationService leave the
baseline.
Fixes#11920
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
A fresh CLI Ghidra session discards an annotation edit when the command
exits, which the help did not say. The returned Evidence and the MCP
contract already describe the lifetime; the help now names the
checkpoint setting and the MCP alternative.
Fixes#8242
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The compare_wasm_interfaces guidance sat at the end of the PE/ELF export
section, where an agent comparing native exports would read an
inapplicable follow-up. Regenerate the Cursor plugin copy.
Fixes#8334
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
npm ci and npm run build:cached leave the Windows addon and manifest
unbuilt; point checkout readers at the contributor guide's extra step.
Fixes#10317
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
DOCTOR_PROVIDER_IDS accepts desktop_build alongside the five engines,
but the CLI guide implied that only engines are accepted.
Fixes#10251
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The setup summary still said setup pins package-runner registrations to
the installed version. Setup records the absolute runtime and entry
script instead, as the guide's MCP Registry section already explains.
Fixes#10252
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The child recorded the received signal with writeFileSync, which creates
an empty file before writing. The test polls for existence and reads the
content while the child is still alive, so it could observe '' instead of
SIGINT (main CI run 44898480483). Write to a sibling file and rename it.
Co-authored-by: gensokyo-dev <gensokyo-dev@users.noreply.github.com>
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>