Commit Graph
206 Commits
Author SHA1 Message Date
morluto 2c7c858c5a refactor(native): share mapped ELF and FAT scalar readers (#12631) 2026-11-20 01:59:55 +00:00
morluto bd887a96be refactor(apk): project signing block pair limits from the parser (#12670)
* refactor(apk): project the signing-block pair limit from the parser

* test(apk): compare the pair refusal with the parser-owned reason
2026-11-20 01:58:07 +00:00
morluto a3df11ebf5 refactor(apk): project the v1 directory entry limit from the parser (#12665)
* refactor(apk): project the v1 directory entry limit from the parser

* test(apk): compare v1 refusal with the parser-owned reason
2026-11-20 01:51:02 +00:00
吴佳浩Albenandmorluto ea4baaf6de fix(v8): read the code cache header size from the container (#10279)
* fix(v8): read the code cache header size from the container

V8 sizes the header with `kHeaderSize = POINTER_SIZE_ALIGN(kUnalignedHeaderSize)` and
`kUnalignedHeaderSize` is 28, so the header is padded *after* its words: a 64-bit producer writes
32 header bytes and a 32-bit one writes 28. The reader pinned 32 and required the declared payload
to equal `bytes.length - 32`, so every container from a 32-bit producer failed as "truncated or
corrupt".

Measured here on Node 24.22.1 (V8 in x64): take a real cache and drop the four alignment bytes at
offset 28. V8 loads it unchanged — `cachedDataRejected === false` — while the reader refused it:

    before: Header declares a 392-byte payload but 388 bytes follow the 32-byte header
    after:  ACCEPT header_bytes=28 words=7 payload.offset=28

The payload-length word sits at byte 20 in both layouts, so the declared length already states how
much trailing padding the container carries. The header size is derived from it now: `28` and `32`
are admitted, the reported word table covers exactly the header the container holds (7 or 8 words),
and the schema requires that table to agree with `header_bytes`.

Nothing is loosened. A header that is neither 28 nor 32 bytes is still `malformed`, and the
16 existing cases pass unchanged — dropping only the derivation back to the constant fails exactly
the new narrow-header case.

`src/v8` — 26 passing. `npm run lint` and `tsc --noEmit` clean.

* fix(v8): refuse a wide cache that is only four bytes short

A review finding on the previous commit, and a real one: deriving the header size from the declared
payload length makes a 32-byte-header container truncated by four bytes resolve to 28, because
`bytes.length - declaredPayload` loses exactly those four bytes. The reader then accepted a
truncated cache and read its payload one word long.

The wide header's last word is `POINTER_SIZE_ALIGN` padding that V8 leaves zero, and a narrow
container has payload where that word sits. Measured on Node 24.22.1 across six different sources:
the padding word is always `0x00000000` and the first payload word is always non-zero. So the zero
word is the only evidence that separates the two, and it is now required to be non-zero for the
28-byte layout:

| container | before this commit | after |
| --- | --- | --- |
| real 32-byte header | accept | accept, `header_bytes=32` |
| real 28-byte header | accept | accept, `header_bytes=28` |
| 32-byte header truncated by 4 | **accept** | refused as `malformed` |

The guide also described one pinned 32-byte header; it now describes both layouts, how the size is
resolved, and why an ambiguous container is refused.

`src/v8` — 27 passing. Removing the guard accepts the truncated container again.

* fix(v8): read the padding word through the header accessor

A Static checks finding: `verify/architecture-guards.mjs` counts raw Buffer reads in parser folders
and allows only a shrinking baseline, and the previous commit added one:

```
raw Buffer or DataView numeric read (use BinaryReader ...); new copies are not allowed:
  src/v8/V8CodeCacheParser.ts: 2 (baseline 1)
```

The read is the narrow-header discriminator — the alignment word a 64-bit producer leaves zero at
offset 28. It now goes through the file's existing `field(index)` accessor instead of calling
`bytes.readUInt32LE` directly, so the count returns to the baseline while the check itself is
unchanged: `field(7)` is byte 28, and `V8_CODE_CACHE_NARROW_HEADER_BYTES / 4` spells that index.

`node scripts/verify/architecture-guards.mjs` — passed across 2 843 source files.
`src/v8` + `tests/boundary/rust` — 68 passing. `tsc --noEmit` 0 errors.
Setting the condition to `false` fails "refuses a wide container that is only four bytes short",
so the check is still load-bearing.

* fix(v8): ground the narrow-header rule in the producer, and test the word table

Two review findings.

**The rule was stated as measurement, not as format.** The previous comment justified the zero-word
discriminator with "measured on Node 24.22.1 every real payload begins with a non-zero word", which
makes support for other producers depend on one host. The producer zeroes that padding rather than
copying payload over it: `SerializedData::AllocateWithPayload` in `src/snapshot/snapshot-data.cc`
runs `std::fill_n(data_, header_size, 0)` before writing any header word, and
`kHeaderSize = POINTER_SIZE_ALIGN(kUnalignedHeaderSize)` in `src/snapshot/code-serializer.h` puts the
four padding bytes inside `header_size`. So a zero word at byte 28 is a fact about the producer, not
about one Node build.

The refusal is now worded as the reservation it is: a narrow container whose payload happened to
begin with four zero bytes would match the same test, and no reading of the header alone separates
the two cases. The message says both readings instead of asserting corruption.

**The word-table rule had no test that could fail.** `header.fields.length * 4 === header.header_bytes`
cannot disagree on a parsed container — the parser derives both from `payloadOffset` — so it is only
reachable through the schema, which is what a stored or projected report also goes through. The new
case builds four reports directly: seven words with 32 bytes and eight words with 28 are refused on
`header.fields`, while the two consistent pairs are accepted. Setting the rule to `false` fails it
with `7 words / 32 bytes: expected true to be false`.

`node scripts/verify/architecture-guards.mjs` — passed across 2 843 source files.
`src/v8` + `tests/boundary/rust` — 69 passing. `tsc --noEmit` 0 errors, `npm run lint` 0 errors.

* refactor(v8): share decoded code cache header words

* fix(v8): validate narrow header evidence without assuming runtime compatibility

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-20 01:41:01 +00:00
morluto 2a6786168a refactor(apk): project scheme limits from the parser (#12662)
* refactor(apk): project scheme limits from the parser

* fix(apk): establish scheme record framing before capacity
2026-11-20 01:38:54 +00:00
morluto 273f048a55 fix(windows): report the enforced shortcut parser limit (#12661) 2026-11-20 01:38:27 +00:00
morluto 6596d294b9 refactor(macho): share selected fixup and magic field reads (#12637)
* refactor(macho): share selected fixup and magic field reads

* fix(macho): retain legacy weak and lazy bind streams
2026-11-20 01:34:45 +00:00
morluto fb9f19d83a refactor(zip): share local header facts across readers (#12629) 2026-11-20 01:34:34 +00:00
morluto e782a6a8cd refactor(nativeaot): share packed method table index reads (#12640) 2026-11-20 01:30:17 +00:00
3cfe8480c5 fix(elf): decode a 32-bit prpsinfo whose ABI gives pr_uid 32 bits (#10189)
* fix(elf): decode a 32-bit prpsinfo whose ABI gives pr_uid 32 bits

`decodeCorePrpsinfo` assumed every ELFCLASS32 core carries the i386/ARM `struct elf_prpsinfo`:
16-bit `pr_uid`/`pr_gid` and a 124-byte descriptor.

`pr_uid` is `__kernel_uid_t`, and its width is an ABI property, not an ELF-class one. Only
`arch/x86/include/uapi/asm/posix_types_32.h` and its ARM/m68k/sparc counterparts narrow it to
`unsigned short`; everything else takes `asm-generic/posix_types.h`'s `unsigned int`, so MIPS o32,
PowerPC-32, s390 and `compat_elf_prpsinfo` (`include/asm-generic/compat.h`:
`typedef u32 __compat_uid_t`) write a 128-byte struct with every member after `pr_flag` four bytes
later.

Reading a 128-byte descriptor with the 124-byte offsets published wrong values rather than null.
Measured through `parseElfNotes`, with `uid 70000, gid 80000, pid 4242, fname mips-proc`:

    before: {"pid":80000,"ppid":4242,"pgrp":1,"sid":4242,"uid":4464,"gid":1,
             "filename":"\u{10}","psargs":""}
    after:  {"pid":4242,"ppid":1,"pgrp":4242,"sid":4242,"uid":70000,"gid":80000,
             "filename":"mips-proc","psargs":"./mips-proc --serve"}

`pid` came out of the middle of `gid` and the two text fields came from the wrong offsets
entirely.

The kernel writes `sizeof(*psinfo)` as the descriptor — `fs/binfmt_elf.c`:
`fill_note(&info->psinfo, PRPSINFO, sizeof(*psinfo), psinfo)` — so the declared length already
carries the distinction and no machine table is needed. The 32-bit id width is now
`descriptor.length >= 128 ? 4 : 2`, and `pr_pid`/`pr_fname`/`pr_psargs` are derived from it. The
124-byte and 136-byte decodes are unchanged; the second new case pins that.

`src/native/elf` and `src/domain/native` — 535 passing. Forcing the 16-bit layout fails the new case.

* test(elf): produce the 32-bit prpsinfo layout from the shared note builder

Review finding: the regression hand-encoded a second NT_PRPSINFO layout while `corePrpsinfoNote` is
the repository's producer for this format, so nothing else could represent the MIPS/PowerPC/s390
ABI and the two encodings could drift.

`corePrpsinfoNote` takes `idWidth: 2 | 4` now. It allocates 124 or 128 bytes from it, writes
`pr_uid`/`pr_gid` at that width, and derives `pr_pid` through `pr_psargs` from `8 + idWidth * 2`
instead of the fixed 12/28/44 offsets. The option is ignored for a 64-bit image, whose layout is
fixed at 136.

Both new cases build their descriptor through the producer, so the test no longer carries offsets
the fixture does not know about.

* test(elf): drop the duplicate 124-byte prpsinfo case

The previous commit's rewrite left the original hand-built 124-byte block in place, so the same
regression ran twice — once through `corePrpsinfoNote`, once with the offsets written out again.
Keeping both is exactly the drift the shared producer was supposed to end.

* fix(elf): preserve SuperH PRPSINFO decoding

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: wunianze666-netizen <wunianze666@gmail.com>
2026-11-20 01:23:27 +00:00
RRFZ 31702dabd8 refactor(electron): carry fuse inspection limits from the reader (#12647) 2026-11-20 01:20:55 +00:00
morluto 939dd19efe fix(gpu): report the enforced parser limit (#12646) 2026-11-20 01:19:45 +00:00
morluto a37fee0543 refactor(elf): project unwind limits from parser failures (#12644) 2026-11-20 01:19:20 +00:00
RRFZ 04b47507dc refactor(pe): read CodeView directory declarations once (#12632) 2026-11-20 01:15:48 +00:00
morluto 21dfefcfb2 refactor(il2cpp): share stored native image scalar reads (#12638)
refactor(il2cpp): share native registration scalar reads
2026-11-20 01:13:26 +00:00
RRFZ bd70cf94ff perf(desktop): compare complete RGBA pixels in the screenshot readiness check (#12633) 2026-11-20 01:12:28 +00:00
morluto 6c7d69245e fix(crash): bound recorded core note source reads (#12634)
refactor(native): share recorded crash source reads
2026-11-20 01:11:57 +00:00
morluto d0ca65e524 refactor(elf): share fixed note descriptor reads (#12630) 2026-11-20 01:10:34 +00:00
RRFZ 22ead365e7 refactor(providers): share firmware and Flutter cleanup aggregation (#12618)
* refactor(providers): share firmware and Flutter cleanup aggregation

* test(firmware): check both cleanup failure records through retry
2026-11-20 01:03:56 +00:00
morluto c98b956da1 refactor(nativeaot): share mapped PE scalar reads (#12610)
refactor(nativeaot): share mapped scalar reads
2026-11-20 00:54:17 +00:00
morluto b8e65d24af fix(windows): retain target uncertainty when ExtraData overruns (#12612) 2026-11-20 00:48:15 +00:00
RRFZ f1ef301f36 refactor(apple): share Mach-O header and FAT slice field reads (#12611) 2026-11-20 00:45:29 +00:00
RRFZ 18f102d692 refactor(elf): read core file and auxiliary words through BinaryReader (#12606) 2026-11-20 00:27:17 +00:00
RRFZ d48f21bf87 refactor(nativeaot): read ReadyToRun directories within their PE section (#12592) 2026-11-20 00:19:20 +00:00
morluto a611944533 fix(windows): report unexamined bytes in shortcut item lists (#12594) 2026-11-20 00:09:51 +00:00
morluto cb380f0ab3 refactor(plist): share binary scalar and key reads (#12593)
refactor(apple): share binary plist scalar reads
2026-11-20 00:07:02 +00:00
morluto b2bb427553 fix(cleanup): report live resources independently of failed closes (#12589)
fix(cleanup): follow live resources across owner close failures
2026-11-20 00:00:10 +00:00
morluto 2b4442c0e9 refactor(ghidra): share DOS relocation word reads (#12585)
refactor(ghidra): read DOS relocation words through BinaryReader
2026-11-19 23:55:59 +00:00
morluto c8a783d7cf refactor(windows): share Shell Link location field reads (#12584) 2026-11-19 23:54:18 +00:00
RRFZandmorluto 6f3c016a5a refactor(native): read Mach-O initializer symbols and relocations with the image reader (#12571)
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 23:49:04 +00:00
morluto cddaef83ae refactor(elf): share fixed-width unwind field reads (#12574)
* refactor(elf): share fixed-width unwind field reads

* refactor(elf): share dynamic hash header word reads (#12577)

refactor(elf): share bounded hardening hash reads
2026-11-19 23:42:01 +00:00
morluto d95287056d fix(managed): bound CIL method headers to their PE section (#12575)
fix(dotnet): bound CIL headers to mapped section bytes
2026-11-19 23:37:16 +00:00
RRFZ 2bfb5541c9 fix(sqlite): retain original failures when cleanup fails in multiple places (#12561) 2026-11-19 22:59:26 +00:00
RRFZ 9ed9d6c8a2 refactor(apple): share fixed-width reads across dyld chained fixups (#12560) 2026-11-19 22:59:05 +00:00
RRFZ 3e40979b42 refactor(native): share file-backed ELF and Mach-O initializer word reads (#12559) 2026-11-19 17:51:40 -05:00
RRFZ 5c3fe9caeb refactor(il2cpp): decode metadata tables through one shared binary reader (#12554) 2026-11-19 22:44:20 +00:00
RRFZ d51dd4a996 refactor(apple): read streamed Mach-O command fields through the shared word reader (#12552) 2026-11-19 17:37:18 -05:00
morluto 4edbbf0df9 refactor(go): share bounded string header word reads (#12553) 2026-11-19 22:35:22 +00:00
RRFZ d3d0355a9a refactor(kuna): share cleanup aggregation for commands and sessions (#12528) 2026-11-19 17:28:13 -05:00
RRFZ fa9abed521 refactor(process): inherit cleanup ownership for debugger cancellation (#12537) 2026-11-19 17:28:02 -05:00
RRFZ 4e30dbef14 refactor(pe): read icon group fields within their resource payload (#12547) 2026-11-19 22:24:24 +00:00
morluto 4892615ecb refactor(macho): share encryption command word reads (#12543) 2026-11-19 17:15:30 -05:00
morluto 0efd54e1c1 refactor(apple): share bounded JVM class field reads (#12540) 2026-11-19 22:04:16 +00:00
RRFZ d5e5aaa062 refactor(elf): read module version CRCs through BinaryReader (#12530) 2026-11-19 16:59:01 -05:00
RRFZ 756f772430 refactor(apple): share lazy dylib payload field reads (#12536) 2026-11-19 16:56:25 -05:00
RRFZ 503379b953 refactor(pe): read TLS and load configuration fields through BinaryReader (#12533) 2026-11-19 16:56:22 -05:00
RRFZ 846052b410 refactor(managed): share fixed-width GUID and user-string heap reads (#12535) 2026-11-19 16:55:46 -05:00
RRFZ 4ecc4f17a5 refactor(managed): share checked reads for metadata stream and table headers (#12526) 2026-11-19 16:55:41 -05:00
morluto 8fb1a3ce99 refactor(artifacts): share bounded NES header reads (#12524) 2026-11-19 16:29:37 -05:00
morluto b239ea8011 refactor(elf): share bounded note header reads (#12527) 2026-11-19 21:17:34 +00:00