* test: assert structured recovery facts instead of recovery wording in src tests
Replace recovery-sentence locks with the structured fields that already
carry those facts, and own Batch 4 temporary directories through
createTestTempDirectory.
* test(hopper): keep recovery order that retry_action does not carry
retry_action names restart or unknown. It does not say to read
provider_operation_health before retrying, or to close_binary before
opening and retrying. Those order checks stay.
Co-authored-by: morluto <morluto@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
* test(limits): check documented limit defaults against code instead of per-file pins
The numeric-limit script now reads every default, floor, and maximum in
docs/design/rea-limit-inventory.md and compares it with ANALYSIS_SETTINGS
or the owner constant the parser enforces. A mismatch names the limit and
both values. Pins that only restated a covered value are removed.
Pwntools input bytes and the Kuna timeouts now use the shared exports, so
the registry value is the one the parser applies.
* fix(limits): reject a fractional documented limit cell
The cell parser treated a dot as the end of the integer, so 5000.5
compared equal to 5000. A documented number is now one complete integer,
with prose only after whitespace.
Co-authored-by: morluto <morluto@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
* refactor(verify): run Ghidra verifier commands through the supervised owner
Route the first Ghidra verifier batch's compilers, linkers, and CLI through
createVerifierCommands, and close that owner before the lineage check.
Replace MCP isError prose checks with the structured refusal each tool builds.
* fix(verify): resolve Windows 6502 toolchain names through the command owner
runOwnedCommand passes a bare ca65 or ld65 name to the Windows process
owner, which accepts only a drive-absolute path. The verifier command
owner resolves those PATH names before launch.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(verify): release the Ghidra fixture when a toolchain probe fails
retain() only registered a cleanup that nothing ran, so a failed compiler
probe left the empty fixture directory behind. Release it after the command
owner closes, and name the retained path when that close does not confirm.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(verify): close the m68k command owner when session shutdown fails
Client, transport, and command cleanup are independent. A failed client or
transport close, or a failed runtime read, no longer skips the command owner.
Co-authored-by: morluto <morluto@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
Share the mcpServers upsert, create-table, empty-file, and uninstall cases
through jsonClientRegistrationContract. Trae and FreeBuff pass a location
resolver because their paths are not join(home, directory, filename).
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Drop recovery-sentence locks when a structured field or the owning
formatter already carries the fact, and own this batch's per-test
temporary directories through createTestTempDirectory. Keep setting
names, caller data, and prose that has no structured carrier.
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
nestedContext builds one EvaluationContext per recursive expression step. A conditional object spread forces V8 through the generic property-copy path even when the spread adds no fields, and prevents a stable shape. It was the top self-time frame (25.4%) in a profile of semantic indexing.
Use two explicit object literals selected by capturePoint, keeping the same field set, order, values and optionality. Completed analyses are byte-identical across 12 representative sources (36 IR/facts/coverage digests), and member-mutation indexing is 1.47-1.65x faster on the profiled alias-chain workload.
Co-authored-by: Zhenyang Han <mshzy@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Use the same APT word reader for positional fields and option assignments. Carry authored and effective repository facts through capture and replay.
Fixes#12694.
* fix(desktop): verify single-stanza APT source identity
* fix(desktop): verify single-stanza APT source identity
* fix(desktop): match APT suites using its configured architecture
* fix(desktop): match APT URI architecture templates
* fix(desktop): normalize empty APT URI ports
* test(desktop): regress empty-port APT repository identity
Assert entryForTarget and repository facts keep the authored empty-port URI while matching the portless Repo-URI APT 2.8.3 emits, including the signing key.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(desktop): parse APT port suffixes with atoi
Match deb822 Repo-URI identity to APT's unsigned port: the host's last colon suffix is atoi'd, zero is omitted, and IPv6 brackets stay intact while the authored URI is kept.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(desktop): accept GNU architecture names and bound port scans
Keep x86_64 as an APT architecture token for $(ARCH) identity, and stop growing a port magnitude once it passes the signed 64-bit limit.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(desktop): keep file:// as APT's empty-path Repo-URI
An empty host with no path stays scheme://, matching APT 2.8.3. A path after that host still drops it, so file:///srv remains file:/srv.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(desktop): normalize APT scheme:host URIs in one host pass
APT 2.8.3 rewrites http:127.0.0.1:18743/archive to an http:// Repo-URI. Identity comparison follows that form and keeps the authored URI. Bracket removal copies each host character once.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(desktop): replay the APT suite selected during capture
---------
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(native): record inspected plist bytes and refuse files outside the bundle
An open app session keeps the executable as the Evidence subject for
inspect_plist, same as the other bundle-resource tools, but the result had
no digest of the plist bytes and any absolute path was sealed under that
subject. Record source_sha256 for the bytes read, and refuse a selection
that resolves outside the opened bundle.
Fixes#9479
* fix(native)!: scope plist selection to the opened bundle
BREAKING CHANGE: To inspect a plist outside an opened app bundle or resource root, open the plist as a separate target.
* fix(native): report plist snapshot filesystem effects
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
* docs(agents): state limit, test, verifier and feature-record conventions
Record ceiling, runtime-setting, assertion, verifier, and feature-record
rules for agents, and make the pull request title pattern explicit.
* docs(agents): defer limit controls to their owning guide
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
REQUIRED_RUNTIME_LIMITS still named three limits whose PRs never merged.
The checker skipped a required name absent from source, so the stale
entries passed. Remove them and fail that case with a typed result that
names the limit.
Co-authored-by: Cursor Agent <cursoragent@cursor.com>