The XML plist reader replaced every literal CR and CRLF with LF before
parsing. CoreFoundation keeps them, so REA reported a different string than
plutil for the same file, and two keys that differ only in their line ending
collapsed into one repeated key.
The document is now parsed as written. Source spans for integer, real, date
and data literals already count CR, CRLF and LF as one line break each.
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
* fix(native): keep an assumed relocation width from reporting a section overrun
inspect_native_initializers assumed that a relocation of a type it does not
size writes a whole word. For a 4-byte field that ends its section, such as
R_X86_64_PLT32 or R_AARCH64_CALL26 on a tail call that ends .text, the assumed
word ran past the section, so the object was reported incomplete with
"A section relocation extends beyond its target mapping".
An assumed width is now narrowed to the bytes its mapping holds. A relocation
of known width that runs past its section is still reported.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* test(native): use the tail-call relocation clang emits for AArch64
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* fix(native): size link-time relocation kinds instead of narrowing an assumed width
Review found that narrowing an assumed word to its mapping hid a real overrun
of an unlisted kind and, in a linked image, a slot behind zero-fill bytes.
The mapping remainder does not establish what a relocation writes.
The section walk is restored to its previous logic. The width table now sizes
the link-time kinds clang emits into x86-64 and AArch64 objects, as the i386
row already does, so a call that ends .text is a known 4-byte field. A kind
the table does not hold keeps its assumed word and its overrun note.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
* test(native): cover a newly sized kind in the loader relocation walk
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
* fix(ci): count named artifact transfers in job timings
* fix(ci): cover named artifact timings against their workflows
---------
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
* fix(app-bundle): apply the plist decode budget to the XML branch
* test(app-bundle): cover the XML plist decode budget
* decode xml plist once, pass the text to the decode preflight
* fix(app-bundle): keep OpenStep plists out of the XML preflight, keep budget failures typed
OpenStep Info.plist text is not XML, so quoted markup inside it is string
data. Run the XML entity-expansion preflight only on actual XML input,
using the same format check the parser already uses. A valid OpenStep
bundle with a DOCTYPE-looking quoted string no longer fails the budget.
Budget exhaustion also keeps its own error: the resolver now returns a
typed bundle_info_plist_decode_budget_exceeded failure naming the 16 MiB
allowance instead of the malformed-plist diagnosis.
* Fix test names and budget error classification after the merge
* fix: regenerate user-visible error catalogue for plist budget constraint
* test: pin budget-exceeded bundle target to its catalogue row
* refactor(plist): give Info.plist decoding a shared owner
---------
Co-authored-by: Dextheking1 <Dextheking1@users.noreply.github.com>
Co-authored-by: benjaminkincses <4175097+benjaminkincses@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
CoreFoundation reads some XML plists that strict XML rejects, such as
documents with a double hyphen in a comment or a control character in a
string. inspect_plist refused them although plutil -lint accepts them,
and the outcome depended on how file(1) described the bytes.
When REA's XML reader refuses a document's syntax, inspection now takes
the existing plutil conversion route. The result keeps format xml and a
limitation names REA's reason. A document plutil also rejects stays
refused with its diagnostic, and plist structure errors in well-formed
XML are still refused without conversion.
Fixes#12234
Admit exact string heap aliases and retain independent Module row facts for distinct declarations. Bind the optional partial row to the same scope checks as named Module Evidence.
* fix(managed): preserve duplicate GUID stream ambiguity
* fix(managed): preserve ambiguous metadata stream declarations (#12226)
Use one stream declaration owner for heap and table diagnostics. Keep user strings and row-layout uncertainty separate from independent PE/CLI observations.
* test(managed): separate heap entries from cache behavior
* fix(managed): preserve duplicate blob heap ambiguity (#12258)
Resolve #Blob in the shared stream layout. Preserve nil references and independent facts without emitting unsupported keys, signatures or hashes.
* fix(erlang): disclose BEAM bytes trailing the declared FOR1 form
A conformant FOR1 container sizes its form to the whole file, so bytes
past the form end are an unexamined appended or corrupt region. The
inspector decoded chunks only within the form but still reported
coverage.status "complete" with no mention of the surplus, so a caller
could not distinguish a clean BEAM from one carrying foreign trailing
bytes.
Compute the trailing byte count, report coverage.status "partial" with a
trailing_bytes field, and append a limitation naming the form end and the
unexamined count. Clean containers stay "complete" with trailing_bytes 0.
* fix(erlang): reparse retained BEAM Evidence without the trailing-bytes field
Evidence retained by a build predating coverage.trailing_bytes has no such
property, and projectErlangBeamView reparses that record with the strict
erlangBeamSchema. A required field rejected those records with an input error
before any summary or page could render, breaking the offline retained-Evidence
flow even for clean files.
Default coverage.trailing_bytes to 0 so historical records reparse while every
new parse still emits the concrete count and preserves each record's stored
status.
* fix(erlang): keep retained BEAM trailing coverage unknown, not zero
Defaulting coverage.trailing_bytes to 0 manufactured a "no trailer" reading for
Evidence retained before the field existed, even when its retained bounds
(artifact.bytes versus form.location.bytes) prove a trailer. Make the field
optional so a pre-field record reparses as unknown instead of a fabricated
zero, while every new parse still emits the concrete count.
* fix(erlang): admit chunk extents before applying count limits
* docs(erlang): explain trailing BEAM coverage
---------
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>