Commit Graph
9278 Commits
Author SHA1 Message Date
gensokyo-devandgensokyo-dev a0d2357230 refactor(macho): read LC_BUILD_VERSION fields through BinaryReader
The build-version platform and tool count were read through a local
DataView after the command-size check. Read them with machoWordReader,
as the other load-command decoders do, and drop the now-unused viewOf.

Refs #11865

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:52:16 +01:00
gensokyo-devandgensokyo-dev add4faf2ad refactor(elf): read GNU property words through BinaryReader
readGnuPropertyWords decoded property type, size and feature words with
endian-selected raw Buffer reads. Every read already sits behind the
record length checks, so the shared reader returns the same values.

Refs #11865

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:52:16 +01:00
Lewis WongandClaude Opus 5.5 b2a7cd91cc fix(apple): require a $top dictionary, not a UID, for another archiver name
A binary plist UID projects as `{ UID: n }` and the XML convention as
`{ CF$UID: n }`, so the structural check accepted a UID-valued $top as the
roots dictionary. A plist naming another archiver with such a $top was then
decoded with an invented root named after the UID key. The kind test now
also requires that $top is not a UID. NSKeyedArchiver archives keep their
existing $top handling.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-21 19:51:56 +01:00
Lewis WongandClaude Opus 5.5 2d182f865f fix(apple): report the declared archiver of a keyed archive
Keyed archives may now name another archiver, so the name is source
metadata a caller needs: a SceneKit scene says SCNKeyedArchiver. The
keyed-archive result gains `archiver`, the declared `$archiver` string, and
the inspect_keyed_archive contract describes archives written by
NSKeyedArchiver or a subclass archiver such as SCNKeyedArchiver instead of
NSKeyedArchiver plists only.

The reviewed golden graph adds `"archiver": "NSKeyedArchiver"` for its
capture; only its provenance digest changes, and the captured XML does not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-21 19:51:56 +01:00
Lewis WongandClaude Opus 5.5 11896a6eb1 fix(apple): decode keyed archives that name another archiver
Foundation's NSKeyedUnarchiver decodes a keyed archive whatever its
$archiver names. SceneKit writes .scn scenes with SCNKeyedArchiver, so
inspect_keyed_archive refused system and third-party scenes such as Audio
MIDI Setup's SpeakerRoom.scn as "not an NSKeyedArchiver archive" and pointed
the caller at inspect_plist.

An archive named NSKeyedArchiver keeps its current handling, including
format failures for a damaged table. Another string archiver name is a keyed
archive when the plist also has an $objects table and $top roots; without
them it stays an ordinary property list with the inspect_plist workflow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-21 19:51:56 +01:00
morluto 1587b46a9f fix(setup): keep MCP launchers usable after session cleanup (#13185) 2026-11-21 18:50:36 +00:00
Shashwat Mishra 49b9245262 docs(sqlite): distinguish exhausted windows from unordered samples (#13124) 2026-11-21 19:47:37 +01:00
Lewis WangandClaude Opus 5.5 f548a62a4f fix(artifacts): keep a ZIP inventory when one member uses an unsupported compression method (#13026)
* fix(artifacts): keep a ZIP inventory when one member uses an unsupported compression method

zip.js refuses a member whose compression method it has no codec for, such
as bzip2 (12) or LZMA (14), before reading its data. typedZipFailure turned
that refusal into an archive-level unavailable failure, so inventory_artifact,
inspect_artifact and compare_artifacts rejected the whole archive and never
listed or hashed its readable members. unzip and bsdtar list them all.

A refusal raised while reading one member is now ArtifactEntryContentUnavailable,
the per-member failure the inventory scan already records, as UnityFS members
with unsupported compression do. The member keeps its occurrence with an
unavailable hash and a limitation naming the method, siblings are hashed, and
coverage is unknown. Extraction of that member is still refused.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(artifacts): keep ZIP entry coverage complete for an unreadable member codec

The central directory still lists every entry when one member's compression
method is unsupported; only that member's content is unreadable. Recording an
unknown traversal made inventory coverage, whose scope is container entries,
claim that entries might be missing. Drop the traversal override, as the
encrypted-member path already does, and let the occurrence limitation carry
the content gap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-21 19:45:46 +01:00
morluto ce61cca68a test(web): consolidate CDP document selection cases (#13183) 2026-11-21 18:44:43 +00:00
Lewis WangandClaude Opus 5.5 af0d69ee91 fix(har): keep Chromium DevTools captures that report an empty server address (#13027)
Chromium DevTools writes serverIPAddress from NetworkRequest.remoteAddress(),
which starts as "" and stays empty when a request has no remote endpoint,
such as a refused connection, an aborted request or an internal redirect.
har-schema requires an IPv4 or IPv6 value, so inspect_web_network_capture
refused the whole export at the first such entry.

For the declared WebInspector 537.36 profile, an empty serverIPAddress is
omitted from the validation copy only, as bracketed IPv6 already is. Reported
Evidence keeps the empty value, and the record gains a limitation that the
server address is unknown. Other producers' empty addresses still fail
validation.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-21 19:42:16 +01:00
Heo Hao a44e705ad8 fix(desktop): skip only ASCII whitespace before a desktop entry key (#13126)
The key reader stripped each line with JavaScript's trimStart(), which also
removes Unicode spaces such as U+00A0 and U+3000. GLib skips only
g_ascii_isspace, so it keeps those bytes inside the key and the record never
matches Name= or Hidden=.

The drift had a safety direction: a line indented with U+00A0 and reading
Hidden=true was accepted as a hidden override by REA but never by the desktop
environment, so findHiddenDesktopEntry() claimed a deletion that GLib would not
honour. #12708 closed this for group headers by validating the captured padding
against GLib's ASCII set; the blank-line, comment and key checks still used the
Unicode-aware trim.

I now strip only [ \t\f\r] before deciding whether a line is blank, a comment
or a key, and hand that same string to the record matcher. ASCII indentation
still parses as before. The inventory test covers the refusal when a hidden
override carries the padding, and the domain tests cover the three Unicode
spaces for keys, blank lines and comments.
2026-11-21 19:40:34 +01:00
morluto 8691cfa96b test(web): acknowledge CDP socket timeout phases before advancing time (#13181) 2026-11-21 18:35:00 +00:00
morluto faab3d98d1 test(web): consolidate warm CDP peer cleanup checks (#13179)
* test(web): consolidate warm CDP peer cleanup checks

* test(web): verify provider close before CDP fixture teardown
2026-11-21 18:34:07 +00:00
gensokyo-devandgensokyo-dev 3ba20f0eb8 refactor(hopper): compose bridge image cleanup through the shared owner
The image and publisher cleanup retry built its composite and bound the
parts by hand; providerCleanupErrorFromFailures builds the same composite.
It names close_binary, the ProviderCleanupError default that the parts
and the previous composite used.

Refs #11859

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:34:01 +01:00
gensokyo-devandgensokyo-dev 2d360253dd refactor(process): compose analysis runtime cleanup through the shared owner
ArtifactAnalysisResources built its multi-failure cleanup composite and
bound the parts by hand; providerCleanupErrorFromFailures builds the same
composite with the existing per-part diagnostics.

Refs #11859

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:34:01 +01:00
gensokyo-devandgensokyo-dev 3af56cc7d5 refactor(native): compose LLDB resolver cleanup through the shared owner
The resolver retry built a multi-marker ProviderCleanupError and bound
the markers by hand; providerCleanupErrorFromFailures builds the same
composite, including the distinct resource list.

Refs #11859

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:34:01 +01:00
gensokyo-devandgensokyo-dev a5f3689179 refactor(inspector): compose provider close failures through the shared owner
V8InspectorProvider built its multi-failure cleanup composite by hand and
bound the parts with bindCleanupDependencies. providerCleanupErrorFromFailures
builds the same composite: resources, reason, operation, aggregate cause
and release tracking.

Refs #11859

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:34:01 +01:00
gensokyo-devandgensokyo-dev 13725d2986 refactor(errors): list distinct resources in providerCleanupErrorFromFailures
Parts of one cleanup composite can share a resource, such as a common
runtime root. Callers deduplicated the list by hand before composing;
normalize it once in the owner so they can use it directly.

Refs #11859

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:34:01 +01:00
morluto 4f9ce44908 test(web): consolidate CDP browser socket identity checks (#13180) 2026-11-21 13:31:08 -05:00
morluto 10e1a5ab25 test(web): consolidate CDP handshake and transport cleanup checks (#13177)
* test(web): consolidate cold CDP handshake cleanup checks

* test(web): wait for physical CDP socket close confirmation
2026-11-21 18:18:02 +00:00
morluto ae2c2142a3 test(web): consolidate CDP wire reply and event checks (#13175) 2026-11-21 18:13:37 +00:00
morluto 48a2ad5e0b test(web): consolidate CDP frame and session identity checks (#13174) 2026-11-21 18:09:48 +00:00
gensokyo-devandgensokyo-dev 10597e10f2 fix(desktop): keep every state-reader close failure in the cleanup composite
The desktop state-reader close collects up to three failures (artifact
scope, SQLite service, and the export worker retry), but composed only
the first two with analysisErrorWithCleanupFailure and bound the rest by
hand. The third failure's reason never reached the caller. Fold the
failures through analysisErrorWithCleanupDependencies so each keeps its
reason and owner; two failures produce the same composite as before.

Refs #11859

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:07:31 +01:00
gensokyo-devandgensokyo-dev a80dc68318 refactor(verify): exclude negated .ok checks from the abort-reclassification guard
The completed-abort-reclassification pattern matched any `.ok && …aborted`,
including `!outcome.ok && signal?.aborted`, which attaches a secondary
cancellation to an already failed primary and reclassifies nothing. Move
the pattern to completed-abort-guard.mjs, where the receiver chain
(member, optional, private, element and call segments) must start the
check, and cover positive and negated forms in tests.
DesktopApplicationState and FridaInstrumentationService leave the
baseline.

Fixes #11920

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:07:31 +01:00
morluto b95bd814a7 test(web): consolidate CDP discovery and HTTP response contracts (#13173) 2026-11-21 13:05:05 -05:00
morluto 6818b01d5a perf(web): normalize each browser redaction marker once (#13172) 2026-11-21 18:02:47 +00:00
gensokyo-devandgensokyo-dev f8192bd39d docs(cli): explain Ghidra annotation lifetime in command help
A fresh CLI Ghidra session discards an annotation edit when the command
exits, which the help did not say. The returned Evidence and the MCP
contract already describe the lifetime; the help now names the
checkpoint setting and the MCP alternative.

Fixes #8242

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:00:27 +01:00
gensokyo-devandgensokyo-dev c5c0063d4c docs(skill): move WASM interface comparison under Offline WASM
The compare_wasm_interfaces guidance sat at the end of the PE/ELF export
section, where an agent comparing native exports would read an
inapplicable follow-up. Regenerate the Cursor plugin copy.

Fixes #8334

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:00:27 +01:00
gensokyo-devandgensokyo-dev 4a6fa19379 docs(install): link Windows native build steps from a source checkout
npm ci and npm run build:cached leave the Windows addon and manifest
unbuilt; point checkout readers at the contributor guide's extra step.

Fixes #10317

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:00:27 +01:00
gensokyo-devandgensokyo-dev 4bd9327325 docs(cli): list the desktop_build doctor scope in provider selection
DOCTOR_PROVIDER_IDS accepts desktop_build alongside the five engines,
but the CLI guide implied that only engines are accepted.

Fixes #10251

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:00:27 +01:00
gensokyo-devandgensokyo-dev c0af3e293c docs(install): describe setup's direct-launch MCP registrations
The setup summary still said setup pins package-runner registrations to
the installed version. Setup records the absolute runtime and entry
script instead, as the guide's MCP Registry section already explains.

Fixes #10252

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 19:00:27 +01:00
morluto 03b99c2bcf fix(web): align scenario schema guidance with admitted inputs (#13170) 2026-11-21 17:56:08 +00:00
morluto 82d613ec63 test(web): consolidate scenario startup redaction fixtures (#13171) 2026-11-21 17:55:43 +00:00
morluto 505cac1487 test(web): consolidate scenario capture schema coverage (#13169)
* test(web): consolidate scenario capture schema coverage

* test(web): preserve wide scenario origin coverage
2026-11-21 17:52:42 +00:00
morluto 96d88a67c3 test(mcp): consolidate browser provider probe ownership checks (#13166) 2026-11-21 17:41:50 +00:00
morluto b5ba2f0f6e test(web): consolidate scenario process and cleanup coverage (#13165) 2026-11-21 12:37:58 -05:00
morluto 03795d55b3 test(web): consolidate wide scenario reference admission (#13163) 2026-11-21 17:33:20 +00:00
morluto 8d17fcb7a2 test(web): consolidate scenario Evidence delivery checks (#13161) 2026-11-21 17:25:33 +00:00
morluto b0043f1fe4 test(web): consolidate scenario Evidence promotion checks (#13160) 2026-11-21 17:22:41 +00:00
morluto 0fa220c735 test(web): consolidate scenario input diagnostics (#13159) 2026-11-21 12:20:56 -05:00
morluto 52437cd431 test(web): consolidate browser opening deadlines and late release checks (#13158) 2026-11-21 17:12:52 +00:00
morluto 6961a8c47c test(web): consolidate Chromium startup contract checks (#13157) 2026-11-21 17:08:12 +00:00
morluto 32549cb3f5 test(web): consolidate attached emulation and CDP admission checks (#13156) 2026-11-21 17:04:53 +00:00
morluto c23aa499f6 test(web): consolidate browser provider observation checks (#13154)
* test(web): consolidate browser provider observation checks

* test(web): update lifecycle operation evidence after consolidation
2026-11-21 11:57:35 -05:00
morluto 3704869199 test(web): exercise provider cancellation through a real session boundary (#13155) 2026-11-21 16:57:14 +00:00
morluto 5dad3b1f29 test(web): consolidate provider shutdown and cleanup recovery checks (#13152)
* test(web): consolidate provider shutdown and cleanup recovery checks

* test(web): point retry evidence at staged provider recovery
2026-11-21 16:56:44 +00:00
df1bd11895 test(process): publish timeout stop signal atomically in ExecFileOutput test (#13151)
The child recorded the received signal with writeFileSync, which creates
an empty file before writing. The test polls for existence and reads the
content while the child is still alive, so it could observe '' instead of
SIGINT (main CI run 44898480483). Write to a sibling file and rename it.

Co-authored-by: gensokyo-dev <gensokyo-dev@users.noreply.github.com>
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-21 17:55:13 +01:00
morluto f609aa3393 test(web): consolidate browser artifact privacy checks (#13150) 2026-11-21 16:44:11 +00:00
morluto 560de528a3 test(web): consolidate scenario deadline and diagnostic checks (#13149) 2026-11-21 11:42:37 -05:00
morluto 436977b0e9 test(web): exercise browser setup recovery and cleanup grace (#13148) 2026-11-21 16:36:35 +00:00