The build-version platform and tool count were read through a local
DataView after the command-size check. Read them with machoWordReader,
as the other load-command decoders do, and drop the now-unused viewOf.
Refs #11865
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
readGnuPropertyWords decoded property type, size and feature words with
endian-selected raw Buffer reads. Every read already sits behind the
record length checks, so the shared reader returns the same values.
Refs #11865
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
A binary plist UID projects as `{ UID: n }` and the XML convention as
`{ CF$UID: n }`, so the structural check accepted a UID-valued $top as the
roots dictionary. A plist naming another archiver with such a $top was then
decoded with an invented root named after the UID key. The kind test now
also requires that $top is not a UID. NSKeyedArchiver archives keep their
existing $top handling.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keyed archives may now name another archiver, so the name is source
metadata a caller needs: a SceneKit scene says SCNKeyedArchiver. The
keyed-archive result gains `archiver`, the declared `$archiver` string, and
the inspect_keyed_archive contract describes archives written by
NSKeyedArchiver or a subclass archiver such as SCNKeyedArchiver instead of
NSKeyedArchiver plists only.
The reviewed golden graph adds `"archiver": "NSKeyedArchiver"` for its
capture; only its provenance digest changes, and the captured XML does not.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Foundation's NSKeyedUnarchiver decodes a keyed archive whatever its
$archiver names. SceneKit writes .scn scenes with SCNKeyedArchiver, so
inspect_keyed_archive refused system and third-party scenes such as Audio
MIDI Setup's SpeakerRoom.scn as "not an NSKeyedArchiver archive" and pointed
the caller at inspect_plist.
An archive named NSKeyedArchiver keeps its current handling, including
format failures for a damaged table. Another string archiver name is a keyed
archive when the plist also has an $objects table and $top roots; without
them it stays an ordinary property list with the inspect_plist workflow.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(artifacts): keep a ZIP inventory when one member uses an unsupported compression method
zip.js refuses a member whose compression method it has no codec for, such
as bzip2 (12) or LZMA (14), before reading its data. typedZipFailure turned
that refusal into an archive-level unavailable failure, so inventory_artifact,
inspect_artifact and compare_artifacts rejected the whole archive and never
listed or hashed its readable members. unzip and bsdtar list them all.
A refusal raised while reading one member is now ArtifactEntryContentUnavailable,
the per-member failure the inventory scan already records, as UnityFS members
with unsupported compression do. The member keeps its occurrence with an
unavailable hash and a limitation naming the method, siblings are hashed, and
coverage is unknown. Extraction of that member is still refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(artifacts): keep ZIP entry coverage complete for an unreadable member codec
The central directory still lists every entry when one member's compression
method is unsupported; only that member's content is unreadable. Recording an
unknown traversal made inventory coverage, whose scope is container entries,
claim that entries might be missing. Drop the traversal override, as the
encrypted-member path already does, and let the occurrence limitation carry
the content gap.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Chromium DevTools writes serverIPAddress from NetworkRequest.remoteAddress(),
which starts as "" and stays empty when a request has no remote endpoint,
such as a refused connection, an aborted request or an internal redirect.
har-schema requires an IPv4 or IPv6 value, so inspect_web_network_capture
refused the whole export at the first such entry.
For the declared WebInspector 537.36 profile, an empty serverIPAddress is
omitted from the validation copy only, as bracketed IPv6 already is. Reported
Evidence keeps the empty value, and the record gains a limitation that the
server address is unknown. Other producers' empty addresses still fail
validation.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The key reader stripped each line with JavaScript's trimStart(), which also
removes Unicode spaces such as U+00A0 and U+3000. GLib skips only
g_ascii_isspace, so it keeps those bytes inside the key and the record never
matches Name= or Hidden=.
The drift had a safety direction: a line indented with U+00A0 and reading
Hidden=true was accepted as a hidden override by REA but never by the desktop
environment, so findHiddenDesktopEntry() claimed a deletion that GLib would not
honour. #12708 closed this for group headers by validating the captured padding
against GLib's ASCII set; the blank-line, comment and key checks still used the
Unicode-aware trim.
I now strip only [ \t\f\r] before deciding whether a line is blank, a comment
or a key, and hand that same string to the record matcher. ASCII indentation
still parses as before. The inventory test covers the refusal when a hidden
override carries the padding, and the domain tests cover the three Unicode
spaces for keys, blank lines and comments.
The image and publisher cleanup retry built its composite and bound the
parts by hand; providerCleanupErrorFromFailures builds the same composite.
It names close_binary, the ProviderCleanupError default that the parts
and the previous composite used.
Refs #11859
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
ArtifactAnalysisResources built its multi-failure cleanup composite and
bound the parts by hand; providerCleanupErrorFromFailures builds the same
composite with the existing per-part diagnostics.
Refs #11859
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The resolver retry built a multi-marker ProviderCleanupError and bound
the markers by hand; providerCleanupErrorFromFailures builds the same
composite, including the distinct resource list.
Refs #11859
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
V8InspectorProvider built its multi-failure cleanup composite by hand and
bound the parts with bindCleanupDependencies. providerCleanupErrorFromFailures
builds the same composite: resources, reason, operation, aggregate cause
and release tracking.
Refs #11859
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Parts of one cleanup composite can share a resource, such as a common
runtime root. Callers deduplicated the list by hand before composing;
normalize it once in the owner so they can use it directly.
Refs #11859
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The desktop state-reader close collects up to three failures (artifact
scope, SQLite service, and the export worker retry), but composed only
the first two with analysisErrorWithCleanupFailure and bound the rest by
hand. The third failure's reason never reached the caller. Fold the
failures through analysisErrorWithCleanupDependencies so each keeps its
reason and owner; two failures produce the same composite as before.
Refs #11859
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The completed-abort-reclassification pattern matched any `.ok && …aborted`,
including `!outcome.ok && signal?.aborted`, which attaches a secondary
cancellation to an already failed primary and reclassifies nothing. Move
the pattern to completed-abort-guard.mjs, where the receiver chain
(member, optional, private, element and call segments) must start the
check, and cover positive and negated forms in tests.
DesktopApplicationState and FridaInstrumentationService leave the
baseline.
Fixes#11920
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
A fresh CLI Ghidra session discards an annotation edit when the command
exits, which the help did not say. The returned Evidence and the MCP
contract already describe the lifetime; the help now names the
checkpoint setting and the MCP alternative.
Fixes#8242
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The compare_wasm_interfaces guidance sat at the end of the PE/ELF export
section, where an agent comparing native exports would read an
inapplicable follow-up. Regenerate the Cursor plugin copy.
Fixes#8334
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
npm ci and npm run build:cached leave the Windows addon and manifest
unbuilt; point checkout readers at the contributor guide's extra step.
Fixes#10317
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
DOCTOR_PROVIDER_IDS accepts desktop_build alongside the five engines,
but the CLI guide implied that only engines are accepted.
Fixes#10251
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The setup summary still said setup pins package-runner registrations to
the installed version. Setup records the absolute runtime and entry
script instead, as the guide's MCP Registry section already explains.
Fixes#10252
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
The child recorded the received signal with writeFileSync, which creates
an empty file before writing. The test polls for existence and reads the
content while the child is still alive, so it could observe '' instead of
SIGINT (main CI run 44898480483). Write to a sibling file and rename it.
Co-authored-by: gensokyo-dev <gensokyo-dev@users.noreply.github.com>
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>