mirror of
https://github.com/morluto/rea.git
synced 2026-11-12 09:52:27 +00:00
3e8a5f76d0
* feat(native): retain LLDB source coordinates and verify Pascal call entries Preserve partial line-table attribution for native locations and historical evidence compatibility. Verify owned Free Pascal call entries through CLI/MCP. Refs #2382, #2372, #2397 Co-Authored-By: Codex <noreply@openai.com> * docs: namespace native specifications by domain and feature Use stable descriptive paths instead of numeric prefixes to avoid parallel contribution collisions. Co-Authored-By: Codex <noreply@openai.com> * fix(native): bound Pascal verification and compare caller coordinates Address review findings at their producing boundaries and preserve directly affected consumers. Source inspection and git diff --check completed. Tests and automated checks were not run at the user’s explicit request. * fix(native): bound compiler shutdown and source-coordinate fixtures * docs: clarify historical native source verification * fix(native): preserve source attribution and compiler ownership * docs(native): qualify retained source attribution * fix(ci): clean up native Pascal verifier processes * test(native): type the Pascal verifier helper import after merging main Main now typechecks this boundary test, which imports the untyped canonical-temporary-directory helper and reads an unknown catch value. Add the helper's declaration file and narrow the caught error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(native): verify partial source attribution caveat * fix(native): retain verifier compiler cleanup ownership * fix(native): forward verifier cancellation and measure path bytes CLI and MCP artifact runs observe the verifier abort signal, and a failed Pascal verifier test stops the compiler group before deleting its directory. Repeated source locations grow by measured UTF-8 JSON bytes; workflow tokens, CPU and peak memory stay unmeasured. --------- Co-authored-by: Matheus Breguêz <matbrgz@gmail.com> Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
37 lines
1.7 KiB
Markdown
37 lines
1.7 KiB
Markdown
# Native call source coordinates
|
|
|
|
Issue: https://github.com/morluto/rea/issues/2382
|
|
|
|
## Problem and outcome
|
|
|
|
The existing bounded macOS LLDB call observation retains module, symbol and
|
|
addresses, but loses compiler-provided source coordinates. Retain line-entry
|
|
metadata at the same producer boundary for breakpoint locations, call entries
|
|
and caller frames.
|
|
|
|
## Requirements
|
|
|
|
- Add optional nullable source_location to the canonical native code location.
|
|
A present object contains nullable file_path, line and column. Positive line
|
|
and column values are one-based. Provider zero values mean unavailable.
|
|
- Preserve partial facts from a valid line entry. Invalid entries or entries
|
|
without any usable facet produce null. Historical captures may omit the field.
|
|
- Read only SBAddress line metadata; do not resolve paths, read source contents,
|
|
evaluate expressions or change the existing launch, stop or cleanup policy.
|
|
- The field establishes LLDB line-table attribution, not verified source bytes.
|
|
- Existing trace and breakpoint byte budgets include the new representation.
|
|
|
|
## Acceptance
|
|
|
|
Producer tests cover valid, invalid and partial entries, Unicode paths and absent
|
|
coordinates. Existing evidence without the field remains accepted. CLI/MCP and
|
|
partial retained-journal paths preserve the canonical field. The real native-call
|
|
verifier checks source coordinates for its owned debug build, including caller
|
|
frames and breakpoint locations, and reports actual host/provider coverage.
|
|
|
|
## Out of scope
|
|
|
|
New debugger adapters, interactive stepping, source breakpoints, source-file
|
|
association verification, source reads, Pascal/Delphi compatibility claims and
|
|
Java/Android/CLR runtime support.
|