mirror of
https://github.com/morluto/rea.git
synced 2026-11-20 13:45:30 +00:00
* fix(elf): decode a 32-bit prpsinfo whose ABI gives pr_uid 32 bits
`decodeCorePrpsinfo` assumed every ELFCLASS32 core carries the i386/ARM `struct elf_prpsinfo`:
16-bit `pr_uid`/`pr_gid` and a 124-byte descriptor.
`pr_uid` is `__kernel_uid_t`, and its width is an ABI property, not an ELF-class one. Only
`arch/x86/include/uapi/asm/posix_types_32.h` and its ARM/m68k/sparc counterparts narrow it to
`unsigned short`; everything else takes `asm-generic/posix_types.h`'s `unsigned int`, so MIPS o32,
PowerPC-32, s390 and `compat_elf_prpsinfo` (`include/asm-generic/compat.h`:
`typedef u32 __compat_uid_t`) write a 128-byte struct with every member after `pr_flag` four bytes
later.
Reading a 128-byte descriptor with the 124-byte offsets published wrong values rather than null.
Measured through `parseElfNotes`, with `uid 70000, gid 80000, pid 4242, fname mips-proc`:
before: {"pid":80000,"ppid":4242,"pgrp":1,"sid":4242,"uid":4464,"gid":1,
"filename":"\u{10}","psargs":""}
after: {"pid":4242,"ppid":1,"pgrp":4242,"sid":4242,"uid":70000,"gid":80000,
"filename":"mips-proc","psargs":"./mips-proc --serve"}
`pid` came out of the middle of `gid` and the two text fields came from the wrong offsets
entirely.
The kernel writes `sizeof(*psinfo)` as the descriptor — `fs/binfmt_elf.c`:
`fill_note(&info->psinfo, PRPSINFO, sizeof(*psinfo), psinfo)` — so the declared length already
carries the distinction and no machine table is needed. The 32-bit id width is now
`descriptor.length >= 128 ? 4 : 2`, and `pr_pid`/`pr_fname`/`pr_psargs` are derived from it. The
124-byte and 136-byte decodes are unchanged; the second new case pins that.
`src/native/elf` and `src/domain/native` — 535 passing. Forcing the 16-bit layout fails the new case.
* test(elf): produce the 32-bit prpsinfo layout from the shared note builder
Review finding: the regression hand-encoded a second NT_PRPSINFO layout while `corePrpsinfoNote` is
the repository's producer for this format, so nothing else could represent the MIPS/PowerPC/s390
ABI and the two encodings could drift.
`corePrpsinfoNote` takes `idWidth: 2 | 4` now. It allocates 124 or 128 bytes from it, writes
`pr_uid`/`pr_gid` at that width, and derives `pr_pid` through `pr_psargs` from `8 + idWidth * 2`
instead of the fixed 12/28/44 offsets. The option is ignored for a 64-bit image, whose layout is
fixed at 136.
Both new cases build their descriptor through the producer, so the test no longer carries offsets
the fixture does not know about.
* test(elf): drop the duplicate 124-byte prpsinfo case
The previous commit's rewrite left the original hand-built 124-byte block in place, so the same
regression ran twice — once through `corePrpsinfoNote`, once with the offsets written out again.
Keeping both is exactly the drift the shared producer was supposed to end.
* fix(elf): preserve SuperH PRPSINFO decoding
---------
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: wunianze666-netizen <wunianze666@gmail.com>
135 lines
7.4 KiB
Markdown
135 lines
7.4 KiB
Markdown
# ELF note tables
|
||
|
||
`inspect_elf_notes` / `inspect-elf-notes` answers whether one selected local
|
||
ELF32/ELF64 image declares `PT_NOTE` program headers or `SHT_NOTE` sections,
|
||
which note owners and types those tables store, and which supported fields
|
||
those notes carry. It reads the file without executing it and
|
||
does not require a disassembler, debug package, or package catalog.
|
||
|
||
```bash
|
||
rea inspect-elf-notes /absolute/path/to/program --json
|
||
```
|
||
|
||
The CLI resolves relative paths against the caller's working directory. MCP
|
||
requires an absolute filesystem path and preserves that exact selection:
|
||
|
||
```json
|
||
{
|
||
"name": "inspect_elf_notes",
|
||
"arguments": { "path": "/artifacts/program" }
|
||
}
|
||
```
|
||
|
||
## Observations
|
||
|
||
The inline Evidence result contains the artifact path, SHA-256, and byte length.
|
||
`tables` lists each declared note program header or section, including the
|
||
section name when a string table is present. Zlib- and Zstandard-compressed
|
||
section-name tables are decompressed within the selected file-size budget. An unsupported
|
||
compression type leaves section names unknown and adds a limitation; note bytes
|
||
remain independently examined. Each `entries[]` item reports owner, type,
|
||
descriptor SHA-256, and a hex preview for descriptors of 64 bytes or less.
|
||
|
||
A section name also stays null when its offset is outside the declared string
|
||
table or its bytes lack a NUL terminator. A limitation explains that missing
|
||
name. Note coverage remains complete when all declared note tables and entries
|
||
were examined; an unavailable section name does not erase those note facts.
|
||
|
||
For GNU notes, `gnu.build_id_hex`, `gnu.abi_tag`, or `gnu.gold_version` are
|
||
filled when the descriptor matches that type. Other owners keep `gnu` null.
|
||
|
||
For Linux `CORE` notes, `core.prpsinfo`, `core.file`, `core.siginfo`, or
|
||
`core.auxv` are decoded for process arguments and status (`NT_PRPSINFO`), mapped
|
||
file memory regions and paths (`NT_FILE`), fault signal and code (`NT_SIGINFO`), and
|
||
auxiliary vectors (`NT_AUXV`) across 32-bit and 64-bit images. Other owners or unparsed
|
||
notes keep `core` null. `NT_FILE` and `NT_AUXV` words follow the ELF class and
|
||
byte order. Addresses and word values retain their unsigned hexadecimal form.
|
||
|
||
For ELF32 `NT_PRPSINFO`, REA uses the declared Linux machine ABI to select the
|
||
UID/GID width and requires the corresponding descriptor length. If either fact
|
||
is insufficient to establish a layout, the note keeps its raw range and hash
|
||
and leaves `core` null.
|
||
|
||
An `NT_FILE` descriptor with nonzero bytes after its declared filenames
|
||
retains its raw note evidence and leaves `core` null.
|
||
|
||
Linux `CORE` decoding requires System V/unspecified (0) or GNU/Linux (3)
|
||
OSABI with ABI version zero. An unspecified OSABI alone does not establish
|
||
Linux origin. An explicitly different OSABI or ABI version leaves `core` null
|
||
and its Linux-specific `type_name` unknown, with a limitation explaining the
|
||
profile. Owner/type numbers, descriptor ranges and hashes, GNU-owned notes,
|
||
and complete table-examination coverage remain available.
|
||
|
||
For Android `NT_ANDROID_TYPE_IDENT` (`.note.android.ident`, owner `Android`,
|
||
type `1`) notes, `android.android_api` is decoded from both legacy 4-byte
|
||
descriptors (where `ndk_version` and `ndk_build_number` remain null) and modern
|
||
132-byte or extended NDK descriptors, which also populate `android.ndk_version`
|
||
and `ndk_build_number` when their 64-byte slots hold NUL-padded
|
||
printable ASCII. Truncated or non-ASCII Android descriptors degrade `android`
|
||
to null while preserving the raw descriptor digest and preview, and other
|
||
owners keep `android` null.
|
||
|
||
Freedesktop `FDO` notes can declare
|
||
[package metadata](https://uapi-group.org/specifications/specs/package_metadata_for_executable_files/)
|
||
(`.note.package`, type `0xcafe1a7e`) and
|
||
[dlopen metadata](https://uapi-group.org/specifications/specs/elf_dlopen_metadata/)
|
||
(`.note.dlopen`, type `0x407c0c0a`). Package metadata is a JSON object and
|
||
dlopen metadata is an array of JSON objects. `fdo.metadata` holds the producer’s
|
||
declaration with unknown fields preserved. The tool does not verify installed
|
||
packages, libraries, or loader behavior.
|
||
|
||
The decoder requires a NUL-terminated UTF-8 payload with only NUL padding,
|
||
unique object keys, and JSON numbers it can represent exactly. An invalid
|
||
or over-budget descriptor keeps its raw range and digest, leaves
|
||
`fdo.metadata` null, and reports the reason in `fdo.issue`. Other note types
|
||
keep `fdo` null. Table coverage describes the notes examined and includes
|
||
entries whose FDO metadata could not be decoded.
|
||
|
||
`PT_NOTE` and `SHT_NOTE` are examined independently. The same file range may
|
||
appear twice when both tables declare it.
|
||
|
||
A missing table list is observed absence of those declarations. It is not proof
|
||
the image never carried notes in another container or overlay.
|
||
|
||
## Limits and failures
|
||
|
||
The selected file is limited to 64 MiB by default (512 MiB maximum). At most
|
||
128 note entries are examined by default across every table (256 maximum), which
|
||
admits distribution glibc builds and their SystemTap probe notes. Retained note
|
||
names, section names, GNU descriptor text, core dump string representations, and Android ident strings share a scan budget based on
|
||
the source bytes plus any decoded section-name table, capped at
|
||
`max_file_bytes`. The raw source and decoded table must also fit together
|
||
within that ceiling. If admission fails, the error reports the required
|
||
`max_file_bytes`; raising it can admit the decoded table up to the operation's
|
||
512 MiB maximum. Once admitted, raising that setting does not increase the
|
||
scan budget for the same source and decoded names. Repeated table ranges count again. Each descriptor range is hashed once,
|
||
and each GNU version's trailing NUL run is scanned once; neither walk may
|
||
exceed that byte ceiling. Malformed ELF headers, truncated header
|
||
tables, declared note tables that extend past the file, and truncated
|
||
note entries fail without partial success. ELF extended
|
||
numbering (`PN_XNUM`, including a section count stored when `e_shnum` is 0) is
|
||
unsupported and returns an unsupported-target outcome rather than invalid-input
|
||
recovery. A direct section count of `0xff00` or greater in `e_shnum` is
|
||
malformed. Compressed section-name tables require zero or a power of two for
|
||
the decoded alignment. A zlib stream must consume its full declared payload.
|
||
|
||
FDO decoding separately admits up to 64 KiB of distinct recognized descriptor
|
||
bytes and up to 64 KiB of projected metadata JSON per report. A repeated
|
||
descriptor consumes projected bytes for each entry that includes it. Metadata
|
||
that would exceed the Evidence JSON nesting allowance is also left undecoded.
|
||
|
||
Zstandard section-name tables also use a 128 MiB decoder window limit and the
|
||
shared [`zstd.max_frames` work limit](design/limits-and-recovery.md#runtime-settings-through-mcp).
|
||
|
||
`SHF_COMPRESSED` note sections return `unsupported_target` before their payload
|
||
is interpreted or decompressed. Their compression header is storage metadata,
|
||
not a note header. The current result requires physical file offsets for each
|
||
note and descriptor, which decoded compressed notes cannot provide. This refusal
|
||
does not label compressed note storage as malformed or allocate its declared
|
||
decoded size. Compressed section-name tables remain supported within the limits
|
||
above. Inspect a separately decompressed copy when these notes are needed,
|
||
retaining the original artifact for provenance.
|
||
|
||
This workflow does not execute the image or verify GNU build-id uniqueness
|
||
against package catalogs.
|