Files
reverse-engineering-anything/src/native/NativeMachoCommandDiagnostics.ts
T
morlutoandCursor Agent c0c3902207 fix(native): preserve Mach-O target selection in macOS tools (#7831)
* fix(native): preserve Mach-O target selection in macOS tools

* fix(native): retain exact Mach-O slice signature coverage

* fix(native): admit x86_64 LIB64 signature selectors

* test(native): match signature checks to actual slices

* fix(native): recognize vtool refusals on private Mach-O aliases

Match vtool's container refusal to the operand the command received so a
parenthesized universal path keeps completed facts and the refusal
limitation. Expect codesign -a only when the target format is universal.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-10-30 00:03:23 +08:00

137 lines
4.7 KiB
TypeScript

import type { AnalysisCapturedOutput } from "../domain/analysisErrorBase.js";
import { AnalysisOutputError } from "../domain/analysisErrorCore.js";
import type { NativeCommandCapture } from "./CommandRunner.js";
import { withoutEchoedPathHeader } from "./parsers/echoedPath.js";
/** Path the command received. Diagnostics echo this operand, not the selected subject. */
export const nativeCommandOperand = (
capture: NativeCommandCapture,
): string | undefined => capture.arguments.at(-1);
/** Recognize vtool's sole settled container-format refusal without hiding other failures. */
export const isVtoolContainerRefusal = (
capture: NativeCommandCapture,
): boolean => {
const operandPath = nativeCommandOperand(capture);
if (
operandPath === undefined ||
capture.tool !== "vtool" ||
capture.exitCode !== 1 ||
capture.signal !== null ||
capture.stdout.trim() !== ""
)
return false;
const diagnostic = capture.stderr.trimEnd();
const suffix = ` error: ${operandPath} file is not mach-o`;
if (!diagnostic.endsWith(suffix)) return false;
const executable = diagnostic.slice(0, -suffix.length);
return (
!/[\r\n]/u.test(executable) &&
(executable === "vtool" || executable.endsWith("/vtool"))
);
};
const MISSING_UUID_DIAGNOSTIC = "missing LC_UUID load command";
const dyldFailureDiagnostics = (
capture: NativeCommandCapture,
outputs: readonly string[],
): readonly string[] =>
capture.tool !== "dyld_info" ||
capture.exitCode === null ||
capture.exitCode === 0 ||
capture.signal !== null
? []
: outputs.flatMap((output) =>
withoutEchoedPathHeader(output, capture.arguments.at(-1))
.split(/\r?\n/u)
.map((line) => line.trim().replace(/^(?:dyld_info:\s*)/u, ""))
.filter(Boolean),
);
/** Admit the observed refusal only when it is the sole settled diagnostic. */
const dyldFailureDiagnostic = (
capture: NativeCommandCapture,
): string | null => {
const diagnostics = dyldFailureDiagnostics(capture, [
capture.stdout,
capture.stderr,
]);
return diagnostics.length === 1 ? (diagnostics[0] ?? null) : null;
};
/** Keep missing-UUID admission limited to its observed stdout-only refusal. */
export const isMissingUuidDyldFailure = (
capture: NativeCommandCapture,
): boolean =>
capture.stderr.trim().length === 0 &&
dyldFailureDiagnostic(capture) === MISSING_UUID_DIAGNOSTIC;
/** Admit the observed dSYM refusal only when no other diagnostic is present. */
export const isUnbackedTextDyldFailure = (
capture: NativeCommandCapture,
): boolean =>
dyldFailureDiagnostic(capture) ===
"section '__TEXT/__text' has offset=0 but is not a zero-fill section type";
/** Reported CORE/FVMLIB refusals still require an independently matching header. */
export const parseDyldFileTypeRefusal = (
capture: NativeCommandCapture,
): {
readonly fileType: "3" | "4";
readonly diagnostic: string;
} | null => {
for (const line of dyldFailureDiagnostics(capture, [
capture.stdout,
capture.stderr,
])) {
const fileType = /^unknown (?:mh\.)?filetype ([34])$/u.exec(line)?.[1];
if (fileType === "3" || fileType === "4")
return { fileType, diagnostic: line };
}
return null;
};
/** Complete captures come from the settled native command owner. */
export const nativeMachoCapturedOutput = (
capture: NativeCommandCapture,
): AnalysisCapturedOutput => ({
stdout: capture.stdout,
stderr: capture.stderr,
truncated: false,
stdout_bytes: capture.stdoutBytes,
stderr_bytes: capture.stderrBytes,
exit_code: capture.exitCode,
signal: capture.signal,
});
/** Keep the exact target diagnostic beside the incomplete collection. */
export const missingUuidLimitation = (mode: "imports" | "exports"): string =>
mode === "imports"
? "dyld_info -imports reported 'missing LC_UUID load command'; import observations are unavailable."
: "dyld_info -exports reported 'missing LC_UUID load command'; exports include nm symbol-table observations only.";
/** Preserve unrecognized nonzero command output as an inspection failure. */
export const unusableNativeCommandOutput = (
capture: NativeCommandCapture,
): AnalysisOutputError =>
new AnalysisOutputError(
"inspect_macho",
`${capture.tool} did not produce a usable inspection result`,
{
capturedOutput: nativeMachoCapturedOutput(capture),
},
);
/** Refuse a recognized error when the independently parsed load table contradicts it. */
export const conflictingUuidCommandEvidence = (
command: NativeCommandCapture,
): AnalysisOutputError =>
new AnalysisOutputError(
"inspect_macho",
"dyld_info reported a missing LC_UUID despite an observed LC_UUID load command",
{
capturedOutput: nativeMachoCapturedOutput(command),
},
);