mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 19:53:50 +00:00
* feat(evidence)!: name the Evidence subject by its target identity (format revision 2) The Evidence subject carries subject.identity (kind, sha256, format, architecture, selection) and the Evidence ID commits to it, so raw/DOL entry points and ESP flash offsets of the same bytes are different subjects. Every record declares evidence_format: 2; revision 1 bundles, standalone records and snapshots are refused with the recreate guidance. binaryTargetIdentity is the one projection of an open target, used by Evidence and snapshot comparison. BREAKING CHANGE: Evidence format revision 2. Evidence IDs commit to the subject's target identity (subject.identity, including the raw/DOL entry point or ESP flash offsets), and every record declares evidence_format: 2. Evidence bundles, records and analysis snapshots from earlier releases are refused; recreate the observations with this release. * refactor(analysis-view): read parent subjects through the Evidence identity accessors (#11423) Analysis views compare their parent's file identity (evidenceFileTarget) and take path and digest from evidenceSubjectTarget instead of reading the subject's digest, format and architecture members, which duplicate subject.identity until they are removed. A counted guard (evidence-subject-declaration-read) keeps new direct reads out and records the 20 remaining files. * fix(evidence): carry format refusals through Evidence readers and bind target selections - safeParseEvidence/safeParseImmutableEvidence return the format refusal as an expected failure; every consumer maps it to the one integrity refusal with the recreate guidance. An unmarked object is an earlier record only when it has every member records have always carried. - ArtifactProvider inventory roots and provider subjects that name the target's own bytes carry the target's selection (ESP flash offsets). - Snapshot rows bind only Evidence whose identity, selection included, matches the snapshot target. - Entry-point selections use the raw-binary entry point form. * fix(evidence): refuse unauthenticated or earlier-format records instead of reading them as absent - recognizeEvidence (evidenceValidation) replaces tryParseEvidence: input without an evidence_id is not Evidence (ok(undefined)); a record that names one but fails authentication or is from another format revision is an EvidenceIntegrityError carrying the recreate guidance, never undefined. - Direct analysis retains that refusal as a secondary failure instead of silently skipping source capture; cleanup projection, source-closure annotation and the flutter, debugger and release-exposure recoveries use the same owner (the last three previously read the unauthenticated schema). - A desktop capture.json from an earlier format is refused with the recreate guidance instead of "not desktop application capture Evidence". * fix(evidence): advertise revision 2 ledger examples and rank delivery omissions by serialized size - The obligation ledger and reconstruction coverage examples named evidence_format 1, which revision 2 refuses; they now use EVIDENCE_FORMAT_REVISION. - MCP delivery chose which unretained recovery to omit by a parsed-storage lower bound clipped at the response budget. Once revision 2 subjects made the source record's estimate cross the budget, both candidates tied at the clip and the smaller source was omitted ahead of the larger completed observation. Candidates are now ranked by serialized size, which is what the budget counts. * refactor(native): compare function snapshots by their Evidence target identity (#11450) Function snapshots carry the subject's file target identity instead of the duplicated subject declaration. Call paths and function comparisons compare targets through sameTargetIdentity, so the same bytes opened at a different raw entry point or ESP flash offset no longer count as one coordinate space: build_call_path refuses the mix, and compare_functions no longer matches entries by address across selections. Structural candidates and native function matching read the architecture and digest through evidenceFileTarget. Refs #11417 * refactor(artifacts): compare artifact and WASM summaries by their Evidence target identity (#11461) Artifact comparison authenticates a summary against its retained inventory through sameTargetIdentity and rebinds the alias with the whole target, selection included, so a flash-selected inventory summary taken under an alias path is no longer refused. WASM comparison, the analysis view artifact projection and the inventory root check read the digest, format and display path through the Evidence identity accessors. Refs #11417 * refactor(evidence): read record subjects through the identity accessors in JS, managed, ledger and bundle readers (#11470) JavaScript application graphs, runtime reconciliation, managed inspection and native verification sources, the record summary filter, the ledger's residual-unknown target and bundle scope selection read the subject digest, format and display path through evidenceFileTarget and evidenceSubjectDisplay. No comparison changes: each reader matches one record's facts against its own payload or a caller filter. Refs #11417 * refactor(evidence)!: name the Evidence subject only by its target identity (#11497) * refactor(evidence)!: name the Evidence subject only by its target identity The subject keeps `identity` and the display facts `name` and `local_path`. The duplicated `digest`, `format` and `architecture` members are removed; the format-owned declaration now validates the identity itself. Readers the type checker found move to the owner accessors; untyped reads in verify scripts, the efficiency harness and test matchers move to `subject.identity`. The `evidence-subject-declaration-read` text guard and its baseline are deleted. Fixes #11473 Refs #11417 BREAKING CHANGE: the Evidence subject no longer has `digest`, `format` or `architecture`; read `subject.identity.sha256`, `subject.identity.format` and `subject.identity.architecture`. A record that still carries them is refused. * test(evidence): give the Flutter verifier fixture the identity subject and check the DOL declaration without the ID * test(evidence): drop the removed subject members from the declaration matrix and tamper fixtures * feat(evidence)!: give every Evidence record an explicit subject identity (#11536) * feat(evidence)!: give every Evidence record an explicit subject identity A producer that cannot name a file passes an `unknown` target identity with a closed reason (derived-from-linked-evidence, not-observed, unsupported-subject) instead of no subject. The subject is non-null; unknown subjects have no display facts. The generic missing-subject limitation and `subjectUnavailableReason` are removed; producer-specific explanations are ordinary limitations. Comparison identity requires the derived unknown, and null-subject consumers ask the owner accessors. Refs #11417 BREAKING CHANGE: every Evidence record has a subject. A record without a file target names `subject.identity` `{ "kind": "unknown", "reason": … }` with `name` and `local_path` null, instead of `subject: null` and the limitation "Artifact identity is unavailable for this observation.". Their Evidence IDs change. * fix(evidence): name explicit unknown subjects in JavaScript callers and keep a managed graph's file subject The verification scripts are not type-checked, so five createEvidence callers still passed undefined (or a missing first target) after the subject became required. They now pass unknownTarget("not-observed"). A managed application graph chose the first present input subject. Every subject is now present, so an unknown artifact subject hid a file subject on the member or boundary Evidence. The graph now takes the first input subject that names a file. * test(evidence): assert the subject kind instead of a presence the type now guarantees Every Evidence record has a subject after this change, so test guards and assertions that checked it for null always passed. Each now checks that the fixture subject names a file, or is removed where a later fileIdentity, fileSubjectTarget or fileSubjectDisplay call already requires that. Non-null assertions on Evidence subjects are removed; analysis-view inputs, whose subject is optional, keep an undefined check. * test(evidence): expect the Evidence subject format under its identity Two boundary tests still matched subject.format, which slice 2e moved into subject.identity. toMatchObject is not type-checked against the Evidence shape, so they failed only when run (the signature test on macOS).
638 lines
20 KiB
TypeScript
638 lines
20 KiB
TypeScript
import { fileIdentity } from "../../fixtures/evidenceSubject.js";
|
|
import { canonicalOutputSchema } from "../../fixtures/canonicalOutputSchema.js";
|
|
import { Ajv2020 } from "ajv/dist/2020.js";
|
|
import { expect, it } from "vitest";
|
|
|
|
import { FUNCTION_COMPARISON_EXAMPLE } from "../../../src/contracts/functionComparisonExample.js";
|
|
import {
|
|
createEvidence,
|
|
parseEvidence,
|
|
evidenceSubjectInput,
|
|
} from "../../../src/domain/evidence.js";
|
|
import { functionDossierSchema } from "../../../src/domain/native/functionDossier.js";
|
|
import { jsonValueSchema } from "../../../src/domain/jsonValue.js";
|
|
import { createTestBinarySession } from "../../fixtures/binarySession.js";
|
|
import { createApplicationMcpHarness } from "../../fixtures/applicationMcpHarness.js";
|
|
import type { RelationshipCoverage } from "../../../src/domain/relationshipCoverage.js";
|
|
import { functionComparisonResultSchema } from "../../../src/domain/functionComparisonSchemas.js";
|
|
|
|
const sourceWithCoverage = (
|
|
template: typeof FUNCTION_COMPARISON_EXAMPLE.left,
|
|
observation: string,
|
|
result: typeof template.normalized_result,
|
|
relationshipCoverage: RelationshipCoverage,
|
|
) => {
|
|
return createEvidence(
|
|
{
|
|
path: `${template.subject.local_path}/${observation}`,
|
|
sha256: fileIdentity(template.subject).sha256,
|
|
format: fileIdentity(template.subject).format,
|
|
},
|
|
template.provider,
|
|
{
|
|
operation: "analyze_function",
|
|
parameters: { ...template.parameters, observation },
|
|
result,
|
|
confidence: template.confidence,
|
|
authority: template.authority,
|
|
relationshipCoverage,
|
|
},
|
|
);
|
|
};
|
|
|
|
const expectAdvertisedComparisonSchema = async (
|
|
client: Awaited<ReturnType<typeof createApplicationMcpHarness>>["client"],
|
|
payload: unknown,
|
|
) => {
|
|
const advertised = (await client.listTools()).tools.find(
|
|
({ name }) => name === "compare_functions",
|
|
);
|
|
if (advertised === undefined)
|
|
throw new Error("compare_functions did not advertise its output schema");
|
|
const outputSchema: Record<string, unknown> = canonicalOutputSchema(
|
|
advertised.name,
|
|
);
|
|
const validator = new Ajv2020({ strict: false, validateFormats: false });
|
|
expect(validator.validateSchema(outputSchema)).toBe(true);
|
|
const validate = validator.compile(outputSchema);
|
|
expect(validate(payload), JSON.stringify(validate.errors)).toBe(true);
|
|
};
|
|
|
|
const expectDiscoveryConsumers = async (
|
|
client: Awaited<ReturnType<typeof createApplicationMcpHarness>>["client"],
|
|
comparison: ReturnType<typeof parseEvidence>,
|
|
label: "partial" | "unreported" | "complete",
|
|
) => {
|
|
const unknowns = await client.callTool({
|
|
name: "list_unknowns",
|
|
arguments: { domain: "function-comparison" },
|
|
});
|
|
expect(unknowns.isError).not.toBe(true);
|
|
const unknownItems = (
|
|
unknowns.structuredContent as { result: { items: unknown[] } }
|
|
).result.items;
|
|
if (label === "complete") expect(unknownItems).toHaveLength(0);
|
|
else
|
|
expect(unknownItems).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
comparison_conclusion_scope: expect.objectContaining({
|
|
comparison_evidence_id: comparison.evidence_id,
|
|
dimensions: expect.arrayContaining(["calls"]),
|
|
}),
|
|
}),
|
|
]),
|
|
);
|
|
const changed = await client.callTool({
|
|
name: "find_changed_behavior",
|
|
arguments: { comparisons: [comparison] },
|
|
});
|
|
expect(changed.isError, JSON.stringify(changed.structuredContent)).not.toBe(
|
|
true,
|
|
);
|
|
const changedEvidence = parseEvidence(changed.structuredContent);
|
|
const findings = (
|
|
changedEvidence.normalized_result as { findings: { items: unknown[] } }
|
|
).findings.items;
|
|
if (label === "complete") expect(findings).toHaveLength(0);
|
|
else
|
|
expect(findings).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
classification: "unresolved_branch",
|
|
}),
|
|
]),
|
|
);
|
|
};
|
|
|
|
const expectHistoricalDiscovery = async (
|
|
session: ReturnType<typeof createTestBinarySession>,
|
|
client: Awaited<ReturnType<typeof createApplicationMcpHarness>>["client"],
|
|
comparison: ReturnType<typeof parseEvidence>,
|
|
) => {
|
|
const current = functionComparisonResultSchema.parse(
|
|
comparison.normalized_result,
|
|
);
|
|
const historical = createEvidence(
|
|
evidenceSubjectInput(comparison.subject),
|
|
comparison.provider,
|
|
{
|
|
predicateType: comparison.predicate_type,
|
|
operation: comparison.operation,
|
|
parameters: comparison.parameters,
|
|
result: {
|
|
...current,
|
|
dimensions: current.dimensions.map((dimension) => {
|
|
if (dimension.dimension !== "calls") return dimension;
|
|
const { discovery_status: _discovery, ...historicalDimension } =
|
|
dimension;
|
|
return { ...historicalDimension, limitations: [] };
|
|
}),
|
|
},
|
|
confidence: comparison.confidence,
|
|
authority: comparison.authority,
|
|
limitations: comparison.limitations,
|
|
evidenceLinks: comparison.evidence_links,
|
|
},
|
|
);
|
|
expect(session.recordEvidence(historical).ok).toBe(true);
|
|
const prior = await verify(
|
|
(name, arguments_) => client.callTool({ name, arguments: arguments_ }),
|
|
historical,
|
|
["calls"],
|
|
);
|
|
expect(prior.normalized_result).toMatchObject({
|
|
claims: {
|
|
items: [{ status: "unknown", observed_status: "unchanged" }],
|
|
},
|
|
});
|
|
const historicalChanged = await client.callTool({
|
|
name: "find_changed_behavior",
|
|
arguments: { comparisons: [historical] },
|
|
});
|
|
expect(historicalChanged.isError).not.toBe(true);
|
|
expect(
|
|
parseEvidence(historicalChanged.structuredContent).normalized_result,
|
|
).toMatchObject({
|
|
findings: {
|
|
items: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
classification: "unresolved_branch",
|
|
}),
|
|
]),
|
|
},
|
|
});
|
|
expect(session.evidenceById(historical.evidence_id)).toEqual(historical);
|
|
};
|
|
|
|
it.each(["complete", "partial"] as const)(
|
|
"retains %s discovery when a call facet is unavailable",
|
|
async (discoveryStatus) => {
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("offline comparison must not launch a provider");
|
|
});
|
|
const { client } = await createApplicationMcpHarness({ session });
|
|
const original = functionDossierSchema.parse(
|
|
FUNCTION_COMPARISON_EXAMPLE.left.normalized_result,
|
|
);
|
|
const unavailable = {
|
|
...original,
|
|
facet_availability: {
|
|
...original.facet_availability,
|
|
callers: { available: false as const, reason: "Read unavailable." },
|
|
},
|
|
};
|
|
const coverage: RelationshipCoverage = {
|
|
status: "complete",
|
|
discovery: {
|
|
callers: { status: "complete" },
|
|
callees:
|
|
discoveryStatus === "complete"
|
|
? { status: "complete" }
|
|
: { status: "partial", reason: "Some bodies unclassified." },
|
|
},
|
|
};
|
|
const left = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.left,
|
|
"facet-left",
|
|
unavailable,
|
|
coverage,
|
|
);
|
|
const right = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.right,
|
|
"facet-right",
|
|
original,
|
|
coverage,
|
|
);
|
|
const compared = await client.callTool({
|
|
name: "compare_functions",
|
|
arguments: { left, right },
|
|
});
|
|
expect(compared.isError).not.toBe(true);
|
|
const comparison = parseEvidence(compared.structuredContent);
|
|
expect(comparison.normalized_result).toMatchObject({
|
|
dimensions: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
status: "unknown",
|
|
discovery_status: discoveryStatus,
|
|
limitations: expect.arrayContaining([
|
|
"Left: callers: Read unavailable.",
|
|
]),
|
|
}),
|
|
]),
|
|
});
|
|
const changed = await client.callTool({
|
|
name: "find_changed_behavior",
|
|
arguments: { comparisons: [comparison] },
|
|
});
|
|
expect(changed.isError).not.toBe(true);
|
|
const findings = (
|
|
parseEvidence(changed.structuredContent).normalized_result as {
|
|
findings: {
|
|
items: Array<{ dimension: string; limitations: string[] }>;
|
|
};
|
|
}
|
|
).findings.items;
|
|
const calls = findings.find((finding) => finding.dimension === "calls");
|
|
expect(calls).toBeDefined();
|
|
expect(calls?.limitations).not.toContain(
|
|
"Static call discovery coverage was not recorded in the comparison.",
|
|
);
|
|
},
|
|
);
|
|
|
|
it.each(["compact"] as const)(
|
|
"qualifies observed calls and verifies discovery independently (%s)",
|
|
async (profile) => {
|
|
for (const [label, coverage, status] of [
|
|
[
|
|
"partial",
|
|
{
|
|
status: "complete",
|
|
discovery: {
|
|
callers: { status: "complete" },
|
|
callees: {
|
|
status: "partial",
|
|
reason: "The fixture body is classified as data.",
|
|
},
|
|
},
|
|
},
|
|
"unknown",
|
|
],
|
|
["unreported", { status: "complete" }, "unknown"],
|
|
[
|
|
"complete",
|
|
{
|
|
status: "complete",
|
|
discovery: {
|
|
callers: { status: "complete" },
|
|
callees: { status: "complete" },
|
|
},
|
|
},
|
|
"pass",
|
|
],
|
|
] as const) {
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("offline comparison must not launch a provider");
|
|
});
|
|
const { client } = await createApplicationMcpHarness({
|
|
session,
|
|
serverOptions: {
|
|
environment: { REA_MCP_OUTPUT_SCHEMA_PROFILE: profile },
|
|
},
|
|
});
|
|
const left = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.left,
|
|
`${label}-left`,
|
|
FUNCTION_COMPARISON_EXAMPLE.left.normalized_result,
|
|
coverage,
|
|
);
|
|
const right = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.right,
|
|
`${label}-right`,
|
|
FUNCTION_COMPARISON_EXAMPLE.left.normalized_result,
|
|
coverage,
|
|
);
|
|
const compared = await client.callTool({
|
|
name: "compare_functions",
|
|
arguments: { left, right },
|
|
});
|
|
if (compared.isError) throw new Error(JSON.stringify(compared));
|
|
const comparison = parseEvidence(compared.structuredContent);
|
|
if (label === "partial")
|
|
await expectAdvertisedComparisonSchema(
|
|
client,
|
|
compared.structuredContent,
|
|
);
|
|
expect(comparison.normalized_result).toMatchObject({
|
|
dimensions: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
status: "unchanged",
|
|
...(label === "partial"
|
|
? {
|
|
limitations: expect.arrayContaining([
|
|
expect.stringContaining(
|
|
"The fixture body is classified as data.",
|
|
),
|
|
]),
|
|
}
|
|
: {}),
|
|
}),
|
|
]),
|
|
});
|
|
await expectDiscoveryConsumers(client, comparison, label);
|
|
const result = await verify(
|
|
(name, arguments_) => client.callTool({ name, arguments: arguments_ }),
|
|
comparison,
|
|
["calls"],
|
|
);
|
|
expect(result.normalized_result).toMatchObject({
|
|
claims: {
|
|
items: [
|
|
{
|
|
claim_id: "calls",
|
|
status,
|
|
observed_status: "unchanged",
|
|
...(label === "partial"
|
|
? {
|
|
limitations: expect.arrayContaining([
|
|
expect.stringContaining(
|
|
"The fixture body is classified as data.",
|
|
),
|
|
]),
|
|
}
|
|
: {}),
|
|
},
|
|
],
|
|
},
|
|
});
|
|
if (label === "unreported")
|
|
await expectHistoricalDiscovery(session, client, comparison);
|
|
}
|
|
},
|
|
);
|
|
|
|
const verify = async (
|
|
call: (
|
|
name: string,
|
|
arguments_: Record<string, unknown>,
|
|
) => Promise<{
|
|
readonly isError?: boolean | undefined;
|
|
readonly structuredContent?: unknown | undefined;
|
|
}>,
|
|
comparison: ReturnType<typeof parseEvidence>,
|
|
dimensions: readonly ("calls" | "overall" | "pseudocode")[],
|
|
) => {
|
|
const response = await call("verify_reconstruction", {
|
|
specification: {
|
|
name: "Function call coverage verification",
|
|
claims: dimensions.map((dimension) => ({
|
|
kind: "structural-function",
|
|
claim_id: dimension,
|
|
title: `Check ${dimension}`,
|
|
comparison_evidence_id: comparison.evidence_id,
|
|
dimension,
|
|
})),
|
|
},
|
|
});
|
|
expect(response.isError, JSON.stringify(response.structuredContent)).not.toBe(
|
|
true,
|
|
);
|
|
return parseEvidence(response.structuredContent);
|
|
};
|
|
|
|
it("keeps an observed call-set difference without claiming a verified difference", async () => {
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("offline comparison must not launch a provider");
|
|
});
|
|
const { client } = await createApplicationMcpHarness({ session });
|
|
const original = functionDossierSchema.parse(
|
|
FUNCTION_COMPARISON_EXAMPLE.left.normalized_result,
|
|
);
|
|
const coverage: RelationshipCoverage = {
|
|
status: "complete",
|
|
discovery: {
|
|
callers: { status: "complete" },
|
|
callees: { status: "partial", reason: "Not all bodies were classified." },
|
|
},
|
|
};
|
|
const left = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.left,
|
|
"difference-left",
|
|
jsonValueSchema.parse({ ...original, callees: [] }),
|
|
coverage,
|
|
);
|
|
const {
|
|
signature: _signature,
|
|
locals: _locals,
|
|
...helper
|
|
} = original.procedure;
|
|
const right = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.right,
|
|
"difference-right",
|
|
jsonValueSchema.parse({
|
|
...original,
|
|
callees: [{ ...helper, address: "0x2000", name: "helper" }],
|
|
}),
|
|
coverage,
|
|
);
|
|
const response = await client.callTool({
|
|
name: "compare_functions",
|
|
arguments: { left, right },
|
|
});
|
|
if (response.isError) throw new Error(JSON.stringify(response));
|
|
const comparison = parseEvidence(response.structuredContent);
|
|
expect(comparison.normalized_result).toMatchObject({
|
|
dimensions: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
status: "changed",
|
|
limitations: expect.arrayContaining([
|
|
expect.stringContaining("Not all bodies were classified."),
|
|
]),
|
|
}),
|
|
]),
|
|
});
|
|
const changed = await client.callTool({
|
|
name: "find_changed_behavior",
|
|
arguments: { comparisons: [comparison] },
|
|
});
|
|
expect(changed.isError).not.toBe(true);
|
|
expect(
|
|
parseEvidence(changed.structuredContent).normalized_result,
|
|
).toMatchObject({
|
|
findings: {
|
|
items: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
classification: "derived_relationship",
|
|
}),
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
classification: "unresolved_branch",
|
|
}),
|
|
]),
|
|
},
|
|
});
|
|
const result = await verify(
|
|
(name, arguments_) => client.callTool({ name, arguments: arguments_ }),
|
|
comparison,
|
|
["calls"],
|
|
);
|
|
expect(result.normalized_result).toMatchObject({
|
|
claims: { items: [{ status: "unknown", observed_status: "changed" }] },
|
|
});
|
|
});
|
|
|
|
const assertChangedDespiteUnknownCalls = async (
|
|
call: Parameters<typeof verify>[0],
|
|
left: ReturnType<typeof parseEvidence>,
|
|
): Promise<void> => {
|
|
const changedRight = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.right,
|
|
"coverage-changed-right",
|
|
jsonValueSchema.parse({
|
|
...functionDossierSchema.parse(
|
|
FUNCTION_COMPARISON_EXAMPLE.right.normalized_result,
|
|
),
|
|
pseudocode: "return 1;",
|
|
}),
|
|
{ status: "unknown", reason: "Call graph unavailable." },
|
|
);
|
|
const changed = await call("compare_functions", {
|
|
left,
|
|
right: changedRight,
|
|
});
|
|
expect(changed.isError, JSON.stringify(changed.structuredContent)).not.toBe(
|
|
true,
|
|
);
|
|
const changedComparison = parseEvidence(changed.structuredContent);
|
|
expect(changedComparison.normalized_result).toMatchObject({
|
|
status: "changed",
|
|
dimensions: expect.arrayContaining([
|
|
expect.objectContaining({ dimension: "calls", status: "unknown" }),
|
|
expect.objectContaining({ dimension: "pseudocode", status: "changed" }),
|
|
]),
|
|
});
|
|
const verification = await verify(call, changedComparison, ["overall"]);
|
|
expect(verification.normalized_result).toMatchObject({
|
|
status: "fail",
|
|
summary: { total: 1, passed: 0, failed: 1, unknown: 0 },
|
|
claims: {
|
|
items: [
|
|
expect.objectContaining({
|
|
claim_id: "overall",
|
|
status: "fail",
|
|
observed_status: "changed",
|
|
}),
|
|
],
|
|
},
|
|
});
|
|
};
|
|
|
|
it("keeps incomplete calls unknown through public comparison and verification while preserving confirmed changes", async () => {
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("Function comparison must not launch a provider");
|
|
});
|
|
const { client } = await createApplicationMcpHarness({
|
|
session,
|
|
clientIdentity: { name: "function-coverage-test", version: "1" },
|
|
serverOptions: {
|
|
environment: {
|
|
...process.env,
|
|
REA_MCP_MAX_INPUT_ELEMENTS: process.env.REA_MCP_MAX_INPUT_ELEMENTS,
|
|
},
|
|
},
|
|
});
|
|
const left = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.left,
|
|
"coverage-left",
|
|
FUNCTION_COMPARISON_EXAMPLE.left.normalized_result,
|
|
{ status: "complete" },
|
|
);
|
|
const right = sourceWithCoverage(
|
|
FUNCTION_COMPARISON_EXAMPLE.right,
|
|
"coverage-right",
|
|
FUNCTION_COMPARISON_EXAMPLE.left.normalized_result,
|
|
{ status: "unknown", reason: "Call graph unavailable." },
|
|
);
|
|
expect(left.subject.identity.kind).toBe("file");
|
|
expect(right.subject.identity.kind).toBe("file");
|
|
const compared = await client.callTool({
|
|
name: "compare_functions",
|
|
arguments: { left, right },
|
|
});
|
|
expect(compared.isError, JSON.stringify(compared.structuredContent)).not.toBe(
|
|
true,
|
|
);
|
|
const comparison = parseEvidence(compared.structuredContent);
|
|
expect(session.evidenceById(left.evidence_id)?.subject).toEqual(
|
|
expect.any(Object),
|
|
);
|
|
expect(session.evidenceById(right.evidence_id)?.subject).toEqual(
|
|
expect.any(Object),
|
|
);
|
|
expect(comparison.normalized_result).toMatchObject({
|
|
status: "unknown",
|
|
summary: { unchanged: 7, changed: 0, unknown: 1 },
|
|
dimensions: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
dimension: "calls",
|
|
status: "unknown",
|
|
conclusion_kind: "unresolved_branch",
|
|
left_count: 0,
|
|
right_count: 0,
|
|
limitations: expect.arrayContaining([
|
|
"Right: Call graph unavailable.",
|
|
"Left: Static direct-call discovery is not established for callers and callees.",
|
|
"Right: Static direct-call discovery is not established for callers and callees.",
|
|
]),
|
|
evidence_links: [left.evidence_id, right.evidence_id],
|
|
}),
|
|
]),
|
|
});
|
|
expect(comparison.evidence_links).toEqual(
|
|
expect.arrayContaining([left.evidence_id, right.evidence_id]),
|
|
);
|
|
|
|
const unknowns = await client.callTool({
|
|
name: "list_unknowns",
|
|
arguments: { domain: "function-comparison" },
|
|
});
|
|
expect(unknowns.isError).not.toBe(true);
|
|
expect(unknowns.structuredContent).toMatchObject({
|
|
result: {
|
|
items: [
|
|
expect.objectContaining({
|
|
domain: "function-comparison",
|
|
status: "open",
|
|
supporting_evidence_ids: expect.arrayContaining([
|
|
left.evidence_id,
|
|
right.evidence_id,
|
|
]),
|
|
}),
|
|
],
|
|
},
|
|
});
|
|
|
|
const verification = await verify(
|
|
async (name, arguments_) =>
|
|
client.callTool({ name, arguments: arguments_ }),
|
|
comparison,
|
|
["calls", "overall", "pseudocode"],
|
|
);
|
|
expect(verification.normalized_result).toMatchObject({
|
|
status: "unknown",
|
|
summary: { total: 3, passed: 1, failed: 0, unknown: 2 },
|
|
claims: {
|
|
items: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
claim_id: "calls",
|
|
status: "unknown",
|
|
observed_status: "unknown",
|
|
}),
|
|
expect.objectContaining({
|
|
claim_id: "overall",
|
|
status: "unknown",
|
|
observed_status: "unknown",
|
|
}),
|
|
expect.objectContaining({
|
|
claim_id: "pseudocode",
|
|
status: "pass",
|
|
observed_status: "unchanged",
|
|
}),
|
|
]),
|
|
},
|
|
});
|
|
|
|
await assertChangedDespiteUnknownCalls(
|
|
async (name, arguments_) =>
|
|
client.callTool({ name, arguments: arguments_ }),
|
|
left,
|
|
);
|
|
});
|