mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 19:53:50 +00:00
* perf(tests): give MCP test clients the shared lazy schema validation The MCP SDK client compiles every listed tool's output schema on its first tool call. With the SDK's default Ajv options, REA's catalog costs gigabytes of allocation per client (inspect_analysis_view alone: 1.7 s and ~500 MiB retained), so native MCP files peaked at 1-2 GiB per worker. tests/fixtures/mcpSchemaValidation already owns lazy, reference-preserving validation. Route the native MCP, process-boundary and shared harness clients through it, share compiled validators across clients in a worker (bounded LRU keyed by schema text), and add a counted architecture guard so default-validation test clients cannot spread; the remaining copies are the baseline. * fix(guards): read call arguments past parentheses inside string literals * perf(tests): give MCP boundary test clients the shared schema validation (#11022) * perf(tests): give MCP boundary test clients the shared schema validation * perf(tests): give the remaining MCP test clients the shared schema validation (#11025) * fix(guards): read an MCP client's validator option from parsed code The default-validation counter searched each new Client(...) call's text for jsonSchemaValidator, so an inline comment, a string literal or a client name naming the option hid a default client. Parse the source with @babel/parser and count NewExpressions of Client whose object-literal arguments have no jsonSchemaValidator property; a source that does not parse counts every textual call. The guard reads raw test sources, and the generated-child-script allowlist entry, which no longer counts as a call, is removed. * fix(guards): read an MCP client's options only from a whole object-literal argument The default-validation counter skipped files without the text 'new Client(', so a comment between the tokens hid a client, and it took any depth-two key as an option, so 'enabled ? { jsonSchemaValidator } : {}' passed while its false branch uses the SDK default. The skip now only requires the name Client, and the validator counts only when it is a key of an object literal that is a whole argument; anything else counts as the default.
150 lines
5.4 KiB
TypeScript
150 lines
5.4 KiB
TypeScript
import {
|
|
canonicalOutputSchema,
|
|
withCanonicalOutputSchema,
|
|
} from "../../fixtures/canonicalOutputSchema.js";
|
|
import { Client, InMemoryTransport } from "@modelcontextprotocol/client";
|
|
import { chmod, readFile, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { Ajv2020 } from "ajv/dist/2020.js";
|
|
import { expect, it, onTestFinished } from "vitest";
|
|
import { toolContract } from "../../../src/contracts/toolContracts.js";
|
|
import { parseEvidence } from "../../../src/domain/evidence.js";
|
|
import { createServer } from "../../../src/server/createServer.js";
|
|
import { createTestBinarySession } from "../../fixtures/binarySession.js";
|
|
import { parseMcpToolError } from "../../fixtures/mcpToolError.js";
|
|
import {
|
|
assertRecoveryCleanup,
|
|
recoveryFixture,
|
|
} from "../../fixtures/javascript-recovery/provider.js";
|
|
import { createMcpSchemaValidation } from "../../fixtures/mcpSchemaValidation.js";
|
|
|
|
it
|
|
.skipIf(process.platform !== "linux" || process.arch !== "x64")
|
|
.each([false, true])(
|
|
"advertises and executes recovery through the named SDK contract (multiple inputs: %s)",
|
|
async (multiple) => {
|
|
const fixture = await recoveryFixture();
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("no binary provider should start");
|
|
});
|
|
const server = createServer(
|
|
{ kind: "session", session },
|
|
{
|
|
javascriptRecovery: fixture.provider,
|
|
},
|
|
);
|
|
const client = new Client(
|
|
{ name: "recovery-contract", version: "1" },
|
|
{ jsonSchemaValidator: createMcpSchemaValidation() },
|
|
);
|
|
onTestFinished(async () => {
|
|
await client.close();
|
|
await server.close();
|
|
await session.close();
|
|
});
|
|
const [clientTransport, serverTransport] =
|
|
InMemoryTransport.createLinkedPair();
|
|
await server.connect(serverTransport);
|
|
await client.connect(clientTransport);
|
|
const tools = await client.listTools();
|
|
const advertised = tools.tools.find(
|
|
(tool) => tool.name === "recover_javascript_sources",
|
|
);
|
|
if (
|
|
advertised === undefined ||
|
|
canonicalOutputSchema(advertised.name) === undefined
|
|
)
|
|
throw new Error("recovery tool must advertise both schemas");
|
|
const ajv = new Ajv2020({ strict: false, validateFormats: false });
|
|
const inputSchema: Record<string, unknown> = advertised.inputSchema;
|
|
const outputSchema: Record<string, unknown> = canonicalOutputSchema(
|
|
advertised.name,
|
|
);
|
|
expect(ajv.validateSchema(inputSchema)).toBe(true);
|
|
expect(ajv.validateSchema(outputSchema)).toBe(true);
|
|
const additional = join(fixture.root, "chunk.js");
|
|
if (multiple) await writeFile(additional, "export const chunk = 1;");
|
|
const args = {
|
|
path: fixture.path,
|
|
output_directory: fixture.output,
|
|
...(multiple ? { additional_paths: [additional] } : {}),
|
|
};
|
|
expect(ajv.validate(inputSchema, args)).toBe(true);
|
|
const response = await client.callTool(
|
|
{ name: "recover_javascript_sources", arguments: args },
|
|
{ toolDefinition: withCanonicalOutputSchema(advertised) },
|
|
);
|
|
expect(response.isError, JSON.stringify(response)).not.toBe(true);
|
|
const parsed = toolContract(
|
|
"recover_javascript_sources",
|
|
).outputSchema.parse(response.structuredContent);
|
|
const evidence = parseEvidence(parsed);
|
|
expect(evidence).toMatchObject({
|
|
operation: "recover_javascript_sources",
|
|
confidence: "derived",
|
|
authority: "shipped-artifact",
|
|
parameters: {
|
|
...args,
|
|
extraction_mode: "structural",
|
|
rewrite_level: "standard",
|
|
},
|
|
});
|
|
expect(session.evidenceById(evidence.evidence_id)).toEqual(evidence);
|
|
await assertRecoveryCleanup(fixture.launches);
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform !== "linux" || process.arch !== "x64")(
|
|
"reports denied selected-input access before launching recovery",
|
|
async (context) => {
|
|
const fixture = await recoveryFixture();
|
|
onTestFinished(() => chmod(fixture.path, 0o600));
|
|
await chmod(fixture.path, 0);
|
|
const denial = await readFile(fixture.path).then(
|
|
() => undefined,
|
|
(cause: unknown) => cause,
|
|
);
|
|
if (denial === undefined) context.skip();
|
|
expect(denial).toMatchObject({ code: "EACCES" });
|
|
const session = createTestBinarySession(() => {
|
|
throw new Error("no binary provider should start");
|
|
});
|
|
const server = createServer(
|
|
{ kind: "session", session },
|
|
{
|
|
javascriptRecovery: fixture.provider,
|
|
},
|
|
);
|
|
const client = new Client(
|
|
{ name: "recovery-denied", version: "1" },
|
|
{ jsonSchemaValidator: createMcpSchemaValidation() },
|
|
);
|
|
onTestFinished(async () => {
|
|
await client.close();
|
|
await server.close();
|
|
await session.close();
|
|
});
|
|
const [clientTransport, serverTransport] =
|
|
InMemoryTransport.createLinkedPair();
|
|
await server.connect(serverTransport);
|
|
await client.connect(clientTransport);
|
|
const result = await client.callTool({
|
|
name: "recover_javascript_sources",
|
|
arguments: { path: fixture.path, output_directory: fixture.output },
|
|
});
|
|
expect(parseMcpToolError(result)).toMatchObject({
|
|
error: {
|
|
code: "access_denied",
|
|
category: "unavailable",
|
|
details: {
|
|
operation: "recover_javascript_sources",
|
|
path: fixture.path,
|
|
system_code: "EACCES",
|
|
boundary: "filesystem-read",
|
|
},
|
|
},
|
|
});
|
|
expect(fixture.launches).toEqual([]);
|
|
},
|
|
);
|