Files
reverse-engineering-anything/tests/boundary/providers/hopper/hopperClient.progress.test.ts
T
gensokyo-devandgensokyo-dev 07e4b700ac test: let the deadline policy own test waits
Vitest's expect.poll and vi.waitFor stop after one second by default, a
host-speed guess that the project's deadline policy does not see. Under
hosted-CI load, kunaProjectConcurrency failed that way twice on unrelated
PRs. Another 256 waits relied on the default, and 97 passed literals
picked to fit some host.

Waits now take as long as their test may run, less the reporting reserve
that children already keep. Each Vitest project sets expect.poll's
default, and the new waitFor in tests/support/testWait.ts replaces
vi.waitFor. Fixture readiness waits (awaitAcknowledgement and the provider
process waits) default to the same deadline, and their host-speed literal
arguments are removed. One remainingTestDeadline owns the arithmetic for
both children and waits.

Ten waits whose short timeout was the real check now assert it directly
(Kuna version probe, Cutter discovery, doctor and Inspector cancellation,
apktool fixture teardown, JADX disconnect): settlement before the
production deadline that would otherwise also satisfy the wait, or a
deadline pinned beyond every test deadline.

The rea/project-wait-deadline lint rule rejects vi.waitFor and explicit
expect.poll timeouts. The testing guide and the CI tests audit skill now
document the policy.

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-14 19:28:38 +08:00

163 lines
4.9 KiB
TypeScript

import { describe, expect, it } from "vitest";
import {
HopperFixtureLauncher,
startHopperFixtureClient as startClient,
} from "./hopperClient.fixture.js";
import { waitFor } from "../../../support/testWait.js";
describe("HopperClient progress", () => {
it("forwards correlated Python progress before the terminal response", async () => {
const launcher = new HopperFixtureLauncher();
const client = await startClient(launcher);
const updates: Array<{
readonly phase: string;
readonly completed: number;
readonly terminal?: boolean;
}> = [];
const pending = client.callTool(
"echo",
{ value: "progress", gate: "progress" },
{
progress: {
report: (update) => {
updates.push(update);
return Promise.resolve();
},
},
},
);
const request = await launcher.waitForRequest("echo", "progress");
await waitFor(() =>
expect(updates).toContainEqual(
expect.objectContaining({ phase: "hopper_bridge", completed: 0 }),
),
);
expect(updates.some(({ terminal }) => terminal === true)).toBe(false);
await launcher.release(request);
const result = await pending;
expect(result).toEqual({
ok: true,
value: { value: "progress", gate: "progress" },
});
expect(updates).toEqual(
expect.arrayContaining([
expect.objectContaining({
phase: "hopper_bridge",
completed: 0,
}),
expect.objectContaining({
phase: "hopper_bridge",
completed: 1,
terminal: true,
}),
]),
);
});
it("isolates synchronous progress observer failures from bridge responses", async () => {
const client = await startClient();
await expect(
client.callTool(
"echo",
{ value: "alive" },
{
progress: {
report: () => {
throw new Error("observer failed");
},
},
},
),
).resolves.toEqual({ ok: true, value: { value: "alive" } });
});
it("projects a missing bridge API as typed capability unavailability", async () => {
const client = await startClient();
const result = await client.callTool("capability_unavailable");
expect(result.ok).toBe(false);
if (!result.ok)
expect(result.error).toMatchObject({
_tag: "AnalysisCapabilityUnavailableError",
providerId: "hopper",
operation: "capability_unavailable",
reason: "fixture API is unavailable",
diagnostics: {
provider_request: {
operation: "capability_unavailable",
provider_code: -32000,
diagnostic_type: "capability_unavailable",
request_id: expect.any(Number),
},
},
});
});
it("cancels and ignores late responses without corrupting the session", async () => {
const launcher = new HopperFixtureLauncher();
const client = await startClient(launcher);
const controller = new AbortController();
const pending = client.callTool(
"echo",
{ gate: "late-reply" },
{ signal: controller.signal },
);
const request = await launcher.waitForRequest("echo", "late-reply");
controller.abort();
const cancelled = await pending;
expect(cancelled.ok).toBe(false);
if (!cancelled.ok)
expect(cancelled.error._tag).toBe("HopperCancelledError");
await launcher.release(request);
await expect(client.callTool("echo", { value: "alive" })).resolves.toEqual({
ok: true,
value: { value: "alive" },
});
});
it("retains cancelled bridge activity until the reply releases the queue", async () => {
const launcher = new HopperFixtureLauncher();
const client = await startClient(launcher);
const progress: string[] = [];
const controller = new AbortController();
const pending = client.callTool(
"echo",
{ gate: "cancel-active" },
{
signal: controller.signal,
progress: {
report: (update) => {
progress.push(update.message);
return Promise.resolve();
},
},
},
);
const request = await launcher.waitForRequest("echo", "cancel-active");
controller.abort();
const result = await pending;
expect(result).toMatchObject({
ok: false,
error: { _tag: "HopperCancelledError" },
});
expect(client.requestActivity()).toMatchObject({
operation: "echo",
callerState: "cancelled",
});
expect(progress).toEqual(
expect.arrayContaining([
expect.stringContaining("started on Hopper's serial bridge"),
]),
);
await launcher.release(request);
await waitFor(() => expect(client.requestActivity()).toBeNull());
await expect(client.callTool("echo", { alive: true })).resolves.toEqual({
ok: true,
value: { alive: true },
});
});
});