mirror of
https://github.com/morluto/rea.git
synced 2026-11-14 18:52:48 +00:00
gensokyo-devandgensokyo-dev
b990eb496d
Every rea process imported and registered all 52 command registrars
(about 1,900 modules) before running any command. A one-shot command
now loads only the registrar that defines its top-level command.
- src/cli/cliCommandRegistrations.ts holds every registrar in one table,
grouped by tool family, with its module loader and its call. The
complete createCli registers the table with static imports, and the
types check that each entry matches its module.
- src/cli/cliShell.ts owns what does not depend on which commands are
registered: identity, globals, argument policy, completions and the
registration builtins. The full and lazy paths share it.
- scripts/record-cli-commands.mjs records, after tsc, which registrar
defines each top-level command, from the same compiled table. The
bundle keeps the record as an external dist module.
- cli/cliLoader.ts selects the recorded registrar when a known top-level
command runs. It loads the complete CLI for help, --schema, --llms,
completions, builtins, unknown names ("did you mean"), or a missing
record.
- Process-owned CLI resources register their closers when their module
loads (cli/cliResources.ts), so the shell no longer imports
JavaScript-analysis and guidance owners just to close them.
Measured on one pinned core (median of 5 warm runs, base main vs this
change):
- guidance: 1.95 s / 253 MB → 0.42 s / 101 MB
- list-cutter-sessions: 1.97 s → 0.49 s
- inspect-go-binary: 1.95 s → 0.95 s
- setup --dry-run: 2.40 s → 1.88 s
- analyze: 2.39 s → 1.78 s
- --help: 1.99 s → 2.04 s (complete CLI, as before)
Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
49 lines
1.4 KiB
TypeScript
49 lines
1.4 KiB
TypeScript
import { expect, it, vi } from "vitest";
|
|
import "../../../src/cli.js";
|
|
import {
|
|
CliResourceOwners,
|
|
cliProcessResourceOwners,
|
|
} from "../../../src/cli/cliResources.js";
|
|
|
|
it.each([
|
|
[false, false],
|
|
[true, false],
|
|
[false, true],
|
|
[true, true],
|
|
])(
|
|
"settles both CLI owners when JavaScript fails=%s and guidance fails=%s",
|
|
async (jsFails, guideFails) => {
|
|
const jsError = new Error("JavaScript resources retained");
|
|
const guideError = new Error("Guidance descriptor retained");
|
|
const js = vi.fn(async () => {
|
|
if (jsFails) throw jsError;
|
|
});
|
|
const guides = vi.fn(async () => {
|
|
if (guideFails) throw guideError;
|
|
});
|
|
const owners = new CliResourceOwners();
|
|
owners.own("javascript-analysis", js);
|
|
owners.own("guidance", guides);
|
|
const closing = owners.close();
|
|
if (jsFails && guideFails)
|
|
await expect(closing).rejects.toMatchObject({
|
|
errors: [jsError, guideError],
|
|
});
|
|
else if (jsFails || guideFails)
|
|
await expect(closing).rejects.toBe(jsFails ? jsError : guideError);
|
|
else await expect(closing).resolves.toBeUndefined();
|
|
expect(js).toHaveBeenCalledOnce();
|
|
expect(guides).toHaveBeenCalledOnce();
|
|
},
|
|
);
|
|
|
|
it("registers every process-owned CLI resource the complete CLI loads", () => {
|
|
expect(cliProcessResourceOwners()).toEqual(
|
|
expect.arrayContaining([
|
|
"javascript-analysis",
|
|
"guidance",
|
|
"mcp-registration",
|
|
]),
|
|
);
|
|
});
|