OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-14 12:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
32,590 Commits 54 Branches 1,942 Tags
1e646ff7ee52ecbbca3d7957b65fb4edfd39d653
Commit Graph
32590 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jesse Glick de8739ed74 Converted ExtensionFinderTest to JenkinsRule. 2020-01-04 20:05:56 -05:00
Jesse Glick 65b39baf63 Pick up https://github.com/jenkinsci/acceptance-test-harness/pull/553. 2020-01-04 11:42:12 -05:00
Jesse Glick 5773970a64 Merge branch 'JENKINS-40228' of github.com:ksenia-nenasheva/jenkins into enable-security-JENKINS-40228 2020-01-04 11:27:26 -05:00
Oleg Nenashev 1f47ad6ea2 Merge pull request #4408 from StefanSpieker/spotbugs_switch 
Fixed Spotbugs Switch related issues and added Suppresses
 2020-01-04 14:16:19 +01:00
Oleg Nenashev 9640790fe1 Merge pull request #4413 from jglick/UpdateCenter.isSiteDataReady-JENKINS-60625 
[JENKINS-60625] Prevent Jenkins page rendering from being blocked when the update center data parsing is in progress
 2020-01-04 14:16:01 +01:00
StefanSpieker 0e6bb91864 Return error when invalid string is passed as a Run status CLI argument (#4212) 
* removed redundnat null checks of nonnull values

* integrated suggestions

* removed local jenkins variable as suggested

* replaced null check with check for error object
 2020-01-03 23:39:22 +01:00
Josh SorefandOleg Nenashev 9b8047acd1 IntelliJ/Java: Duplicate declaration -> AntClassLoader.getUrl (#4254) 
* IntelliJ/Java: Duplicate declaration

AntClassLoader.getUrl

* Add missing import for annotation

* Switch from Vector to ArrayList<File>

* Drop inferable File

* Use for (File pathComponent : pathComponents) sugar

* Accept generic container type for getUrl

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2020-01-03 23:35:38 +01:00
Vincent Latombe dd59e8c11c [JENKINS-60449] Attempt to fix an odd case of OptionalExtension blowing up Jenkins (#4393) 
* Add new module optional-depender and a new failing test

* Variant plugin is a dependency of optional-depender

Optional-depender contains the following class

@OptionalExtension(requirePlugins = {"dependee"})
public class OptionalDependerExtension {
      private static void foo(Dependee d) {

      }
}

* [JENKINS-60449] Move plugin initialization at the end, keep only one extension refresh

* Improve logic to detect classloading issues

Inspect all declared constructors/methods/fields recursively to exclude
failing classes from Guice rather than have Guice explode.

This also fix the failing test, but the previous commit is still better
because it avoids an extra Jenkins.get().refreshExtensions() call.

* Only test resolveClass method if the classloader is not the bootstrap one
 2020-01-03 23:26:35 +01:00
Jesse GlickandDaniel Beck e621b6e0cd Be explicit that UpdateSite.hasUnparsedData is not intended as an API. 
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
 2020-01-03 16:49:04 -05:00
Jesse Glick 84f66e3c4e [JENKINS-60634] Define $WORKSPACE_TMP for (non-Pipeline) builds. 2020-01-03 14:57:53 -05:00
Jeff Thompson 50921ccbec Reduce JnlpSlaveAgentProtocol to minimum. 
Remove anything unnecessary. Move SLAVE_SECRET to JnlpAgentReceiver
and alias it for existing usages.
 2020-01-03 12:08:24 -07:00
Jeff Thompson bd0d9560dc Update to Remoting without protocols. 2020-01-03 11:06:06 -07:00
Jesse Glick 29fbc9c451 Quiet down log message about parsing JSON. (Though it is kind of interesting just how slow it is.) 2020-01-02 21:29:35 -05:00
Jesse Glick af7c4bece2 [JENKINS-60625] Introduced UpdateCenter.isSiteDataReady for use from administrative monitors. 2020-01-02 17:23:01 -05:00
Jesse Glick 0ba0ea93d5 Normalized loading of UpdateCenter/CoreUpdateMonitor/message.properties by moving changelog.url to jenkins-version.properties. 2020-01-02 17:04:23 -05:00
Kohsuke Kawaguchi 5d78705806 [maven-release-plugin] prepare for next development iteration 2020-01-02 07:54:36 -08:00
Kohsuke Kawaguchi 806d8b57b6 [maven-release-plugin] prepare release jenkins-2.211 jenkins-2.211 2020-01-02 07:54:28 -08:00
Mark Waite 9690e5ab65 Merge pull request #4409 from StefanSpieker/spotbugs_excludes 
Spotbugs: remove UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS from global exclude
 2019-12-31 07:10:43 -07:00
Stefan Spieker f9d1801bd6 remove UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS from global exclude 2019-12-31 12:15:04 +01:00
Stefan Spieker dbaec7ec03 set spotbugs URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD to ignore because reads are not detectable by spotbugs 2019-12-31 11:37:20 +01:00
Stefan Spieker 492505fd5d fixed spotbugs switch case related findings 2019-12-31 11:13:22 +01:00
Stefan Spieker 2fbc94bb87 set spotbugs ICAST_IDIV_CAST_TO_DOUBLE to ignore, because precision loss is intended 2019-12-31 10:50:09 +01:00
Oleg Nenashev 1a23ebd14c Add Jenkins Changelog Generator to the GitHub Actions release drafter Pipeline (#4406) 
* Add Jenkins Changelog Generator to the GitHub Actions release drafter Pipeline

* The Changelog generator repo was renamed
 2019-12-30 19:38:27 +01:00
Oleg Nenashev 937f30d915 Switch Release Drafter to GitHub Actions (#4323) 
* Switch Release Drafter to GitHub Actions

* Switch back to the upstream version after fixes
 2019-12-30 15:58:04 +01:00
Pierre Beitz 4b6049d586 [JENKINS-21311] Make the queue/cancelItem API an API. (#4395) 
* [JENKINS-21311] Make the queue/cancelItem API an API.

This change:
* documents the API
* adds meaningful return codes to help API caller.

* [JENKINS-21311] Code review

* [JENKINS-21311] Update failing integration test
 2019-12-30 10:06:40 +01:00
StefanSpiekerandOleg Nenashev 8b893a1cbe [JENKINS-36720]: Fixed some Spotbugs issues (#4180) 
* [JENKINS-36720]: Fixed Spotbugs issues WMI_WRONG_MAP_ITERATOR and OS_OPEN_STREAM in core

* merged try with resources with try finally

* reverted auto format from IDE

* reverted auto format from IDE

* use Util.fileToPath() as suggested to remove catch block

* merged try statements

* merged try statements

* reverted some whitespace fixes

* reverted another whitespace fix

* Apply suggestions from code review

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* reverted change

* reverted change

* reverted change

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2019-12-29 12:50:10 +01:00
Oleg Nenashev 45d7cf1668 Merge pull request #4378 from cesarsotovalero/JENKINS-60326 
Remove unused direct dependency commons-codec from Jenkins CLI
 2019-12-29 12:46:59 +01:00
Josh SorefandOleg Nenashev 7897ee0fe2 Add @CheckForNull annotation 
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
 2019-12-27 13:06:07 -05:00
StefanSpiekerandZbynek Konecny 23242cab56 Replace compare() implementations with call to Integer.compare or Long.compare (#4371) 
* replaced implementation with call to Integer.compare or Long.compare

* Update core/src/main/java/hudson/model/HealthReport.java

Co-Authored-By: Zbynek Konecny <zbynek1729@gmail.com>

* mark compare methods as deprecated

Co-authored-by: Zbynek Konecny <zbynek1729@gmail.com>
 2019-12-27 09:45:08 +01:00
Mark Waite 37d0776618 Merge pull request #4403 from StefanSpieker/suppress_cleanup 
removed obsolete SpotBugs suppresses
 2019-12-24 14:04:06 -07:00
Stefan Spieker 838f4ab504 removed obsolete SpotBugs suppresses 2019-12-23 16:04:30 +01:00
Kohsuke Kawaguchi d1502bffe8 [maven-release-plugin] prepare for next development iteration 2019-12-22 13:46:47 -08:00
Kohsuke Kawaguchi 10520e8301 [maven-release-plugin] prepare release jenkins-2.210 jenkins-2.210 2019-12-22 13:46:40 -08:00
StefanSpieker 6affcc507a JENKINS-60513: Added transient to SCMDescriptor#generation AtomicInteger to fix warnings (#4400) 
* JENKINS-60513: Added AtomicInteger to whitelist

* JENKINS-60513: Mark field as transient

* reverted whitelist change

* renamed field to support deserialization of ols values
 2019-12-21 13:52:12 +01:00
StefanSpieker 94f0976fd8 Spotbugs findings (catch runtime ex. and known null) (#4380) 
* refactor exception to actually put the failing string inside instead of null

* do not catch RuntimeExceptions
 2019-12-21 13:49:41 +01:00
Jeff Thompson 659f38886c Cleanup JavaDoc from references to removed classes. 2019-12-20 15:26:15 -07:00
Jesse Glick 84f6eb075a [JENKINS-60554] - EscapedMarkupFormatter did not properly handle a null argument. (#4401) 2019-12-20 22:02:56 +01:00
Daniel Beck 2ac61e59fa [JENKINS-60553][SECURITY-1605] Remove teamconcert with security warning from wizard (#4397) 2019-12-20 11:17:56 +01:00
Jesse Glick 7ab6d8e575 Adapt to newer HtmlUnit (#4398) 
* Adapt to newer HtmlUnit.

* https://github.com/HtmlUnit/htmlunit/pull/29 seems to have been incompatible.
WebClient.addRequestHeader will no longer override a header in a WebRequest,
such as when the same WebClient/WebRequest was previously used with different headers.

* Tracked down a behavioral change in passing through URL-encoded path characters.
https://github.com/HtmlUnit/htmlunit/commit/2c4956863420e4baef9d3d8c23ec0577ec64d2bf picks up
https://github.com/apache/httpcomponents-client/commit/8c04c6ae5e5ba1432e40684428338ce68431766b which is the actual change.

* jenkins-test-harness 2.58
 2019-12-20 11:12:44 +01:00
Oleg Nenashev f9b2c5957a Merge pull request #4394 from jvz/user-seed-fix 
[JENKINS-59107] User is no longer logged out when authenticating another user
 2019-12-20 11:12:20 +01:00
Oleg Nenashev 19ca6228aa Merge pull request #4396 from TheLastPossibleUsernameEver/master 
fixed_typos_in_bom/pom.xml
 2019-12-20 11:08:15 +01:00
James Nord 7228af5bb1 [JENKINS-60351] - Make it possible to disable multiple deletion attempts by setting hudson.Util.maxFileDeletionRetries to zero (#4382) 
* [JENKINS-60351] It should be possible to disable a retry of the
PathRemover

This does not address the issues that the comments and code in
hudons.Util are inconsistent if they are for retries or total number of
attempts (they are currently total number of attempts)

* [JENKINS-60351] Make the code conform to the documentation

maxRetries should control the number of retries not the number of
attempts.

* rename field from DELETION_MAX to DELETION_RETRIES
 2019-12-20 11:07:33 +01:00
Kohsuke Kawaguchi cffb86a4e2 [maven-release-plugin] prepare for next development iteration 2019-12-18 20:43:47 -08:00
Kohsuke Kawaguchi 3607b41062 [maven-release-plugin] prepare release jenkins-2.204.1 jenkins-2.204.1 2019-12-18 20:43:39 -08:00
Jesse Glick a67f59aca5 Merge pull request #4399 from jglick/dns 
DNS comparisons of jenkins.io and www.jenkins.io do not pass.
 2019-12-17 19:34:37 -05:00
Jesse Glick b0527d2fd9 DNS comparisons of jenkins.io and www.jenkins.io do not pass. 2019-12-17 16:52:13 -05:00
TheLastPossibleUsernameEver 365d6f8cd8 fixed_typos_in_bom/pom.xml 
Fixed typos in comment on servlet-api version tag
 2019-12-15 20:45:44 -01:00
Kohsuke Kawaguchi 8019dfa9cd [maven-release-plugin] prepare for next development iteration 2019-12-15 13:00:04 -08:00
Kohsuke Kawaguchi 4179cb034c [maven-release-plugin] prepare release jenkins-2.209 jenkins-2.209 2019-12-15 12:59:52 -08:00
Matt Sicker d5b716625c [JENKINS-59107] User is no longer logged out when authenticating another user 
This fixes a regression introduced in SECURITY-901 where performing an authentication check on another user while logged in caused the user to get logged out.

Signed-off-by: Matt Sicker <boards@gmail.com>
 2019-12-13 11:07:40 -06:00