Commit Graph
32590 Commits
Author SHA1 Message Date
StefanSpieker 9368197d25 Replaced integer with AtomicInteger to fix spotbugs issue (#4337)
* replaced integer with AtomicInteger to fix spotbugs issue

* added @Restricted to prevent further usage

* replaced volatile with final because of AtomicInteger usage

* implemented a getter and an increment method

* fixed typeo in javadoc
2019-12-12 08:46:24 +01:00
Oleg Nenashev 171c4d7f6d Merge pull request #4388 from jglick/nullability-Label
Adding some nullability annotations related to Label
2019-12-10 22:45:12 +01:00
Thomas de Grenier de Latour d36acc1c81 [JENKINS-59656] check build id before interrupting from the executors widget (#4264)
* [JENKINS-59656] when stopping a Run via the executors widget, make sure it's the intended one

* [JENKINS-59656] added Executor.stopBuild(String) instead of .stop(String)

* revert change to deprecated doStop(StaplerRequest,StaplerResponse), useless now that it's doStopBuild(String) which takes a runExtId parameter

* javadoc: "@since TODO" rather than "@since 2.???"

* [JENKINS-59656] added test case

* jelly cleanup with h.urlEncode(String)

* make Functions.urlEncode(null) return empty String

* Executor.doStopBuild(runExtId): ignore runExtId if executable is not a Run

* Executor.doStopBuild(runExtId) doesn't have to be a public API
2019-12-10 22:44:51 +01:00
Oleg Nenashev 2479e8ba7c Merge pull request #4390 from StefanSpieker/test_cleanup
Minor test code cleanup
2019-12-10 22:44:06 +01:00
Oleg Nenashev 02a5dc5341 Merge pull request #4384 from contextshuffling/master
[JENKINS-60357] Use XMLUnit to fix test
2019-12-10 22:43:18 +01:00
Jesse Glick 5fee388540 Merge pull request #4392 from jglick/jth-jetty-upgrade
Adapt some tests to newer Jetty
2019-12-10 08:21:27 -05:00
Jesse Glick 9fae4cf68f jenkins-test-harness 2.57 2019-12-09 20:05:29 -05:00
Oleg Nenashev f3e1fa7ef1 Merge pull request #4370 from StefanSpieker/repeated_conditional
merged superfluous if with while loop
2019-12-09 22:08:30 +00:00
Jesse Glick f86cf08e1e Adapt some tests to newer Jetty. 2019-12-09 16:54:25 -05:00
Jeff Thompson cece2b4406 Minor review comments. 2019-12-09 13:14:55 -07:00
Jeff Thompson ab780080d0 Clean up suppression filter. 2019-12-09 11:21:21 -07:00
StefanSpiekerandZbynek Konecny 059515e65c Apply suggestions from code review
Co-Authored-By: Zbynek Konecny <zbynek1729@gmail.com>
2019-12-09 09:43:05 +01:00
Kohsuke Kawaguchi a2918a48dc [maven-release-plugin] prepare for next development iteration 2019-12-09 00:01:21 -08:00
Kohsuke Kawaguchi 8622af2233 [maven-release-plugin] prepare release jenkins-2.208 jenkins-2.208 2019-12-09 00:01:11 -08:00
Stefan Spieker 1bd637c4a0 removed whitespace and reworked to clearer assert in case of exception 2019-12-08 12:53:38 +01:00
Stefan Spieker 08a4f0429c minor code cleanup, simplified asserts and try with resources 2019-12-08 11:36:39 +01:00
Jeff Thompson 5f8f935f39 Add stack trace suppression into core as a standard. 2019-12-06 13:49:01 -07:00
Jesse Glick 1125b1b4d7 Adding some nullability annotations related to Label. 2019-12-06 10:33:26 -05:00
Jeff Thompson d611ba1b91 Remove deprecated agent protocols. 2019-12-04 13:59:43 -07:00
Mark Waite d5b416eb76 Merge pull request #4383 from fedepell/fac_rules_help
Fix online example/documentation for File Access Rules
2019-12-04 10:07:50 +00:00
César Soto Valero 2bb4f5e0e2 rolling back dependency changes in core 2019-12-04 11:07:44 +01:00
Oleg Nenashev d7066d19ee Merge pull request #4373 from fedepell/whitelist_empty_bug
[JENKINS-60278] Prevent Oops when Whitelisted Commands input is empty
2019-12-04 05:38:35 +00:00
contextshuffling ce0e4a6e36 use XMLUnit to fix test 2019-12-03 23:13:32 -06:00
Federico Pellegrin 91af9a4727 Fix online example/documentation for File Access Rules 2019-12-03 17:00:56 +01:00
Baptiste Mathus cb424f3ca0 Merge pull request #4329 from lgoenner/executor
[JENKINS-57304] - Add call to oneOffExecutors.remove in Computer.removeExecutor
2019-12-03 15:23:39 +01:00
Kohsuke Kawaguchi c8efc7c78e [maven-release-plugin] prepare for next development iteration 2019-12-02 16:57:46 -08:00
Kohsuke Kawaguchi e834ba8b65 [maven-release-plugin] prepare release jenkins-2.207 jenkins-2.207 2019-12-02 16:57:37 -08:00
Vincent Latombe b4e4d7888d [JENKINS-6798] Redirect on HTTP 502, 503, 504 (#4366)
* [JENKINS-6798] Redirect on HTTP >= 502 (502, 503, 504)

When Jenkins is behind a reverse proxy and is not available or
restarting, the reverse proxy will answer a HTTP 502 (because the upstream
doesn't answer).

* Add upper bound
2019-11-29 11:17:34 +01:00
César Soto Valero 2869c8615d Update pom.xml 2019-11-29 09:02:32 +01:00
cesarsotovalero 16f46bc1a9 remove unused dependencies 2019-11-29 01:06:03 +01:00
Oleg Nenashev 038109d2bd Merge pull request #4375 from jglick/ntp
Jenkinsfile: Use -ntp in the Maven Build
2019-11-28 22:31:22 +01:00
Oleg Nenashev ead55ac41d Merge pull request #4372 from StefanSpieker/remove_redundancies
Removed some redundant constructs
2019-11-28 11:47:53 +01:00
Oleg Nenashev a92eb87eb4 Merge pull request #4377 from jglick/PlainCLIProtocolTest
Race condition in PlainCLIProtocolTest
2019-11-28 11:38:09 +01:00
Jesse Glick 50c68f851c ath branch also needs to suppress download messages, though 3.5.4 is too old for -ntp. 2019-11-26 09:08:48 -05:00
Jesse Glick 8c81991ec0 Race condition in PlainCLIProtocolTest. 2019-11-26 09:03:58 -05:00
Jesse Glick 24adf98afe Merge branch 'master' into ntp 2019-11-26 08:35:02 -05:00
Manuel cd030e30a3 [JENKINS-59665] - Fix sorting of the Uninstall column in the Install pane of the Plugin Manager (#4298)
* refs #JENKINS-59665 Fixed sorting for uninstall column of installed in plugin manager

* refs #JENKINS-59665 removed test attribute

(cherry picked from commit 5f413e5c41)
2019-11-26 10:23:37 +01:00
Baptiste Mathus b4d19ab10a Merge pull request #4346 from MRamonLeon/JENKINS-59793
[JENKINS-59793] Avoid hanging jobs with faulty SubTasks

(cherry picked from commit 5f810770b4)
2019-11-26 10:04:01 +01:00
Baptiste Mathus 2bc3690b4f Merge pull request #4349 from fqueiruga/JENKINS-59508
[JENKINS-59508] Sidebar links show full label on hover

(cherry picked from commit a8853c26e2)
2019-11-26 09:57:58 +01:00
Oleg Nenashev b82404a8c2 Merge pull request #4367 from daniel-beck/script-security-1.68
Update bundled script-security to 1.68
2019-11-25 22:29:24 +01:00
Jesse Glick b4856f6a17 -ntp 2019-11-25 16:26:22 -05:00
Andrea Scarpino 10a52c102b JENKINS-42658: fix NPE when the slave if offline 2019-11-25 12:34:57 +01:00
Federico Pellegrin 6186c3b72f Prevent Oops when Whitelisted Commands input is empty 2019-11-25 09:07:25 +01:00
Kohsuke Kawaguchi c3cba50800 [maven-release-plugin] prepare for next development iteration 2019-11-24 16:52:08 -08:00
Kohsuke Kawaguchi 95a464305c [maven-release-plugin] prepare release jenkins-2.206 jenkins-2.206 2019-11-24 16:51:59 -08:00
Stefan Spieker 40206e023c removed some redundant constructs and replaced stringbuilder operations with too few arguments with string concatenation 2019-11-24 16:15:20 +01:00
Stefan Spieker 5f406626d5 merged superfluous if with while loop 2019-11-24 15:47:03 +01:00
Oleg Nenashev eedf2a4e2a Merge pull request #4262 from StefanSpieker/replace_getActiveInstance
Replaced deprecated getActiveInstance() with get()
2019-11-22 10:25:21 +01:00
Oleg Nenashev 8bc435f32e Merge pull request #4348 from pilou-/handle_empty_views
[JENKINS-60092] getPrimaryView: return null if no view is defined
2019-11-22 10:14:47 +01:00
StefanSpiekerandWadeck Follonier d92b172aaf Set the HttpOnly flag for the page auto-refresh tokens (#4363)
* set HttpOnly flag to prevent cookie read by a malicious script in browser

* Update core/src/main/java/hudson/Functions.java

Co-Authored-By: Wadeck Follonier <Wadeck@users.noreply.github.com>
2019-11-22 10:14:17 +01:00